pengfei added inline comments.
================ Comment at: clang/test/CodeGen/attr-cpuspecific-cpus.c:1-2 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - %s +// RUN: %clang_cc1 -triple x86_64-windows-pc -fms-compatibility -emit-llvm -o - %s + ---------------- Is it only to check no compile warning/error? Should we add a `-verify`? ================ Comment at: clang/test/CodeGen/attr-cpuspecific-cpus.c:8 +#define ATTR(X) __attribute__((X)) +#endif // _MSC_VER + ---------------- _MSC_VER or _WIN64? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152989/new/ https://reviews.llvm.org/D152989 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
