[PATCH] D146715: [NVPTX] Enforce half type support is present for builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae3c981aa4b8: [NVPTX] Enforce half type support is present for builtins (authored by jchlanda). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] ae3c981 - [NVPTX] Enforce half type support is present for builtins

Author: Jakub Chlanda Date: 2023-03-28T08:48:10+02:00 New Revision: ae3c981aa4b85cfae6531ba50df7ad84feebe43c URL: https://github.com/llvm/llvm-project/commit/ae3c981aa4b85cfae6531ba50df7ad84feebe43c DIFF: https://github.com/llvm/llvm-project/commit/ae3c981aa4b85cfae6531ba50df7ad84feebe43c.diff

[PATCH] D146758: Fix codegen for coroutine with function-try-block

ChuanqiXu added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:724-730 + Stmt *BodyStmt = S.getBody(); + CompoundStmt *Body = dyn_cast(BodyStmt); + if (Body == nullptr) { +Body = +CompoundStmt::Create(getContext(), {BodyStmt}, FP

[PATCH] D145545: [clang][Interp] Fix local variable (destructor) management in loop bodies

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:199-200 +bool ByteCodeStmtGen::visitUnscopedCompoundStmt(const Stmt *S) { + if (isa(S)) +return true; + aaron.ballman wrote: > Errr, I'm surprised it isn't UB to call this wi

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

PiotrZSL added a comment. In D140760#4226213 , @ccotter wrote: > Should we handle that in a separate patch? Ok. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

tbaeder added a subscriber: cjdb. tbaeder added a comment. Pinging @cjdb and @aaron.ballman for some feedback on the wording CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146358/new/ https://reviews.llvm.org/D146358 ___ cfe-commits mailing li

[PATCH] D146678: Fix unexpected nullptr in ConceptSpecializationExpr's ArgsAsWritten field

shafik added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:843 Expr *NewIDC = ConceptSpecializationExpr::Create( - C, CSE->getNamedConcept(), CSD, nullptr, CSE->isInstantiationDependent(), - CSE->containsUnexpandedParameterPack()); + C, CSE->getNamed

[PATCH] D146844: [clang-format] Handle '_' in ud-suffix for IntegerLiteralSeparator

owenpan updated this revision to Diff 508889. owenpan added a comment. Treats imaginary number suffixes (starting with an `i`) just like any user-defined suffixes (starting with an underscore). Also handles ud-suffixes (e.g. `_km` and `_Pa`) containing letters that can be part of a floating-poin

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:714-716 +if (!Args.hasFlag(options::OPT_fdata_sections, + options::OPT_fno_data_sections, UseSeparateSections) && +Args.hasArg(options::OPT_fno_da

[PATCH] D146986: Downgrade reserved module identifier error into a warning

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. > Presumably adding an alias for #pragma clang system_header called > system_module wouldn't be too hard? (though the pragma is also being removed > from libc++ soon, I think, in favor o

[PATCH] D146929: [clang-tidy] Ignore unevaluated exprs in rvalue-reference-param-not-moved

ccotter added a comment. @PiotrZSL if you're happy with these changes, would you mind committing them for me? "Chris Cotter " Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146929/new/ https://reviews.llvm.org/D146929 _

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter added a comment. In D140760#4222989 , @PiotrZSL wrote: > What about classes that doesn't have begin/end method but got cbegin/cend ? > I thing there is open issue for that. Should we handle that in a separate patch? Repository: rG LLVM Githu

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

kito-cheng added a comment. Sorry for cross post, but I guess some people might not follow closely in discourse (like me :P): Another proposal from me is using gp as platform register: https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/371 Some advantage on taking gp as platform registe

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 508869. ccotter marked 2 inline comments as done. ccotter added a comment. - fix docs, fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files: clang-tools-e

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ForwardingReferenceParamNotForwardedCheck.cpp:20 + +AST_MATCHER(Expr, hasUnevaluatedContext) { + if (isa(Node) || isa(Node)) PiotrZSL wrote: > move this matcher to some ut

[PATCH] D146929: [clang-tidy] Ignore unevaluated exprs in rvalue-reference-param-not-moved

ccotter updated this revision to Diff 508865. ccotter added a comment. - move to utility file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146929/new/ https://reviews.llvm.org/D146929 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveChe

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

jdoerfert added a comment. @sivachandra Host and device should agree on all ABI related properties of types or things turn badly, fast. That has to be a given for things to work, and from there, users expect types to be copyable, and usable on both sides. @jhuber6 There are things we might need

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

jhuber6 added a comment. In D146973#4225983 , @jdoerfert wrote: > I said this before, many times: > > We don't want to have different host and device libraries that are > incompatible. > Effectively, what we really want, is the host environment to just w

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

sivachandra added a comment. In D146973#4225983 , @jdoerfert wrote: > For most of libc, we might get away with custom GPU headers but eventually it > will break "expected to work" user code, at the latest when we arrive at > libc++. > A user can, right

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

dblaikie added a comment. In D138247#4217189 , @efriedma wrote: > The relevant text of the current Itanium ABI (which was updated in > https://github.com/itanium-cxx-abi/cxx-abi/commit/d8e9d102c83f177970f0db6cc8bee170f2779bc1) > >> In the following conte

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

dblaikie updated this revision to Diff 508847. dblaikie added a comment. Rename VariableTemplate classification to TemplatedVariable to match ABI wording Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138247/new/ https://reviews.llvm.org/D138247 Fi

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

dblaikie updated this revision to Diff 508842. dblaikie added a comment. Remove `StaticDataMember` and classify static member variables of templates as variable templates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138247/new/ https://reviews.ll

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

jdoerfert added a comment. I said this before, many times: We don't want to have different host and device libraries that are incompatible. Effectively, what we really want, is the host environment just work on the GPU, that includes extensions in the host headers, macros, taking the address of

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

dblaikie added inline comments. Comment at: clang/test/CodeGen/preferred_name.cpp:49 + +Foo> varFooInt; + Michael137 wrote: > dblaikie wrote: > > Michael137 wrote: > > > probinson wrote: > > > > This doesn't become `Foo` ? > > > The name stays as `Foo>` but t

[PATCH] D146975: [NVPTX] Add __CUDA_ARCH__ macro to standalone NVPTX compilations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jhuber6 marked an inline comment as done. Closed by commit rGbed7005eb4d4: [NVPTX] Add __CUDA_ARCH__ macro to standalone NVPTX compilations (authored by jhuber6). Chan

[clang] bed7005 - [NVPTX] Add __CUDA_ARCH__ macro to standalone NVPTX compilations

Author: Joseph Huber Date: 2023-03-27T18:08:15-05:00 New Revision: bed7005eb4d4850b6f9d93707213ced5c0c19de0 URL: https://github.com/llvm/llvm-project/commit/bed7005eb4d4850b6f9d93707213ced5c0c19de0 DIFF: https://github.com/llvm/llvm-project/commit/bed7005eb4d4850b6f9d93707213ced5c0c19de0.diff

[PATCH] D146686: [Driver] Fix rpath for compiler-rt

yaxunl updated this revision to Diff 508823. yaxunl added a comment. revised by Fangrui's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146686/new/ https://reviews.llvm.org/D146686 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp clang/lib/Dri

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j added a comment. In D145770#4220246 , @mdtoguchi wrote: > @lamb-j - is it expected for any bundled objects created before your change > without the explicit env field to be able to be unbundled? Newly generated > bundles work as expected given s

[PATCH] D146892: [documentation]Fixed Random Typo

ayushi-8102 added a comment. My Pleasure! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146892/new/ https://reviews.llvm.org/D146892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

aprantl added a subscriber: rnk. aprantl added a comment. In D146595#4225630 , @aaron.ballman wrote: > It's less about other debug formats and more about user experience. My two > big concerns are: 1) writing multiple attributes to do the same thing is

[PATCH] D147003: [clang-format] JSON Add ability to add a space before the colon

owenpan added a comment. You need to add `CHECK_PARSE_BOOL(SpaceBeforeJsonColon)` in ConfigParseTest.cpp. Comment at: clang/include/clang/Format/Format.h:3717 + /// If ``true``, a space will be add before a json colon + /// \code Commen

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

PiotrZSL added a comment. To be honest, i got this check implemented and running already on some big code base since years, and inserted few thousands of std::move's with 0 false-positives, maybe not finding all cases, but I'm satisfied. I will put here source code, maybe you will get some idea

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

jhuber6 added a comment. In D146973#4225641 , @aaron.ballman wrote: >> This lets offloading languages such as OpenMP use the system string.h when >> compiling for the host and then the LLVM libc string.h when targeting the >> GPU. > > How do we avoid A

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

aaron.ballman added a comment. > This lets offloading languages such as OpenMP use the system string.h when > compiling for the host and then the LLVM libc string.h when targeting the GPU. How do we avoid ABI issues when the two headers get sufficiently out of sync? (In general, I'm pretty surp

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9972c9a89347: [NFC] Remove unused member variable `PolicyBitMask` in SemaRecord (authored by schittir). Repository: rG LLVM Github Monorepo CHANG

[clang] 9972c9a - [NFC] Remove unused member variable `PolicyBitMask` in SemaRecord

Author: Chittireddy, Sindhu Date: 2023-03-27T17:39:40-04:00 New Revision: 9972c9a893478241b7c9d8b587df978bc6d7e5a0 URL: https://github.com/llvm/llvm-project/commit/9972c9a893478241b7c9d8b587df978bc6d7e5a0 DIFF: https://github.com/llvm/llvm-project/commit/9972c9a893478241b7c9d8b587df978bc6d7e5a0

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

aaron.ballman added a comment. In D146595#4225490 , @aprantl wrote: >> We don't want to have one attribute per debug format, because that's not >> going to scale. > > LLVM supports outputting a total of 2 debug info formats. Why should the user have to

[PATCH] D147003: [clang-format] JSON Add ability to add a space before the colon

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: owenpan, HazardyKnusperkeks, rymiel. MyDeveloperDay added projects: clang, clang-format. Herald added a project: All. MyDeveloperDay requested review of this revision. I've seen a couple of request for extra Json formatting to m

[PATCH] D147002: [clang][deps] Don't cache stat failures for .framework directories

jansvoboda11 created this revision. jansvoboda11 added a reviewer: Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The .framework directory might be c

[clang] 158a431 - Revert ExtractAPI from https://reviews.llvm.org/D146656

Author: Daniel Grumberg Date: 2023-03-27T22:12:36+01:00 New Revision: 158a431227a876306fe5838936413dd51588d0c6 URL: https://github.com/llvm/llvm-project/commit/158a431227a876306fe5838936413dd51588d0c6 DIFF: https://github.com/llvm/llvm-project/commit/158a431227a876306fe5838936413dd51588d0c6.dif

[PATCH] D146866: [clang][ExtractAPI] Remove extra pointer indirection from declaration fragments for Obj-C lightweight generics on id

chaitanyav added a comment. looks like its waiting on libcxx build(https://buildkite.com/llvm-project/premerge-checks/builds/143382#job-01872209-2788-44ef-930c-11e741ff906e) and it is actively being debugged as per comments on other differential. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D146758: Fix codegen for coroutine with function-try-block

MatzeB updated this revision to Diff 508792. MatzeB marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146758/new/ https://reviews.llvm.org/D146758 Files: clang/include/clang/AST/StmtCXX.h clang/lib/AST/ASTImporter.c

[PATCH] D146895: [clang-format] Don't annotate left brace of struct as FunctionLBrace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG767aee1de9e9: [clang-format] Don't annotate left brace of struct as FunctionLBrace (authored by owenpan). Repository: rG LLVM Github Monorepo CHA

[clang] 767aee1 - [clang-format] Don't annotate left brace of struct as FunctionLBrace

Author: Owen Pan Date: 2023-03-27T14:07:15-07:00 New Revision: 767aee1de9e98256a62ae8b4c2f84381203613c3 URL: https://github.com/llvm/llvm-project/commit/767aee1de9e98256a62ae8b4c2f84381203613c3 DIFF: https://github.com/llvm/llvm-project/commit/767aee1de9e98256a62ae8b4c2f84381203613c3.diff LOG:

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1230 + llvm::sys::path::append(P, "llvm-libc"); + CmdArgs.push_back("-c-isystem"); + CmdArgs.push_back(Args.MakeArgString(P)); jhuber6 wrote: > sivachandra wrote: > > tra

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

awarzynski added a comment. Thanks for the updates! A few more pointers, but nothing major. Btw, are there any tests that check for debug info in the compiled files? For example: ! RUN: flang -g1 -S %s | FileCheck -check-prefixes=DEBUG-INFO-PRESENT ! RUN: flang -g0 -S %s | FileCheck -check-

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1230 + llvm::sys::path::append(P, "llvm-libc"); + CmdArgs.push_back("-c-isystem"); + CmdArgs.push_back(Args.MakeArgString(P)); sivachandra wrote: > tra wrote: > > siva

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

aprantl added a comment. > We don't want to have one attribute per debug format, because that's not > going to scale. LLVM supports outputting a total of 2 debug info formats. > So how do we validate that this attribute should be exposed to users *now* > before we know what the story is for ot

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 508773. paulkirth retitled this revision from "[clang] Preliminary fat-lot-object support" to "[clang] Preliminary fat-lto-object support". paulkirth added a comment. Herald added a subscriber: inglorion. Fix typo in title Repository: rG LLVM Github Mon

[PATCH] D144870: [Clang][DebugInfo] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units.

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. One entirely optional suggestion on the test. LGTM. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1563 + + assert(PreviousBitfield->isBitField()); + j

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

jp4a50 added a comment. I've removed the special-casing that I added for namespace scope statements. If I make those changes at all, I'll raise them as a follow up diff. Comment at: clang/unittests/Format/FormatTest.cpp:21953 - verifyFormat("std::sort(v.begin(), v.end(),\n" -

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

jp4a50 updated this revision to Diff 508765. jp4a50 added a comment. Re-enable OuterScope lambda body indentation of lambdas in namespace scope statements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146042/new/ https://reviews.llvm.org/D146042

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

aprantl added a comment. > Why should this feature be limited to DWARF? Don't we have the same kind of > stepping behavior issue with PDB files, for example? That's not what I was trying to say. Yes, `DW_AT_trampoline` is a DWARF feature. But the "target function" LLVM IR feature is not necessa

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

jp4a50 added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:21952 "}", Style); + verifyFormat("void test() {\n" MyDeveloperDay wrote: > I feel like lots of these test changes could be made on their own, BEFORE

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

jp4a50 updated this revision to Diff 508762. jp4a50 added a comment. Rebase diff on top of D146995 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146042/new/ https://reviews.llvm.org/D146042 Files: clang/docs/C

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

asbirlea added a comment. Nit: the diffs would be easier to analyze with "-fno-discard-value-names". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145265/new/ https://reviews.llvm.org/D145265 ___ cfe-com

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

aprantl added a comment. > I guess it was implemented there first/ported to clang with the fortran effort Yeah my understanding is that the LLVM feature was added for flang, and so I'm not sure what the targeted debugger is, I believe there are some non-GDB/LLDB debuggers targeting the HPC mark

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

aaron.ballman added a comment. In D146595#4225259 , @augusto2112 wrote: > In D146595#4225170 , @aaron.ballman > wrote: > >> In D146595#4225132 , @aprantl >> wrote: >> >

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

jhuber6 added a comment. In D146973#4225300 , @tschuett wrote: > Could you hide the amdgpu and nvptx somewhere libc here `clang > -print-resource-dir` in two different directories? One for AMD, one for > NVPTX. So, right now this header is installed f

[PATCH] D146995: [clang-format] Refactor unit tests for "LambdaBodyIndentation: OuterScope" option.

jp4a50 added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:21978 Style); - EXPECT_EQ("SomeResult doSomething(SomeObject promise) {\n" -" return promise.then(\n" The refactored version of these test cases has been

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

tschuett added a comment. Could you hide the amdgpu and nvptx somewhere here `clang -print-resource-dir` in two different directories? One for AMD, one for NVPTX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146973/new/ https://reviews.llvm.org/

[PATCH] D146995: [clang-format] Refactor unit tests for "LambdaBodyIndentation: OuterScope" option.

jp4a50 created this revision. Herald added a project: All. jp4a50 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The changes: - make the tests more concise - fix invalid C++ in the code samples - ensure line breaks in tests' code samples

[PATCH] D146986: Downgrade reserved module identifier error into a warning

dblaikie added a comment. In D146986#4225192 , @aaron.ballman wrote: > In D146986#4225121 , @dblaikie > wrote: > >> From the discussion on the issue: >> >>> Do we want this loosening of the restriction to apply

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

sivachandra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1230 + llvm::sys::path::append(P, "llvm-libc"); + CmdArgs.push_back("-c-isystem"); + CmdArgs.push_back(Args.MakeArgString(P)); tra wrote: > sivachandra wrote: > >

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

augusto2112 added a comment. In D146595#4225170 , @aaron.ballman wrote: > In D146595#4225132 , @aprantl wrote: > >> In D146595#4225048 , @dblaikie >> wrote: >> >>> I kno

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

JonChesterfield added a comment. Can we default to freestanding on, or just document that freestanding is a good idea, instead of hacking with include behaviour directly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146973/new/ https://reviews.ll

[PATCH] D145545: [clang][Interp] Fix local variable (destructor) management in loop bodies

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:338 +this->emitDestructors(); +this->Ctx->emitDestroy(*Idx, SourceInfo{}); + } Should we be setting `Idx = std::nullopt;` after this so that the `LocalScope` destruc

[PATCH] D146908: [clang][MinGW] Add asan link flags before other libs and objects

alvinhochun updated this revision to Diff 508751. alvinhochun added a comment. Trying to fix the test... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146908/new/ https://reviews.llvm.org/D146908 Files: clang/lib/Driver/ToolChains/MinGW.cpp cl

[PATCH] D146338: [MSVC compatibility][dllimport/dllexport][PS] Allow dllexport/dllimport for classes with UniqueExternalLinkage

wolfgangp added inline comments. Comment at: clang/test/SemaCXX/dllexport.cpp:437 +class Base {}; +class __declspec(dllexport) ExportedClass {}; hans wrote: > Is this one used somewhere? It's not. Thanks for finding it. Comment at: clang/test

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1230 + llvm::sys::path::append(P, "llvm-libc"); + CmdArgs.push_back("-c-isystem"); + CmdArgs.push_back(Args.MakeArgString(P)); sivachandra wrote: > jhuber6 wrote: > > tra

[PATCH] D146338: [MSVC compatibility][dllimport/dllexport][PS] Allow dllexport/dllimport for classes with UniqueExternalLinkage

wolfgangp updated this revision to Diff 508747. wolfgangp marked an inline comment as done. wolfgangp added a comment. Added 2 test cases that check that dll{ex,im}ported classes that are instantiated with classes with internal linkage as template arguments are not exported or imported. Had to

[PATCH] D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations

ziqingluo-90 added a comment. In D137379#4225000 , @manojgupta wrote: > This is firing even in checked length codes, is that expected? Yes, it is expected. The unsafe buffer analysis is syntax-based. The analysis warns operations that do not follow t

[PATCH] D146986: Downgrade reserved module identifier error into a warning

aaron.ballman added a comment. In D146986#4225121 , @dblaikie wrote: > From the discussion on the issue: > >> Do we want this loosening of the restriction to apply to *only* `std` and >> the same followed by a number, or to any reserved identifier used i

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

dblaikie added a comment. In D146595#4225132 , @aprantl wrote: > In D146595#4225048 , @dblaikie > wrote: > >> I know this is a bit of a redirection/scope creep/etc - but I'd quite like >> to see a solution that

[PATCH] D146840: [AMDGPU] Replace target feature for global fadd32

rampitec requested changes to this revision. rampitec added a comment. This revision now requires changes to proceed. You cannot just enable it on gfx908 which does not have return version of it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146840/

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:4343 + WhitespaceSensitiveMacros == R.WhitespaceSensitiveMacros && + Macros == R.Macros; } I put a lot of effort into bringing the stuff sorted. And n

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

aaron.ballman added a comment. In D146595#4225132 , @aprantl wrote: > In D146595#4225048 , @dblaikie > wrote: > >> I know this is a bit of a redirection/scope creep/etc - but I'd quite like >> to see a solution

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 marked an inline comment as not done. Michael137 added inline comments. Comment at: clang/test/CodeGen/preferred_name.cpp:49 + +Foo> varFooInt; + dblaikie wrote: > Michael137 wrote: > > probinson wrote: > > > This doesn't become `Foo` ? > > The nam

[PATCH] D144358: [clang][github] Added checking for completeness of lvalue in conditional operator [#59718]

aaron.ballman added a comment. In D144358#4225139 , @Aditya-pixel wrote: > Oh, okay, Ill change the patch now. Also, it seems my local directory is out > of sync. Should I always update it before submitting a patch, or is it > alright without updating

[PATCH] D144358: [clang][github] Added checking for completeness of lvalue in conditional operator [#59718]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdedd7b6548f4: Added checking for completeness of lvalue in conditional operator (authored by Aditya-pixel, committed by aaron.ballman). Herald added

[clang] dedd7b6 - Added checking for completeness of lvalue in conditional operator

Author: Aditya Singh Date: 2023-03-27T14:47:08-04:00 New Revision: dedd7b6548f4a37f4f691aa0cd3a709756b7e794 URL: https://github.com/llvm/llvm-project/commit/dedd7b6548f4a37f4f691aa0cd3a709756b7e794 DIFF: https://github.com/llvm/llvm-project/commit/dedd7b6548f4a37f4f691aa0cd3a709756b7e794.diff

[PATCH] D146924: [clang] Add support for dollar sign in ud_suffix of numeric constants

annara added a comment. Thanks for all the input! I'll work on @cor3ntin points and take a look at the crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146924/new/ https://reviews.llvm.org/D146924 __

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

aprantl added a comment. In D146595#4225048 , @dblaikie wrote: > I know this is a bit of a redirection/scope creep/etc - but I'd quite like to > see a solution that is likely to be usable for the "std::function" problem > (stepping into std::function sh

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

sivachandra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1230 + llvm::sys::path::append(P, "llvm-libc"); + CmdArgs.push_back("-c-isystem"); + CmdArgs.push_back(Args.MakeArgString(P)); jhuber6 wrote: > tra wrote: > > jhub

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

dblaikie added inline comments. Comment at: clang/test/CodeGen/preferred_name.cpp:49 + +Foo> varFooInt; + Michael137 wrote: > probinson wrote: > > This doesn't become `Foo` ? > The name stays as `Foo>` but the type of the template parameter > becomes `BarInt

[PATCH] D146986: Downgrade reserved module identifier error into a warning

dblaikie added a comment. From the discussion on the issue: > Do we want this loosening of the restriction to apply to *only* `std` and the > same followed by a number, or to any reserved identifier used in a module? > e.g., > > module std; // error today, but will become a warning > module

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1230 + llvm::sys::path::append(P, "llvm-libc"); + CmdArgs.push_back("-c-isystem"); + CmdArgs.push_back(Args.MakeArgString(P)); tra wrote: > jhuber6 wrote: > > tra wrot

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

jp4a50 marked an inline comment as done. jp4a50 added a comment. All actionable comments have been addressed. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1665-1669 + const auto DesignatedInitializerIndentWidth = + Style.DesignatedInitializerIndentWidth <

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

tra added a subscriber: echristo. tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1230 + llvm::sys::path::append(P, "llvm-libc"); + CmdArgs.push_back("-c-isystem"); + CmdArgs.push_back(Args.MakeArgString(P)); jhuber6 wr

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

jp4a50 updated this revision to Diff 508740. jp4a50 added a comment. Address minor review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146101/new/ https://reviews.llvm.org/D146101 Files: clang/docs/ClangFormatStyleOptions.rst clang/

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

firewave added a comment. In D137205#4225006 , @Febbe wrote: > Yes, I agree, while I can't understand, why someone still wants to use only > c++11 I can totally understand, that a single Software Engineer can't do > anything about this, when the corpora

[PATCH] D146801: [clang] Fix consteval initializers of temporaries

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Precommit CI is still falling over because of the libcxx bot. That issue is being actively investigated, but we don't have an ETA on it being resolved. I think these changes are sufficiently safe to land and watch for pos

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added a comment. I do not have the commit access, can you commit on my behalf @nickdesaulniers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145726/new/ https://reviews.llvm.org/D145726 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D146234: [clang] Fix crash when handling nested immediate invocations

aaron.ballman added a comment. I think this LGTM, but I'm holding off on signing off until @shafik is satisfied with the part he was asking about. You should add a release note for the fix, too. Comment at: clang/lib/Sema/SemaExpr.cpp:17891-17894 + // It is possible that

[PATCH] D146686: [Driver] Fix rpath for compiler-rt

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/OHOS.cpp:140 getFilePaths().clear(); - std::string CandidateLibPath = getArchSpecificLibPath(); - if (getVFS().exists(CandidateLibPath)) -getFilePaths().push_back(CandidateLibPath); + for (const auto

[PATCH] D146686: [Driver] Fix rpath for compiler-rt

MaskRay added a comment. The new test can be placed in `arch-specific-libdir-rpath.c`. One or two additional RUN lines seem sufficient, no need to duplicate too many. Also, use `--target=` for new tests and avoid `^//$`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146686/new/ https:

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

dblaikie added a comment. I know this is a bit of a redirection/scope creep/etc - but I'd quite like to see a solution that is likely to be usable for the "std::function" problem (stepping into std::function should allow you to reach the underlying function - but lldb currently skips any call t

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:976-985 + bool IsInputTyAsm = false; + for (const auto &II : Inputs) { +CmdArgs.push_back(II.getFilename()); +StringRef BaseInput = StringRef(II.getBaseInput()); +types::ID InputTyp

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1230 + llvm::sys::path::append(P, "llvm-libc"); + CmdArgs.push_back("-c-isystem"); + CmdArgs.push_back(Args.MakeArgString(P)); tra wrote: > Ensuring the right include

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:976-985 + bool IsInputTyAsm = false; + for (const auto &II : Inputs) { +CmdArgs.push_back(II.getFilename()); +StringRef BaseInput = StringRef(II.getBaseInput()); +types::ID InputT

  1   2   3   >