aaron.ballman added a comment. In D144358#4225139 <https://reviews.llvm.org/D144358#4225139>, @Aditya-pixel wrote:
> Oh, okay, Ill change the patch now. Also, it seems my local directory is out > of sync. Should I always update it before submitting a patch, or is it > alright without updating it? It's usually good to rebase each time you update the patch, but it's not a requirement either (sometimes it's easier to rebase at the end instead of while the patch is under review). I've landed the changes for you in dedd7b6548f4a37f4f691aa0cd3a709756b7e794 <https://reviews.llvm.org/rGdedd7b6548f4a37f4f691aa0cd3a709756b7e794> Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144358/new/ https://reviews.llvm.org/D144358 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
