[PATCH] D136751: [clang][Interp] This pointers are writable in constructors

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:264-270 + const Function *Func = S.Current->getFunction(); + if (Func && Func->isConstructor()) { +// The This pointer is writable in constructors, even if +// isConst() returns true. +if (Pt

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 498253. 4vtomat marked 2 inline comments as done. 4vtomat added a comment. Update to v20230206 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141672/new/ https://reviews.llvm.org/D141672 Files: clang/test/Pre

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

pengfei added inline comments. Comment at: llvm/docs/LangRef.rst:2166 + +If the mode is ``"dynamic"``, the behavior is derived from the +dynamic state of the floating-point environment. Transformations 1. Does it mean users must specify `dynamic` when the

[PATCH] D144157: Add 128-bit integer support to enum element

MaskRay added a comment. We also need a codegen test. `clang/test/CodeGen/enum2.c` may be a good one. It tests that debug information is correct as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144157/new/ https://reviews.llvm.org/D144157

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

sepavloff added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:824 + continue; +} + efriedma wrote: > sepavloff wrote: > > efriedma wrote: > > > Is this necessary? The non-delayed-parsed case seems to work correctly > > > o

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

sepavloff updated this revision to Diff 498248. sepavloff added a comment. Remove copying StrictFPAttr from InstantiateAttrs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143919/new/ https://reviews.llvm.org/D143919 Files: clang/include/clang/Se

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added a comment. poke - anyone mind reviewing this? I used this tool to fix two small cases of missing move in the llvm project: https://reviews.llvm.org/D142824 https://reviews.llvm.org/D142825 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D143755: [clang-format] Add a space between an overloaded operator and '>'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb05dc1b8766a: [clang-format] Add a space between an overloaded operator and '>' (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGE

[clang] b05dc1b - [clang-format] Add a space between an overloaded operator and '>'

Author: Owen Pan Date: 2023-02-16T20:25:39-08:00 New Revision: b05dc1b8766a47482cae432011fd2faa04c83a3e URL: https://github.com/llvm/llvm-project/commit/b05dc1b8766a47482cae432011fd2faa04c83a3e DIFF: https://github.com/llvm/llvm-project/commit/b05dc1b8766a47482cae432011fd2faa04c83a3e.diff LOG:

[PATCH] D136751: [clang][Interp] This pointers are writable in constructors

shafik added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:264-270 + const Function *Func = S.Current->getFunction(); + if (Func && Func->isConstructor()) { +// The This pointer is writable in constructors, even if +// isConst() returns true. +if (Ptr

[PATCH] D136751: [clang][Interp] This pointers are writable in constructors

shafik added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:264-270 + const Function *Func = S.Current->getFunction(); + if (Func && Func->isConstructor()) { +// The This pointer is writable in constructors, even if +// isConst() returns true. +if (Ptr

[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

adalava added a comment. Nice catch! I'm not a LLVM maintainer but from FreeBSD PowerPC side I agree with the changes, only added two suggestions that could improve code readability Comment at: clang/lib/Basic/Targets/PPC.h:428 ABI = "elfv2"; +} else if (Triple.isO

[PATCH] D141591: [clang][Interp] Properly identify not-yet-defined functions

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1486 bool IsBeingCompiled = Func && !Func->isFullyCompiled(); - bool WasNotDefined = Func && !Func->hasBody(); + bool WasNotDefined = Func && !Func->isConstexpr() && !Func->hasBody(); --

[PATCH] D144016: [Sema] Relax a failing assertion in TransformBlockExpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcda4a0e918b5: [Sema] Relax a failing assertion in TransformBlockExpr (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D14

[clang] cda4a0e - [Sema] Relax a failing assertion in TransformBlockExpr

Author: Akira Hatanaka Date: 2023-02-16T18:40:26-08:00 New Revision: cda4a0e918b591be9ae0732f7df07678efb75047 URL: https://github.com/llvm/llvm-project/commit/cda4a0e918b591be9ae0732f7df07678efb75047 DIFF: https://github.com/llvm/llvm-project/commit/cda4a0e918b591be9ae0732f7df07678efb75047.diff

[PATCH] D141194: [clang][Interp] Implement bitcasts

shafik added a comment. I think `VisitCastExpr` is the right place to start looking for what to do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141194/new/ https://reviews.llvm.org/D141194 ___ cfe-comm

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

ahatanak added inline comments. Comment at: clang/lib/CodeGen/Address.h:67 return; -// Currently the max supported alignment is much less than 1 << 63 and is +// Currently the max supported alignment is much less than 1 << 32 and is // guaranteed to be a power

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

ahatanak added a subscriber: aeubanks. ahatanak added inline comments. Comment at: clang/lib/CodeGen/Address.h:67 return; -// Currently the max supported alignment is much less than 1 << 63 and is +// Currently the max supported alignment is much less than 1 << 32

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139741/new/ https://reviews.llvm.org/D139741 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D140508: [clang] fix -Wuninitialized for asm goto outputs on indirect edges.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf6656338db3: [clang] fix -Wuninitialized for asm goto outputs on indirect edges. (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D143205: [clang] add __has_extension(gnu_asm_goto_with_outputs_full)

This revision was automatically updated to reflect the committed changes. Closed by commit rG54186d33c3a0: [clang] add __has_extension(gnu_asm_goto_with_outputs_full) (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143205

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

This revision was automatically updated to reflect the committed changes. Closed by commit rG329ef60f3e21: [Clang] support for outputs along indirect edges of asm goto (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13649

[PATCH] D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1bc723dfe97: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] af66563 - [clang] fix -Wuninitialized for asm goto outputs on indirect edges.

Author: Nick Desaulniers Date: 2023-02-16T17:58:35-08:00 New Revision: af6656338db365fde6c0b0e53db8f98aa8ed59d4 URL: https://github.com/llvm/llvm-project/commit/af6656338db365fde6c0b0e53db8f98aa8ed59d4 DIFF: https://github.com/llvm/llvm-project/commit/af6656338db365fde6c0b0e53db8f98aa8ed59d4.di

[clang] 54186d3 - [clang] add __has_extension(gnu_asm_goto_with_outputs_full)

Author: Nick Desaulniers Date: 2023-02-16T17:58:35-08:00 New Revision: 54186d33c3a0d4834d2e5f95640b63677f5b5142 URL: https://github.com/llvm/llvm-project/commit/54186d33c3a0d4834d2e5f95640b63677f5b5142 DIFF: https://github.com/llvm/llvm-project/commit/54186d33c3a0d4834d2e5f95640b63677f5b5142.di

[clang] 329ef60 - [Clang] support for outputs along indirect edges of asm goto

Author: Nick Desaulniers Date: 2023-02-16T17:58:34-08:00 New Revision: 329ef60f3e21fd6845e8e8b0da405cae7eb27267 URL: https://github.com/llvm/llvm-project/commit/329ef60f3e21fd6845e8e8b0da405cae7eb27267 DIFF: https://github.com/llvm/llvm-project/commit/329ef60f3e21fd6845e8e8b0da405cae7eb27267.di

[clang] b1bc723 - [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

Author: Nick Desaulniers Date: 2023-02-16T17:58:34-08:00 New Revision: b1bc723dfe9734a8b3157dbf50328b5d62436bd6 URL: https://github.com/llvm/llvm-project/commit/b1bc723dfe9734a8b3157dbf50328b5d62436bd6 DIFF: https://github.com/llvm/llvm-project/commit/b1bc723dfe9734a8b3157dbf50328b5d62436bd6.di

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

efriedma added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:824 + continue; +} + sepavloff wrote: > efriedma wrote: > > Is this necessary? The non-delayed-parsed case seems to work correctly on > > trunk without any chang

[PATCH] D144188: Tighten up a modules test

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144188/new/ https://reviews.llvm.org/D144188 ___ cfe-commits mailing lis

[PATCH] D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

nickdesaulniers updated this revision to Diff 498209. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - fix bugprone-argument-comment as per @shafik Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137113/new/ https:

[PATCH] D144169: [WebAssembly] Fix simd bit shift intrinsics codegen

This revision was automatically updated to reflect the committed changes. Closed by commit rGf253bb640d97: [WebAssembly] Fix simd bit shift intrinsics codegen (authored by junparser). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144169/new/ https:/

[clang] f253bb6 - [WebAssembly] Fix simd bit shift intrinsics codegen

Author: Jun Ma Date: 2023-02-17T09:17:47+08:00 New Revision: f253bb640d97756d2808bb7c7b2bb31b1090a654 URL: https://github.com/llvm/llvm-project/commit/f253bb640d97756d2808bb7c7b2bb31b1090a654 DIFF: https://github.com/llvm/llvm-project/commit/f253bb640d97756d2808bb7c7b2bb31b1090a654.diff LOG: [

[clang] e073de8 - [WebAssembly] Update wasm.c with update_cc_test_checks.py. NFC

Author: Jun Ma Date: 2023-02-17T09:17:47+08:00 New Revision: e073de833671159f89d72a1018d335cc042d URL: https://github.com/llvm/llvm-project/commit/e073de833671159f89d72a1018d335cc042d DIFF: https://github.com/llvm/llvm-project/commit/e073de833671159f89d72a1018d335cc042d.diff LOG: [

[PATCH] D143704: [Flang] Part one of Feature List action

elmcdonough added a comment. Thank you all for your feedback. We're putting the second part off for now and I'm going to retool this as a plugin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704

[PATCH] D144003: [clang][analyzer] Improve bug reports of StdLibraryFunctionsChecker.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks like a massive improvement. Yes, the warning text traditionally focuses on what exactly is wrong. Describing why it's wrong is important as well, but usually less important. We're making an ex

[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

jrtc27 added inline comments. Comment at: clang/test/AST/ast-dump-overloaded-operators.cpp:27 // CHECK-NEXT: | `-ParmVarDecl {{.*}} col:19{{( imported)?}} 'E' -// CHECK-NEXT: `-FunctionDecl {{.*}} line:14:6{{( imported)?}} test 'void ()' +// CHECK-NEXT: -FunctionDecl {{.*}}

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

rsmith added a comment. Until or unless a C++ DR permits us to define `__has_cpp_attribute(carries_dependency)` to any value other than `200809L`, we have a conformance requirement to macro-expand this to that value. CWG2695 only adds a note, so it changes nothing in this regard. Similarly, we

[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

Eugene.Zelenko added a comment. May be you could use heard in other test in same patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144216/new/ https://reviews.llvm.org/D144216 ___ cfe-commits mailing

[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

vabridgers added a comment. @donat.nagy , regarding the namespace leaking, there was a change -> https://reviews.llvm.org/D116774 that modified the behavior for aarch64 and arm. While not incorrect, it may offer some historical view or examples of how to address the current cases. @whisperity

[PATCH] D143680: [WIP][-Wunsafe-buffer-usage] Improve fix-its for local variable declarations with null pointer initializers

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1034-1035 +assert(!InitFixIts.empty() && + "Expected at least one fix-it for an initializer of an unsafe " + "variable declaration."); // The loc right before the

[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

pkubaj updated this revision to Diff 498185. pkubaj added a comment. Fix indenting according to clang-format suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144232/new/ https://reviews.llvm.org/D144232 Files: clang/lib/Basic/Targets/P

[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

pkubaj created this revision. pkubaj added reviewers: dim, nemanjai, adalava. Herald added subscribers: shchenz, kbarton, hiraditya. Herald added a project: All. pkubaj requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Curre

[PATCH] D143301: [flang] Handle unsupported warning flags

elmcdonough updated this revision to Diff 498164. elmcdonough added a comment. Change multiclass name for the sake of clarity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143301/new/ https://reviews.llvm.org/D143301 Files: clang/include/clang/

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

hubert.reinterpretcast added inline comments. Comment at: clang/test/Preprocessor/has_attribute.cpp:51 // FIXME(201806L) CHECK: assert: 0 -// CHECK: carries_dependency: 200809L +// CHECK: carries_dependency: 0 // CHECK: deprecated: 201309L aaron.ballman wrote:

[PATCH] D143205: [clang] add __has_extension(gnu_asm_goto_with_outputs_full)

nickdesaulniers updated this revision to Diff 498159. nickdesaulniers added a comment. - final rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143205/new/ https://reviews.llvm.org/D143205 Files: clang/docs/LanguageExtensions.rst clang/inc

[PATCH] D140508: [clang] fix -Wuninitialized for asm goto outputs on indirect edges.

nickdesaulniers updated this revision to Diff 498158. nickdesaulniers added a comment. - final rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140508/new/ https://reviews.llvm.org/D140508 Files: clang/lib/Analysis/UninitializedValues.cpp

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 498157. nickdesaulniers added a comment. - final rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497 Files: clang/docs/LanguageExtensions.rst clang/doc

[PATCH] D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

nickdesaulniers updated this revision to Diff 498156. nickdesaulniers added a comment. - final rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137113/new/ https://reviews.llvm.org/D137113 Files: clang/lib/CodeGen/CGStmt.cpp Index: clang/li

[PATCH] D144047: [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on host/device

shangwuyao updated this revision to Diff 498145. shangwuyao added a comment. Run clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144047/new/ https://reviews.llvm.org/D144047 Files: clang/lib/Basic/Targets/SPIR.h clang/test/CodeGenC

[PATCH] D140723: [clang][Interp] Only check constructors for global variables

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140723/new/ https://reviews.llvm.org/D140723 ___

[PATCH] D140723: [clang][Interp] Only check constructors for global variables

shafik added a comment. So we are only checking global constructors b/c it is valid in a constant expression context to initialize a record and not initialize all their fields as long as we don't use any of those fields. Note, cases that stem from this has been discussed as part of https://git

[PATCH] D144192: GH60642: Fix ICE when checking a lambda defined in a concept definition

erichkeane added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:4572 : Sema::ExpressionEvaluationContext::ConstantEvaluated, -/*LambdaContextDecl=*/nullptr, /*ExprContext=*/ +Sema::ReuseLambdaContextDecl, /*ExprContext=*/ Sema

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin updated this revision to Diff 498140. DmitryPolukhin added a comment. Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/CompileCommands.cpp cla

[PATCH] D143691: Fix clang-formats IncludeCategory to match the documentation

Febbe added inline comments. Comment at: clang/unittests/Format/SortIncludesTest.cpp:548 + EXPECT_EQ("#include \"a.h\"\n" +"#include \"llvm/a.h\"\n" +"#include \"b.h\"\n" HazardyKnusperkeks wrote: > Febbe wrote: > > HazardyKnusperkeks wro

[PATCH] D144192: GH60642: Fix ICE when checking a lambda defined in a concept definition

shafik added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:4572 : Sema::ExpressionEvaluationContext::ConstantEvaluated, -/*LambdaContextDecl=*/nullptr, /*ExprContext=*/ +Sema::ReuseLambdaContextDecl, /*ExprContext=*/ Sema::Ex

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath created this revision. mysterymath added reviewers: aaron.ballman, aykevl, dylanmckay. Herald added a subscriber: Jim. Herald added a project: All. mysterymath requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For AVR, the definit

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin added a comment. @nridge I'm sorry, I pushed version without all tests. Now I added test case for response files, it seems that clangd hasn't had it before this patch. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:222 + tooling::addExpandedResponseFi

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin updated this revision to Diff 498138. DmitryPolukhin added a comment. Add test for expanded response files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

mikecrowe marked 2 inline comments as done. mikecrowe added a comment. I ended up splitting out the std::format and std::print tests to their own file which meant that I didn't need to modify the existing `redundant-string-cstr.cpp` file in this commit. (Though of course I had to extract the h

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

mikecrowe updated this revision to Diff 498136. mikecrowe edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143342/new/ https://reviews.llvm.org/D143342 Files: clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp clang-tools-extra/doc

[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

mikecrowe created this revision. mikecrowe added a reviewer: njames93. Herald added a subscriber: xazax.hun. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. In preparation for using the imp

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 added a comment. In D144181#4133025 , @dblaikie wrote: > Ah, accidentally posted to the lldb part of this stack... instead: > > Any chance we can make these work more like member functions (could the ctors > include their mangled names, for in

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

dblaikie added a comment. Ah, accidentally posted to the lldb part of this stack... instead: Any chance we can make these work more like member functions (could the ctors include their mangled names, for instance)? Or is it the innate nature of ctors having the various C1

[PATCH] D144206: [clang-tidy] Fix false-positive in cppcoreguidelines-slicing

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, shchenz, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL published this revision for review. PiotrZSL added a comment. Herald added a project: clang-tools-extra. Herald ad

[PATCH] D144136: Add a "remark" to report on array accesses

void added a comment. In D144136#4131825 , @aaron.ballman wrote: > I'd like to understand what the overhead is for this. How much overhead does > this add when the remark is disabled? How much overhead does this add when > the remark is enabled? > >> T

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 498118. qiongsiwu1 added a comment. Rebase to resolve clang release note conflict. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseNotes

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

jcranmer-intel added a comment. In D142907#4132430 , @arsenm wrote: > I was thinking of changing the default in general to dynamic. I was going to > at least change the strictfp default in a follow up I had the same thought too, but I reflected a little

[PATCH] D143691: Fix clang-formats IncludeCategory to match the documentation

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/SortIncludesTest.cpp:548 + EXPECT_EQ("#include \"a.h\"\n" +"#include \"llvm/a.h\"\n" +"#include \"b.h\"\n" Febbe wrote: > HazardyKnusperkeks wrote: > > While I m

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:625 +// same spelling. +static std::vector patchDiags(llvm::ArrayRef BaselineDiags, +const ScannedPreamble &BaselineScan, I think this function

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

nickdesaulniers added inline comments. Comment at: clang/test/SemaCXX/expressions.cpp:146-148 #define Y2 2 bool r2 = X || Y2; // expected-warning {{use of logical '||' with constant operand}} \ // expected-note {{use '|' for a bitwise operation}}

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

nickdesaulniers added a comment. Hmm...looking at some of the commits to the related code, it might be very intentional that we don't warn symmetrically: 938533db602b32ab435078e723b656ac6e779a1b e54ff6cc3e479523b71e4c7eb4bd13707d84de0f Comment at: clang/test/SemaCXX/expressio

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

asb added a comment. LGTM, and the summary of the discussion in the sync-up call matches my understanding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143953/new/ https://reviews.llvm.org/D143953 ___

[clang] 22e199e - [RISCV] Accept zicsr and zifencei command line options

Author: Philip Reames Date: 2023-02-16T10:41:41-08:00 New Revision: 22e199e6afb1263c943c0c0d4498694e15bf8a16 URL: https://github.com/llvm/llvm-project/commit/22e199e6afb1263c943c0c0d4498694e15bf8a16 DIFF: https://github.com/llvm/llvm-project/commit/22e199e6afb1263c943c0c0d4498694e15bf8a16.diff

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG22e199e6afb1: [RISCV] Accept zicsr and zifencei command line options (authored by reames). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[libunwind] 372820b - [libunwind][PowerPC] Fix saving/restoring VSX registers on LE systems

Author: Nemanja Ivanovic Date: 2023-02-16T13:37:58-05:00 New Revision: 372820bf571c8d32c8165cfc74b0439c7bb397f9 URL: https://github.com/llvm/llvm-project/commit/372820bf571c8d32c8165cfc74b0439c7bb397f9 DIFF: https://github.com/llvm/llvm-project/commit/372820bf571c8d32c8165cfc74b0439c7bb397f9.di

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm added a comment. In D142907#4132543 , @kpn wrote: > What's the plan for tying this to strictfp? Because I don't it should be tied > to cases where we use the constrained intrinsics but the exceptions are > ignored and the default rounding is in s

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

MaskRay added a comment. Behaviors due to a new environment variable should be very careful. Why is this useful? If you want this, you can add a wrapper around `clang` to specify `--config=` by yourself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

efriedma added inline comments. Comment at: clang/lib/CodeGen/Address.h:67 return; -// Currently the max supported alignment is much less than 1 << 63 and is +// Currently the max supported alignment is much less than 1 << 32 and is // guaranteed to be a power

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/PreambleTests.cpp:235 MockFS FS; - auto TU = TestTU::withCode(Modified); + auto &TU = PreambleTU; + TU.Code = M

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

nickdesaulniers added a comment. I did kernel builds of x86_64 and aarch64 defconfigs. This found new instance: https://github.com/ClangBuiltLinux/linux/issues/1806 which looks like something we can fix in the kernel sources. Our CI will probably find more instances once this lands, but I'm happ

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames added a comment. This was discussed at today's RISCV sync-up call. We have a large conversion pending on the topic of isa compatibility checking, but there was a consensus that this was reasonable and could move forward. I'm going to be landing this change in the near future. CHANGES

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

aaron.ballman marked an inline comment as done. aaron.ballman added a comment. In D143670#4116858 , @erichkeane wrote: > The guidance from EWG this week and in the past was that we are always > required to 'parse and diagnose appertainment' of standard

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

kpn added a comment. What's the plan for tying this to strictfp? Because I don't it should be tied to cases where we use the constrained intrinsics but the exceptions are ignored and the default rounding is in stated. Those instructions are supposed to behave the same as the non-constrained ins

[PATCH] D141307: [WIP] Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 498065. Leporacanthicus added a comment. Rebased and updated help-message Also using different type of template for the option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

raghavendhra accepted this revision. raghavendhra added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 ___

[PATCH] D144120: [HLSL] add log library functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf842b7a6b8f4: [HLSL] add log library functions (authored by bob80905). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[clang] f842b7a - [HLSL] add log library functions

Author: Joshua Batista Date: 2023-02-16T09:50:12-08:00 New Revision: f842b7a6b8f40d817d6d43143e09521bd586a756 URL: https://github.com/llvm/llvm-project/commit/f842b7a6b8f40d817d6d43143e09521bd586a756 DIFF: https://github.com/llvm/llvm-project/commit/f842b7a6b8f40d817d6d43143e09521bd586a756.diff

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

aprantl added a comment. Size-wise this looks like an acceptable increase. If we created a new DW_AT_LLVM_abi_tag, we could save an extra 4 bytes (assuming DW_FORM_strp) per DIE. That might be worth it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D144120: [HLSL] add log library functions

bob80905 updated this revision to Diff 498051. bob80905 added a comment. - add newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144120/new/ https://reviews.llvm.org/D144120 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h clang/test/CodeGe

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm added a comment. In D142907#4132318 , @jcranmer-intel wrote: > Not entirely sure where the best place to effect this (I think somewhere in > the clang driver code?), but on further reflection, it feels like strict > fp-model in clang should set

[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

balazske added a comment. With this fix the `std::__va_list` is created at initialization of Sema, previously it was not there. Function `CreateAArch64ABIBuiltinVaListDecl` (ASTContext.cpp) makes the namespace `std` and `__va_list` record. This change fixes the problem with `ASTImporter` probab

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

nridge added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:222 + tooling::addExpandedResponseFiles(Cmd, Command.Directory, Tokenizer, *FS); + tooling::addTargetAndModeForProgramName(Cmd, Cmd.front()); auto &OptTable = clang::driver::getDriverOptTa

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

nridge added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:222 + tooling::addExpandedResponseFiles(Cmd, Command.Directory, Tokenizer, *FS); + tooling::addTargetAndModeForProgramName(Cmd, Cmd.front()); auto &OptTable = clang::driver::getDriverOptTa

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

jcranmer-intel added a comment. Not entirely sure where the best place to effect this (I think somewhere in the clang driver code?), but on further reflection, it feels like strict fp-model in clang should set the denormal mode to dynamic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:167 + // Spelling should include brackets or quotes, e.g. . + llvm::SmallVector + mainFileIncludesWithSpelling(llvm::StringRef Spelling) const { we're still returning just the `Head

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin updated this revision to Diff 498038. DmitryPolukhin added a comment. Move standard adaptors to CommandMangler Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/cla

[PATCH] D144195: [XCore] Adapt Clang tests to opaque pointers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0871337d97f7: [XCore] Adapt Clang tests to opaque pointers. (authored by nigelp-xmos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] 0871337 - [XCore] Adapt Clang tests to opaque pointers.

Author: Nigel Perks Date: 2023-02-16T16:32:29Z New Revision: 0871337d97f71cac2dbc9cce33c0ecca3c5e5f9c URL: https://github.com/llvm/llvm-project/commit/0871337d97f71cac2dbc9cce33c0ecca3c5e5f9c DIFF: https://github.com/llvm/llvm-project/commit/0871337d97f71cac2dbc9cce33c0ecca3c5e5f9c.diff LOG: [

[PATCH] D144196: [C2x] Remove the ATOMIC_VAR_INIT macro from stdatomic.h

aaron.ballman created this revision. aaron.ballman added reviewers: clang-language-wg, jyknight, libc++. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements WG14 N2886 (https://www.ope

[PATCH] D144195: [XCore] Adapt Clang tests to opaque pointers.

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144195/new/ https://reviews.llvm.org/D144195 ___ c

  1   2   >