[PATCH] D141409: [SystemZ] Fix handling of vectors and their exposure of the vector ABI.

Andreas-Krebbel added a comment. In D141409#4083192 , @uweigand wrote: > In D141409#4083017 , @jonpa wrote: > >> Review addressed - hopefully this time with a better result. >> >> I think the patch now does what I

[PATCH] D139926: [clangd] Add semantic token for angle brackets

nridge added a comment. In D139926#4084970 , @ckandeler wrote: > Adding AutoTypeLoc broke tons of tests, so I left it out for now. Poked at this a bit, it looks like `AutoTypeLoc.getLAngleLoc()` is only safe to access if it `isConstrained()`. This is po

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added a comment. In D142836#4089721 , @kadircet wrote: > And to follow up, I definitely see the problem you're facing and it's > something we'd like to address as well, just not in the way you proposed. > > This falls under the bucket of "we migh

[clang-tools-extra] 89590cd - [clangd] Fix test failure in TypeHints.Decltype

Author: Nathan Ridge Date: 2023-01-30T02:08:02-05:00 New Revision: 89590cd1fe7ce61edf0ba59d3e7dc171e5fc0211 URL: https://github.com/llvm/llvm-project/commit/89590cd1fe7ce61edf0ba59d3e7dc171e5fc0211 DIFF: https://github.com/llvm/llvm-project/commit/89590cd1fe7ce61edf0ba59d3e7dc171e5fc0211.diff

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added a comment. Another question is that file `clang/Tooling/Inclusions/StdSymbolMap.inc` seems to be out-of-date. What's worse, the archive of cppref doesn't always update on time The latest version from official is published in 201

[PATCH] D142697: [3/3][Clang][RISCV] Add `__riscv_` for overloaded intrinsics

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142697/new/ https://reviews.llvm.org/D142697 ___

[PATCH] D142644: [2/3][Clang][RISCV] Add `__riscv_` for non-overloaded intrinsics

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142644/new/ https://reviews.llvm.org/D142644 ___

[PATCH] D142085: [1/3][Clang][RISCV] Add `__riscv_` prefix for vread, vwrite, vlenb, vsetvl, and vsetvlmax

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142085/new/ https://reviews.llvm.org/D142085 ___

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

kadircet added a comment. And to follow up, I definitely see the problem you're facing and it's something we'd like to address as well, just not in the way you proposed. This falls under the bucket of "we might have symbols missing from our stdlib mappings and should try to compensate for that"

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

kadircet added a subscriber: VitaNuo. kadircet added a comment. thanks a lot for the patch, we're already having some efforts right now to improve our cppreference parsing and get to a more complete set of symbols (@VitaNuo for visibility, who drives these efforts). Regarding the experimental s

[PATCH] D142440: [clangd] Don't show 'auto' type hint when type deduction fails

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68d7f69001c5: [clangd] Don't show 'auto' type hint when type deduction fails (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SI

[clang-tools-extra] 68d7f69 - [clangd] Don't show 'auto' type hint when type deduction fails

Author: Nathan Ridge Date: 2023-01-30T01:21:09-05:00 New Revision: 68d7f69001c5123d3ec4a93df483a417d981d415 URL: https://github.com/llvm/llvm-project/commit/68d7f69001c5123d3ec4a93df483a417d981d415 DIFF: https://github.com/llvm/llvm-project/commit/68d7f69001c5123d3ec4a93df483a417d981d415.diff

[PATCH] D142440: [clangd] Don't show 'auto' type hint when type deduction fails

nridge updated this revision to Diff 493203. nridge added a comment. address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142440/new/ https://reviews.llvm.org/D142440 Files: clang-tools-extra/clangd/InlayHints.cpp clang-tools-extra/clangd

[PATCH] D142867: [Clang] Add machinery to catch overflow in unary minus outside of a constant expression context

shafik created this revision. shafik added reviewers: erichkeane, aaron.ballman. Herald added a project: All. shafik requested review of this revision. We provide several diagnostics for various undefined behaviors due to signed integer overflow outside of a constant expression context. We were m

[PATCH] D142804: [clang-format] Support clang-format on/off line comments as prefixes

alexolog added inline comments. Comment at: clang/lib/Format/Format.cpp:3893 +bool isClangFormatOn(StringRef Comment) { + if (Comment == "/* clang-format on */") owenpan wrote: > alexolog wrote: > > alexolog wrote: > > > Here's my attempt at something flexible

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan updated this revision to Diff 493195. zyounan added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142836/new/ https://reviews.llvm.org/D142836 Files: clang-tools-extra/clangd/index/CanonicalIncludes.cpp clang-tools-ex

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter added a comment. Gentle poke for any last reviews? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141133/new/ https://reviews.llvm.org/D141133 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

erikdesjardins added inline comments. Comment at: llvm/test/DebugInfo/X86/gnu-public-names.ll:68-71 ; ASM: .byte 32 # Attributes: VARIABLE, EXTERNAL +; ASM-NEXT: .asciz "ns::global_namespace_variable" # External Name +; ASM: .byte 32

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

erikdesjardins created this revision. Herald added subscribers: Moerafaat, zero9178, Enna1, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, wenlei, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, r

[PATCH] D142861: [Clang] avoid relying on StringMap iteration order when roundtripping -analyzer-config

erikdesjardins created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, mgrang, baloghadamsoftware. Herald added a project: All. erikdesjardins requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-c

[PATCH] D142804: [clang-format] Support clang-format on/off line comments as prefixes

owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:3901 + return Comment.startswith(Prefix) && + (Comment.size() == Size || isblank(Comment[Size])); +} HazardyKnusperkeks wrote: > owenpan wrote: > > HazardyKnusperkeks wrote: > > > rym

[PATCH] D142804: [clang-format] Support clang-format on/off line comments as prefixes

owenpan updated this revision to Diff 493180. owenpan added a comment. Improves `isClangFormatOnOff()` a little bit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142804/new/ https://reviews.llvm.org/D142804 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/F

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when '-T' is specified

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:544 + if (SectionAddressData) { +CmdArgs.push_back(Args.MakeArgString( +"-Tdata=0x" + Twine::utohexstr(*SectionAddressData))); Just moving the default `-T` f

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when '-T' is specified

benshi001 updated this revision to Diff 493179. benshi001 retitled this revision from "[Driver][AVR] Don't emit default '-Tdata' when a linker script is specified" to "[Driver][AVR] Don't emit default '-Tdata' when '-T' is specified". benshi001 edited the summary of this revision. benshi001 remov

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

akyrtzi added a comment. Hi @domada, these changes break compilation of clang, with such build error: FAILED: tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTContext.cpp.o In file included from /llvm-project/clang/lib/AST/ASTContext.cpp:81: In file included from /llvm-project/llvm/i

[PATCH] D142857: [clang] Remove clang::Optional

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG125f4457a54a: [clang] Remove clang::Optional (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] 125f445 - [clang] Remove clang::Optional

Author: Kazu Hirata Date: 2023-01-29T18:08:00-08:00 New Revision: 125f4457a54a550846732763ee36b1447ec8d66e URL: https://github.com/llvm/llvm-project/commit/125f4457a54a550846732763ee36b1447ec8d66e DIFF: https://github.com/llvm/llvm-project/commit/125f4457a54a550846732763ee36b1447ec8d66e.diff L

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when a linker script is specified

benshi001 added a comment. In D142595#4089124 , @MaskRay wrote: > OK. If this doesn't add `-Tdata=` driver options, I'm fine with it. > But why is default `-Tdata` added in the first place? > > Most linker scripts are added as `-Wl,-T,a.lds` (`-Wl,` value

[PATCH] D142857: [clang] Remove clang::Optional

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142857/new/ https://reviews.llvm.org/D142857 __

[PATCH] D142857: [clang] Remove clang::Optional

kazu created this revision. Herald added a project: All. kazu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is part of an effort to migrate from llvm::Optional to std::optional: https://discourse.llvm.org/t/deprecating-llvm-optional

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

nridge added a comment. @daiyousei-qz what is the current status of this patch? Is it ready to be merged again? (If so, I can do that for you.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127082/new/ https://reviews.llvm.org/D127082 ___

[clang] 7a063c1 - [AST] Use llvm::bit_ceil (NFC)

Author: Kazu Hirata Date: 2023-01-29T15:39:46-08:00 New Revision: 7a063c1a13b209425ef1611a5f08e2c500ac7f30 URL: https://github.com/llvm/llvm-project/commit/7a063c1a13b209425ef1611a5f08e2c500ac7f30 DIFF: https://github.com/llvm/llvm-project/commit/7a063c1a13b209425ef1611a5f08e2c500ac7f30.diff L

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:687 +def warn_drv_dxc_missing_dxv : Warning<"dxv not found." +" Resulting DXIL will not be signed for use in release environments.">; MaskRay wrote: > python3k

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 493149. python3kgae marked 2 inline comments as done. python3kgae added a comment. add space for warning message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/ https://reviews.llvm.org/D141705

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when a linker script is specified

MaskRay added a comment. OK. If this doesn't add `-Tdata=` driver options, I'm fine with it. But why is default `-Tdata` added in the first place? Most linker scripts are added as `-Wl,-T,a.lds` (`-Wl,` values are opaque to the driver), so the driver cannot really know whether a linker script is

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

MaskRay added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:687 +def warn_drv_dxc_missing_dxv : Warning<"dxv not found." +" Resulting DXIL will not be signed for use in release environments.">; python3kgae wrote: > beanz wr

[PATCH] D142733: Add _Optional as fast qualifier

chrisbazley added a comment. Hi, thanks very much for looking at my patch. I added the link that you proposed to all of the patches in the stack. > Assuming that we want to go in this direction, it seems quite expensive to > model this as a fast qualifier rather than an extended qualifier. Tru

[PATCH] D142804: [clang-format] Support clang-format on/off line comments as prefixes

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3901 + return Comment.startswith(Prefix) && + (Comment.size() == Size || isblank(Comment[Size])); +} owenpan wrote: > HazardyKnusperkeks wrote: > > rymiel wrote: > > > Shou

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp marked an inline comment as done. carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:34 +static StringRef TrimFirstChar(StringRef x) { return x.substr(1); } + ClockMan wrote: > Looks like usecase o

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 493110. carlosgalvezp added a comment. Wrap trimming functionality in desc function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D141144 Files: clang-tools-extra/

[PATCH] D142704: [C++20][Modules] Handle template declarations in header units.

iains added a comment. AFAICT the failing test is unrelated to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142704/new/ https://reviews.llvm.org/D142704 ___ cfe-commits mailing list cfe-comm

[clang] 3d25896 - [AST] Use std::clamp (NFC)

Author: Kazu Hirata Date: 2023-01-29T09:43:36-08:00 New Revision: 3d25896bd97cc0f86d5861ec123a6b9556727b6c URL: https://github.com/llvm/llvm-project/commit/3d25896bd97cc0f86d5861ec123a6b9556727b6c DIFF: https://github.com/llvm/llvm-project/commit/3d25896bd97cc0f86d5861ec123a6b9556727b6c.diff L

cfe-commits@lists.llvm.org

dkt01 updated this revision to Diff 493104. dkt01 added a comment. Updates suggested in owenpan's review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141959/new/ https://reviews.llvm.org/D141959 Files: clang/lib/Format/TokenAnnotator.cpp clang/lib/Format/TokenAnnotator.h clang/

cfe-commits@lists.llvm.org

dkt01 marked 11 inline comments as done. dkt01 added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1195-1198 + // Handle unbalanced braces. + if (!Scopes.empty()) +Scopes.pop_back(); // Lines can start with '}'. owenpan

[PATCH] D142738: Warn if _Optional used at top-level of decl

chrisbazley added a comment. Please refer to https://discourse.llvm.org/t/rfc-optional-a-type-qualifier-to-indicate-pointer-nullability/ and https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3089.pdf for the wider context of this commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D142737: Updated getNullabilityAnnotation for checkers

chrisbazley added a comment. Please refer to https://discourse.llvm.org/t/rfc-optional-a-type-qualifier-to-indicate-pointer-nullability/ and https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3089.pdf for the wider context of this commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D142736: Add QualType::getNullability for _Optional

chrisbazley added a comment. Please refer to https://discourse.llvm.org/t/rfc-optional-a-type-qualifier-to-indicate-pointer-nullability/ and https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3089.pdf for the wider context of this commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D142734: Updated CheckAddressOfOperand

chrisbazley added a comment. Please refer to https://discourse.llvm.org/t/rfc-optional-a-type-qualifier-to-indicate-pointer-nullability/ and https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3089.pdf for the wider context of this commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D142733: Add _Optional as fast qualifier

chrisbazley added a comment. Please refer to https://discourse.llvm.org/t/rfc-optional-a-type-qualifier-to-indicate-pointer-nullability/ and https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3089.pdf for the wider context of this commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D142744: Re-analyze functions as top-level

chrisbazley added a comment. Please refer to https://discourse.llvm.org/t/rfc-optional-a-type-qualifier-to-indicate-pointer-nullability/ and https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3089.pdf for the wider context of this commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D142743: Fix nullability checking of top-level functions

chrisbazley added a comment. Please refer to https://discourse.llvm.org/t/rfc-optional-a-type-qualifier-to-indicate-pointer-nullability/ and https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3089.pdf for the wider context of this commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D142742: Generate ImplicitNullDerefEvent from CallAndMessageChecker

chrisbazley added a comment. Please refer to https://discourse.llvm.org/t/rfc-optional-a-type-qualifier-to-indicate-pointer-nullability/ and https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3089.pdf for the wider context of this commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D142741: Fix ProgramState::isNull for non-region symbols

chrisbazley added a comment. Please refer to https://discourse.llvm.org/t/rfc-optional-a-type-qualifier-to-indicate-pointer-nullability/ and https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3089.pdf for the wider context of this commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D142739: Standalone checker for use of _Optional qualifier

chrisbazley added a comment. Please refer to https://discourse.llvm.org/t/rfc-optional-a-type-qualifier-to-indicate-pointer-nullability/ and https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3089.pdf for the wider context of this commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace

tom-anders marked an inline comment as done. tom-anders added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1714 +} +llvm::copy_if(SpecifiedScopes.scopesForIndexQuery(), + std::back_inserter(QueryScopes), Should I

[PATCH] D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace

tom-anders updated this revision to Diff 493096. tom-anders marked 8 inline comments as done. tom-anders added a comment. Address review comments, add regression test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140915/new/ https://reviews.llvm.or

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

v1nh1shungry added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:994 HI.CalleeArgInfo.emplace(toHoverInfoParam(PVD, PP)); + PassType.PassBy = getPassMode(PVD->getType()); +} kadircet wrote: > v1nh1shungry wrote: > > kadircet wrot

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson marked an inline comment as done. royjacobson added a comment. In D142578#4088011 , @tschuett wrote: > IDK. Clang 16 is fully is a fully conformant C++20 except for some DRs. Or > beginning with Clang 16, we start a long-term project to overh

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan updated this revision to Diff 493081. zyounan added a comment. Do not format inc file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142836/new/ https://reviews.llvm.org/D142836 Files: clang-tools-extra/clangd/index/CanonicalIncludes.cpp

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan edited the summary of this revision. zyounan added reviewers: hokein, sammccall, nridge. zyounan published this revision for review. Herald added subscribers: cfe-commits, MaskRay, ilya