[PATCH] D136848: [clang][AST] Compare UnresolvedLookupExpr in structural equivalence.

gamesh411 accepted this revision. gamesh411 added a comment. This revision is now accepted and ready to land. I have verified this patch on open-source projects. Bitcoin had quite a few crashes without this; those are gone. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

v1nh1shungry updated this revision to Diff 484170. v1nh1shungry added a comment. Insert the using-declarations in the outermost `CompoundStmt` instead of the innermost one. Can reduce some potential rebundancy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/TypeTraitsCheck.cpp:140 +const internal::VariadicDynCastAllOfMatcher +dependentNameTypeLoc; // NOLINT(readability-identifier-naming) + I don't see a reason why the naming

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

royjacobson added a comment. This seems to be stuck with no reviewers, is there any way to help here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137302/new/ https://reviews.llvm.org/D137302 ___ cfe-co

[PATCH] D140018: [clang-tidy] Support std::string_view in readability-redundant-string-cstr

carlosgalvezp accepted this revision. carlosgalvezp added a comment. LGTM, perhaps give a couple days to @njames93 to give a final look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140018/new/ https://reviews.llvm.org/D140018 ___

[PATCH] D140261: [C++20][Modules] Do not allow non-inline external definitions in header units.

ChuanqiXu added a comment. > So it's not a change that breaks existing code - because no-one has Header > Units in existing code. We can't assume this. Since we already said people can try to use header units in clang15. We can't assume there is nobody using header units just because they don'

[PATCH] D140261: [C++20][Modules] Do not allow non-inline external definitions in header units.

iains marked an inline comment as done. iains added a comment. In D140261#4006653 , @ChuanqiXu wrote: > In D140261#4004542 , @iains wrote: > >> OK so this is what I plan to land assuming testing goes OK. >> I susp

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

uabelho added a comment. In D112621#4004586 , @steakhal wrote: > Fixed by f61a08b67f5c8b0202dd30821766ee029e880b7c > Yep, thanks! Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

uabelho added a comment. In D138253#4006197 , @NoQ wrote: > Also if you're compiling your code with `-Weverything` by default, I do > recommend explicitly disabling `-Wunsafe-buffer-usage` for at least a month > or so, until we land all the basic functi

[PATCH] D140292: [OpenMP] Migrate OpenMPOffloadMappingFlags from Clang CodeGen to OMPConstants

jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:193 - OMP_TGT_EXEC_MODE_GENERIC | OMP_TGT_EXEC_MODE_SPMD, - LLVM_MARK_AS_BITMASK_ENUM(/* LargestValue */ OMP_TGT_EXEC_MODE_GENERIC_SPMD) }; TIFitis wrote: > jdoer

[PATCH] D137343: [clang] add -Wvla-stack-allocation

rjmccall added a comment. Aaron's suggested design makes the most sense to me, of all the designs I've seen here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137343/new/ https://reviews.llvm.org/D137343 _

[PATCH] D136639: [CodeGen][ObjC] Fix a memory leak that occurs when a non-trivial C struct property is set using dot notation

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Oh, I see. That's a really unfortunate way to end up emitting this code pattern, since ignoring the result is so common. To fix that, we'd have to either figure out the result was unused

[PATCH] D140292: [OpenMP] Migrate OpenMPOffloadMappingFlags from Clang CodeGen to OMPConstants

TIFitis marked an inline comment as done. TIFitis added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:193 - OMP_TGT_EXEC_MODE_GENERIC | OMP_TGT_EXEC_MODE_SPMD, - LLVM_MARK_AS_BITMASK_ENUM(/* LargestValue */ OMP_TGT_EXEC_MODE_GENERIC_SPMD) };

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 484156. ziqingluo-90 added a comment. did a rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139737/new/ https://reviews.llvm.org/D139737 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h clang/lib/Analysis/UnsafeBufferU

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 484154. 4vtomat marked 22 inline comments as done. 4vtomat added a comment. Replace llvm/test/MC/RISCV/rvv/rv64zvknhb.s and llvm/test/MC/RISCV/rvv/rv64zvknhb.s with a single llvm/test/MC/RISCV/rvv/rv64zvknh.s Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D116070: [X86] Enable ibt-seal optimization when LTO is used in Kernel

MaskRay added a comment. Sent D140363 to remove this incorrectly implemented option. Comment at: llvm/test/CodeGen/X86/ibtseal-small.ll:1 +; RUN: llc < %s -O2 -mtriple=x86_64-unknown-linux-gnu -x86-indirect-branch-tracking --code-model=small

[PATCH] D140363: Remove incorrectly implemented -mibt-seal

MaskRay created this revision. MaskRay added reviewers: joaomoreira, kees, nickdesaulniers, pcc, samitolvanen, xiangzhangllvm. Herald added subscribers: StephenFan, pengfei, hiraditya. Herald added a project: All. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Heral

[PATCH] D140361: [WIP][RISCV] Merge Masked and unMasked manual codegen

BeMg created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabu

[PATCH] D140261: [C++20][Modules] Do not allow non-inline external definitions in header units.

ChuanqiXu added a comment. In D140261#4004542 , @iains wrote: > OK so this is what I plan to land assuming testing goes OK. > I suspect that this might cause some user code to flag errors - there are > quite a number of ODR violations "in the wild". I f

[PATCH] D140281: [X86] Rename CMPCCXADD intrinsics.

lebedev.ri added a comment. In D140281#4006650 , @FreddyYe wrote: > In D140281#4004707 , @lebedev.ri > wrote: > >> This patch says what it does, but not why it does what it does. > > Sorry for not mention. This p

[PATCH] D140281: [X86] Rename CMPCCXADD intrinsics.

FreddyYe added a comment. In D140281#4004707 , @lebedev.ri wrote: > This patch says what it does, but not why it does what it does. Sorry for not mention. This patch is mainly to align with other intrinsics to follow single leading "_" style. Gcc and i

[PATCH] D139233: [-Wunsafe-buffer-usage] Add an unsafe gadget for pointer-arithmetic operations

ziqingluo-90 updated this revision to Diff 484138. ziqingluo-90 added a comment. Did a rebase and addressed the comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139233/new/ https://reviews.llvm.org/D139233 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsageGadgets.de

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

MaskRay added a comment. (Sorry for my belated response.) If we make ThinLTO properly track combined the address-taken property, and combine precise `addressTaken` and `VisibleToRegularObj`, it seems that we can use this condition to decide whether ENDBR is needed with an appropriate code mode

[PATCH] D140035: [X86] Prevent -mibt-seal to work together with -flto=thin

MaskRay added a comment. I did not notice this patch (and https://github.com/ClangBuiltLinux/linux/issues/1737#issuecomment-1310741237) but make a comment yesterday while studying CFI schemes in llvm-project: https://reviews.llvm.org/D116070#4004060 As mentioned, the `isUsedInRegularObj` issue

[PATCH] D138329: [-Wunsafe-buffer-usage] Add a new recursive matcher to replace `forEachDescendant` in unsafe buffer check

ziqingluo-90 updated this revision to Diff 484136. ziqingluo-90 added a comment. Did a rebase and addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138329/new/ https://reviews.llvm.org/D138329 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-u

[PATCH] D127221: [Clang] Enable -print-pipeline-passes in clang.

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. Herald added a subscriber: wdng. I have no idea how you're supposed to work with clang without this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D115232: [clangd] Indexing of standard library

bnbarham added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:1008-1010 + // TUScheduler is the only thing that starts background indexing work. + if (IndexTasks && !IndexTasks->wait(timeoutSeconds(TimeoutSeconds))) +return false; @s

[clang] 2916b99 - [ADT] Alias llvm::Optional to std::optional

Author: Benjamin Kramer Date: 2022-12-20T01:01:46+01:00 New Revision: 2916b99182752b1aece8cc4479d8d6a20b5e02da URL: https://github.com/llvm/llvm-project/commit/2916b99182752b1aece8cc4479d8d6a20b5e02da DIFF: https://github.com/llvm/llvm-project/commit/2916b99182752b1aece8cc4479d8d6a20b5e02da.dif

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

efriedma added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4852 + if (!CD->isTrivial() && !D->getTLSKind()) +NeedsGlobalCtor = true; +} zahiraam wrote: > efriedma wrote: > > zahiraam wrote: > > > efriedma wrote: >

[PATCH] D139496: [CMake] Add perf profiling for clang-bolt

Amir updated this revision to Diff 484102. Amir added a comment. Typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake llvm/docs/AdvancedBuil

[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

barannikov88 accepted this revision. barannikov88 added inline comments. Comment at: llvm/lib/CodeGen/RegAllocGreedy.h:83 public: -ExtraRegInfo() = default; +ExtraRegInfo() {} ExtraRegInfo(const ExtraRegInfo &) = delete; bkramer wrote: > baranniko

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4852 + if (!CD->isTrivial() && !D->getTLSKind()) +NeedsGlobalCtor = true; +} efriedma wrote: > zahiraam wrote: > > efriedma wrote: > > > I have no idea wh

[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

bkramer marked an inline comment as done. bkramer added a comment. In D140332#4005988 , @MaskRay wrote: > Can you push `using OptionalFileEntryRef = > CustomizableOptional;` and the renaming as a separate commit to > make this patch smaller? > There is

[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

bkramer marked an inline comment as done. bkramer added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:513 if (Opts.MaxBitIntWidth) -MaxBitIntWidth = Opts.MaxBitIntWidth; +MaxBitIntWidth = (unsigned)Opts.MaxBitIntWidth; barannikov88 wrot

[PATCH] D127442: [Sema] Fix a bug where clang doesn't detect uses of unavailable decls in C++ base or member initializers

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127442/new/ https://reviews.llvm.org/D127442 ___

[PATCH] D140336: [OpenMP][NFC] Cleanup clause boilerplate (unfinished)

This revision was automatically updated to reflect the committed changes. Closed by commit rG66890ce0b3d3: [OpenMP][NFC] Cleanup clause boilerplate (authored by jdoerfert). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D

[clang] 66890ce - [OpenMP][NFC] Cleanup clause boilerplate

Author: Johannes Doerfert Date: 2022-12-19T14:32:39-08:00 New Revision: 66890ce0b3d384225302d8c95817a51954102891 URL: https://github.com/llvm/llvm-project/commit/66890ce0b3d384225302d8c95817a51954102891 DIFF: https://github.com/llvm/llvm-project/commit/66890ce0b3d384225302d8c95817a51954102891.d

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

efriedma added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4852 + if (!CD->isTrivial() && !D->getTLSKind()) +NeedsGlobalCtor = true; +} zahiraam wrote: > efriedma wrote: > > I have no idea what this code is suppos

[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

NoQ added a comment. Also if you're compiling your code with `-Weverything` by default, I do recommend explicitly disabling `-Wunsafe-buffer-usage` for at least a month or so, until we land all the basic functionality and you can make an informed decision whether you actually need it (more read

[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

NoQ added a comment. Ooo thanks I'll fix asap. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138253/new/ https://reviews.llvm.org/D138253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D140339: [clang-format] Remove special logic for parsing concept definitions.

rymiel marked an inline comment as done. rymiel added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:23940 // assert. - verifyFormat("template \n" - "concept C = requires C2;"); - - verifyFormat("template \n" - "concept C = 5 +

[PATCH] D140339: [clang-format] Remove special logic for parsing concept definitions.

rymiel updated this revision to Diff 484066. rymiel added a comment. Use verifyNoCrash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140339/new/ https://reviews.llvm.org/D140339 Files: clang/lib/Format/TokenAnnotator.cpp clang/lib/Format/Unwra

[PATCH] D140339: [clang-format] Remove special logic for parsing concept definitions.

rymiel added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1683 -if (Tok->isOneOf(tok::kw_class, tok::kw_enum, tok::kw_concept, - tok::kw_struct, tok::kw_using)) { +if (Tok->isOneOf(tok::kw_class, tok::kw_enum, tok::kw_

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4852 + if (!CD->isTrivial() && !D->getTLSKind()) +NeedsGlobalCtor = true; +} efriedma wrote: > I have no idea what this code is supposed to do. I have remove

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484062. zahiraam marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/Co

[PATCH] D140312: [clang-format] Disallow decltype in the middle of constraints

rymiel added a comment. What if I make this depend on D140339 ? Then this change would no longer impact concept definitions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140312/new/ https://reviews.llvm.org/D1403

[PATCH] D140339: [clang-format] Remove special logic for parsing concept definitions.

HazardyKnusperkeks added a comment. I'm shocked and impressed, that it just works. Comment at: clang/lib/Format/TokenAnnotator.cpp:1683 -if (Tok->isOneOf(tok::kw_class, tok::kw_enum, tok::kw_concept, - tok::kw_struct, tok::kw_using)) { +

[PATCH] D140312: [clang-format] Disallow decltype in the middle of constraints

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. You have to do better: https://gcc.godbolt.org/z/7hEKx1dhv Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140312

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

dblaikie added a comment. In D139986#4003873 , @Mordante wrote: > In D139986#4001180 , @Michael137 > wrote: > >> Missed couple of test cases in libcxx >> About to fix those > > There were more breakage due to thi

[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

MaskRay added a comment. Can you push `using OptionalFileEntryRef = CustomizableOptional;` and the renaming as a separate commit to make this patch smaller? There is a smaller that this rename may be reverted. 205c0589f918f95d2f2c586a01bea2716d73d603

[PATCH] D138300: [clangd] Support type hints for `decltype(expr)`

nridge added a comment. Done, thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138300/new/ https://reviews.llvm.org/D138300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D139938: [clang] Don't spuriously pass -stdlib=libc++ to CC1 on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rG6540f32db09c: [clang] Don't spuriously pass -stdlib=libc++ to CC1 on Darwin (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139938/new/

[clang] 6540f32 - [clang] Don't spuriously pass -stdlib=libc++ to CC1 on Darwin

Author: Louis Dionne Date: 2022-12-19T16:11:39-05:00 New Revision: 6540f32db09cf6b367812642fbd91d44cbb6638d URL: https://github.com/llvm/llvm-project/commit/6540f32db09cf6b367812642fbd91d44cbb6638d DIFF: https://github.com/llvm/llvm-project/commit/6540f32db09cf6b367812642fbd91d44cbb6638d.diff

[PATCH] D138300: [clangd] Support type hints for `decltype(expr)`

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b2cf982cc51: [clangd] Support type hints for `decltype(expr)` (authored by v1nh1shungry, committed by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang-tools-extra] 4b2cf98 - [clangd] Support type hints for `decltype(expr)`

Author: v1nh1shungry Date: 2022-12-19T16:10:26-05:00 New Revision: 4b2cf982cc51b425b935842e64aa7ec645ad6807 URL: https://github.com/llvm/llvm-project/commit/4b2cf982cc51b425b935842e64aa7ec645ad6807 DIFF: https://github.com/llvm/llvm-project/commit/4b2cf982cc51b425b935842e64aa7ec645ad6807.diff

[PATCH] D140308: [clang][dataflow][NFC] Fix comments related to widening.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2e4aaf6ac3b: [clang][dataflow][NFC] Fix comments related to widening. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] d2e4aaf - [clang][dataflow][NFC] Fix comments related to widening.

Author: Yitzhak Mandelbaum Date: 2022-12-19T21:01:27Z New Revision: d2e4aaf6ac3bc7c72a81f050512afa17a9ceb54b URL: https://github.com/llvm/llvm-project/commit/d2e4aaf6ac3bc7c72a81f050512afa17a9ceb54b DIFF: https://github.com/llvm/llvm-project/commit/d2e4aaf6ac3bc7c72a81f050512afa17a9ceb54b.diff

[PATCH] D140344: [clang][dataflow] In optional model, implement `widen` and make `compare` sound.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2, kinu, sgatev. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch includes two rel

[PATCH] D140339: [clang-format] Remove special logic for parsing concept definitions.

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, clang-format relied on a special method to pa

[PATCH] D140330: [clang-format] Set requires expression params as not an expression

rymiel updated this revision to Diff 484040. rymiel added a comment. Small spacing typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140330/new/ https://reviews.llvm.org/D140330 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Forma

[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

barannikov88 added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:513 if (Opts.MaxBitIntWidth) -MaxBitIntWidth = Opts.MaxBitIntWidth; +MaxBitIntWidth = (unsigned)Opts.MaxBitIntWidth; Nit: C-style casts are generally discouraged (there ar

[PATCH] D139701: [Clang] Emit "min-legal-vector-width" attribute for X86 only

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139701/new/ https://reviews.llvm.org/D139701 ___

[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

probinson added a comment. Herald added subscribers: jsetoain, JDevlieghere, ormris. Worth trying on MSVC, which is the other more likely place to fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140332/new/ https://reviews.llvm.org/D140332 ___

[PATCH] D140330: [clang-format] Set requires expression params as not an expression

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, the parens of a requires expression's "parame

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. usaxena95 marked an inline comment as done. Closed by commit rGb3ce87285186: Make evaluation of nested requirement consistent with requires expr. (authored by usaxena95

[clang] b3ce872 - Make evaluation of nested requirement consistent with requires expr.

Author: Utkarsh Saxena Date: 2022-12-19T20:22:03+01:00 New Revision: b3ce87285186ba190103a90b0b49da2e45fb7d1f URL: https://github.com/llvm/llvm-project/commit/b3ce87285186ba190103a90b0b49da2e45fb7d1f DIFF: https://github.com/llvm/llvm-project/commit/b3ce87285186ba190103a90b0b49da2e45fb7d1f.diff

[PATCH] D138393: HIP: Directly call fabs builtins

arsenm closed this revision. arsenm added a comment. 81616561c1b376af85365c9eaf94d49ad184c623 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138393/new/ https://reviews.llvm.org/D138393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D140328: [ASTMatchers] Add isInAnonymousNamespace narrowing matcher

carlosgalvezp created this revision. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Used in a couple clang-tidy checks so it could be extracted out as its own matcher. Repository: rG LLVM Gith

[PATCH] D140327: [clang] Remove overly restrictive aggregate paren init logic

ayzhao created this revision. ayzhao added a reviewer: ilya-biryukov. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, we would only attempt to perform a parenthesized aggregate initialization

[PATCH] D140292: [OpenMP] Migrate OpenMPOffloadMappingFlags from Clang CodeGen to OMPConstants

jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:193 - OMP_TGT_EXEC_MODE_GENERIC | OMP_TGT_EXEC_MODE_SPMD, - LLVM_MARK_AS_BITMASK_ENUM(/* LargestValue */ OMP_TGT_EXEC_MODE_GENERIC_SPMD) }; TIFitis wrote: > I am

[PATCH] D140300: [lit] Fix a few issues in relative_lines.py

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG683451bce3d6: [lit] Fix a few issues in relative_lines.py (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D138511: [CodeGen][AArch64] Fix AArch64ABIInfo::EmitAAPCSVAArg crash with empty record type in variadic arg

efriedma added a comment. Not sure what this is waiting on; do you need someone to merge for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138511/new/ https://reviews.llvm.org/D138511 ___ cfe-commit

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

efriedma added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4761 + return Opts.CPlusPlus && D->hasConstantInitialization() && + D->getType()->isRecordType(); +} Not sure what the `D->getType()->isRecordType()` check is doing here. =

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

usaxena95 updated this revision to Diff 484013. usaxena95 added a comment. Herald added a subscriber: arphaman. Removed use of SubstitutionDiagnostic from NestedRequirement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138914/new/ https://reviews.

[PATCH] D140284: [include-cleaner] Base-type usage from member exprs is implicit.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a7ea764b258: [include-cleaner] Base-type usage from member exprs is implicit. (authored by hokein). Changed prior to commit: https://reviews.llvm

[clang-tools-extra] 8a7ea76 - [include-cleaner] Base-type usage from member exprs is implicit.

Author: Haojian Wu Date: 2022-12-19T19:46:18+01:00 New Revision: 8a7ea764b2583e93fe0a332739c391d3bb11a867 URL: https://github.com/llvm/llvm-project/commit/8a7ea764b2583e93fe0a332739c391d3bb11a867 DIFF: https://github.com/llvm/llvm-project/commit/8a7ea764b2583e93fe0a332739c391d3bb11a867.diff LO

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484006. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CGE

[PATCH] D140290: [clang-tidy] Add misc-static-declaration-in-header check

carlosgalvezp updated this revision to Diff 484000. carlosgalvezp added a comment. Replace quotes with single backticks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140290/new/ https://reviews.llvm.org/D140290 Files: clang-tools-extra/clang-ti

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

arsenm added a comment. This will produce worse codegen in many situations. I'm working on a stack of patches to convert is.fpclass back to fcmp when legal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112932/new/ https://reviews.llvm.org/D112932

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

sepavloff updated this revision to Diff 483994. sepavloff added a comment. Remove __builtin_isfpclass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112932/new/ https://reviews.llvm.org/D112932 Files: clang/include/clang/Basic/Builtins.def clan

[PATCH] D140315: [AMDGCN] Update search path for device libraries

scchan created this revision. scchan added a reviewer: yaxunl. Herald added subscribers: kosarev, kerbowa, jvesely. Herald added a project: All. scchan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. - Add support for finding device

[PATCH] D140290: [clang-tidy] Add misc-static-declaration-in-header check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc/static-declaration-in-header.rst:39 + A semicolon-separated list of filename extensions of header files (the filename + extensions should not include "." prefix). Default is ";h;

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

barannikov88 accepted this revision. barannikov88 added a comment. In D139973#4005120 , @sebastian-ne wrote: > the question gets wether we want to keep llvm::Any around as a wrapper of > std::any once we can use it (in this case this patch would be obso

[PATCH] D137790: [clang][analyzer] Remove report of null stream from StreamChecker.

balazske added a comment. I would split the patches D135360 and D135247 (the two before this) into new patches, one for `StreamChecker`, other for `StdLibraryFunctionsChecker` only. This can make review (and commit history) m

[PATCH] D138392: clang/HIP: Fix broken implementations of __make_mantissa* functions

arsenm requested review of this revision. arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138392/new/ https://reviews.llvm.org/D138392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D140312: [clang-format] Disallow decltype in the middle of constraints

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a function with a `requires` clause as a constraint ha

[PATCH] D140290: [clang-tidy] Add misc-static-declaration-in-header check

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc/static-declaration-in-header.rst:39 + A semicolon-separated list of filename extensions of header files (the filename + extensions should not include "." prefix). Default is ";h;h

[PATCH] D140290: [clang-tidy] Add misc-static-declaration-in-header check

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc/static-declaration-in-header.rst:39 + A semicolon-separated list of filename extensions of header files (the filename + extensions should not include "." prefix). Default is ";h;h

[PATCH] D140290: [clang-tidy] Add misc-static-declaration-in-header check

carlosgalvezp updated this revision to Diff 483981. carlosgalvezp marked an inline comment as done. carlosgalvezp added a comment. Add description in release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140290/new/ https://reviews.llvm.org/

[PATCH] D140226: [NVPTX] Introduce attribute to mark kernels without a language mode

jhuber6 added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1198 -def CUDAGlobal : InheritableAttr { - let Spellings = [GNU<"global">, Declspec<"__global__">]; +def CUDAGlobal : InheritableAttr, TargetSpecificAttr { + let Spellings = [GNU<"global">, Declspec<

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

sebastian-ne added inline comments. Comment at: lldb/include/lldb/Core/RichManglingContext.h:90-91 assert(parser.has_value()); -assert(llvm::any_isa(parser)); +assert(llvm::any_cast(&parser)); return llvm::any_cast(parser); } barannikov88 wro

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

sebastian-ne updated this revision to Diff 483975. sebastian-ne marked 2 inline comments as done. sebastian-ne added a comment. > It is surprising to me that std::any can work without RTTI. Never thought it > could be implemented. It seems like libstdc++ and libc++ both implement it the way llvm

[PATCH] D136639: [CodeGen][ObjC] Fix a memory leak that occurs when a non-trivial C struct property is set using dot notation

ahatanak added inline comments. Comment at: clang/test/CodeGenObjC/nontrivial-c-struct-property.m:89 + +// CHECK: call void @__destructor_8_s0(ptr %[[AGG_TMP_ENSURED]]) + rjmccall wrote: > ahatanak wrote: > > rjmccall wrote: > > > It looks like we're copying `a`

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

barannikov88 added a comment. Related: https://reviews.llvm.org/D139974 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139973/new/ https://reviews.llvm.org/D139973 ___ cfe-commits mailing list cfe-commits

[PATCH] D140226: [NVPTX] Introduce attribute to mark kernels without a language mode

shangwuyao added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1198 -def CUDAGlobal : InheritableAttr { - let Spellings = [GNU<"global">, Declspec<"__global__">]; +def CUDAGlobal : InheritableAttr, TargetSpecificAttr { + let Spellings = [GNU<"global">, Declsp

[PATCH] D136639: [CodeGen][ObjC] Fix a memory leak that occurs when a non-trivial C struct property is set using dot notation

ahatanak updated this revision to Diff 483973. ahatanak marked an inline comment as done. ahatanak added a comment. Check that the destructor is called conditionally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136639/new/ https://reviews.llvm.or

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

v1nh1shungry added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139705/new/ https://reviews.llvm.org/D139705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D140308: [clang][dataflow][NFC] Fix comments related to widening.

ymandel created this revision. ymandel added reviewers: gribozavr2, xazax.hun. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. The comments describing the API for analy

[PATCH] D140290: [clang-tidy] Add misc-static-declaration-in-header check

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/StaticDeclarationInHeaderCheck.cpp:46 +: ClangTidyCheck(Name, Context), + RawStringHeaderFileExtensions(Options.getLocalOrGlobal( + "HeaderFileExtensions", utils::defaultHeaderFi

[PATCH] D140290: [clang-tidy] Add misc-static-declaration-in-header check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/StaticDeclarationInHeaderCheck.cpp:46 +: ClangTidyCheck(Name, Context), + RawStringHeaderFileExtensions(Options.getLocalOrGlobal( + "HeaderFileExtensions", utils::defaultHeaderF

  1   2   >