carlosgalvezp added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/misc/StaticDeclarationInHeaderCheck.cpp:46 + : ClangTidyCheck(Name, Context), + RawStringHeaderFileExtensions(Options.getLocalOrGlobal( + "HeaderFileExtensions", utils::defaultHeaderFileExtensions())) { ---------------- Eugene.Zelenko wrote: > Look like this setting should be global for Clang-tidy, because it already > used in other checks. It also accompanied by other option. Fully agree, I can put up a separate patch for that. I suppose we need to wait 2 releases to be able to remove the existing duplicated options from the checks? @njames93 Do you agree? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140290/new/ https://reviews.llvm.org/D140290 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits