[PATCH] D129443: [clang-format] Add option for aligning requires clause body

owenpan added a comment. In D129443#3867364 , @rymiel wrote: > How should I proceed with a stale rejecting review? You can commit as https://reviews.llvm.org/D129443#3641571 has been addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

LuoYuanke added inline comments. Comment at: clang/lib/Headers/avx512bf16intrin.h:13 +#ifdef __SSE2__ + What is this macro check used for? Comment at: clang/test/CodeGen/X86/avx512bf16-error.c:14 +__bfloat16 bar(__bfloat16 a, __bfloat16 b) {

[PATCH] D136013: [clang][Interp] Fix ignoring expression return values

tbaeder added inline comments. Comment at: clang/test/AST/Interp/records.cpp:208 + +struct S { + int a = 0; aaron.ballman wrote: > Hmmm, this feels related to the discarded value results changes, but it might > be a test case for a different scenario as well, s

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:144 + +if (!this->emitCast(*FromT, PT_Float, CE)) + return false; sepavloff wrote: > Does this two-stage conversion make sense? In contrast to things like > `PT_Sint8` `

[PATCH] D136017: [clang][Interp] Materializing primitive temporaries

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:513 + + if (!this->emitSetLocal(PT_Sint32, *LocalIndex, E)) +return false; shafik wrote: > Should this use `*SubExprT` instead? Ah, yes. Thanks! Co

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

rymiel added a comment. How should I proceed with a stale rejecting review? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129443/new/ https://reviews.llvm.org/D129443 ___ cfe-commits mailing list cfe-com

[PATCH] D135429: [HLSL] [DirectX backend] Move generateGlobalCtorDtorCalls into DirectX backend.

python3kgae added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135429/new/ https://reviews.llvm.org/D135429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D136229: [include-cleaner] Fix link errors when -DBUILD_SHARED_LIBS=ON

lkail created this revision. lkail added reviewers: hokein, sammccall, PowerPC. Herald added a project: All. lkail requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixed ppc buildbot https://lab.llvm.org/buildbot/#/builders/121/b

[PATCH] D136154: [clang-format] Fix the continuation indenter

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Needs a better title to the review please to explain what it’s doing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1361

[PATCH] D136154: [clang-format] Fix the continuation indenter

MyDeveloperDay added a comment. Is it seeing the ‘ :’ as a binary operator? And not an inheritance colon? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136154/new/ https://reviews.llvm.org/D136154 ___ cf

[PATCH] D136154: [clang-format] Fix the continuation indenter

MyDeveloperDay added a comment. Can we log a GitHub issue I can’t see what you are trying to fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136154/new/ https://reviews.llvm.org/D136154 ___ cfe-commits

[PATCH] D136212: [clangd] consider ~^foo() to target the destructor, not the type

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks for fixing! Comment at: clang-tools-extra/clangd/Selection.cpp:881 + return CDD->getNameInfo().getNamedTypeInfo()->getTypeLoc().getBeginLoc(); +if (const Stmt

[PATCH] D131919: Move googletest to the third-party directory

tstellar updated this revision to Diff 468784. tstellar marked 4 inline comments as done. tstellar added a comment. Herald added a subscriber: zero9178. Rebase and fix some missed path updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131919/ne

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

serge-sans-paille accepted this revision. serge-sans-paille added a comment. I really like the new message, thanks for taking account the diverging reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135920/new/ https://reviews.llvm.org/D135920

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe added inline comments. Comment at: llvm/test/CodeGen/X86/avxvnniint8-intrinsics.ll:6 + +declare <4 x i32> @llvm.x86.avx2.vpdpbssd.128(<4 x i32>, <4 x i32>, <4 x i32>) + craig.topper wrote: > FreddyYe wrote: > > craig.topper wrote: > > > Are there tests f

[PATCH] D136040: [X86][1/2] Support PREFETCHI instructions

craig.topper added inline comments. Comment at: clang/lib/Headers/prfchiintrin.h:16 +/// Loads an instruction sequence containing the specified memory address into +///all level cache. +/// craig.topper wrote: > It looks old that this indented differently tha

[PATCH] D136145: [IR][RFC] Restrict read only when cache type of llvm.prefetch is instruction

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7574 - if (NumArgs > 3) + if (NumArgs > 4) return Diag(TheCall->getEndLoc(), craig.topper wrote: > Not clear to me that we should be changing the definition of > `__builtin_

[PATCH] D136145: [IR][RFC] Restrict read only when cache type of llvm.prefetch is instruction

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7574 - if (NumArgs > 3) + if (NumArgs > 4) return Diag(TheCall->getEndLoc(), Not clear to me that we should be changing the definition of `__builtin_prefetch`. It wouldn't

[PATCH] D136224: [clang-tidy] Skip private default ctors in modernize-use-equals-default

alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: gribozavr2, alexfh, rsmith. alexander-shaposhnikov created this object with visibility "All Users". Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. alexander-shaposhnikov requested

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

efriedma added a comment. One, -mlong-calls isn't currently compatible with PIE. Two, on ARM, there are no special plt relocations; the linker just takes care of it. (You can see the differences if you try to take the address of a function without calling it.) Repository: rG LLVM Github Mo

[PATCH] D136040: [X86][1/2] Support PREFETCHI instructions

craig.topper added a comment. Can the intrinsics changes be split from this patch so they don't depend on D136145 . There's no reason to block assembler/disassembler support for that. Comment at: clang/lib/Headers/prfchiintrin.h:16 +/// Loads

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

craig.topper added inline comments. Comment at: llvm/test/CodeGen/X86/avxvnniint8-intrinsics.ll:6 + +declare <4 x i32> @llvm.x86.avx2.vpdpbssd.128(<4 x i32>, <4 x i32>, <4 x i32>) + FreddyYe wrote: > craig.topper wrote: > > Are there tests for commuting? > Hi Cra

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

paulkirth added a subscriber: rnk. paulkirth added a comment. @rnk This is the prototype I mentioned the other night at the meetup. I'm pretty sure something like the `LiveDebugValues` pass has a mapping of all the debug information to locations that I'd ever need, but I'm not sure how to poke

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe added inline comments. Comment at: llvm/test/CodeGen/X86/avxvnniint8-intrinsics.ll:6 + +declare <4 x i32> @llvm.x86.avx2.vpdpbssd.128(<4 x i32>, <4 x i32>, <4 x i32>) + craig.topper wrote: > Are there tests for commuting? Hi Craig, Can you show an exampl

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe marked 2 inline comments as done. FreddyYe added a comment. In D135938#3864521 , @RKSimon wrote: > Can you fix the MC + disasm test file names - drop att/intel and ensure you > test both syntaxes for 32 and 64 bits. > > Ideally the 32/64 bit nam

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

paulkirth planned changes to this revision. paulkirth added a comment. I plan to add/update the tests, and give the new pass a few cleanups. The test code can probably be much smaller & have its debug info reduced significantly. There is also a lack of documentation. Repository: rG LLVM Gith

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

paulkirth updated this revision to Diff 468770. paulkirth added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: abrachet, sstefan1, pengfei, ormris. Refactor printing into a dedicated pass - add some basic lit tests - change the printing format to be more machine readable

[PATCH] D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names

MaskRay added inline comments. Comment at: llvm/lib/IR/Verifier.cpp:3473 !Call.getCalledFunction()->isInterposable() && + !Call.getCalledFunction()->isDeclaration() && Call.getCalledFunction()->getSubprogram()) Removing this check does not brea

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

ZhiyaoMa98 added a comment. Unfortunately, `-fPIE` seems not to be generating the PLT on LLVM for embedded ARM. C source file (test.c): extern void bar(void); void foo(void) { bar(); } LLVM with `clang -O2 -fPIE -fsemantic-interposition -mlong-calls --target=armv7em-none-eabi -c t

[PATCH] D136103: OpenMP asynchronous memory copy support

tianshilei1992 requested changes to this revision. tianshilei1992 added inline comments. This revision now requires changes to proceed. Comment at: openmp/libomptarget/src/api.cpp:208 + + TargetMemcpyArgsTy *Args = (TargetMemcpyArgsTy *)Task->shareds; + I didn't

[PATCH] D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names

MaskRay added a comment. Nice. This also fixes DW_AT_call_all_calls for functions which call builtins/reserved name functions. Comment at: llvm/test/Verifier/callsite-dbgloc.ll:49 +; CHECK-NOT: inlinable function call in a function with debug info must have a !dbg location +;

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

efriedma added a comment. The construct you want is pretty similar to a GOT. if you compile with -fPIE -fsemantic-interposition, you get basically the code you want, except that the compiler uses a plt by default instead of a got. If we supported -fno-plt for ARM, it would be almost exactly wh

[PATCH] D136216: [clangd] go-to-def on new/delete targets the constructor

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Related to

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.h:91 llvm::DebuggerKind getDefaultDebuggerTuning() const override { -return llvm::DebuggerKind::DBX; +return llvm::DebuggerKind::Default; } This sounds not right. Omitting `-

[PATCH] D136019: [clang][lex] Avoid `DirectoryLookup` copies

jansvoboda11 added a comment. In D136019#3860557 , @ributzka wrote: > We could invoke clang with the `-stats` option and compare the result against > the expected number of stat calls. The `-stats-file=` option only tells you how many times Clang reques

[PATCH] D136080: [flang] Add -ffp-contract option processing

DavidTruby added a comment. Glad to see this flag being added to `flang-new`! As a note to self I've written some tests that should be updated once this lands that currently don't pass through the `flang-new` driver. Comment at: flang/test/Driver/driver-help.f90:108 ! HELP-F

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. Looks good with the suggestion to split the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135128/new/ https://reviews.llvm.org/D13

[PATCH] D134597: [CMake] install clang and other resource headers into `CLANG_RESOURCE_DIR/include` if `CLANG_RESOURCE_DIR` is not empty

paperchalice added a comment. Ping @phosek, but may need suggestions from other reviewers... Thanks in advance if someone can commit this change. Comment at: openmp/CMakeLists.txt:80 if(${OPENMP_STANDALONE_BUILD}) set(LIBOMP_HEADERS_INSTALL_PATH "${CMAKE_INSTALL_INCLUDEDIR}

[clang] 13d6a57 - [Clang] constraints partial ordering should work with deduction guide

Author: Yuanfang Chen Date: 2022-10-18T17:30:47-07:00 New Revision: 13d6a57cbe2776c4873302c0cf04e27b77bd2862 URL: https://github.com/llvm/llvm-project/commit/13d6a57cbe2776c4873302c0cf04e27b77bd2862 DIFF: https://github.com/llvm/llvm-project/commit/13d6a57cbe2776c4873302c0cf04e27b77bd2862.diff

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

rupprecht added a comment. In D129755#3866213 , @aaronpuchert wrote: > Are you seeing warnings because of the different treatment of copy-elided > construction, or because we've started to consider `CXXConstructorCall`s > outside of the initializer of

[PATCH] D136124: [clang][deps] Remove unintentional `move`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd239f3c627a3: [clang][deps] Remove unintentional `move` (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d239f3c - [clang][deps] Remove unintentional `move`

Author: Jan Svoboda Date: 2022-10-18T16:40:31-07:00 New Revision: d239f3c627a396a80181806960957d5d0eba7e91 URL: https://github.com/llvm/llvm-project/commit/d239f3c627a396a80181806960957d5d0eba7e91 DIFF: https://github.com/llvm/llvm-project/commit/d239f3c627a396a80181806960957d5d0eba7e91.diff L

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

ZhiyaoMa98 added a comment. > Can you describe a little more what you're trying to do here? Sure. My eventual goal is to enable fine-granular live-update on ARM based microcontrollers, which requires the system to do some relocation at runtime. Below I will describe the challenge with a simple

[PATCH] D136212: [clangd] consider ~^foo() to target the destructor, not the type

sammccall updated this revision to Diff 468741. sammccall added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136212/new/ https://reviews.llvm.org/D136212 Files: clang-tools-extra/clangd/Selection.cpp clang-tools-extra/clangd

[PATCH] D135657: add time traces for AST serialization

jansvoboda11 added a comment. In D135657#3865581 , @Trass3r wrote: > Thanks, could you also commit it? I don't have the rights. Sure. What name and email do you want me to associate with the commit? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D136212: [clangd] consider ~^foo() to target the destructor, not the type

sammccall created this revision. sammccall added a reviewer: nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Thi

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

This revision was automatically updated to reflect the committed changes. Closed by commit rG14ae5d2b745f: [HLSL] Add SV_DispatchThreadID (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D

[clang] 14ae5d2 - [HLSL] Add SV_DispatchThreadID

Author: Xiang Li Date: 2022-10-18T16:17:19-07:00 New Revision: 14ae5d2b745f76018a963b395fc9d7ad987f1c5c URL: https://github.com/llvm/llvm-project/commit/14ae5d2b745f76018a963b395fc9d7ad987f1c5c DIFF: https://github.com/llvm/llvm-project/commit/14ae5d2b745f76018a963b395fc9d7ad987f1c5c.diff LOG:

[PATCH] D133668: [HLSL] Disable int16_t to avoid promote to int for HLSL.

python3kgae updated this revision to Diff 468731. python3kgae marked an inline comment as done. python3kgae added a comment. Update comment and fix tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668 F

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void updated this revision to Diff 468728. void added a comment. Update the error message to remove the reference to bytes, which can be confusing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135920/new/ https://reviews.llvm.org/D135920 Files:

[PATCH] D135634: [clang][modules] Serialize VFS overlay paths into PCMs

bnbarham added a comment. In D135634#3866704 , @jansvoboda11 wrote: > In D135634#3866353 , @benlangmuir > wrote: > >> I think we should deduplicate the vfs overlays if the same ivfsoverlay is >> specified in bo

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

efriedma added a comment. > that I can redirect the function call at runtime, for dynamic linking purpose. Can you describe a little more what you're trying to do here? If you want to replace the implementation of an existing function at runtime, you'd be better off implementing the indirection

[PATCH] D135634: [clang][modules] Serialize VFS overlay paths into PCMs

jansvoboda11 added a comment. In D135634#3866353 , @benlangmuir wrote: > I think we should deduplicate the vfs overlays if the same ivfsoverlay is > specified in both the pcm and the command-line. My understanding is that `ASTUnit` never uses command-l

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

jdoerfert added a comment. > However cleanup looks scary. Msan reports maybe 20% of unique tests on our > code base. Many a of them share root cause, but still many unique root causes. On quick looks I see no false report While scary, this also is extremely encouraging to move forward with this

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added inline comments. Comment at: clang/test/CXX/over/over.match/over.match.best/p1-2a.cpp:106 template - constexpr int goo(const int b) requires AtLeast2 { + constexpr int goo(const int b) requires AtLeast2 { // expected-note {{candidate function}} return 2; --

[clang-tools-extra] 25bac38 - [include-cleaner] Add line numbers to HTML output

Author: Sam McCall Date: 2022-10-19T00:21:33+02:00 New Revision: 25bac38a02e3d43a16282d66c38084bcd553c9b5 URL: https://github.com/llvm/llvm-project/commit/25bac38a02e3d43a16282d66c38084bcd553c9b5 DIFF: https://github.com/llvm/llvm-project/commit/25bac38a02e3d43a16282d66c38084bcd553c9b5.diff LO

[PATCH] D136188: Update docs for -fuse-ctor-homing

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good to me with the addition of the forth homing strategy. In D136188#3866494 , @probinson wrote: > +jmorse who is closer to this topic than

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

ZhiyaoMa98 added a comment. @efriedma Thank you for your suggestion. I will remove the extra indirection. I was wondering if you could also provide some insights about the RWPI case. I believe the same optimization also applies to RWPI. However, I actually want to store the function address as

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

dblaikie added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration anderslanglands wrote: > dblaikie wrote: >

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

phosek added inline comments. Comment at: clang/lib/Basic/Targets/X86.h:812-828 +case CC_X86StdCall: +case CC_X86ThisCall: +case CC_X86FastCall: + return CCCR_Ignore; +case CC_C: +case CC_X86VectorCall: +case CC_IntelOclBicc: Accordin

[PATCH] D136103: OpenMP asynchronous memory copy support

jz10 added a comment. I'm not sure if it copies, will check it to confirm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://reviews.llvm.org/D136103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D136103: OpenMP asynchronous memory copy support

jdoerfert added a comment. > 6. Why do you access args_ for some parts and not for others? That said, > where does the hidden helper need access to the dependences anyway? > > there's type cast for depend objects from 'omp_depend_t' to > 'kmp_depend_info_t*', and the array of casted depend obj

[libunwind] 09dcb93 - [CMake] Fix LIBUNWIND_ENABLE_CET build after D110005

Author: jinge90 Date: 2022-10-18T15:00:09-07:00 New Revision: 09dcb933eff331749842d86b439e1a4fed76cb20 URL: https://github.com/llvm/llvm-project/commit/09dcb933eff331749842d86b439e1a4fed76cb20 DIFF: https://github.com/llvm/llvm-project/commit/09dcb933eff331749842d86b439e1a4fed76cb20.diff LOG:

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

efriedma added inline comments. Comment at: llvm/test/CodeGen/Thumb2/thumb2-execute-only-long-calls.ll:19 +; STATIC-NEXT: movt[[REG0]], :upper16:.LCP1_0 +; STATIC-NEXT: ldr [[REG1:r[0-9]+]], [[[REG0]]] +; STATIC-NEXT: blx [[REG1]] Is there some rea

[PATCH] D133668: [HLSL] Disable int16_t to avoid promote to int for HLSL.

rjmccall added a comment. Okay, this seems fine to me. I think you accidentally removed the word "promotion" from the patch title, though. I assume HLSL also provides `uint16_t`, and you should test the behavior for it. You should also test this for whatever 8-bit types HLSL provides (`char`,

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

ZhiyaoMa98 created this revision. ZhiyaoMa98 added reviewers: labrinea, rengolin. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. ZhiyaoMa98 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added projects: clang, LLVM. Promo

[PATCH] D135440: [SourceManager] Speedup getFileIDLocal with a separate Offset Table.

MaskRay added a comment. > Speedup: Linux kernel: getFileIDLocal overhead is reduced to 1.66% (~30% > saving) What's the fraction related to the whole parsing time? > The sad bit is thatit increases SourceManager memory usage, however it is a > small fraction (< 10%) of clang AST memory usage,

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

beanz accepted this revision. beanz added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 468706. python3kgae added a comment. More check on the ir. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 Files: clang/include/clang/Basic/Attr.td clang/incl

[PATCH] D136100: [clang-format] Do not parse certain characters in pragma directives

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG037669de8bdf: [clang-format] Do not parse certain characters in pragma directives (authored by jhuber6). Repository: rG LLVM Github Monorepo CHAN

[clang] 037669d - [clang-format] Do not parse certain characters in pragma directives

Author: Joseph Huber Date: 2022-10-18T16:38:19-05:00 New Revision: 037669de8bdff42fc17b72460bf8784403c8d055 URL: https://github.com/llvm/llvm-project/commit/037669de8bdff42fc17b72460bf8784403c8d055 DIFF: https://github.com/llvm/llvm-project/commit/037669de8bdff42fc17b72460bf8784403c8d055.diff

[PATCH] D136198: [OpenMP] Make kernels have protected visibility

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c1449a84d61: [OpenMP] Make kernels have protected visibility (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136198/new/ https://revie

[clang] 8c1449a - [OpenMP] Make kernels have protected visibility

Author: Joseph Huber Date: 2022-10-18T16:37:28-05:00 New Revision: 8c1449a84d61f6caa4b6e63f262b2c8976949548 URL: https://github.com/llvm/llvm-project/commit/8c1449a84d61f6caa4b6e63f262b2c8976949548 DIFF: https://github.com/llvm/llvm-project/commit/8c1449a84d61f6caa4b6e63f262b2c8976949548.diff

[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

leonardchan updated this revision to Diff 468701. leonardchan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134687/new/ https://reviews.llvm.org/D134687 Files: clang/lib/CodeGen/CGVTables.cpp clang/lib/CodeGen/C

[PATCH] D136103: OpenMP asynchronous memory copy support

jz10 updated this revision to Diff 468695. jz10 added a comment. Thanks Johannes for your comments, and I relied them below 1. format issues I ran clang-format to reformat, please check if there's any missed things; 2. replace '0' with 'nullptr' fixed 3. proper return value for helper functio

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 468700. python3kgae added a comment. Check sret parameter exist. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 Files: clang/include/clang/Basic/Attr.td clan

[PATCH] D135634: [clang][modules] Serialize VFS overlay paths into PCMs

bnbarham added a comment. In D135634#3866353 , @benlangmuir wrote: > I think we should deduplicate the vfs overlays if the same ivfsoverlay is > specified in both the pcm and the command-line. > > @bnbarham any concern about overlay vs chaining behaviou

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

jmciver added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:1746 + if (auto TyPtr = Ty.getTypePtrOrNull()) { +if (!(TyPtr->isSpecificBuiltinType(BuiltinType::UChar) || vitalybuka wrote: > Taking into account potantial risks from pre-existing UB

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

anderslanglands added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration dblaikie wrote: > royjacobson wrote

[PATCH] D136188: Update docs for -fuse-ctor-homing

probinson added a subscriber: jmorse. probinson added a comment. +jmorse who is closer to this topic than I am. We've had a few complaints from licensees about ctor homing, and debug-info size in general is something of a sensitive topic. But if we can come to a place where `-fstandalone-debug

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

royjacobson added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration anderslanglands wrote: > dblaikie wrote

[PATCH] D136071: [include-cleaner] WIP: Add PragmaIncludes which handles include-mapping pragmas.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Hooks.h:38 +// spelling header rather than the header directly defines the symbol. +class PragmaIncludes { +public: sammccall wrote: > sammccall wrote: > >

[PATCH] D136071: [include-cleaner] WIP: Add PragmaIncludes which handles include-mapping pragmas.

hokein updated this revision to Diff 468688. hokein marked 4 inline comments as done. hokein added a comment. - rebase - address comments - implement shouldKeep - add unittests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136071/new/ https://revie

[PATCH] D136188: Update docs for -fuse-ctor-homing

akhuang updated this revision to Diff 468687. akhuang added a comment. Move ctor homing info to fstandalone-debug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136188/new/ https://reviews.llvm.org/D136188 Files: clang/docs/UsersManual.rst Ind

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void added inline comments. Comment at: clang/test/SemaCXX/array-bounds.cpp:240 -((char*)foo)[sizeof(foo)] = '\0'; // expected-warning {{array index 32768 is past the end of the array (which contains 32768 elements)}} +((char*)foo)[sizeof(foo)] = '\0'; // expected-wa

[PATCH] D136188: Update docs for -fuse-ctor-homing

dblaikie added a subscriber: probinson. dblaikie added a comment. (Speaking of which, might be worth pushing on the changes to remove the flags/support for opting out of ctor homing... I know @probinson had some concerns - but I really don't want to end up holding onto the tech debt of these va

[PATCH] D136188: Update docs for -fuse-ctor-homing

dblaikie added a comment. In D136188#3866385 , @akhuang wrote: > Actually, maybe I should add some of this info to the -fstandalone-debug > section. Ah, sure, if you like. At some point I think I/someone should write a full ramble about DWARF type hom

[PATCH] D136154: Fix the continuation indenter

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:812-814 +if (Style.BreakBeforeBinaryOperators == FormatStyle::BOS_None || ++ Style.BreakBeforeBinaryOperators == FormatStyle::BOS_NonAssignment) CurrentState.LastSpace

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

dblaikie added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration anderslanglands wrote: > dblaikie wrote: >

[clang] 5b773dc - Fix incorrect check for running out of source locations.

Author: Paul Pluzhnikov Date: 2022-10-18T20:48:00Z New Revision: 5b773dcd2de0c4844814266a90dac14c349b8f18 URL: https://github.com/llvm/llvm-project/commit/5b773dcd2de0c4844814266a90dac14c349b8f18 DIFF: https://github.com/llvm/llvm-project/commit/5b773dcd2de0c4844814266a90dac14c349b8f18.diff LO

[PATCH] D135192: Fix incorrect check for running out of source locations.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b773dcd2de0: Fix incorrect check for running out of source locations. (authored by ppluzhnikov, committed by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D135192: Fix incorrect check for running out of source locations.

ppluzhnikov added a comment. In D135192#3866294 , @dblaikie wrote: > Sounds good (guess this is pretty impractical to have a regression test/would > require very large files to test?) Yea, overflowing this requires a very convoluted setup; I don't think

[clang] 4481057 - [clang] Move variable declaration closer to use

Author: Nico Weber Date: 2022-10-18T16:40:46-04:00 New Revision: 4481057d4cbe60878d16b26085d8ab90ec5f7a43 URL: https://github.com/llvm/llvm-project/commit/4481057d4cbe60878d16b26085d8ab90ec5f7a43 DIFF: https://github.com/llvm/llvm-project/commit/4481057d4cbe60878d16b26085d8ab90ec5f7a43.diff LO

[PATCH] D136188: Update docs for -fuse-ctor-homing

akhuang added a comment. Actually, maybe I should add some of this info to the -fstandalone-debug section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136188/new/ https://reviews.llvm.org/D136188 ___

[PATCH] D136188: Update docs for -fuse-ctor-homing

akhuang updated this revision to Diff 468677. akhuang edited the summary of this revision. akhuang added a comment. Remove documentation paragraph. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136188/new/ https://reviews.llvm.org/D136188 Files:

[PATCH] D136188: Update docs for -fuse-ctor-homing

akhuang added a comment. In D136188#3866266 , @dblaikie wrote: > (not sure whether to discuss this here or on the bug) > > Should we remove the documentation? Part of the principles of "cc1" flags is > that their implementation details, not to be publicl

[PATCH] D135634: [clang][modules] Serialize VFS overlay paths into PCMs

benlangmuir added a subscriber: bnbarham. benlangmuir added a comment. I think we should deduplicate the vfs overlays if the same ivfsoverlay is specified in both the pcm and the command-line. @bnbarham any concern about overlay vs chaining behaviour here? I remember you looking at that a while

[PATCH] D136198: [OpenMP] Make kernels have protected visibility

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, but all of this code should move into the IR Builder... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136198/new/ https://reviews.llvm

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

anderslanglands added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration dblaikie wrote: > aaron.ballman wro

[PATCH] D136198: [OpenMP] Make kernels have protected visibility

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, ABataev, JonChesterfield, tianshilei1992, ronlieb. Herald added subscribers: kosarev, mattd, asavonic, guansong, yaxunl, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe

  1   2   3   >