craig.topper added inline comments.

================
Comment at: clang/lib/Sema/SemaChecking.cpp:7574
 
-  if (NumArgs > 3)
+  if (NumArgs > 4)
     return Diag(TheCall->getEndLoc(),
----------------
Not clear to me that we should be changing the definition of 
`__builtin_prefetch`.

It wouldn't cost much to add a new builtin for X86 for the new instructions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136145/new/

https://reviews.llvm.org/D136145

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to