[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

MaskRay added a comment. In D134454#3826143 , @10ne1 wrote: > In D134454#3824571 , @MaskRay wrote: > >> I'll grab an Arch Linux machine for testing, but I don't think this is >> currently in a form for submitting

[PATCH] D134744: [clang][Interp] Implement rem opcode

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:164 + + if (RHS.isZero()) { +const SourceInfo &Loc = S.Current->getSource(OpPC); shafik wrote: > You also need to catch when the result is not

[PATCH] D134749: [clang][Interp] Implement Div opcode

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:181 + + + constexpr int LHS = 12; aaron.ballman wrote: > The only test coverage is for integer division; do you intend to also cover > floati

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

mgorny added a comment. Is anyone working on a solution that would work for people using a zstd install method that's actually supported upstream? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465

[PATCH] D134905: [clang] [Driver] Disable default configs via envvar during testing

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. But `CCC_OVERRIDE_OPTIONS=+--no-default-config` leaves an annoying notice, so I guess introducing a new environment variable is still fine. CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D134905: [clang] [Driver] Disable default configs via envvar during testing

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. Wait. The effect can be achieved today with `CCC_OVERRIDE_OPTIONS=+--no-default-config` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134905/new/ https://reviews.llvm.org

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

10ne1 added a comment. In D134454#3824571 , @MaskRay wrote: > I'll grab an Arch Linux machine for testing, but I don't think this is > currently in a form for submitting. > This adds new functionality for non-MIPS and we need some fake file > hierarchie

[PATCH] D134905: [clang] [Driver] Disable default configs via envvar during testing

sepavloff added a comment. A more flexible way is to implement support for environment variable like `CL` and `_CL` (https://learn.microsoft.com/en-us/cpp/build/reference/cl-environment-variables?view=msvc-170 ). They could be used to deliver `--no-default-config` and would have wide usage tha

[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:471 auto *If = cast(*First); if (!If->hasInitStorage() && !If->hasVarStorage()) { ExprAndBool ThenReturnBool = Probably

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

kees added inline comments. Comment at: clang/test/CodeGen/bounds-checking-fam.c:23 }; // CHECK-LABEL: define {{.*}} @{{.*}}test_one{{.*}}( I would expect to see here: ``` struct Zero { int a[0]; }; // CHECK-LABEL: define {{.*}} @{{.*}}test_zero{{.*}}( in

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius. Herald added a project: All. rymiel updated this revision to Diff 463768. rymiel edited the summary of this revision. rymiel added a comment. rymiel updated this revision to Diff 464145. rym

[clang] 1ecaa61 - [clang][Interp] Handle enums

Author: Timm Bäder Date: 2022-09-30T08:18:14+02:00 New Revision: 1ecaa617e73e9c1eeba47b0d12626f0a846a4288 URL: https://github.com/llvm/llvm-project/commit/1ecaa617e73e9c1eeba47b0d12626f0a846a4288 DIFF: https://github.com/llvm/llvm-project/commit/1ecaa617e73e9c1eeba47b0d12626f0a846a4288.diff LO

[PATCH] D125142: [clang][auto-init] Remove -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang

kees updated this revision to Diff 464146. kees retitled this revision from "[clang][auto-init] Remove -enable flag for "zero" mode" to "[clang][auto-init] Remove -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang". kees added a comment. rebase and tweak Rebase to main, up

[PATCH] D134905: [clang] [Driver] Disable default configs via envvar during testing

mgorny added a comment. In D134905#3826111 , @MaskRay wrote: >> during testing > > This part of the subject is probably not needed. I think exposing the idea to > user can probably be useful, too. Sure but the larger part of the commit is actually about

[PATCH] D134905: [clang] [Driver] Disable default configs via envvar during testing

MaskRay added a comment. > during testing This part of the subject is probably not needed. I think exposing the idea to user can probably be useful, too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134905/new/ https://reviews.llvm.org/D134905 ___

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: clang/test/Driver/config-file3.c:176 // -// SHORT-NAME: Configuration file: {{.*}}/testdmode/qqq.cfg -// SHORT-NAME: -Werror -// SHORT-NAME-NOT: -Wundefined-func-template +// FULL3-NOT: Configurat

[PATCH] D134905: [clang] [Driver] Disable default configs via envvar during testing

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1073 + if (const char *NoConfigEnv = ::getenv("CLANG_NO_DEFAULT_CONFIG")) { +if (*NoConfigEnv) + return false; MaskRay wrote: > Looking at LLDB_LAUNCH_FLAG_DISABLE_ASLR/LIBCLANG_DISAB

[clang] 052da73 - [clang] [test] Use --implicit-check-not in config-file3 tests

Author: Michał Górny Date: 2022-09-30T08:02:57+02:00 New Revision: 052da736e51db68202f20155792a692c93897100 URL: https://github.com/llvm/llvm-project/commit/052da736e51db68202f20155792a692c93897100 DIFF: https://github.com/llvm/llvm-project/commit/052da736e51db68202f20155792a692c93897100.diff

[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

rymiel updated this revision to Diff 464142. rymiel edited the summary of this revision. rymiel added a comment. Add release note Thank you, Aaron! Is the note I've added okay? I didn't expect to need to add a note to a bugfix, but I haven't written a release note before at all regardless. And

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

kees marked an inline comment as done. kees added a comment. In D125142#3825972 , @MaskRay wrote: >> [clang][auto-init] Remove -enable flag for "zero" mode > > The subject should be updated to mention the exact option name, not a vague > `-enable` and `"

[PATCH] D134928: [Sema] Don't treat a non-null template argument as if it were null.

shafik added a comment. It looks like in `Sema::CheckTemplateArgument` in C++17 mode we end up calling `CheckConvertedConstantExpression` which sees a `IntegralToPointer` cast which is basically an reintepret_cast and rejects it as ill-formed. In the C++11 case we end up in `CheckTemplateArgume

[PATCH] D134650: [runtimes] Remove all traces of the legacy testing configuration system

vvereschaka added inline comments. Comment at: clang/cmake/caches/CrossWinToARMLinux.cmake:163 set(RUNTIMES_${TOOLCHAIN_TARGET_TRIPLE}_COMPILER_RT_EMULATOR "\\\"${Python3_EXECUTABLE}\\\" \\\"${LLVM_PROJECT_DIR}/llvm/utils/remote-exec.py\\\" --execdir %%T --exec-patt

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

peixin added a comment. Please fix the clang-format issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134821/new/ https://reviews.llvm.org/D134821 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

MaskRay added a comment. > [clang][auto-init] Remove -enable flag for "zero" mode The subject should be updated to mention the exact option name, not a vague `-enable` and `"zero" mode` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125142/new/ ht

[PATCH] D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker

MaskRay added inline comments. Comment at: clang/test/Driver/lto-aix.c:2 +// Test LTO path, mcpu and opt level options +// RUN: %clang -target powerpc-ibm-aix -### %s -flto -fuse-ld=ld -O3 2>&1 \ +// RUN: | FileCheck -check-prefixes=LTOPATH,MCPUOPTLEVEL %s Repl

[PATCH] D134788: [ARM64EC][clang-cl] Add /arm64EC flag

bcl5980 added a comment. In D134788#3823181 , @DavidSpickett wrote: > Has Microsoft documented this option? Not doubting it exists but I mostly see > how to use it rather than a specific page describing the option and its > behaviour. > > Not a big dea

[PATCH] D134788: [ARM64EC][clang-cl] Add /arm64EC flag

bcl5980 updated this revision to Diff 464128. bcl5980 added a comment. address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134788/new/ https://reviews.llvm.org/D134788 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Options.td clan

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

dblaikie added a comment. Again, I'm not advocating for the printing as-is, I think adding the top level name that disambiguates would be a good thing - and I think the GCC and MSVC examples somewhat show why adding all the other layers would be harmful to readability - th

[PATCH] D134929: [clang-tidy] Skip variadic ctors in use-equals-default

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LGTM! Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134929/new/ https://reviews.llvm.org/D134929 __

[PATCH] D134928: [Sema] Don't treat a non-null template argument as if it were null.

shafik added inline comments. Comment at: clang/test/CXX/temp/temp.arg/temp.arg.nontype/p1-11.cpp:31 IP<&tl> ip7; // expected-error{{non-type template argument of type 'int *' is not a constant expression}} +IP<(int*)1> ip8; // expected-error {{non-type template argument does n

[PATCH] D134928: [Sema] Don't treat a non-null template argument as if it were null.

shafik added inline comments. Comment at: clang/test/CXX/temp/temp.arg/temp.arg.nontype/p1-11.cpp:31 IP<&tl> ip7; // expected-error{{non-type template argument of type 'int *' is not a constant expression}} +IP<(int*)1> ip8; // expected-error {{non-type template argument does n

[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

sammccall updated this revision to Diff 464118. sammccall added a comment. Rebase on top of using enum parsing changes, store 'enum' location separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134303/new/ https://reviews.llvm.org/D134303 Fi

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

shafik added inline comments. Comment at: clang/lib/AST/Interp/Floating.h:80 + bool isMinusOne() const { return V == -1; } + + ComparisonCategoryResult compare(const Floating &RHS) const { `bool isNaN() const { return V != V; }` CHANGES SINCE LAST ACTION ht

[PATCH] D134923: [clang][deps] Canonicalize module map path

benlangmuir updated this revision to Diff 464117. benlangmuir added a comment. Simplify modmap checks in test to use PREFIX CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134923/new/ https://reviews.llvm.org/D134923 Files: clang/include/clang/Lex/ModuleMap.h clang/lib/Lex/HeaderSear

[PATCH] D134929: [clang-tidy] Skip variadic ctors in use-equals-default

alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: gribozavr2, njames93, alexfh. alexander-shaposhnikov created this object with visibility "All Users". Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. alexander-shaposhnikov request

[PATCH] D134928: [Sema] Don't treat a non-null template argument as if it were null.

efriedma created this revision. efriedma added reviewers: aaron.ballman, erichkeane. efriedma added a project: clang. Herald added a project: All. efriedma requested review of this revision. The way this code checks whether a pointer is null is wrong for other reasons; it doesn't actually check w

[PATCH] D134923: [clang][deps] Canonicalize module map path

jansvoboda11 added a comment. (You could also use the `PREFIX` variable you're passing to `FileCheck` to remove some `.*` regexes.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134923/new/ https://reviews.llvm.org/D134923 ___ cfe-commits ma

[PATCH] D134923: [clang][deps] Canonicalize module map path

benlangmuir updated this revision to Diff 464109. benlangmuir added a comment. Fix windows path separators using sed instead of regex "." CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134923/new/ https://reviews.llvm.org/D134923 Files: clang/include/clang/Lex/ModuleMap.h clang/lib/

[PATCH] D134923: [clang][deps] Canonicalize module map path

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Thanks, this LGTM with the test extension. Comment at: clang/test/ClangScanDeps/modules-symlink-dir.c:33 +// CHECK-NOT: symlink-to-module +// CHECK: "

[PATCH] D134923: [clang][deps] Canonicalize module map path

benlangmuir updated this revision to Diff 464104. benlangmuir added a comment. Test -fmodule-map-file paths as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134923/new/ https://reviews.llvm.org/D134923 Files: clang/include/clang/Lex/ModuleMap.h clang/lib/Lex/HeaderSearch.cpp

[PATCH] D134923: [clang][deps] Canonicalize module map path

benlangmuir added a comment. In D134923#3825673 , @jansvoboda11 wrote: > IIUC this not only canonicalizes path to the main input file when compiling a > PCM, but also `-fmodule-map-file=` arguments for dependencies, correct? Since > that behavior is de

[PATCH] D134923: [clang][deps] Canonicalize module map path

jansvoboda11 added inline comments. Comment at: clang/lib/Lex/ModuleMap.cpp:1307 + // Do not canonicalize within the framework; the module map parser expects + // Modules/ not Versions/A/Modules. + if (llvm::sys::path::filename(Dir) == "Modules") { Is that bec

[PATCH] D134923: [clang][deps] Canonicalize module map path

jansvoboda11 added a comment. IIUC this not only canonicalizes path to the main input file when compiling a PCM, but also `-fmodule-map-file=` arguments for dependencies, correct? Since that behavior is desirable, I think it would make sense to check for that in the test, WDYT? Repository:

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

kees added a comment. Excellent! Thank you for getting this prepared. Having this properly managed in the kernel means we don't have to do horrible ugly hacks to work around old 0-length arrays in UAPI (which have all been unioned with a proper flexible array now). Repository: rG LLVM Githu

[PATCH] D134921: [HLSL] add cos library function

python3kgae added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/cos.hlsl:11 +// NO_HALF: define noundef float @"?test_cos_half@@YA$halff@$halff@@Z"( +// NO_HALF: call noundef float @"?cos@@YAMM@Z"(float noundef %0) +half test_cos_half ( half p0 ) {

[PATCH] D134923: [clang][deps] Canonicalize module map path

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, Bigcheese. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When dep-scanning, canonicalize the module map path as much as

[PATCH] D134885: [Clang] Fix variant crashes from GH58028, GH57370

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LFTM besides the comment about the test. Comment at: clang/test/SemaCXX/specialization-diagnose-crash.cpp:2 +// RUN: %clang_cc1 -fsyntax-only %s -verify +// expected-no-diagn

[PATCH] D134921: [HLSL] add cos library function

bob80905 updated this revision to Diff 464091. bob80905 added a comment. - remove int overloads Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134921/new/ https://reviews.llvm.org/D134921 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h clang/te

[PATCH] D134921: [HLSL] add cos library function

python3kgae added inline comments. Comment at: clang/lib/Headers/hlsl/hlsl_intrinsics.h:111 +int16_t3 cos(int16_t3); +__attribute__((clang_builtin_alias(__builtin_elementwise_cos))) +int16_t4 cos(int16_t4); why there're integer overloads? Repository: rG LLVM

[clang] 7eee2a2 - [IR] Don't allow DLL storage-class and local linkage

Author: Ben Dunbobbin Date: 2022-09-30T00:26:01+01:00 New Revision: 7eee2a2d4401813cd485ae708e8cb0f94469e037 URL: https://github.com/llvm/llvm-project/commit/7eee2a2d4401813cd485ae708e8cb0f94469e037 DIFF: https://github.com/llvm/llvm-project/commit/7eee2a2d4401813cd485ae708e8cb0f94469e037.diff

[PATCH] D134921: [HLSL] add cos library function

bob80905 created this revision. bob80905 added reviewers: python3kgae, beanz, pow2clk. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change exposes the cos l

[PATCH] D134874: [Concepts] Fix Concepts on generic lambda in a VarTemplateSpecDecl

shafik added a comment. I made mostly minor comments, the diff is difficult to follow wrt to what has really changed but it mostly makes sense. I will probably need a second look. Comment at: clang/lib/Sema/SemaConcept.cpp:508-510 MLTAL = getTemplateInstantiationArgs(FD, nu

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

samitolvanen added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8686 +def warn_cast_function_type_strict : Warning, + InGroup, DefaultIgnore; def err_cast_pointer_to_non_pointer_int : Error< aaron.ballman wrote: > nathanchance w

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

samitolvanen updated this revision to Diff 464067. samitolvanen marked 8 inline comments as done. samitolvanen added a comment. Moved `CastFunctionTypeStrict` to a subgroup of `CastFunctionType`, addressed other feedback, and updated tests. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D134650: [runtimes] Remove all traces of the legacy testing configuration system

ldionne updated this revision to Diff 464060. ldionne added a comment. Rebase on main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134650/new/ https://reviews.llvm.org/D134650 Files: clang/cmake/caches/CrossWinToARMLinux.cmake libcxx/cmake/c

[PATCH] D134650: [runtimes] Remove all traces of the legacy testing configuration system

ldionne added a subscriber: vvereschaka. ldionne added a comment. @vvereschaka Can you please confirm that the CMake cache changes look good to you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134650/new/ https://reviews.llvm.org/D134650 __

[PATCH] D134878: Update developer policy on potentially breaking changes

ldionne accepted this revision. ldionne added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:140 + +* After the change has been committed to the repository, the potentially + disruptive changes described in the release notes should be posted to the a

[PATCH] D111000: [clang-format] allow clang-format to be passed a file of filenames so we can add a regression suite of "clean clang-formatted files" from LLVM

MyDeveloperDay added a comment. The use of a response file was actually new to me, I suspect it isn't widely know about, but yes in theory it could be used. As this feature has been landed for sometime, I'm not included to remove it, there could be other people using it. Repository: rG LLVM

[PATCH] D134911: [clang][DebugInfo] Respect fmodule-file-home-is-cwd in skeleton CUs for clang modules

bulbazord created this revision. bulbazord added reviewers: rmaz, aprantl. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When `-fmodule-file-home-is-cwd` and the path to the PCM is relative, we shou

[PATCH] D134898: [Clang] define __cpp_named_character_escapes

cor3ntin added a comment. Thanks for catching that, I missed there was a feature test macro for it. It doesn't really make sense for it to be a feature test macro (given WG21's current policies) so I'll make raise an issue about that but I'm happy to approve the change in the meantime Reposito

[clang] 10d6a34 - [NFC] Use %clang_cc1

Author: Xiang Li Date: 2022-09-29T14:26:01-07:00 New Revision: 10d6a34ef6e9792cace5f3ce769908d1ee04193a URL: https://github.com/llvm/llvm-project/commit/10d6a34ef6e9792cace5f3ce769908d1ee04193a DIFF: https://github.com/llvm/llvm-project/commit/10d6a34ef6e9792cace5f3ce769908d1ee04193a.diff LOG:

[PATCH] D124751: [HLSL] Support -E option for HLSL.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/test/Driver/hlsl-entry.cpp:1 +// RUN:not %clang -cc1 -triple dxil-pc-shadermodel6.3-compute -x c++ -hlsl-entry foo %s 2>&1 | FileCheck %s --check-prefix=NOTHLSL + ---

[clang] e09a6f3 - [NFC] Move cc1 test out of Driver test

Author: Xiang Li Date: 2022-09-29T14:19:12-07:00 New Revision: e09a6f37d5ec0dea47fe0feb32556e77450cd6c4 URL: https://github.com/llvm/llvm-project/commit/e09a6f37d5ec0dea47fe0feb32556e77450cd6c4 DIFF: https://github.com/llvm/llvm-project/commit/e09a6f37d5ec0dea47fe0feb32556e77450cd6c4.diff LOG:

[clang] be07c80 - [HLSL] add ceil library function

Author: Joshua Batista Date: 2022-09-29T14:03:30-07:00 New Revision: be07c80cf7774e8ada84ddc29ae7ab5efa4d1ec9 URL: https://github.com/llvm/llvm-project/commit/be07c80cf7774e8ada84ddc29ae7ab5efa4d1ec9 DIFF: https://github.com/llvm/llvm-project/commit/be07c80cf7774e8ada84ddc29ae7ab5efa4d1ec9.diff

[PATCH] D134319: [HLSL] add ceil library function

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe07c80cf777: [HLSL] add ceil library function (authored by bob80905, committed by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134319/new/ h

[PATCH] D134905: [clang] [Driver] Disable default configs via envvar during testing

MaskRay added a comment. The concept LGTM. Comment at: clang/lib/Driver/Driver.cpp:1073 + if (const char *NoConfigEnv = ::getenv("CLANG_NO_DEFAULT_CONFIG")) { +if (*NoConfigEnv) + return false; Looking at LLDB_LAUNCH_FLAG_DISABLE_ASLR/LIBCLANG_DISABLE

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. Great stuff @ekieri , thanks for doing this! You may want add a note in the summary that you've updated the docs as well. This is consistent with what we discussed in https://github.

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat marked an inline comment as done. azat added a comment. Apparently test failures are not related? Failed Tests (1): Clangd Unit Tests :: ./ClangdTests/TUSchedulerTests/IncluderCache Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133092/ne

[PATCH] D134905: [clang] [Driver] Disable default configs via envvar during testing

mgorny added a comment. I'm not sure if we should be documenting this in the user manual, or if it should be considered an internal-use envvar. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134905/new/ https://reviews.llvm.org/D134905 ___ cf

[PATCH] D134905: [clang] [Driver] Disable default configs via envvar during testing

mgorny created this revision. mgorny added reviewers: MaskRay, sepavloff, zturner. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. Add support for a CLANG_NO_DEFAULT_CONFIG envvar that works like the --no-default-config option when set

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

void created this revision. void added a reviewer: kees. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The -fstrict-flex-arrays=3 is the most restrictive type of flex arrays. No number, including 0, is al

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

usaxena95 added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:887 -bool OverloadCandidateSet::OperatorRewriteInfo::shouldAddReversed( -OverloadedOperatorKind Op) { ilya-biryukov wrote: > Why do we need to move this from `OperatorRewriteInfo`

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

usaxena95 updated this revision to Diff 464012. usaxena95 added a comment. Added test for static operator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134529/new/ https://reviews.llvm.org/D134529 Files: clang/docs/ReleaseNotes.rst clang/incl

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

usaxena95 updated this revision to Diff 464010. usaxena95 marked 7 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134529/new/ https://reviews.llvm.org/D134529 Files: clang/do

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

MaskRay added inline comments. Comment at: clang/test/Driver/lit.local.cfg:8 -('%clang_cc1', - """*** Do not use 'clang -cc1' in Driver tests. ***""") ) MaskRay wrote: > mgorny wrote: > > MaskRay wrote: > > > probinson wrote: > > > > But we _don't_ want

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

MaskRay added a subscriber: yaxunl. MaskRay added inline comments. Comment at: clang/test/Driver/lit.local.cfg:8 -('%clang_cc1', - """*** Do not use 'clang -cc1' in Driver tests. ***""") ) mgorny wrote: > MaskRay wrote: > > probinson wrote: > > > But we

[clang] cecb0e9 - [HIP] stop forcing the lang std in the driver

Author: Siu Chi Chan Date: 2022-09-29T16:18:29-04:00 New Revision: cecb0e98d4b182038f97b621b04ad43ecbac54a2 URL: https://github.com/llvm/llvm-project/commit/cecb0e98d4b182038f97b621b04ad43ecbac54a2 DIFF: https://github.com/llvm/llvm-project/commit/cecb0e98d4b182038f97b621b04ad43ecbac54a2.diff

[PATCH] D134314: [HIP] stop forcing the lang std in the driver

This revision was automatically updated to reflect the committed changes. Closed by commit rGcecb0e98d4b1: [HIP] stop forcing the lang std in the driver (authored by scchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134314/new/ https://reviews.

[PATCH] D134898: [Clang] define __cpp_named_character_escapes

royjacobson updated this revision to Diff 464007. royjacobson added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134898/new/ https://reviews.llvm.org/D134898 Files: clang/lib/Frontend/InitPreprocessor.cpp clang/test/Lexer/cx

[clang] 8a1e069 - [Clang][NFC] Fix broken link in release notes

Author: Roy Jacobson Date: 2022-09-29T23:16:17+03:00 New Revision: 8a1e069cc479e501b058bdb1a3d961ee6f852c3d URL: https://github.com/llvm/llvm-project/commit/8a1e069cc479e501b058bdb1a3d961ee6f852c3d DIFF: https://github.com/llvm/llvm-project/commit/8a1e069cc479e501b058bdb1a3d961ee6f852c3d.diff

[PATCH] D133659: [Clang] P1169R4: static operator()

This revision was automatically updated to reflect the committed changes. Closed by commit rG6523814c4e38: [Clang] P1169R4: static operator() (authored by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.o

[clang] 6523814 - [Clang] P1169R4: static operator()

Author: Roy Jacobson Date: 2022-09-29T23:03:26+03:00 New Revision: 6523814c4e38ad70f8fd3fc3c39d089195e099a1 URL: https://github.com/llvm/llvm-project/commit/6523814c4e38ad70f8fd3fc3c39d089195e099a1 DIFF: https://github.com/llvm/llvm-project/commit/6523814c4e38ad70f8fd3fc3c39d089195e099a1.diff

[PATCH] D134874: [Concepts] Fix Concepts on generic lambda in a VarTemplateSpecDecl

erichkeane updated this revision to Diff 464003. erichkeane added a comment. Looks like that problem was fixed easy enough, so back to all tests passing :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134874/new/ https://reviews.llvm.org/D134874 Files: clang/include/clang/AST/DeclBa

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson added a comment. Thanks for the patient review and the discussion! @aaron.ballman @cor3ntin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659 ___ cfe-

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

mgorny added inline comments. Comment at: clang/test/Driver/lit.local.cfg:8 -('%clang_cc1', - """*** Do not use 'clang -cc1' in Driver tests. ***""") ) MaskRay wrote: > probinson wrote: > > But we _don't_ want to use `%clang_cc1` in Driver tests; if we

[PATCH] D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker

qiongsiwu1 updated this revision to Diff 464001. qiongsiwu1 added a comment. Try fixing the test case on Windows, hopefully one last time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134820/new/ https://reviews.llvm.org/D134820 Files: clang/li

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

MaskRay added a comment. In D134671#3824672 , @aaron.ballman wrote: > In D134671#3824644 , > @nickdesaulniers wrote: > >> I don't think it's an issue for us to work around downstream, but this did >> regress su

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

ekieri updated this revision to Diff 463998. ekieri added a comment. Fix test link-f90-main.f90, which was failing for statically linked builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134821/new/ https://reviews.llvm.org/D134821 Files: cl

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

MaskRay added a comment. In D134337#3824683 , @ojeda wrote: > Thanks Nick for the ping. Indeed, `rustc` allows to use a "target > specification file" to create new targets that are not built-in, as a JSON > file. > > They are unstable though, since they

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:240-243 +- -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang + has been deprecated. The flag will be removed in Clang 17. + -ftrivial-auto-var-init=zero is now available uncondit

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

kees added a comment. Thanks for all the careful consideration; I appreciate it! I'll land this tomorrow unless there are new specific objections. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125142/new/ https://reviews.llvm.org/D125142 _

[PATCH] D52290: [driver][mips] Adjust target triple accordingly to provided ABI name

MaskRay added inline comments. Herald added a project: All. Comment at: cfe/trunk/lib/Driver/Driver.cpp:486 + // accordingly to provided ABI name. + A = Args.getLastArg(options::OPT_mabi_EQ); + if (A && Target.isMIPS()) getLastArg claims the option for non-mip

[PATCH] D134801: [clang][Interp] Implement ConditionalOperators

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:90 bool VisitOpaqueValueExpr(const OpaqueValueExpr *E); + bool VisitConditionalOperator(const ConditionalOperator *E); Do we want to handle `BinaryConditionalOperator` a

[PATCH] D124751: [HLSL] Support -E option for HLSL.

MaskRay added inline comments. Comment at: clang/test/Driver/hlsl-entry.cpp:1 +// RUN:not %clang -cc1 -triple dxil-pc-shadermodel6.3-compute -x c++ -hlsl-entry foo %s 2>&1 | FileCheck %s --check-prefix=NOTHLSL + Note, test/Driver deliberately discourages `%cla

[clang] 3a79f1c - [Driver][test] Restore %clang -cc1 in test/Driver

Author: Fangrui Song Date: 2022-09-29T12:21:57-07:00 New Revision: 3a79f1caa9bd1e43f4e0e9187b87c978105c40b1 URL: https://github.com/llvm/llvm-project/commit/3a79f1caa9bd1e43f4e0e9187b87c978105c40b1 DIFF: https://github.com/llvm/llvm-project/commit/3a79f1caa9bd1e43f4e0e9187b87c978105c40b1.diff

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a think-o that I introduced with an earlier suggested change. I'm not super qualified for the CodeGen changes. They look correct to me, but @beanz would probably

[PATCH] D134874: [Concepts] Fix Concepts on generic lambda in a VarTemplateSpecDecl

erichkeane added inline comments. Comment at: clang/test/SemaTemplate/concepts-lambda.cpp:26 + template + auto f2 = [](auto... args) +requires (sizeof...(args) > 0) Huh... this f2 example seems to ICE for some reason, I could swear it worked, but building

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

MaskRay added inline comments. Comment at: clang/test/Driver/lit.local.cfg:8 -('%clang_cc1', - """*** Do not use 'clang -cc1' in Driver tests. ***""") ) probinson wrote: > But we _don't_ want to use `%clang_cc1` in Driver tests; if we do, then we're >

[PATCH] D134020: [clang][Interp] Handle enums

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/enums.cpp:25 + SIX = FIVE + 2, + +}; tbaeder wrote: > aaron.ballman wrote: > > tbaeder wrote: > > > aaron.ballman wrote: > > > > tbaeder wrote: > > > > > aaron.ballman wrote: > > > > > > tbae

[PATCH] D133659: [Clang] P1169R4: static operator()

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for all the work on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D1336

  1   2   3   >