python3kgae added inline comments.

================
Comment at: clang/test/CodeGenHLSL/builtins/cos.hlsl:11
+// NO_HALF: define noundef float @"?test_cos_half@@YA$halff@$halff@@Z"(
+// NO_HALF: call noundef float @"?cos@@YAMM@Z"(float noundef %0)
+half test_cos_half ( half p0 ) {
----------------
We want to lower it into llvm::Intrinsic::cos.

You can add it in CodeGenFunction::EmitBuiltinExpr like how elementwise_ceil is 
lowered.
And add people who did the elementwise_ceil work to review. Better create 
another PR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134921/new/

https://reviews.llvm.org/D134921

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to