tbaeder marked an inline comment as done.
tbaeder added inline comments.
================
Comment at: clang/lib/AST/Interp/Interp.h:164
+
+ if (RHS.isZero()) {
+ const SourceInfo &Loc = S.Current->getSource(OpPC);
----------------
shafik wrote:
> You also need to catch when the result is not representable e.g `INT_MIN % -1`
>
> see `CheckICE(...)`
I added the check here some lines below; Is that alright? If so I'd add the
same code to the `div()` implementation.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134744/new/
https://reviews.llvm.org/D134744
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
