[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

inclyc updated this revision to Diff 449195. inclyc added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130906/new/ https://reviews.llvm.org/D130906 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/format-strings-scanf.

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

inclyc added inline comments. Comment at: clang/test/Sema/format-strings-scanf.c:236 + scanf(1 ? "%s" : "%d", i); // expected-warning{{format specifies type 'char *'}} \ + // expected-note{{format string is defined here}} scanf(0 ? "%d %d" : "%d",

[PATCH] D130311: [RISCV] Enable strict FP in clang as long as Zve* or V are not enabled.

kito-cheng added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:286 + // StrictFP support for vectors is incomplete. + if (ISAInfo->hasExtension("zve32x")) +HasStrictFP = false; craig.topper wrote: > reames wrote: > > craig.topper wrote: > >

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

tbaeder added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:8507 +if (Result.Val.isLValue()) { + auto *LVE = Result.Val.getLValueBase().dyn_cast(); + if (LVE && LVE->getStmtClass() == Stmt::StringLiteralClass) { inclyc wrote: > tbaede

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

inclyc updated this revision to Diff 449191. inclyc added a comment. Make if statements concise and add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130906/new/ https://reviews.llvm.org/D130906 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

inclyc added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:8507 +if (Result.Val.isLValue()) { + auto *LVE = Result.Val.getLValueBase().dyn_cast(); + if (LVE && LVE->getStmtClass() == Stmt::StringLiteralClass) { tbaeder wrote: > I thin

[PATCH] D130827: [clang] Fixed a number of typos

h-vetinari added a comment. Thanks for chasing these down! Comment at: clang/include/clang/Basic/SourceManager.h:1922 +/// SourceManager and necessary dependencies (e.g. VFS, FileManager) for a +/// single in-memorty file. class SourceManagerForFile { Even tho

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke updated this revision to Diff 449188. Sockke added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-extra/docs/ReleaseNo

[PATCH] D130510: Missing tautological compare warnings due to unary operators

rtrieu reopened this revision. rtrieu added a comment. This revision is now accepted and ready to land. This warning is now flagging some code which I believe is a false positive. In particular, when template arguments are involved, their values can be calculated during template instantiation,

[PATCH] D130964: Enable __bf16 for x86 targets.

FreddyYe created this revision. Herald added subscribers: luke957, pengfei, s.egerton, simoncook. Herald added a project: All. FreddyYe requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, pcwang-thead. Herald added projects: clang, LLVM. X86 psABI has updated to

[PATCH] D130791: [clang] Short-circuit trivial constexpr array constructors

tbaeder updated this revision to Diff 449182. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130791/new/ https://reviews.llvm.org/D130791 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ExprConstant.cpp Index: clang/lib/AST/ExprConstant.cpp =

[PATCH] D130791: [clang] Short-circuit trivial constexpr array constructors

tbaeder added a comment. In D130791#3692071 , @dblaikie wrote: > also: What about zero length arrays? (which are supported as an extension) - > this change would cause failures that wouldn't be emitted in the old code? There's a `if (FinalSize == 0) ret

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

tbaeder added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:8504 return SLCT_UncheckedLiteral; + Expr::EvalResult Result; + if (E->EvaluateAsRValue(Result, S.Context)) { A comment above this line would be helpful. Would also visually separat

[clang] 6d10733 - [C++20] [Modules] Handle initializer for Header Units

Author: Chuanqi Xu Date: 2022-08-02T11:24:46+08:00 New Revision: 6d10733d445506c02ebec9faa54658431857bb49 URL: https://github.com/llvm/llvm-project/commit/6d10733d445506c02ebec9faa54658431857bb49 DIFF: https://github.com/llvm/llvm-project/commit/6d10733d445506c02ebec9faa54658431857bb49.diff LO

[clang] 39cfde2 - Revert "[C++20] [Modules] Handle initializer for Header Units"

Author: Chuanqi Xu Date: 2022-08-02T11:09:38+08:00 New Revision: 39cfde236693a928ff6594ddc321c4550237cfaa URL: https://github.com/llvm/llvm-project/commit/39cfde236693a928ff6594ddc321c4550237cfaa DIFF: https://github.com/llvm/llvm-project/commit/39cfde236693a928ff6594ddc321c4550237cfaa.diff LO

[PATCH] D130864: [NFC] Introduce ASTContext::isInSameModule()

ChuanqiXu marked 2 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6232 + + auto getHashValueForPrimaryModule = [this](const Module *M) { +if (!PrimaryModuleHash.count(M)) erichkeane wrote: > Doesn't `FindAn

[PATCH] D130864: [NFC] Introduce ASTContext::isInSameModule()

ChuanqiXu updated this revision to Diff 449173. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130864/new/ https://reviews.llvm.org/D130864 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Sema/Sema.h clang/lib/AST/ASTCon

[clang] 29f852a - [Driver] Remove deprecated -fsanitize-coverage-{black,white}list=

Author: Fangrui Song Date: 2022-08-01T19:39:25-07:00 New Revision: 29f852a1516bcd3928dad74835965f238de34409 URL: https://github.com/llvm/llvm-project/commit/29f852a1516bcd3928dad74835965f238de34409 DIFF: https://github.com/llvm/llvm-project/commit/29f852a1516bcd3928dad74835965f238de34409.diff

[clang] 0bb3aaf - [docs] Regenerate clang/docs/ClangCommandLineReference.rst

Author: Fangrui Song Date: 2022-08-01T19:31:25-07:00 New Revision: 0bb3aafbd5d59fdd3720c4ba9b995863bc3d2f45 URL: https://github.com/llvm/llvm-project/commit/0bb3aafbd5d59fdd3720c4ba9b995863bc3d2f45 DIFF: https://github.com/llvm/llvm-project/commit/0bb3aafbd5d59fdd3720c4ba9b995863bc3d2f45.diff

[PATCH] D130871: [C++20] [Modules] Handle initializer for Header Units

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb6152ad66d7: [C++20] [Modules] Handle initializer for Header Units (authored by ChuanqiXu). Changed prior to commit: https://reviews.llvm.org/D130871?vs=448931&id=449172#toc Repository: rG LLVM Gith

[clang] db6152a - [C++20] [Modules] Handle initializer for Header Units

Author: Chuanqi Xu Date: 2022-08-02T10:27:02+08:00 New Revision: db6152ad66d7cf48f9f5c3eb28bf54c092978773 URL: https://github.com/llvm/llvm-project/commit/db6152ad66d7cf48f9f5c3eb28bf54c092978773 DIFF: https://github.com/llvm/llvm-project/commit/db6152ad66d7cf48f9f5c3eb28bf54c092978773.diff LO

[PATCH] D130936: [SemaCXX] Validate destructor is valid for dependent classes

shafik added a comment. LGTM but let's have Erich take a look. Comment at: clang/lib/Sema/SemaDecl.cpp:11499 - // FIXME: Shouldn't we be able to perform this check even when the class - // type is dependent? Both gcc and edg can handle that. The FIX

[clang] 9bf6ecc - [clang] Only run test on x86

Author: Alex Brachet Date: 2022-08-02T00:56:05Z New Revision: 9bf6eccae112476d953180e814781b99237bd0bb URL: https://github.com/llvm/llvm-project/commit/9bf6eccae112476d953180e814781b99237bd0bb DIFF: https://github.com/llvm/llvm-project/commit/9bf6eccae112476d953180e814781b99237bd0bb.diff LOG:

[PATCH] D129048: Rewording the "static_assert" to static assertion

thakis added a comment. This change caused a ton of churn, for what I understand fix the diag in C mode when assert.h is not included. IMHO, it would've been better to change the diag to say either `static_assert` as before in c++ mode or when assert.h is included (i.e. almost always), and `_S

[PATCH] D130863: [clangd] Make git ignore index directories

sums marked an inline comment as done. sums added inline comments. Comment at: clang-tools-extra/clangd/test/background-index.test:23 +# RUN: ls %/t/.cache/clangd/index/.gitignore +# RUN: ls %/t/sub_dir/.cache/clangd/index/.gitignore + sammccall wrote: > Bleh, id

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

python3kgae created this revision. python3kgae added reviewers: aaron.ballman, Anastasia, kuhar, bogner, beanz, pow2clk. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ''register(ID, space)'' like

[PATCH] D130800: [clang][Headers] Avoid compiler warnings in builtin headers

tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_builtin_vars.h:37 -#if __cplusplus >= 201103L +#if defined(__cplusplus) && __cplusplus >= 201103L #define __DELETE =delete Are there actual use cases where CUDA headers are used from a non-C

[PATCH] D130311: [RISCV] Enable strict FP in clang as long as Zve* or V are not enabled.

craig.topper updated this revision to Diff 449150. craig.topper added a comment. Add hasVInstructions to RISCVISAInfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130311/new/ https://reviews.llvm.org/D130311 Files: clang/lib/Basic/Targets/RISCV

[PATCH] D130935: [clang] Only modify FileEntryRef names that are externally remapped

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98cf745a032e: [clang] Only modify FileEntryRef names that are externally remapped (authored by benlangmuir). Repository: rG LLVM Github Monorepo

[clang] 98cf745 - [clang] Only modify FileEntryRef names that are externally remapped

Author: Ben Langmuir Date: 2022-08-01T15:45:51-07:00 New Revision: 98cf745a032ea0d29fbddaa204760d4e823c237f URL: https://github.com/llvm/llvm-project/commit/98cf745a032ea0d29fbddaa204760d4e823c237f DIFF: https://github.com/llvm/llvm-project/commit/98cf745a032ea0d29fbddaa204760d4e823c237f.diff

[PATCH] D130311: [RISCV] Enable strict FP in clang as long as Zve* or V are not enabled.

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:286 + // StrictFP support for vectors is incomplete. + if (ISAInfo->hasExtension("zve32x")) +HasStrictFP = false; reames wrote: > craig.topper wrote: > > reames wrote: > > > c

[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

NoQ accepted this revision. NoQ added a comment. Great, thanks! Unless there are other objections from other reviewers, I think this is good to go. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126097/new/ https://reviews.llvm.org/D126097 __

[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

t-rasmud updated this revision to Diff 449144. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126097/new/ https://reviews.llvm.org/D126097 Files: clang-tools-extra/clang-tidy/objc/CMakeLists.txt clang-tools-extra/clang-tidy/objc/NSDateFormatterCheck.cpp clang-tools-extra/clang-tidy/

[clang] 6b3fa58 - [clang] Make test agnostic to file seperator character

Author: Alex Brachet Date: 2022-08-01T22:12:04Z New Revision: 6b3fa58fde5962f00523e2a8f2498b1206345db2 URL: https://github.com/llvm/llvm-project/commit/6b3fa58fde5962f00523e2a8f2498b1206345db2 DIFF: https://github.com/llvm/llvm-project/commit/6b3fa58fde5962f00523e2a8f2498b1206345db2.diff LOG:

[clang] 71f2d5c - [clang] Re-enable test after marking it XFAIL

Author: Alex Brachet Date: 2022-08-01T22:09:13Z New Revision: 71f2d5c2d195256f27f293aefdc1d4f6c117065d URL: https://github.com/llvm/llvm-project/commit/71f2d5c2d195256f27f293aefdc1d4f6c117065d DIFF: https://github.com/llvm/llvm-project/commit/71f2d5c2d195256f27f293aefdc1d4f6c117065d.diff LOG:

[PATCH] D130871: [C++20] [Modules] Handle initializer for Header Units

iains accepted this revision. iains added a comment. This revision is now accepted and ready to land. LGTM, one small point about the test, Comment at: clang/test/CodeGenCXX/module-initializer-header.cppm:5-7 +// RUN: %clang_cc1 -std=c++20 -triple=x86_64-unknown-linux-gnu -xc+

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

steplong updated this revision to Diff 449140. steplong added a comment. Herald added a subscriber: steakhal. - Change unittest to match Num Args 1 or 2 I won't merge this. Just want to see if this passes the unittest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D130934: [clang] Update code that assumes FileEntry::getName is absolute NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4c6dc2e6637: [clang] Update code that assumes FileEntry::getName is absolute NFC (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[clang] b4c6dc2 - [clang] Update code that assumes FileEntry::getName is absolute NFC

Author: Ben Langmuir Date: 2022-08-01T14:48:37-07:00 New Revision: b4c6dc2e66370d94ff52075c2710a674d8e1e0f8 URL: https://github.com/llvm/llvm-project/commit/b4c6dc2e66370d94ff52075c2710a674d8e1e0f8 DIFF: https://github.com/llvm/llvm-project/commit/b4c6dc2e66370d94ff52075c2710a674d8e1e0f8.diff

[PATCH] D130936: [SemaCXX] Validate destructor is valid for dependent classes

royjacobson created this revision. Herald added a project: All. royjacobson updated this revision to Diff 449130. royjacobson added a comment. royjacobson retitled this revision from "[SemaCXX] Fix destructor name accepts-invalid bug." to "[SemaCXX] Validate destructor is valid for dependent clas

[PATCH] D129954: [CodeGen][inlineasm] assume the flag output of inline asm is boolean value

nickdesaulniers accepted this revision. nickdesaulniers added a comment. Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129954/new/ https://reviews.llvm.org/D129954 ___ cfe-commits m

[PATCH] D130516: [llvm] compression classes

dblaikie added a comment. (still lots of outstanding comments from my last round, so I won't reiterate those - but waiting for some responses to them) Comment at: llvm/lib/Support/Compression.cpp:30-32 +ZStdCompressionAlgorithm +*llvm::compression::ZStdCompressionAlgorithm

[PATCH] D130754: [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. LGTM; thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130754/new/ https://reviews.llvm.org/D130754 __

[PATCH] D130935: [clang] Only modify FileEntryRef names that are externally remapped

benlangmuir updated this revision to Diff 449124. benlangmuir added a comment. Flip the order of comparisons to avoid unnecessary string comparisons. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130935/new/ https://reviews.llvm.org/D130935 Files:

[clang] 4b8f375 - [clang] Temporarily expect failure from test

Author: Alex Brachet Date: 2022-08-01T21:11:21Z New Revision: 4b8f375c9f9ece32106da899bc2debf31ed20970 URL: https://github.com/llvm/llvm-project/commit/4b8f375c9f9ece32106da899bc2debf31ed20970 DIFF: https://github.com/llvm/llvm-project/commit/4b8f375c9f9ece32106da899bc2debf31ed20970.diff LOG:

[PATCH] D130791: [clang] Short-circuit trivial constexpr array constructors

dblaikie added a comment. > Thank you for working on this! This should also include test coverage (hmmm, > we don't have a reasonable way to lit test performance regressions though > so perhaps we just need to ensure there's at least one test that would > normally have been unreasonably slo

[PATCH] D130935: [clang] Only modify FileEntryRef names that are externally remapped

benlangmuir added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:277-278 - if (Status.getName() == Filename) { -// The name matches. Set the FileEntry. + if (Status.getName() == Filename || !Status.ExposesExternalVFSPath) { +// Use the requested name. Se

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

abrachet added a comment. In D120175#3692032 , @thakis wrote: > This breaks tests on mac and win: > http://45.33.8.238/macm1/41545/step_7.txt > http://45.33.8.238/win/63579/step_7.txt > > Please take a look and revert for now if it takes a while to fix.

[clang] 9028966 - [clang] Don't create executable in test

Author: Alex Brachet Date: 2022-08-01T20:59:40Z New Revision: 9028966a717239cf586d6c4f606965d444176dc4 URL: https://github.com/llvm/llvm-project/commit/9028966a717239cf586d6c4f606965d444176dc4 DIFF: https://github.com/llvm/llvm-project/commit/9028966a717239cf586d6c4f606965d444176dc4.diff LOG:

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

thakis added a comment. This breaks tests on mac and win: http://45.33.8.238/macm1/41545/step_7.txt http://45.33.8.238/win/63579/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D130935: [clang] Only modify FileEntryRef names that are externally remapped

bnbarham accepted this revision. bnbarham added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Basic/FileManager.cpp:277-278 - if (Status.getName() == Filename) { -// The name matches. Set the FileEntry. + if (Status.getName() == F

[PATCH] D130800: [clang][Headers] Avoid compiler warnings in builtin headers

ddcc updated this revision to Diff 449118. ddcc added a comment. Undef macros instead, handle other header files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130800/new/ https://reviews.llvm.org/D130800 Files: clang/lib/Headers/__clang_cuda_bui

[PATCH] D130934: [clang] Update code that assumes FileEntry::getName is absolute NFC

bnbarham accepted this revision. bnbarham added a comment. This revision is now accepted and ready to land. LGTM, thanks for doing this 🙇 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130934/new/ https://reviews.llvm.org/D130934 __

[PATCH] D130935: [clang] Only modify FileEntryRef names that are externally remapped

benlangmuir created this revision. benlangmuir added reviewers: bnbarham, jansvoboda11. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As progress towards having FileEntryRef contain the requested n

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

abrachet added a comment. In D120175#3691843 , @MaskRay wrote: > LGTM > > (Note: This is a patch which I think would benefit from a second look and > 2.5h from approval to push was too short for others to react on this patch.) Ack, I'll give more time i

[clang] 1ccded0 - [clang] Fix build when targeting ps4

Author: Alex Brachet Date: 2022-08-01T20:31:01Z New Revision: 1ccded0fc111700f72ffa36b5d0160a86c65ec3a URL: https://github.com/llvm/llvm-project/commit/1ccded0fc111700f72ffa36b5d0160a86c65ec3a DIFF: https://github.com/llvm/llvm-project/commit/1ccded0fc111700f72ffa36b5d0160a86c65ec3a.diff LOG:

[PATCH] D130934: [clang] Update code that assumes FileEntry::getName is absolute NFC

benlangmuir created this revision. benlangmuir added reviewers: bnbarham, jansvoboda11. Herald added a project: All. benlangmuir requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. It's an accident that we started return asbol

[PATCH] D130933: Add docs for function attributes hot/cold

OfekShilon created this revision. OfekShilon added reviewers: xur, davidxl. Herald added a reviewer: aaron.ballman. Herald added a project: All. OfekShilon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Following this

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

MaskRay added a comment. LGTM (Note: I think 2.5h from approval to push was too short for others to react on this patch.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120175/new/ https://reviews.llvm.org/D120175

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

This revision was automatically updated to reflect the committed changes. Closed by commit rG5fd03b00ee02: [Driver] Re-run lld with --reproduce when it crashes (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHA

[clang] 5fd03b0 - [Driver] Re-run lld with --reproduce when it crashes

Author: Alex Brachet Date: 2022-08-01T20:01:01Z New Revision: 5fd03b00ee029b4cc958ae8e6c970a6123bd12f6 URL: https://github.com/llvm/llvm-project/commit/5fd03b00ee029b4cc958ae8e6c970a6123bd12f6 DIFF: https://github.com/llvm/llvm-project/commit/5fd03b00ee029b4cc958ae8e6c970a6123bd12f6.diff LOG:

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman added a comment. Ah my bad didn't realize you hadn't accepted this, was there anything else you wanted me to change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130041/new/ https://reviews.llvm.org/D130041 _

[PATCH] D130863: [clangd] Make git ignore index directories

sammccall added a comment. My 2c, though I'm away with kids right now so will leave to @kadircet to make a call Given that this is fully contained (logically and physically) within clangd's index directory, this seems elegant and harmless to me. (At first i thought it was modifying project-lev

[PATCH] D130791: [clang] Short-circuit trivial constexpr array constructors

aaron.ballman added a comment. Thank you for working on this! This should also include test coverage (hmmm, we don't have a reasonable way to lit test performance regressions though so perhaps we just need to ensure there's at least one test that would normally have been unreasonably slow?)

[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

NoQ added a comment. Uh-oh sorry! I have a couple more questions and then we can probably land. Comment at: clang-tools-extra/clang-tidy/objc/NSDateFormatterCheck.cpp:24 + Finder->addMatcher( + objcMessageExpr(hasSelector("setDateFormat:"), + hasArgum

[PATCH] D130800: [clang][Headers] Avoid compiler warnings in builtin headers

aaron.ballman added a comment. Thanks for catching this! As far as these changes go, they're pretty reasonable, but don't seem like they hit all of the problem areas. There's 20+ occurrences of `#if __STDC_VERSION__` and 10+ of `#if __cplusplus` in lib/Headers; shouldn't they all be updated?

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

khchen added a comment. oops.. all tests need to updated and include all intrinsic IR tests... Is there any benefit to switch UndefValue to PoisonValue? maybe those changed should be in other follow-up patches? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG61ef0ab70196: [clangd] Add decl/def support to SymbolDetails (authored by dgoldman). Repository: rG LLVM Github Monorep

[clang-tools-extra] 61ef0ab - [clangd] Add decl/def support to SymbolDetails

Author: David Goldman Date: 2022-08-01T14:42:19-04:00 New Revision: 61ef0ab70196bfdc4c301e12384aa91938b15cc4 URL: https://github.com/llvm/llvm-project/commit/61ef0ab70196bfdc4c301e12384aa91938b15cc4 DIFF: https://github.com/llvm/llvm-project/commit/61ef0ab70196bfdc4c301e12384aa91938b15cc4.diff

[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

t-rasmud added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126097/new/ https://reviews.llvm.org/D126097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

khchen added a comment. In D126745#3691544 , @craig.topper wrote: > In D126745#3691528 , @khchen wrote: > >> In D126745#3678776 , @nlopes wrote: >> >>> While at it, could

[PATCH] D130311: [RISCV] Enable strict FP in clang as long as Zve* or V are not enabled.

reames added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:286 + // StrictFP support for vectors is incomplete. + if (ISAInfo->hasExtension("zve32x")) +HasStrictFP = false; craig.topper wrote: > reames wrote: > > craig.topper wrote: > > > r

[PATCH] D130311: [RISCV] Enable strict FP in clang as long as Zve* or V are not enabled.

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:286 + // StrictFP support for vectors is incomplete. + if (ISAInfo->hasExtension("zve32x")) +HasStrictFP = false; reames wrote: > craig.topper wrote: > > reames wrote: > > > a

[PATCH] D130311: [RISCV] Enable strict FP in clang as long as Zve* or V are not enabled.

reames added a comment. In D130311#3691146 , @craig.topper wrote: > In D130311#3691029 , @reames wrote: > >> I'm not fluent on strict FP, so let me summarize my understanding. This is >> mostly so you can easil

[PATCH] D130918: [clang][ExtractAPI] Record availability information on all platforms

zixuw added a comment. Thanks Daniel! Comment at: clang/test/ExtractAPI/availability.c:16 +//--- input.h +/// Documentation for a. +void a(void); Do we care about doc comments for this particular test? The testing convention for all the ExtractAPI tests is prob

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

craig.topper added a comment. In D126745#3691528 , @khchen wrote: > In D126745#3678776 , @nlopes wrote: > >> While at it, could you switch those UndefValue with PoisonValue if possible? >> Thank you! > > I'm not

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

khchen added a comment. In D126745#3678776 , @nlopes wrote: > While at it, could you switch those UndefValue with PoisonValue if possible? > Thank you! I'm not sure UndefValue will work because the backend would only check isUndef() to generate correc

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

v.g.vassilev added a comment. @tapaswenipathak, ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126266/new/ https://reviews.llvm.org/D126266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D130918: [clang][ExtractAPI] Record availability information on all platforms

dang created this revision. dang added reviewers: zixuw, QuietMisdreavus, ributzka. Herald added a subscriber: mgorny. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently ExtractAPI only emits availab

[PATCH] D126743: [RISCV][Clang] Add tests for all supported policy functions. (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e51917b39cd: [RISCV][Clang] Add tests for all supported policy functions. (NFC) (authored by khchen). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

aaron.ballman added a comment. In D130058#3689053 , @thakis wrote: > In D130058#3687868 , @aaron.ballman > wrote: > >> In D130058#3687680 , @thakis wrote: >> >>> Hello, t

[PATCH] D130807: [InstrProf] Add the omitprofile attribute

paulkirth added a comment. > I agree that `omitprofile` probably doesn't communicate the correct meaning > very well. I like `nodirectprofile` because it hopefully implies that > indirect profiles are allowed. I'm wondering if anyone else has suggestions. > > Is there any precedent for renamin

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:3381 &SS) && isConstructorDeclarator(/*Unqualified*/ false)) goto DoneWithDeclSpec; The only remaining failure is in `test/Pars

[PATCH] D130516: [llvm] compression classes

ckissane added inline comments. Comment at: llvm/lib/Support/Compression.cpp:30-32 +ZStdCompressionAlgorithm +*llvm::compression::ZStdCompressionAlgorithm::Instance = +new ZStdCompressionAlgorithm(); dblaikie wrote: > leonardchan wrote: > > Perhaps fo

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 449066. v.g.vassilev edited the summary of this revision. v.g.vassilev added a comment. Herald added subscribers: sstefan1, Anastasia. Herald added a reviewer: jdoerfert. Rely on the CXXScopeSpec to detect more accurately if we are parsing a constructor

[PATCH] D130827: [clang] Fixed a number of typos

aaron.ballman added a comment. In D130827#3691371 , @GabrielRavier wrote: >> Do you need someone to land this on your behalf? > > I assume so since landing seems to mean pushing the commit to the repo which > I'm pretty sure I don't have the rights to d

[PATCH] D130827: [clang] Fixed a number of typos

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5674a3c88088: Fixed a number of typos (authored by GabrielRavier, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 5674a3c - Fixed a number of typos

Author: Gabriel Ravier Date: 2022-08-01T13:13:18-04:00 New Revision: 5674a3c88088e668b684326c2194a6282e8270ff URL: https://github.com/llvm/llvm-project/commit/5674a3c88088e668b684326c2194a6282e8270ff DIFF: https://github.com/llvm/llvm-project/commit/5674a3c88088e668b684326c2194a6282e8270ff.diff

[PATCH] D130827: [clang] Fixed a number of typos

GabrielRavier added a comment. > Do you need someone to land this on your behalf? Yes. > If so, what name and email address would you like used for patch attribution? `Gabriel Ravier`, `gabrav...@gmail.com` (By the way, is there any way to make this information part of my Phabricator account

[PATCH] D130807: [InstrProf] Add the omitprofile attribute

ellis added a comment. In D130807#3688798 , @paulkirth wrote: > Do you expect the difference between `noprofile` and `omitprofile` to be > confusing to users? I can certainly see how users could be confused by what > the difference is between `noprofile

[clang-tools-extra] 556c422 - clang-tidy doc: fix some typos

Author: Sylvestre Ledru Date: 2022-08-01T18:57:36+02:00 New Revision: 556c422de1c3b0623e83c85b36a43dd743660fb1 URL: https://github.com/llvm/llvm-project/commit/556c422de1c3b0623e83c85b36a43dd743660fb1 DIFF: https://github.com/llvm/llvm-project/commit/556c422de1c3b0623e83c85b36a43dd743660fb1.dif

[PATCH] D130531: [IR] Use Min behavior for module flag "PIC Level"

MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130531/new/ https://reviews.llvm.org/D130531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D130827: [clang] Fixed a number of typos

aaron.ballman added a comment. Thanks for the typo fixes! All the changes look correct to me, so LGTM. Do you need someone to land this on your behalf? If so, what name and email address would you like used for patch attribution? Comment at: clang/lib/Headers/opencl-c.h:17856

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari updated this revision to Diff 449059. Purva-Chaudhari added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 Files: clang/include/clang/Sema/Sema.h clang/lib/Interpreter/IncrementalParser.cpp clang/test/I

[clang-tools-extra] 37047a2 - misc-const-correctness: fix the link to readability-isolate-declaration

Author: Sylvestre Ledru Date: 2022-08-01T18:52:53+02:00 New Revision: 37047a26731a6731c949682e159fe40786e6d711 URL: https://github.com/llvm/llvm-project/commit/37047a26731a6731c949682e159fe40786e6d711 DIFF: https://github.com/llvm/llvm-project/commit/37047a26731a6731c949682e159fe40786e6d711.dif

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman updated this revision to Diff 449050. dgoldman added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130041/new/ https://reviews.llvm.org/D130041 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/clan

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

njames93 updated this revision to Diff 449048. njames93 added a comment. Rebase and Ping?? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130181/new/ https://reviews.llvm.org/D130181 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

njames93 updated this revision to Diff 449046. njames93 added a comment. Revert to first version, just so we can sort out the 15.X branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128379/new/ https://reviews.llvm.org/D128379 Files: clang-to

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd added a comment. Hi all, I just wanted to check in on this again and see if any more feedback or progress could be made. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 _

[PATCH] D130019: [HLSL] CodeGen HLSL Resource annotations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5dbb92d8cdf7: [HLSL] CodeGen HLSL Resource annotations (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

  1   2   >