Author: Alex Brachet Date: 2022-08-01T22:09:13Z New Revision: 71f2d5c2d195256f27f293aefdc1d4f6c117065d
URL: https://github.com/llvm/llvm-project/commit/71f2d5c2d195256f27f293aefdc1d4f6c117065d DIFF: https://github.com/llvm/llvm-project/commit/71f2d5c2d195256f27f293aefdc1d4f6c117065d.diff LOG: [clang] Re-enable test after marking it XFAIL This test had to be disabled because ps4 targets don't support -fuse-ld. Preferably, this should just be unsupported for ps4 targets. However no such lit feature exists so I have just gone ahead and set the target explicitly. Moreover, this needs to create a terminal link step, either an executable or shared object to get the link error. With the change to the explicit target I've had to also add -nostartfiles -nostdlib so that clang doesn't pull crt files into the link which may not be present. Again, this would likely be solved if this test was unsupported for the one platform that disables -fuse-ld Added: Modified: clang/test/Driver/lld-repro.c Removed: ################################################################################ diff --git a/clang/test/Driver/lld-repro.c b/clang/test/Driver/lld-repro.c index 2643ad871835..733a6f9d1305 100644 --- a/clang/test/Driver/lld-repro.c +++ b/clang/test/Driver/lld-repro.c @@ -1,7 +1,6 @@ // REQUIRES: lld -// XFAIL: * -// RUN: not %clang %s -target x86_64-linux -c -fuse-ld=lld -gen-reproducer=error -fcrash-diagnostics-dir=%t -fcrash-diagnostics=all 2>&1 \ +// RUN: not %clang %s -target x86_64-linux -nostartfiles -nostdlib -fuse-ld=lld -gen-reproducer=error -fcrash-diagnostics-dir=%t -fcrash-diagnostics=all 2>&1 \ // RUN: | FileCheck %s // check that we still get lld's output @@ -14,9 +13,9 @@ // CHECK-NEXT: note: diagnostic msg: // CHECK: ******************** -// RUN: not %clang %s -target x86_64-linux -c -fuse-ld=lld -gen-reproducer=error -fcrash-diagnostics-dir=%t -fcrash-diagnostics=compiler 2>&1 \ +// RUN: not %clang %s -target x86_64-linux -nostartfiles -nostdlib -fuse-ld=lld -gen-reproducer=error -fcrash-diagnostics-dir=%t -fcrash-diagnostics=compiler 2>&1 \ // RUN: | FileCheck %s --check-prefix=NO-LINKER -// RUN: not %clang %s -target x86_64-linux -c -fuse-ld=lld -gen-reproducer=error -fcrash-diagnostics-dir=%t 2>&1 \ +// RUN: not %clang %s -target x86_64-linux -nostartfiles -nostdlib -fuse-ld=lld -gen-reproducer=error -fcrash-diagnostics-dir=%t 2>&1 \ // RUN: | FileCheck %s --check-prefix=NO-LINKER // NO-LINKER-NOT: Preprocessed source(s) and associated run script(s) are located at: _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
