dblaikie added a comment. > Thank you for working on this! This should also include test coverage (hmmm, > we don't have a reasonable way to lit test performance regressions though.... > so perhaps we just need to ensure there's at least one test that would > normally have been unreasonably slow?) and a release note.
I think generally for pure-perf fixes we don't include any testing. (like switching a container type, adding caching, etc) But may be worth double-checking that there's reasonable test coverage for the feature. also: What about zero length arrays? (which are supported as an extension) - this change would cause failures that wouldn't be emitted in the old code? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130791/new/ https://reviews.llvm.org/D130791 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
