[PATCH] D130411: [clang-format] Fix a hang when formatting C# $@ string literals

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

mstorsjo added a comment. In D129377#3673237 , @mib wrote: > In D129377#3673204 , @mstorsjo > wrote: > >> This broke building of Clang, when it's set up by symlinking >> `llvm-project/clang` into `llvm-project/l

[clang] 1a3a2ee - [NFC] Move function definition to cpp file

Author: Jun Zhang Date: 2022-07-23T13:43:42+08:00 New Revision: 1a3a2eec717b6067e29d8a07318257d2d96da238 URL: https://github.com/llvm/llvm-project/commit/1a3a2eec717b6067e29d8a07318257d2d96da238 DIFF: https://github.com/llvm/llvm-project/commit/1a3a2eec717b6067e29d8a07318257d2d96da238.diff LOG

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

shafik added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:899 + // triviality properties of the class until selecting a destructor and + // computing the eligibility of SMFs. This is because those member + // functions may have constraints that we need to

[PATCH] D130299: [clang-format] FIX: Misformatting lambdas with trailing return type 'auto' in braced lists

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. In D130299#3672486 , @denis-fatkulin wrote: >> Could you please add full git context? > > I updated the patch with p

[PATCH] D130406: Use llvm::sort instead of std::sort where possible

gribozavr created this revision. Herald added subscribers: bzcheeseman, sdasgup3, carlosgalvezp, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, usaxe

[PATCH] D129573: [clang] add a diagnostic note 'while loop outside functions' at global scope

mizvekov accepted this revision as: mizvekov. mizvekov added a comment. This revision is now accepted and ready to land. Thanks! The patch itself LGTM. Please update / fix up the commit message before merging. It still mentions `note` and has some minor English spelling issues. CHANGES SINCE L

[PATCH] D130063: [Driver] Enable sanitizers on FreeBSD AArch64

MaskRay accepted this revision. MaskRay added a comment. Herald added a subscriber: StephenFan. > [Driver] Enable sanitizers on FreeBSD AArch64 Be specific what sanitizers are enabled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130063/new/ http

[PATCH] D130403: Use the range-based overload of llvm::sort where possible

gribozavr created this revision. Herald added subscribers: carlosgalvezp, cishida, cmtice, usaxena95, kadircet, arphaman, mgrang. Herald added a reviewer: jhenderson. Herald added a reviewer: aaron.ballman. Herald added a reviewer: ributzka. Herald added a project: All. gribozavr requested review

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80a4e6fd31a0: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation (authored by MaskRay). Changed prior to commit: https://reviews.llvm.

[clang] 80a4e6f - [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

Author: Fangrui Song Date: 2022-07-22T17:16:41-07:00 New Revision: 80a4e6fd31a06143b83947785ea3bd5c04344ea6 URL: https://github.com/llvm/llvm-project/commit/80a4e6fd31a06143b83947785ea3bd5c04344ea6 DIFF: https://github.com/llvm/llvm-project/commit/80a4e6fd31a06143b83947785ea3bd5c04344ea6.diff

[PATCH] D130308: WIP: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov marked 3 inline comments as done. mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12670 + return QualType(); +// FIXME: The modified types can be different as well. +// FIXME: It's inneficient to have to unify the modified types. ---

[PATCH] D130308: WIP: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov updated this revision to Diff 447009. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaTemplateDeduc

[PATCH] D130398: [clang][dataflow] Add DataflowEnvironment::dump()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5414b566a5a: [clang][dataflow] Add DataflowEnvironment::dump() (authored by gribozavr). Changed prior to commit: https://reviews.llvm.org/D130398

[clang] b5414b5 - [clang][dataflow] Add DataflowEnvironment::dump()

Author: Dmitri Gribenko Date: 2022-07-23T01:31:53+02:00 New Revision: b5414b566a5aedd90e41f01dd2b7b632afc5d5b7 URL: https://github.com/llvm/llvm-project/commit/b5414b566a5aedd90e41f01dd2b7b632afc5d5b7 DIFF: https://github.com/llvm/llvm-project/commit/b5414b566a5aedd90e41f01dd2b7b632afc5d5b7.dif

[PATCH] D130377: Move "clang/Basic/TokenKinds.h" into a separate top-level module.

vsapsai added a comment. Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130377/new/ https://reviews.llvm.org/D130377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D130377: Move "clang/Basic/TokenKinds.h" into a separate top-level module.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e4478bbea72: Move "clang/Basic/TokenKinds.h" into a separate top-level module. (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGE

[clang] 1e4478b - Move "clang/Basic/TokenKinds.h" into a separate top-level module.

Author: Volodymyr Sapsai Date: 2022-07-22T16:26:27-07:00 New Revision: 1e4478bbea727dbbffb1023eedfc24eae7185782 URL: https://github.com/llvm/llvm-project/commit/1e4478bbea727dbbffb1023eedfc24eae7185782 DIFF: https://github.com/llvm/llvm-project/commit/1e4478bbea727dbbffb1023eedfc24eae7185782.di

[PATCH] D130399: [clang][dataflow] Expose stringification functions for SAT solver enums

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee6aba85aa48: [clang][dataflow] Expose stringification functions for SAT solver enums (authored by gribozavr). Changed prior to commit: https://re

[clang] ee6aba8 - [clang][dataflow] Expose stringification functions for SAT solver enums

Author: Dmitri Gribenko Date: 2022-07-23T01:21:20+02:00 New Revision: ee6aba85aa48d03a931ba989ea2c1584b468588a URL: https://github.com/llvm/llvm-project/commit/ee6aba85aa48d03a931ba989ea2c1584b468588a DIFF: https://github.com/llvm/llvm-project/commit/ee6aba85aa48d03a931ba989ea2c1584b468588a.dif

[PATCH] D130400: [clang][dataflow] ArrayRef'ize debugString()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG589ddd7fe8e4: [clang][dataflow] ArrayRef'ize debugString() (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 589ddd7 - [clang][dataflow] ArrayRef'ize debugString()

Author: Dmitri Gribenko Date: 2022-07-23T01:16:31+02:00 New Revision: 589ddd7fe8e4dcf3323dd0b8f6af3ae953ed6037 URL: https://github.com/llvm/llvm-project/commit/589ddd7fe8e4dcf3323dd0b8f6af3ae953ed6037 DIFF: https://github.com/llvm/llvm-project/commit/589ddd7fe8e4dcf3323dd0b8f6af3ae953ed6037.dif

[PATCH] D119296: KCFI sanitizer

MaskRay added a comment. (Will read new updates.) Note that release/15.x is branching soon (https://discourse.llvm.org/t/llvm-15-0-0-release-schedule/63495): 2022-07-26. It seems that we can miss the branch to have more time mature the feature and have it for 16.0. Repository: rG LLVM Githu

[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

MaskRay added a comment. In D130078#3669072 , @awarzynski wrote: > In D130078#3667188 , @MaskRay wrote: > >> `forwardOptions` will be better if you are renaming it anyway. > > I'd rather create a separate patch a

[PATCH] D119296: KCFI sanitizer

samitolvanen planned changes to this revision. samitolvanen added a comment. Based on the recent LKML discussions about X86 retbleed mitigations (https://lore.kernel.org/lkml/20220716230344.239749...@linutronix.de/), we're going to need some changes to the code generated for X86. Repository:

[PATCH] D130301: [Clang] Fix how we set the NumPositiveBits on an E numDecl to cover the case of single enumerator with value zero or an empty enum

shafik added inline comments. Comment at: compiler-rt/test/ubsan/TestCases/Misc/enum.cpp:10 +enum class EBool : bool { a = 1 } e3; +enum EEmpty {}; erichkeane wrote: > can you do a test on: > > `enum ENeg { a = -1 }` > ? > > That should ALSO have only a singl

[PATCH] D130301: [Clang] Fix how we set the NumPositiveBits on an E numDecl to cover the case of single enumerator with value zero or an empty enum

shafik updated this revision to Diff 446997. shafik marked 4 inline comments as done. shafik added a comment. - Addressed style comments - Changed to use initializer_list version of std::max - Added test to cover enum with -1 as sole enumerator value CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

mib added a comment. In D129377#3673204 , @mstorsjo wrote: > This broke building of Clang, when it's set up by symlinking > `llvm-project/clang` into `llvm-project/llvm/tools`. In that case, cmake > configure errors out like this: > > -- Configuring d

[PATCH] D130145: [AArch64] Simplify BTI/PAC-RET module flags

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4415-4430 -// Upgrade branch protection and return address signing module flags. The -// module flag behavior for these fields were Error and now they are Min.

[clang] d959324 - Revert "[lldb/Fuzzer] Add fuzzer for expression evaluator"

Author: Med Ismail Bennani Date: 2022-07-22T15:24:40-07:00 New Revision: d959324e1efec12c3924c17b7d90db0b37eb84c3 URL: https://github.com/llvm/llvm-project/commit/d959324e1efec12c3924c17b7d90db0b37eb84c3 DIFF: https://github.com/llvm/llvm-project/commit/d959324e1efec12c3924c17b7d90db0b37eb84c3.

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

mstorsjo added a comment. This broke building of Clang, when it's set up by symlinking `llvm-project/clang` into `llvm-project/llvm/tools`. In that case, cmake configure errors out like this: -- Configuring done CMake Error in tools/clang/tools/clang-fuzzer/handle-cxx/CMakeLists.txt: T

[PATCH] D116070: [X86] Enable ibt-seal optimization when LTO is used in Kernel

MaskRay added a comment. Herald added subscribers: jsji, StephenFan. Herald added a project: All. The module flags metadata usage "Override" was wrong. I fixed it by using "Min". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116070/new/ https://rev

[PATCH] D130398: [clang][dataflow] Add Environment::dump()

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/DebugSupport.cpp:117-120 +for (const std::string &S : ConstraintsStrings) { + Result += S; + Result += '\n';

[clang] 8f0c901 - [Driver] Report -Wunused-command-line-argument for unimplemented -mtune=

Author: Fangrui Song Date: 2022-07-22T15:07:28-07:00 New Revision: 8f0c901c1a172313a32bc06a1fcface76cd1220f URL: https://github.com/llvm/llvm-project/commit/8f0c901c1a172313a32bc06a1fcface76cd1220f DIFF: https://github.com/llvm/llvm-project/commit/8f0c901c1a172313a32bc06a1fcface76cd1220f.diff

[PATCH] D130398: [clang][dataflow] Add Environment::dump()

gribozavr updated this revision to Diff 446992. gribozavr added a comment. Reverted more changes broken out to separate revisions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130398/new/ https://reviews.llvm.org/D130398 Files: clang/include/cla

[clang] 1f02ba4 - [Driver][SystemZ] Simplify -mtune

Author: Fangrui Song Date: 2022-07-22T14:54:27-07:00 New Revision: 1f02ba4843a519606a3bdfd7e7a289f3d8c1c14b URL: https://github.com/llvm/llvm-project/commit/1f02ba4843a519606a3bdfd7e7a289f3d8c1c14b DIFF: https://github.com/llvm/llvm-project/commit/1f02ba4843a519606a3bdfd7e7a289f3d8c1c14b.diff

[PATCH] D130399: [clang][dataflow] Expose stringification functions for SAT solver enums

gribozavr updated this revision to Diff 446991. gribozavr added a comment. Fix the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130399/new/ https://reviews.llvm.org/D130399 Files: clang/include/clang/Analysis/FlowSensitive/DebugSupport.h

[clang] a4df2da - [Driver][RISCV] Simplify -mtune

Author: Fangrui Song Date: 2022-07-22T14:51:07-07:00 New Revision: a4df2da173ba3907d652d24c9b4d8bb7d2ff447c URL: https://github.com/llvm/llvm-project/commit/a4df2da173ba3907d652d24c9b4d8bb7d2ff447c DIFF: https://github.com/llvm/llvm-project/commit/a4df2da173ba3907d652d24c9b4d8bb7d2ff447c.diff

[PATCH] D130400: [clang][dataflow] ArrayRef'ize debugString()

gribozavr created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. gribozavr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monor

[PATCH] D130398: [clang][dataflow] Add Environment::dump()

gribozavr updated this revision to Diff 446988. gribozavr added a comment. Moved some changes to a different revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130398/new/ https://reviews.llvm.org/D130398 Files: clang/include/clang/Analysis/

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

tejohnson added inline comments. Comment at: clang/test/CodeGen/memprof.cpp:15 +// # Collect memory profile: +// $ clang++ -fuse-ld=lld -Wl,-no-pie -Wl,--no-rosegment -gmlt \ +// -fdebug-info-for-profiling -mno-omit-leaf-frame-pointer \ snehasish wrote: > Ju

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

tejohnson updated this revision to Diff 446986. tejohnson marked 3 inline comments as done. tejohnson added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128142/new/ https://reviews.llvm.org/D128142 Files: clang/lib/F

[PATCH] D130399: [clang][dataflow] Expose stringification functions for SAT solver enums

gribozavr created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. gribozavr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monor

[clang] 12fbd2d - [Driver][test] Clean up and improve some -mtune tests

Author: Fangrui Song Date: 2022-07-22T14:37:58-07:00 New Revision: 12fbd2d377e396ad61bce56d71c98a1eb1bebfa9 URL: https://github.com/llvm/llvm-project/commit/12fbd2d377e396ad61bce56d71c98a1eb1bebfa9 DIFF: https://github.com/llvm/llvm-project/commit/12fbd2d377e396ad61bce56d71c98a1eb1bebfa9.diff

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

xazax.hun added a comment. In D130306#3671852 , @samestep wrote: > In D130306#3670259 , @xazax.hun > wrote: > >> > > Yes, we considered a summary-based approach, but we decided not to use it > because (as you m

[PATCH] D130398: [clang][dataflow] Add Environment::dump()

gribozavr created this revision. Herald added subscribers: martong, tschuett, mgrang, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. gribozavr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Start by dumping the flow

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

This revision was automatically updated to reflect the committed changes. Closed by commit rGb797834748f1: [lldb/Fuzzer] Add fuzzer for expression evaluator (authored by cassanova). Changed prior to commit: https://reviews.llvm.org/D129377?vs=444761&id=446982#toc Repository: rG LLVM Github M

[clang] b797834 - [lldb/Fuzzer] Add fuzzer for expression evaluator

Author: Chelsea Cassanova Date: 2022-07-22T17:32:00-04:00 New Revision: b797834748f1954950880bf50fb78abedd4494e6 URL: https://github.com/llvm/llvm-project/commit/b797834748f1954950880bf50fb78abedd4494e6 DIFF: https://github.com/llvm/llvm-project/commit/b797834748f1954950880bf50fb78abedd4494e6.d

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny added a comment. Thank you for the review! Before I push the change into main I may add an entry to `clang/docs/ReleaseNotes.rst`, right? And do you agree that the test failures are unrelated to my change? It looks like they are all located in `libomptarget` caused by a linker error

[PATCH] D130273: [clang][Driver] Handle SPARC -mcpu=native etc.

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Arch/Sparc.cpp:121 +StringRef CPUName = A->getValue(); + +if (CPUName == "native") { delete blank line

[clang] 475e526 - [Driver][AArch64] Simplify -mtune

Author: Fangrui Song Date: 2022-07-22T14:19:27-07:00 New Revision: 475e526d85003404ba521e15f8acef1b439fb910 URL: https://github.com/llvm/llvm-project/commit/475e526d85003404ba521e15f8acef1b439fb910 DIFF: https://github.com/llvm/llvm-project/commit/475e526d85003404ba521e15f8acef1b439fb910.diff

[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

sammccall added a comment. In D126731#3672666 , @vsapsai wrote: > In D126731#3670896 , @sammccall > wrote: > >> Hmm, I also don't know. >> The idea here is that we specifically depend only on the TokenKind enum f

[PATCH] D130377: Move "clang/Basic/TokenKinds.h" into a separate top-level module.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130377/new/ https://reviews.llvm.org/D130377 ___

[PATCH] D130387: [CUDA/SPIR-V] Force passing aggregate type byval

tra added a comment. It's OK. If something comes up you can address it in a follow-up patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130387/new/ https://reviews.llvm.org/D130387 ___ cfe-commits mai

[PATCH] D130387: [CUDA/SPIR-V] Force passing aggregate type byval

shangwuyao added a comment. In D130387#3672969 , @tra wrote: > In D130387#3672961 , @shangwuyao > wrote: > >> Accidentally submitted early... > > The landed revision seems to have my comments addressed. Was there

[PATCH] D130387: [CUDA/SPIR-V] Force passing aggregate type byval

tra added a comment. In D130387#3672961 , @shangwuyao wrote: > Accidentally submitted early... The landed revision seems to have my comments addressed. Was there something missing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D130387: [CUDA/SPIR-V] Force passing aggregate type byval

shangwuyao added a comment. Accidentally submitted early... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130387/new/ https://reviews.llvm.org/D130387 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] 6a1ccf6 - Revert "[NFC] Add some additional features to MultiLevelTemplateArgumentList"

Author: Nuno Lopes Date: 2022-07-22T21:33:22+01:00 New Revision: 6a1ccf61cdf80c793f9c699ada33af5d85263b30 URL: https://github.com/llvm/llvm-project/commit/6a1ccf61cdf80c793f9c699ada33af5d85263b30 DIFF: https://github.com/llvm/llvm-project/commit/6a1ccf61cdf80c793f9c699ada33af5d85263b30.diff LO

[PATCH] D130387: [CUDA/SPIR-V] Force passing aggregate type byval

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG31d8dbd1e5b4: [CUDA/SPIR-V] Force passing aggregate type byval (authored by shangwuyao). Changed prior to commit: https://reviews.llvm.org/D130387

[clang] 31d8dbd - [CUDA/SPIR-V] Force passing aggregate type byval

Author: Shangwu Yao Date: 2022-07-22T20:30:15Z New Revision: 31d8dbd1e5b4ee0fd04bfeb3a64d8f9f33260905 URL: https://github.com/llvm/llvm-project/commit/31d8dbd1e5b4ee0fd04bfeb3a64d8f9f33260905 DIFF: https://github.com/llvm/llvm-project/commit/31d8dbd1e5b4ee0fd04bfeb3a64d8f9f33260905.diff LOG: [

[PATCH] D130362: Fix one stray `{LLVM -> CLANG}_TOOLS_INSTALL_DIR`

mstorsjo added a comment. In D130362#3672886 , @mstorsjo wrote: > I don't find any existing instances of `CLANG_TOOLS_INSTALL_DIR` anywhere in > the current monorepo - that doesn't seem right? (I looked in a slightly outdated working dir that I hadn't u

[PATCH] D130387: [CUDA/SPIR-V] Force passing aggregate type byval

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM with a couple of nits. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10450 + +if (isAggregateTypeForABI(Ty)) { + return getNaturalAlignIndirect(Ty, /* byval */ true);

[PATCH] D130362: Fix one stray `{LLVM -> CLANG}_TOOLS_INSTALL_DIR`

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130362/new/ https://reviews.llvm.org/D130362 ___

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

samestep updated this revision to Diff 446958. samestep added a comment. Appease -Wmissing-field-initializers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130306/new/ https://reviews.llvm.org/D130306 Files: clang/include/clang/Analysis/FlowSens

[PATCH] D130362: Fix one stray `{LLVM -> CLANG}_TOOLS_INSTALL_DIR`

mstorsjo added a comment. I don't find any existing instances of `CLANG_TOOLS_INSTALL_DIR` anywhere in the current monorepo - that doesn't seem right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130362/new/ https://reviews.llvm.org/D130362

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

samestep added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.h:64 TypeErasedDataflowAnalysis(bool ApplyBuiltinTransfer) : Options({ApplyBuiltinTransfer}) {} li.zhe.hua wrote: > Nit: `-Wmissing-fiel

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks

barannikov88 updated this revision to Diff 446953. barannikov88 added a comment. Reword commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130394/new/ https://reviews.llvm.org/D130394 Files: clang/lib/CodeGen/ABIInfo.h clang/lib/Cod

[clang] 0b36a62 - [NFC] Add some additional features to MultiLevelTemplateArgumentList

Author: Erich Keane Date: 2022-07-22T13:05:42-07:00 New Revision: 0b36a62d5f3505e21692ae0abf25ef00836329e3 URL: https://github.com/llvm/llvm-project/commit/0b36a62d5f3505e21692ae0abf25ef00836329e3 DIFF: https://github.com/llvm/llvm-project/commit/0b36a62d5f3505e21692ae0abf25ef00836329e3.diff L

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks

barannikov88 created this revision. Herald added a subscriber: dschuff. Herald added a project: All. barannikov88 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Swift calling conventions stands out in the way that they are lowered

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

li.zhe.hua added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.h:64 TypeErasedDataflowAnalysis(bool ApplyBuiltinTransfer) : Options({ApplyBuiltinTransfer}) {} Nit: `-Wmissing-field-initializers` is

[clang] 70c62f4 - [NFC] give getParentFunctionOrMethod a 'Lexical' parameter

Author: Erich Keane Date: 2022-07-22T12:52:26-07:00 New Revision: 70c62f4cadbec132c4ab5f939648d10ca6338b15 URL: https://github.com/llvm/llvm-project/commit/70c62f4cadbec132c4ab5f939648d10ca6338b15 DIFF: https://github.com/llvm/llvm-project/commit/70c62f4cadbec132c4ab5f939648d10ca6338b15.diff L

[clang] 3ff86f9 - [NFC] Start saving InstantiatedFromDecl in non-template functions

Author: Erich Keane Date: 2022-07-22T12:37:14-07:00 New Revision: 3ff86f961094306d1a3f219a44614e9cfd1dbd6b URL: https://github.com/llvm/llvm-project/commit/3ff86f961094306d1a3f219a44614e9cfd1dbd6b DIFF: https://github.com/llvm/llvm-project/commit/3ff86f961094306d1a3f219a44614e9cfd1dbd6b.diff L

[PATCH] D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler

lamb-j updated this revision to Diff 446946. lamb-j added a comment. Fixing header typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129873/new/ https://reviews.llvm.org/D129873 Files: clang/include/clang/Driver/OffloadBundler.h clang/lib/Dri

[PATCH] D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler

lamb-j updated this revision to Diff 446945. lamb-j added a comment. Switching pointers to references, adding namespace comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129873/new/ https://reviews.llvm.org/D129873 Files: clang/include/clang

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

This revision was automatically updated to reflect the committed changes. Closed by commit rG7068aa98412a: Strengthen -Wint-conversion to default to an error (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129881/new/ http

[clang-tools-extra] 7068aa9 - Strengthen -Wint-conversion to default to an error

Author: Aaron Ballman Date: 2022-07-22T15:24:54-04:00 New Revision: 7068aa98412ade19a34b7ed126f4669f581b2311 URL: https://github.com/llvm/llvm-project/commit/7068aa98412ade19a34b7ed126f4669f581b2311 DIFF: https://github.com/llvm/llvm-project/commit/7068aa98412ade19a34b7ed126f4669f581b2311.diff

[PATCH] D129891: [test-suite] Update the test suite for changes to -Wint-conversion

This revision was automatically updated to reflect the committed changes. Closed by commit rT1c09bf48b36b: Update the test suite for changes to -Wint-conversion (authored by aaron.ballman). Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129891/new/ https://rev

[PATCH] D130387: [CUDA/SPIR-V] Force passing aggregate type byval

shangwuyao created this revision. shangwuyao added reviewers: jlebar, mkuper, tra, yaxunl. Herald added subscribers: mattd, ThomasRaoux. Herald added a project: All. shangwuyao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch forc

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

efriedma accepted this revision as: efriedma. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129881/new/ https://reviews.llvm.org/D129881 ___ cfe-commits mailing l

[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

vsapsai added a comment. In D126731#3670896 , @sammccall wrote: > Hmm, I also don't know. > The idea here is that we specifically depend only on the TokenKind enum from > TokenKinds.h (which doesn't need any generated headers), not on other headers > fr

[PATCH] D129891: [test-suite] Update the test suite for changes to -Wint-conversion

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. Thanks! This is similar to D123241 Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/Index/annotate-operator-call-expr.cpp:21 +// CHECK1: Punctuation: "(" [7:6 - 7:7] CallExpr=operator():3:7 +// CHECK1: Punctuation: ")" [7:7 - 7:8]

[PATCH] D129891: [test-suite] Update the test suite for changes to -Wint-conversion

aaron.ballman added a comment. Ping Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129891/new/ https://reviews.llvm.org/D129891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129881/new/ https://reviews.llvm.org/D129881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

abrachet added a comment. In D128465#3672515 , @MaskRay wrote: > I am still seeing the > > zstdConfig.cmake > zstd-config.cmake > > warning. @ckissane @phosek will you fix it? :) I've quieted the warnings in https://github.com/llvm/llvm-project/comm

[PATCH] D130377: Move "clang/Basic/TokenKinds.h" into a separate top-level module.

vsapsai created this revision. vsapsai added reviewers: sammccall, aprantl, jansvoboda11, iana. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes modular build fo

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

MaskRay added a comment. I am still seeing the zstdConfig.cmake zstd-config.cmake warning. @ckissane @phosek will you fix it? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 _

[PATCH] D130299: [clang-format] FIX: Misformatting lambdas with trailing return type 'auto' in braced lists

denis-fatkulin updated this revision to Diff 446916. denis-fatkulin added a comment. > Could you please add full git context? I updated the patch with properly git context. Thanks! > Was the problem due to misannotation of auto? If so, could you add an > annotator test? I'm not sure about the

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

skc7 updated this revision to Diff 446919. skc7 added a comment. Fixes as per review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130224/new/ https://reviews.llvm.org/D130224 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/lib/CodeG

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

samestep updated this revision to Diff 446915. samestep added a comment. Update comment about default parameters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130306/new/ https://reviews.llvm.org/D130306 Files: clang/include/clang/Analysis/FlowS

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

samestep added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:220 + assert(Body != nullptr); + initGlobalVars(*Body, Env); + ymandel wrote: > samestep wrote: > > ymandel wrote: > > > samestep wrote: > > > > ymandel wrote:

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

samestep updated this revision to Diff 446914. samestep added a comment. Don't allow globals Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130306/new/ https://reviews.llvm.org/D130306 Files: clang/include/clang/Analysis/FlowSensitive/DataflowEnv

[PATCH] D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc.

ABataev added a comment. In D129872#3672332 , @jyu2 wrote: > In D129872#3671847 , @ABataev wrote: > >> Why does it get truncated if the type must be integer? Probably, something >> incorrect in sema. > > This is

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

barannikov88 added a comment. In D130322#3672362 , @MaskRay wrote: > Testing and will push in one minute Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130322/new/ https://reviews.llvm.org/D130322

[PATCH] D130301: [Clang] Fix how we set the NumPositiveBits on an E numDecl to cover the case of single enumerator with value zero or an empty enum

erichkeane added a comment. My concern with the 'num positive bits' is really that `enum EEmpty{};`, `enum EZero{ A =0 };`, and `enum ENeg {A = -1};` should all have 1 total bit of 'values'. So as long as THAT is true, I would expect this to be ok. I fear that sticking to the 'non-negative' de

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG37502e042ff0: [clang][CodeGen] Only include ABIInfo.h where required (NFC) (authored by barannikov88, committed by MaskRay). Changed prior to commit

[clang] 37502e0 - [clang][CodeGen] Only include ABIInfo.h where required (NFC)

Author: Sergei Barannikov Date: 2022-07-22T10:45:02-07:00 New Revision: 37502e042ff007972db0a03dd8c5e293c3219de3 URL: https://github.com/llvm/llvm-project/commit/37502e042ff007972db0a03dd8c5e293c3219de3 DIFF: https://github.com/llvm/llvm-project/commit/37502e042ff007972db0a03dd8c5e293c3219de3.d

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

jdoerfert added a comment. Generating freeze seems an option, just not sure we can easily get all locations with this approach. Anyway, some code comments below. Comment at: clang/lib/CodeGen/CGCall.cpp:2061 +} + } + return ArgHasMayBeUndefAttr; Early ex

[PATCH] D130168: [CUDA] remove duplicate condition

VitalyR added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130168/new/ https://reviews.llvm.org/D130168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

MaskRay added a comment. Testing and will push in one minute Comment at: clang/lib/CodeGen/CGObjCRuntime.h:37 namespace CodeGen { + class CGFunctionInfo; class CodeGenFunction; The style is to remove indentation. I'll fix it. Repository: rG LLVM Github

  1   2   3   >