[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:357 +// Turn on _float16 for x86 (feature sse2) +HasFloat16 = SSELevel >= SSE2; MaskRay wrote: > MaskRay wrote: > > `_Float16` > > > > `for x86` convey no extra information sinc

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Basic/Targets/X86.cpp:357 +// Turn on _float16 for x86 (feature sse2) +HasFloat16 = SSELevel >= SSE2; MaskRay wrote: >

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei updated this revision to Diff 441272. pengfei added a comment. Address review comments. Thanks @MaskRay ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.org/D128571 Files: clang/docs/LanguageExtensions.rst

[PATCH] D128556: Make Objective-C++ match Objective-C's behavior on implicit ivar access when `self` is shadowed

mwyman updated this revision to Diff 441270. mwyman added a comment. Change to use a unit test on the semantic lookup code, rather than a codegen test; I realized the name lookup behavior could be more directly checked by inspecting the internal references in the generated AST to ensure the foun

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:357 +// Turn on _float16 for x86 (feature sse2) +HasFloat16 = SSELevel >= SSE2; `_Float16` `for x86` convey no extra information since this file is for x86. Repository: rG L

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Herald added a subscriber: StephenFan. Comment at: clang/test/CodeGen/X86/Float16-arithmetic.c:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown \ +// RUN

[PATCH] D128465: Zstandard as a second compression method to LLVM

MaskRay added inline comments. Comment at: llvm/cmake/modules/FindZSTD.cmake:1 +# Copyright (c) Meta Platforms, Inc. and affiliates. +# How did you derive this? The file seems contributed by you (I don't think facebook/zstd has such a file). It should not have

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

jyu2 updated this revision to Diff 441257. jyu2 added a comment. Thanks Alexey for the review. This is to address Alexey's comments, CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127803/new/ https://reviews.llvm.org/D127803 Files: clang/lib/Sema/SemaOpenMP.cpp clang/lib/Sema/Tree

[clang-tools-extra] 67854f9 - Use value_or instead of getValueOr. NFC

Author: Fangrui Song Date: 2022-06-29T21:55:02-07:00 New Revision: 67854f9ed0cd512f59736730f4c05de25501ae54 URL: https://github.com/llvm/llvm-project/commit/67854f9ed0cd512f59736730f4c05de25501ae54 DIFF: https://github.com/llvm/llvm-project/commit/67854f9ed0cd512f59736730f4c05de25501ae54.diff

[PATCH] D128612: RISC-V big-endian support implementation

MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.h:144 + +StringRef LayoutEndianness = Triple.isLittleEndian() ? "e" : "E"; + gbenyei wrote: > MaskRay wrote: > > You may use a `char` and possibly fold this into the expression below. >

[PATCH] D128612: RISC-V big-endian support implementation

gbenyei marked 3 inline comments as done. gbenyei added a comment. In D128612#3620911 , @MaskRay wrote: > In D128612#3618167 , @gbenyei wrote: > >> In D128612#3617955 , @M

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm updated this revision to Diff 441253. srishti-pm added a comment. Addressed of all Jeff's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124750/new/ https://reviews.llvm.org/D124750 Files: mlir/include/mlir/Transforms/Commuta

[clang] 75113f3 - [Driver] Always use --as-needed with libunwind

Author: Petr Hosek Date: 2022-06-30T03:33:40Z New Revision: 75113f3539df03625b43754f17f9a570cc1c2e3b URL: https://github.com/llvm/llvm-project/commit/75113f3539df03625b43754f17f9a570cc1c2e3b DIFF: https://github.com/llvm/llvm-project/commit/75113f3539df03625b43754f17f9a570cc1c2e3b.diff LOG: [D

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke updated this revision to Diff 441241. Sockke added a comment. Added release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-extra/do

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei updated this revision to Diff 441236. pengfei added a comment. Exclude the ABI change on Darwin platform. Will enable it by a followup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.org/D128571 Files: cla

[PATCH] D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths

MaskRay added a comment. The description seems unclear to me. Is a `riscv64-unknown-linux-gnu` GCC installation selected while the requested target triple is `riscv64-unknown-elf`? This could be an instance of https://discourse.llvm.org/t/rfc-fix-loose-behaviors-of-clang-target/60272 (`[RFC] F

[PATCH] D128726: [RISCV][NFC] Move static global variables into static variable in function.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b8cde9b6338: [RISCV][NFC] Move static global variables into static variable in function. (authored by kito-cheng). Repository: rG LLVM Github Mon

[clang] 1b8cde9 - [RISCV][NFC] Move static global variables into static variable in function.

Author: Kito Cheng Date: 2022-06-30T10:30:01+08:00 New Revision: 1b8cde9b633841c7199b345132423dd3d6bdf3e7 URL: https://github.com/llvm/llvm-project/commit/1b8cde9b633841c7199b345132423dd3d6bdf3e7 DIFF: https://github.com/llvm/llvm-project/commit/1b8cde9b633841c7199b345132423dd3d6bdf3e7.diff LO

[PATCH] D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM, `riscv*-unknown-unknown` match `riscv*-unknown-elf` sound make more sense than `riscv*-unknown-linux-gnu` :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added a comment. I remember now, @njames93 : Without the `-fix-errors`, the test fails as follows: Command Output (stdout): -- Running ['clang-tidy', '/var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/tools/extra/test/clang-tidy/checkers/bugprone/Output/bra

[PATCH] D128489: [ODRHash diagnostics] Move common code for calculating diag locations in `DiagnoseODRMismatch` into a lambda. NFC.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM with comments. Comment at: clang/lib/Serialization/ASTReader.cpp:10020 +auto GetMismatchedDeclLoc = [](const NamedDecl *Container, +

[PATCH] D128488: [ODRHash diagnostics] Split `err_module_odr_violation_mismatch_decl_diff` into per-entity diagnostics. NFC.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM if the changes is specific to C++. Otherwise we need to rename for that enumerate. Comment at: clang/lib/Serialization/ASTReader.cpp:9642 + // note_module_odr_vi

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. In D126907#3619270 , @erichkeane wrote: > All but the 1 comment from @ChuanqiXu fixed, not sure what to do about the > 'info'. LGTM. But the '

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei added a comment. In D128571#3619438 , @pengfei wrote: > In D128571#3619265 , @alexfh wrote: > >> @pengfei could you fix the Darwin tests as well? And a general comment >> regarding the ongoing `_Float16`

[PATCH] D126839: [clang][BPF] Update comment to include TYPE_MATCH

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70557eb3938a: [clang][BPF] Update comment to include TYPE_MATCH (authored by d-e-s-o, committed by yonghong-song). Repository: rG LLVM Github Mono

[clang] 70557eb - [clang][BPF] Update comment to include TYPE_MATCH

Author: Daniel Müller Date: 2022-06-29T18:32:06-07:00 New Revision: 70557eb3938a0bdc784c9ae14e84e9ad9914ebdc URL: https://github.com/llvm/llvm-project/commit/70557eb3938a0bdc784c9ae14e84e9ad9914ebdc DIFF: https://github.com/llvm/llvm-project/commit/70557eb3938a0bdc784c9ae14e84e9ad9914ebdc.diff

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei updated this revision to Diff 441222. pengfei added a comment. Disable `extendhfsf2/truncsfhf2` tests on Darwin to avoid the fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.org/D128571 Files: clang/do

[PATCH] D128612: RISC-V big-endian support implementation

MaskRay added a comment. In D128612#3618167 , @gbenyei wrote: > In D128612#3617955 , @MaskRay wrote: > >> lld/ELF change should be dropped from this change. Don't use >> `config->endianness`. >> I feel sad that f

[PATCH] D127807: [clang-tidy] Properly forward clang-tidy output when running tests

nicovank added a reviewer: LegalizeAdulthood. nicovank added a comment. Ping, adding one more person who has history changing this script. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127807/new/ https://reviews.llvm.org/D127807 _

[PATCH] D128329: [clangd] Also mark output arguments of operator call expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc09e53337413: [clangd] Also mark output arguments of operator call expressions (authored by ckandeler, committed by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[clang-tools-extra] c09e533 - [clangd] Also mark output arguments of operator call expressions

Author: Christian Kandeler Date: 2022-06-29T20:12:37-04:00 New Revision: c09e533374139f17a040040ffdb03ea20fac2736 URL: https://github.com/llvm/llvm-project/commit/c09e533374139f17a040040ffdb03ea20fac2736 DIFF: https://github.com/llvm/llvm-project/commit/c09e533374139f17a040040ffdb03ea20fac2736.

[PATCH] D128774: [libTooling] Add a comment about comment parsing to getAssociatedRange.

jacobsa marked an inline comment as done. jacobsa added a comment. @ymandel: thanks! Are you able to commit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128774/new/ https://reviews.llvm.org/D128774 ___

[PATCH] D128774: [libTooling] Add a comment about comment parsing to getAssociatedRange.

jacobsa updated this revision to Diff 441203. jacobsa added a comment. Address formatting comment from ymandel. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128774/new/ https://reviews.llvm.org/D128774 Files: clang/include/clang/Tooling/Transfo

[PATCH] D128726: [RISCV][NFC] Move static global variables into static variable in function.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. > It's violate coding guideline in LLVM coding standard[1], because the the > initialization order is nondeterministic and that might increase the launch > time of programs. nondeterministi

[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

5chmidti updated this revision to Diff 441197. 5chmidti added a comment. Address inlining isLanguageVersionSupported Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128861/new/ https://reviews.llvm.org/D128861 Files: clang-tools-extra/clang-tidy/c

[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/SymmetricBinaryOperatorCheck.h:29 + + bool isLanguageVersionSupported(const LangOptions &LangOpts) const override; +}; This method is usually inlined. Repository:

[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

5chmidti updated this revision to Diff 441196. 5chmidti added a comment. Fixup for the same reason Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128861/new/ https://reviews.llvm.org/D128861 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/C

[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

5chmidti updated this revision to Diff 441194. 5chmidti added a comment. Fixup addressing comments, missed changing the links for docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128861/new/ https://reviews.llvm.org/D128861 Files: clang-tools-

[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

5chmidti updated this revision to Diff 441193. 5chmidti added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128861/new/ https://reviews.llvm.org/D128861 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLis

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 441192. ishaangandhi added a comment. Remove `-fix-errors` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/docs/

[PATCH] D128754: Refactor LLVM compression namespaces

MaskRay added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:183-191 +* Refactor compression namespaces across the project, making way for a possible + introduction of alternatives to zlib compression in the llvm toolchain. + Changes are as follows: + * Remove crc32 f

[PATCH] D128772: [Lex] Make sure to notify `MultipleIncludeOpt` for "read tokens" during fast dependency directive lexing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc68b8c84eb17: [Lex] Make sure to notify `MultipleIncludeOpt` for "read tokens" during fast… (authored by akyrtzi). Changed prior to commit: https:

[clang] c68b8c8 - [Lex] Make sure to notify `MultipleIncludeOpt` for "read tokens" during fast dependency directive lexing

Author: Argyrios Kyrtzidis Date: 2022-06-29T15:50:16-07:00 New Revision: c68b8c84eb17e4c125897a8a381aa31eea5e5c58 URL: https://github.com/llvm/llvm-project/commit/c68b8c84eb17e4c125897a8a381aa31eea5e5c58 DIFF: https://github.com/llvm/llvm-project/commit/c68b8c84eb17e4c125897a8a381aa31eea5e5c58.

[PATCH] D128754: Refactor LLVM compression namespaces

leonardchan added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:183-191 +* Refactor compression namespaces across the project, making way for a possible + introduction of alternatives to zlib compression in the llvm toolchain. + Changes are as follows: + * Remove crc

[PATCH] D128772: [Lex] Make sure to notify `MultipleIncludeOpt` for "read tokens" during fast dependency directive lexing

akyrtzi added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:4251 DepDirectives.front().Tokens[NextDepDirectiveTokenIndex++]; + if (NextDepDirectiveTokenIndex > 1 || DDTok.Kind != tok::hash) { +// Read something other than a preprocessor directive hash.

[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

Eugene.Zelenko added a comment. Please note that documentation and test locations were changed recently. Please rebase from `main` and make necessary changes. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/SymmetricBinaryOperatorCheck.h:27 +public: + SymmetricBin

[PATCH] D128645: Update developer policy.

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM! Comment at: llvm/docs/DeveloperPolicy.rst:88 +#. Patches should be unified diffs with "infinite context" (i.e. using something + like `git diff -U99 main`). + ve

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:964 TestAndClearIgnoreImag(); BinOpInfo Ops; rjmccall wrote: > Please make a helper function to emit an operand as a possibly-promoted > complex value. As requested, please i

[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

5chmidti updated this revision to Diff 441186. 5chmidti added a comment. rm wrong op from isComparisonOperator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128861/new/ https://reviews.llvm.org/D128861 Files: clang-tools-extra/clang-tidy/cppcore

[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

5chmidti updated this revision to Diff 441185. 5chmidti added a comment. rm unused function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128861/new/ https://reviews.llvm.org/D128861 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLis

[PATCH] D128772: [Lex] Make sure to notify `MultipleIncludeOpt` for "read tokens" during fast dependency directive lexing

benlangmuir added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:4251 DepDirectives.front().Tokens[NextDepDirectiveTokenIndex++]; + if (NextDepDirectiveTokenIndex > 1 || DDTok.Kind != tok::hash) { +// Read something other than a preprocessor directive hash.

[PATCH] D128807: [clang][transformer] Finish plumbing `Note` all the way to the output.

ymandel added a comment. Overall, looks good. But my main question is whether this functionality should be supported in the Edit's Metadata field instead. Eric -- what do you think? You've thought a lot more about metadata recently. Comment at: clang/lib/Tooling/Transformer/R

[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

5chmidti created this revision. 5chmidti added reviewers: aaron.ballman, njames93, alexfh, LegalizeAdulthood, Eugene.Zelenko. Herald added subscribers: carlosgalvezp, shchenz, kbarton, xazax.hun, mgorny, nemanjai. Herald added a project: All. 5chmidti requested review of this revision. Herald add

[PATCH] D128488: [ODRHash diagnostics] Split `err_module_odr_violation_mismatch_decl_diff` into per-entity diagnostics. NFC.

vsapsai updated this revision to Diff 441182. vsapsai added a comment. Rebase after blocking change has landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128488/new/ https://reviews.llvm.org/D128488 Files: clang/include/clang/Basic/Diagnosti

[clang] 3514131 - [ODRHash diagnostics] Fix typos. NFC.

Author: Volodymyr Sapsai Date: 2022-06-29T14:59:37-07:00 New Revision: 3514131219ffdc94c0c61c5b585b53e97501fbea URL: https://github.com/llvm/llvm-project/commit/3514131219ffdc94c0c61c5b585b53e97501fbea DIFF: https://github.com/llvm/llvm-project/commit/3514131219ffdc94c0c61c5b585b53e97501fbea.di

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

t-rasmud updated this revision to Diff 441179. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128103/new/ https://reviews.llvm.org/D128103 Files: clang/docs/LibASTMatchersReference.html clang/docs/ReleaseNotes.rs

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

rui.zhang added a comment. > Well, if you can find a solution to the `void*` <-> `T**` problem, that might > make it tractable. Or you can introduce a flag to control whether we do this > — I guess on some level `-fstrict-aliasing` ought to be the full language > model, so this would mean intr

[clang] ff093c0 - Revert "[Driver] Always use --as-needed with libunwind"

Author: Petr Hosek Date: 2022-06-29T21:41:47Z New Revision: ff093c0a5d292b3076d712b277e6996158b1218e URL: https://github.com/llvm/llvm-project/commit/ff093c0a5d292b3076d712b277e6996158b1218e DIFF: https://github.com/llvm/llvm-project/commit/ff093c0a5d292b3076d712b277e6996158b1218e.diff LOG: Re

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

bmahjour accepted this revision. bmahjour added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128653/new/ https://reviews.llvm.org/D128653 __

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

masoud.ataei updated this revision to Diff 441170. masoud.ataei added a comment. Update the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128653/new/ https://reviews.llvm.org/D128653 Files: clang/test/CodeGen/lower-mass-end-to-end.c llvm/

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam updated this revision to Diff 441169. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/Targets/X86.cpp

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. Fixed LIT tests. Fixed EmitPromoted for the Complex emitter (not 100% sure about it?). Added compound operator scalar emulation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 ___

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam updated this revision to Diff 441167. zahiraam marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Target

[PATCH] D128855: [HLSL] Change WaveActiveCountBits to wrapper of __builtin_hlsl_wave_active_count_bits

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128855/new/ https://reviews.llvm.org/D128855 ___

[PATCH] D128855: [HLSL] Change WaveActiveCountBits to wrapper of __builtin_hlsl_wave_active_count_bits

python3kgae created this revision. python3kgae added reviewers: Anastasia, svenvh, jdoerfert, azabaznov, beanz, tra, yaxunl, pow2clk. Herald added subscribers: luke957, s.egerton, simoncook, mgorny. Herald added a reviewer: aaron.ballman. Herald added a project: All. python3kgae requested review o

[PATCH] D128805: [pseudo] Fix bugs/inconsistencies in forest dump.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGbc5e7ced1c7e: [pseudo] Fix bugs/inconsistencies in forest dump. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D128805?vs=440939&i

[clang-tools-extra] bc5e7ce - [pseudo] Fix bugs/inconsistencies in forest dump.

Author: Sam McCall Date: 2022-06-29T22:56:26+02:00 New Revision: bc5e7ced1c7e6155e9d527f88a657793ffad4761 URL: https://github.com/llvm/llvm-project/commit/bc5e7ced1c7e6155e9d527f88a657793ffad4761 DIFF: https://github.com/llvm/llvm-project/commit/bc5e7ced1c7e6155e9d527f88a657793ffad4761.diff LO

[PATCH] D128853: [Interpreter] Pass target features to JIT

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Thanks for the clarification! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128853/new/ https://reviews.llvm.org/D128853

[PATCH] D128805: [pseudo] Fix bugs/inconsistencies in forest dump.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/unittests/ForestTest.cpp:138 + + const auto *B = &Arena.createSequence(symbol("B"), ruleFor("B"), {Star}); + const auto *A1 = &Arena.createSequence(symbol("A"), rul

[PATCH] D128589: [clang-repl] Support destructors of global objects.

Hahnfeld added inline comments. Comment at: clang/test/Interpreter/execute.cpp:22-23 +struct D { float f = 1.0; D *m = nullptr; D(){} ~D() { printf("D[f=%f, m=0x%llx]\n", f, reinterpret_cast(m)); }} d; +// CHECK: D[f=1.00, m=0x0] + I think it would be bett

[PATCH] D128853: [Interpreter] Pass target features to JIT

Hahnfeld added a comment. In D128853#3620342 , @v.g.vassilev wrote: > Looks good to me but can we add a test? Do we have builders with that target? In principle, this is visible in *every* usage of `clang-repl`, including the existing tests such as `cl

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

tejohnson marked 3 inline comments as done. tejohnson added inline comments. Comment at: llvm/include/llvm/Analysis/MemoryProfileInfo.h:1 +//===- llvm/Analysis/MemoryProfileInfo.h - memory profile info ---*- C++ -*-==// +// snehasish wrote: > Can you split out t

[PATCH] D128841: [Driver] Always use --as-needed with libunwind

This revision was automatically updated to reflect the committed changes. Closed by commit rG2482b3a9679e: [Driver] Always use --as-needed with libunwind (authored by phosek). Herald added a subscriber: mstorsjo. Changed prior to commit: https://reviews.llvm.org/D128841?vs=441093&id=441155#toc

[clang] 2482b3a - [Driver] Always use --as-needed with libunwind

Author: Petr Hosek Date: 2022-06-29T20:41:19Z New Revision: 2482b3a9679ed2d92abbdbae6927e022903acc70 URL: https://github.com/llvm/llvm-project/commit/2482b3a9679ed2d92abbdbae6927e022903acc70 DIFF: https://github.com/llvm/llvm-project/commit/2482b3a9679ed2d92abbdbae6927e022903acc70.diff LOG: [D

[PATCH] D128486: [pseudo] Add error-recovery framework & brace-based recovery

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h:150 +// OldHeads is the parse state at TokenIndex. +// This function consumes consumes zero or more tokens (advancing TokenIndex), +// and places any recovery states created in NewHea

[PATCH] D128486: [pseudo] Add error-recovery framework & brace-based recovery

sammccall updated this revision to Diff 441154. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128486/new/ https://reviews.llvm.org/D128486 Files: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h c

[PATCH] D128853: [Interpreter] Pass target features to JIT

v.g.vassilev added a comment. Looks good to me but can we add a test? Do we have builders with that target? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128853/new/ https://reviews.llvm.org/D128853 ___

[PATCH] D128487: [ODRHash diagnostics] Move repetetive code at lambda calls into lambdas themselves. NFC.

vsapsai added a comment. In D128487#3617821 , @ChuanqiXu wrote: > No immediate or concert ideas here.. It is hard to do refactoring. I sent > https://reviews.llvm.org/D118437 before to do some simplification for the > dispatch of default template argume

[PATCH] D128853: [Interpreter] Pass target features to JIT

Hahnfeld created this revision. Hahnfeld added a reviewer: v.g.vassilev. Herald added subscribers: luke957, luismarques, s.egerton, PkmX, simoncook, arichardson. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-c

[PATCH] D128487: [ODRHash diagnostics] Move repetetive code at lambda calls into lambdas themselves. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG017c068f7899: [ODRHash diagnostics] Move repetetive code at lambda calls into lambdas… (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[clang] 017c068 - [ODRHash diagnostics] Move repetetive code at lambda calls into lambdas themselves. NFC.

Author: Volodymyr Sapsai Date: 2022-06-29T13:24:55-07:00 New Revision: 017c068f7899b895e654c8efc1c4d02d940dbf8a URL: https://github.com/llvm/llvm-project/commit/017c068f7899b895e654c8efc1c4d02d940dbf8a DIFF: https://github.com/llvm/llvm-project/commit/017c068f7899b895e654c8efc1c4d02d940dbf8a.di

[PATCH] D128248: [clang] Avoid an assertion in APValue::hasArrayFiller()

shafik added inline comments. Comment at: clang/include/clang/AST/APValue.h:511-512 bool hasArrayFiller() const { +if (!isArray()) + return false; return getArrayInitializedElts() != getArraySize(); aaron.ballman wrote: > I think this makes the i

[clang] 3d2629d - [Clang] Mark consteval as supported in Clang 15 [NFC]

Author: Corentin Jabot Date: 2022-06-29T22:23:17+02:00 New Revision: 3d2629dd3aab17098813c68b5b76bb864bc5e285 URL: https://github.com/llvm/llvm-project/commit/3d2629dd3aab17098813c68b5b76bb864bc5e285 DIFF: https://github.com/llvm/llvm-project/commit/3d2629dd3aab17098813c68b5b76bb864bc5e285.diff

[PATCH] D128248: [clang] Avoid an assertion in APValue::hasArrayFiller()

shafik added a comment. > and run the test case, the first added line prints `1` and the second one > `0`. `Result` is being mutated when doing the in-place evaluation. I did not catch that. That is unfortunate, I am wondering now if we need a `Result.isArray() && ` before the `EvaluateInPlace`

[PATCH] D128826: Go-to-type on smart_ptr now also shows Foo

tom-anders updated this revision to Diff 441147. tom-anders marked an inline comment as done. tom-anders added a comment. - Remove obsolete comment - Return empty vector when type isNull() - Add comment about why we don't deduplicate results - Use out-parameter in unwrapFindType to make structure

[PATCH] D128826: Go-to-type on smart_ptr now also shows Foo

tom-anders marked 6 inline comments as done. tom-anders added a comment. > In D128826#3619956 , @tom-anders > wrote: > So here's what I thought: Say you have a variable that's a smart pointer and trigger textDocument/typeDefinition on it and th

[PATCH] D128448: [clang][dataflow] Delete SourceLocationsLattice

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a97be27a1de: [clang][dataflow] Delete SourceLocationsLattice (authored by samestep). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] 6a97be2 - [clang][dataflow] Delete SourceLocationsLattice

Author: Sam Estep Date: 2022-06-29T20:14:07Z New Revision: 6a97be27a1de652b8f09f43178d09fc100b05990 URL: https://github.com/llvm/llvm-project/commit/6a97be27a1de652b8f09f43178d09fc100b05990 DIFF: https://github.com/llvm/llvm-project/commit/6a97be27a1de652b8f09f43178d09fc100b05990.diff LOG: [cl

[PATCH] D128448: [clang][dataflow] Delete SourceLocationsLattice

samestep updated this revision to Diff 441144. samestep added a comment. Update from main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128448/new/ https://reviews.llvm.org/D128448 Files: clang/docs/tools/clang-formatted-files.txt clang/includ

[PATCH] D128356: [clang][dataflow] Use NoopLattice in optional model

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf1f978d319b: [clang][dataflow] Use NoopLattice in optional model (authored by samestep). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] cf1f978 - [clang][dataflow] Use NoopLattice in optional model

Author: Sam Estep Date: 2022-06-29T20:10:42Z New Revision: cf1f978d319b91464370d71289e1c7c30baa4243 URL: https://github.com/llvm/llvm-project/commit/cf1f978d319b91464370d71289e1c7c30baa4243 DIFF: https://github.com/llvm/llvm-project/commit/cf1f978d319b91464370d71289e1c7c30baa4243.diff LOG: [cl

[PATCH] D128356: [clang][dataflow] Use NoopLattice in optional model

samestep updated this revision to Diff 441142. samestep added a comment. Herald added a subscriber: carlosgalvezp. Herald added a project: clang-tools-extra. Update UncheckedOptionalAccessCheck.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12835

[clang] dcea10c - Fix miscompile with [[no_unique_address]] struct fields.

Author: Richard Smith Date: 2022-06-29T13:08:40-07:00 New Revision: dcea10c3c6ac963387e53f918c3616b64cb82e8d URL: https://github.com/llvm/llvm-project/commit/dcea10c3c6ac963387e53f918c3616b64cb82e8d DIFF: https://github.com/llvm/llvm-project/commit/dcea10c3c6ac963387e53f918c3616b64cb82e8d.diff

[clang] 5086e05 - Repair tautological condition.

Author: Richard Smith Date: 2022-06-29T13:08:40-07:00 New Revision: 5086e05bb0cdeef68b110336dba2fe229be95110 URL: https://github.com/llvm/llvm-project/commit/5086e05bb0cdeef68b110336dba2fe229be95110 DIFF: https://github.com/llvm/llvm-project/commit/5086e05bb0cdeef68b110336dba2fe229be95110.diff

[PATCH] D128851: [clang][dataflow] Use NoopLattice in optional model

samestep created this revision. Herald added subscribers: martong, tschuett, carlosgalvezp, xazax.hun. Herald added a project: All. samestep requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Reland of D128356

[PATCH] D128848: Fix assertion when analyzing a for-loop with no condition expression

li.zhe.hua abandoned this revision. li.zhe.hua added a comment. In D128848#3620185 , @ymandel wrote: > Looks like you and Stanislav had the same idea? > https://reviews.llvm.org/D128833 Seems like it. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

efriedma added inline comments. Comment at: clang/lib/CodeGen/CodeGenTBAA.cpp:366 + // so may differ from declaration order. In particular, Itanium ABI will + // allocate a primary base first. + llvm::sort(Fields, Maybe add a comment explaining why

[PATCH] D128821: [clangd][ObjC] Fix ObjC method definition completion

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:866 case CodeCompletionResult::RK_Pattern: - return Result.Pattern->getTypedText(); + CCS = Result.Pattern; + break; sammccall wrote: > weirdly, codeCompleti

[PATCH] D128848: Fix assertion when analyzing a for-loop with no condition expression

ymandel added a comment. Looks like you and Stanislav had the same idea? https://reviews.llvm.org/D128833 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128848/new/ https://reviews.llvm.org/D128848 ___ cf

[PATCH] D128850: [HIP] Generate offloading entries for HIP with the new driver.

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, yaxunl, tra. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the small change required to outp

  1   2   3   >