MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/Basic/Targets/X86.cpp:357 + // Turn on _float16 for x86 (feature sse2) + HasFloat16 = SSELevel >= SSE2; ---------------- MaskRay wrote: > `_Float16` > > `for x86` convey no extra information since this file is for x86. Thinking again: The comment just repeats what the code does. So it can be deleted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.org/D128571 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits