[PATCH] D128373: [Sema] Check whether `__auto_type` has been deduced before merging

ahatanak updated this revision to Diff 439636. ahatanak added a comment. Change the type of `memset`'s length parameter to silence warnings on windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128373/new/ https://reviews.llvm.org/D128373 File

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

NoQ added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:34 /// Return whether `Var` was changed in `LoopStmt`. static bool isChanged(const Stmt *LoopStmt, const VarDecl *Var, ASTContext *Context) { --

[PATCH] D128496: [clang-format] Further improve requires clause detection

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscri

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme added a comment. In D126061#3605276 , @miyuki wrote: > Hi Martin, > > I think this patch caused a regression in diagnostics. Clang used to warn > about the following code: [snip] > And now it doesn't. Could you please have a look into it? Than

[PATCH] D128022: [HIP] add -fhip-kernel-arg-name

yaxunl marked 5 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6353 CmdArgs.push_back("-fgpu-allow-device-init"); +if (Args.hasFlag(options::OPT_fhip_kernel_arg_name, + options::OPT_fno_hip_k

[PATCH] D128489: [ODRHash diagnostics] Move common code for calculating diag locations in `DiagnoseODRMismatch` into a lambda. NFC.

vsapsai created this revision. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D128489 Files: clang

[PATCH] D128488: [ODRHash diagnostics] Split `err_module_odr_violation_mismatch_decl_diff` into per-entity diagnostics. NFC.

vsapsai created this revision. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We'll need to add more cases for Objective-C entities and adding everything to `err_mod

[PATCH] D128487: [ODRHash diagnostics] Move repetetive code at lambda calls into lambdas themselves. NFC.

vsapsai created this revision. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It helps to avoid copy-paste mistakes and makes custom code paths more noticeable. Not

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 439596. ishaangandhi added a comment. Alphabetize some more CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/docs

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM > Yes, but not indirectly called from C/C++ but rather from compiler-generated > code right? That's presumably why this patch + D116130 > worked for @zhuhan0

[PATCH] D119296: KCFI sanitizer

pcc added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6694 - if (isExternallyVisible(T->getLinkage())) { + if (isExternallyVisible(T->getLinkage()) || !OnlyExternal) { std::string OutName; It would be better to have a separate functi

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

daiyousei-qz updated this revision to Diff 439592. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127082/new/ https://reviews.llvm.org/D127082 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hover.h clang-tools-extra/clangd/u

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

daiyousei-qz updated this revision to Diff 439591. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127082/new/ https://reviews.llvm.org/D127082 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hover.h clang-tools-extra/clangd/u

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

daiyousei-qz updated this revision to Diff 439590. daiyousei-qz added a comment. use a rebased patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127082/new/ https://reviews.llvm.org/D127082 Files: clang-tools-extra/clangd/Hover.cpp clang-too

[PATCH] D128485: [pseudo] Store shift and goto actions in a compact structure with faster lookup.

sammccall updated this revision to Diff 439589. sammccall added a comment. remove debugging code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128485/new/ https://reviews.llvm.org/D128485 Files: clang-tools-extra/pseudo/include/clang-pseudo/gram

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

daiyousei-qz added a comment. Sorry I'm a little occupied lately. Regarding to the order of `Definition` and `MacroExpansion`, I experimented putting expansion first and noticed the following: 1. Short definition and short expansion: order doesn't matter, it's always clear 2. Short definition a

[PATCH] D128485: [pseudo] Store shift and goto actions in a compact structure with faster lookup.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a subscriber: mgrang. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. The actions table is ver

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

daiyousei-qz updated this revision to Diff 439585. daiyousei-qz added a comment. - add context to patch - use a fixed size buffer for expansion text Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127082/new/ https://reviews.llvm.org/D127082 Files:

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

gribozavr2 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:184-185 +const Decl *Func) { + bool containsFunc = false; + bool overlap = false; + gribozavr2 wrote: > It seems like you missed this

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

ziqingluo-90 updated this revision to Diff 439580. ziqingluo-90 added a comment. Addressing Dmitri's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128401/new/ https://reviews.llvm.org/D128401 Files: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp clang-tools-e

[PATCH] D128406: clang: Tweak behaviour of warn_empty_while_body and warn_empty_if_body

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG37b881aa0bca: clang: Tweak behaviour of warn_empty_while_body and warn_empty_if_body (authored by gribozavr). Repository: rG LLVM Github Monorepo

[clang] 37b881a - clang: Tweak behaviour of warn_empty_while_body and warn_empty_if_body

Author: Dmitri Gribenko Date: 2022-06-24T02:40:25+02:00 New Revision: 37b881aa0bca09b7cc80575cc4b97453aa724186 URL: https://github.com/llvm/llvm-project/commit/37b881aa0bca09b7cc80575cc4b97453aa724186 DIFF: https://github.com/llvm/llvm-project/commit/37b881aa0bca09b7cc80575cc4b97453aa724186.dif

[PATCH] D128482: [clang codegen] Add dso_local/hidden/etc. markings to VTT declarations

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128482/new/ https://reviews.llvm.org/D128482 _

[PATCH] D128482: [clang codegen] Add dso_local/hidden/etc. markings to VTT declarations

efriedma created this revision. efriedma added reviewers: rjmccall, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. efriedma requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We were marking definitions, but not d

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

ziqingluo-90 updated this revision to Diff 439573. ziqingluo-90 added a comment. rebased with the latest `main:HEAD` where clang-tidy file structure has changed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128401/new/ https://reviews.llvm.org/D128401 Files: clang-tidy/bugprone/Infin

[PATCH] D128373: [Sema] Check whether `__auto_type` has been deduced before merging

ahatanak updated this revision to Diff 439574. ahatanak added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128373/new/ https://reviews.llvm.org/D128373 Files: clang/lib/AST/ASTContext.cpp clang/test/Sema/warn-memset-bad-size

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaExprMember.cpp:1873-1877 +if (auto *PrivateCopy = +isOpenMPFDCaptureDecl(Field, Base.get(), IsArrow, OpLoc, &SS, + /*TemplateKWLoc=*/SourceLocation(), Field, +

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

jyu2 updated this revision to Diff 439571. jyu2 edited the summary of this revision. jyu2 added a comment. Thanks Alexey's review. Address Alexey's review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127803/new/ https://reviews.llvm.org/D127803 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim added a comment. In D127911#3605774 , @MaskRay wrote: >> This saves about ~0.275% of the optimised clang binary. > > Worth clarifying a bit which -O level and whether -g is used. `clang-15` binary, no `-g`, `-DLLVM_ENABLE_ASSERTIONS=ON -DCMAKE_BUI

[PATCH] D128406: clang: Tweak behaviour of warn_empty_while_body and warn_empty_if_body

bmoody added a comment. I don't have merge access so please merge on my behalf :) Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128406/new/ https://reviews.llvm.org/D128406 ___ cfe-commits mailin

[PATCH] D128467: [clang][dataflow] Allow MatchSwitch to return a value

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/MatchSwitch.h:49 /// appropriate handler. -template -using MatchSwitch = std::function; +template +using MatchSwitch = std::function; WD

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 updated this revision to Diff 439549. ziqingluo-90 added a comment. adjusted my changes with respect to the recent file structure changes in clang-tidy test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128314/new/ https://reviews.llvm.org/D128314 Files: clang-tools-ext

[PATCH] D128472: [pseudo] Check follow-sets instead of tying reduce actions to lookahead tokens.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a subscriber: mgrang. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Previously, the action t

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 updated this revision to Diff 439545. ziqingluo-90 removed reviewers: rsundahl, yln, kubamracek, krispy1994, jkorous, delcypher, chrisdangelo, thetruestblue, dcoughlin. ziqingluo-90 added a comment. rebased with the latest main's HEAD CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D128467: [clang][dataflow] Allow MatchSwitch to return a value

samestep created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1

[PATCH] D128465: [WIP] Zstandard as a second compression method to LLVM

ckissane created this revision. ckissane added reviewers: phosek, leonardchan. ckissane added a project: LLVM. Herald added subscribers: Enna1, abrachet, wenlei, usaxena95, kadircet, arphaman, hiraditya, arichardson, mgorny, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a r

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3075 +ConvertType(DstType), ScalarConversionOpts()); +} + ...I wrote out what this function should look like, and Phabricator just threw it away. Let me try t

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae created this revision. python3kgae added reviewers: amccarth, craig.topper, hans, rnk, stefan_reinalter, beanz, pow2clk. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, M

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:236 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches ishaangandhi wrote: > Eugene.Zelenko wrote: > > ishaangandhi wrote: > > > Eugene.Zelenk

[PATCH] D128461: [X86] Simplify __cpuid_count

MaskRay added a comment. Ah, OK. I am investigating a miscompile that `: "=a"(__eax), "=r" (__ebx), "=c"(__ecx), "=d"(__edx) \` may assign `"=r"` to use RDX. The output then looks like xchgq %rbx, %rdx cpuid xchgq %rbx, %rdx and rbx is clobbered, since cpuid writes rax/rbx/rcx/rdx. Rep

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:934 + return ComplexExprEmitter(*this).EmitPromoted(E, DstTy); +} + rjmccall wrote: > `EmitPromotedComplexExpr` should look like `EmitPromotedScalarExpr`, i.e. it > should start wit

[PATCH] D128461: [X86] Simplify __cpuid_count

craig.topper added a comment. I think it's still relevant. We had the same issue on Windows as recently as https://github.com/llvm/llvm-project/issues/49477 see also https://github.com/llvm/llvm-project/issues/17204 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D128461: [X86] Simplify __cpuid_count

MaskRay created this revision. Herald added subscribers: jsji, StephenFan, pengfei. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use the x86-32 implementation for x86-64, i.e. replace =r plus xchgq wi

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. In D113107#3606107 , @zahiraam wrote: > For this test case: > _Float16 add_half_cr(_Float16 a, _Float16 b) { > > return a > b ? a : b; > > } > > are we expecting the phi node to be > > cond.true: > > %2 = load float , ptr >

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:236 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches Eugene.Zelenko wrote: > ishaangandhi wrote: > > Eugene.Zelenko wrote: > > > ishaangandhi

[clang] 517bbc6 - DebugInfo: Fully integrate ctor type homing into 'limited' debug info

Author: David Blaikie Date: 2022-06-23T20:15:00Z New Revision: 517bbc64dbe493644eff8d55fd9566435e930520 URL: https://github.com/llvm/llvm-project/commit/517bbc64dbe493644eff8d55fd9566435e930520 DIFF: https://github.com/llvm/llvm-project/commit/517bbc64dbe493644eff8d55fd9566435e930520.diff LOG:

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. For this test case: _Float16 add_half_cr(_Float16 a, _Float16 b) { return a > b ? a : b; } are we expecting the phi node to be cond.true: %2 = load float , ptr ... cond.false: %3 = load float, ptr ... %cond = phi float {{.*}} {{.*}} ? CHANGES SINCE L

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. In D113107#3606094 , @zahiraam wrote: > In D113107#3605797 , @rjmccall > wrote: > >> I think on balance the right thing to do is probably to add an alternative >> to `-fexcess-precision

[clang] 77f72ac - [HLSL] Enable half type for hlsl.

Author: Xiang Li Date: 2022-06-23T12:56:26-07:00 New Revision: 77f72ac15bcac8923c6bd104f303feaa1e964692 URL: https://github.com/llvm/llvm-project/commit/77f72ac15bcac8923c6bd104f303feaa1e964692 DIFF: https://github.com/llvm/llvm-project/commit/77f72ac15bcac8923c6bd104f303feaa1e964692.diff LOG:

[PATCH] D124790: [HLSL] Enable half type for hlsl.

This revision was automatically updated to reflect the committed changes. Closed by commit rG77f72ac15bca: [HLSL] Enable half type for hlsl. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124790/new/ https://reviews.llvm.or

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. In D113107#3605797 , @rjmccall wrote: > I think on balance the right thing to do is probably to add an alternative to > `-fexcess-precision`, like `-fexcess-precision=none`. We can default to > `-fexcess-precision=standard` an

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added a comment. >> I will update the commit messages, but I cannot commit to the github repo. > > Ah, thank you for letting me know. I can land the changes on your behalf. > What name and email address would you like me to use for patch attribution? > (I probably won't land it until t

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 439507. vaibhav.y added a comment. Reword commit messages - Prefix `[tag]` specifying which components are affected - Append link to D109701 in commit message per commit message guidelines Repository: rG LLVM Github M

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman added a comment. In D109701#3606042 , @vaibhav.y wrote: > Thanks for your patience with the review as well! Likewise! > Just noticed that I need to add a link to revision in the commit messages as > well: (https://www.llvm.org/docs/Phabri

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4d3c010f1d01: [CUDA] Do not embed a fatbinary when using the new driver (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 4d3c010 - [CUDA] Do not embed a fatbinary when using the new driver

Author: Joseph Huber Date: 2022-06-23T15:40:43-04:00 New Revision: 4d3c010f1d012ade0ca36fdd7bc8b8baeb8df1f2 URL: https://github.com/llvm/llvm-project/commit/4d3c010f1d012ade0ca36fdd7bc8b8baeb8df1f2 DIFF: https://github.com/llvm/llvm-project/commit/4d3c010f1d012ade0ca36fdd7bc8b8baeb8df1f2.diff

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added inline comments. Comment at: clang/docs/LanguageExtensions.rst:746 * SPIR -* X86 (Only available under feature AVX512-FP16) +* X86 (Enabled with feature SSE2 and up) rjmccall wrote: > Note that I'm not trying to propose this specific name for th

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam updated this revision to Diff 439502. zahiraam marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Target

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added a comment. Thanks for your patience with the review as well! Just noticed that I need to add a link to revision in the commit messages as well: (https://www.llvm.org/docs/Phabricator.html#committing-a-change) I will update the commit messages, but I cannot commit to the github r

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

jamieschmeiser added inline comments. Comment at: clang/test/Driver/check-time-trace-path.cpp:5 +// RUN: | FileCheck %s + +// CHECK: "beginningOfTime": {{[0-9]{16},}} This test is the same as the one in check-time-trace.cpp except for the path feature. A

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 439501. ishaangandhi marked an inline comment as done. ishaangandhi added a comment. Change doc path CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/Bran

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added subscribers: wenlei, usaxena95, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-ext

[PATCH] D128406: clang: Tweak behaviour of warn_empty_while_body and warn_empty_if_body

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Test cases look good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128406/new/ https://reviews.llvm.org/D128406 __

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:236 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches ishaangandhi wrote: > Eugene.Zelenko wrote: > > ishaangandhi wrote: > > > Eugene.Zelenk

[PATCH] D128337: [clang-tidy] Extend spelling for CheckOptions

This revision was automatically updated to reflect the committed changes. Closed by commit rGfbf611ed2a76: [clang-tidy] Extend spelling for CheckOptions (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128337/new/ https://review

[clang-tools-extra] fbf611e - [clang-tidy] Extend spelling for CheckOptions

Author: Nathan James Date: 2022-06-23T19:59:31+01:00 New Revision: fbf611ed2a768999202e2c5e1e1a6c3c6bb94725 URL: https://github.com/llvm/llvm-project/commit/fbf611ed2a768999202e2c5e1e1a6c3c6bb94725 DIFF: https://github.com/llvm/llvm-project/commit/fbf611ed2a768999202e2c5e1e1a6c3c6bb94725.diff

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi marked an inline comment as done. ishaangandhi added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:236 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches Eugene.Zelenko wrote: > ishaangandhi wrote

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 439488. ishaangandhi added a comment. Alphabetize release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/

[clang-tools-extra] 768216c - [pseudo] Handle no-reductions-available on the fastpath. NFC

Author: Sam McCall Date: 2022-06-23T20:34:11+02:00 New Revision: 768216cac0242db609fef55ea98283f57801fd18 URL: https://github.com/llvm/llvm-project/commit/768216cac0242db609fef55ea98283f57801fd18 DIFF: https://github.com/llvm/llvm-project/commit/768216cac0242db609fef55ea98283f57801fd18.diff LO

[PATCH] D128337: [clang-tidy] Extend spelling for CheckOptions

njames93 updated this revision to Diff 439478. njames93 added a comment. Rebase to check CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128337/new/ https://reviews.llvm.org/D128337 Files: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp cla

[PATCH] D127446: [clang-tidy] Add `-verify-config` command line argument

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ca68d5845c0: [clang-tidy] Add `-verify-config` command line argument (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127446/new/ http

[clang-tools-extra] 5ca68d5 - [clang-tidy] Add `-verify-config` command line argument

Author: Nathan James Date: 2022-06-23T19:23:09+01:00 New Revision: 5ca68d5845c04421eef9659119ba2c12d2a56803 URL: https://github.com/llvm/llvm-project/commit/5ca68d5845c04421eef9659119ba2c12d2a56803 DIFF: https://github.com/llvm/llvm-project/commit/5ca68d5845c04421eef9659119ba2c12d2a56803.diff

[PATCH] D128307: [pseudo] Store reduction sequences by pointer in heaps, instead of by value.

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:270 + +Sequences.emplace(F, PushSpec{N, Seq}); return; sammccall wrote: > hokein wrote: > > Just an idea (no action required) > > > > If we want to do further optm

[PATCH] D128373: [Sema] Check whether `__auto_type` has been deduced before merging

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Oh, great catch! Thank you for the fix. The changes here LGTM, but precommit CI failed because of patch application. That issue was resolved on the precommit CI machine, so it mi

[clang-tools-extra] 466eae6 - [pseudo] Store last node popped in the queue, not its parent(s). NFC

Author: Sam McCall Date: 2022-06-23T20:10:20+02:00 New Revision: 466eae6aa3574aea6604d42666f099025718ffa4 URL: https://github.com/llvm/llvm-project/commit/466eae6aa3574aea6604d42666f099025718ffa4 DIFF: https://github.com/llvm/llvm-project/commit/466eae6aa3574aea6604d42666f099025718ffa4.diff LO

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Okay, thanks both for your perspective on this. This LGTM as-is and we can handle validation and integration in subsequent patches. Thank you for this, @vaibhav.y! Repository:

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

jhuber6 added a comment. In D128441#3605809 , @tra wrote: >> The linker wrapper cannot do anything with these embedded PTX files because >> we do not know how to link them, > > Neither, apparently does `nvlink`. It does have `--emip-ptx ` option, > but

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

jspam added a comment. I see :) Yes, looks like Git's rename detection did its job. Thanks for the review. Could you or someone else please merge this for me? Author: Joachim Priesner Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128157/new/ htt

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

njames93 added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:928 +std::tie(Module, Check) = Name.split('-'); +assert(!Module.empty() && !Check.empty()); +return {("https://clang.llvm.org/extra/clang-tidy/checks/"; + Module + "/" + -

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

efriedma accepted this revision. efriedma added a comment. LGTM with one minor comment (feel free to ignore if you disagree) Comment at: llvm/lib/Target/ARM/Thumb1FrameLowering.cpp:958 +static void popRegsFromStack(MachineBasicBlock &MBB, + MachineBa

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. > The linker wrapper cannot do anything with these embedded PTX files because > we do not know how to link them, Neither, apparently does `nvlink`. It does have `--emip-ptx ` option, but only if LT

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae added a comment. Thanks for the review. Updated the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124790/new/ https://reviews.llvm.org/D124790 ___ cfe-commits mailing list cfe-commi

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae updated this revision to Diff 439463. python3kgae marked 3 inline comments as done. python3kgae added a comment. Cleanup comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124790/new/ https://reviews.llvm.org/D124790 Files: clan

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128157/new/ https://reviews.llvm.org/D128157 _

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. I think on balance the right thing to do is probably to add an alternative to `-fexcess-precision`, like `-fexcess-precision=none`. We can default to `-fexcess-precision=standard` and treat `-fexcess-precision=fast` as an alias for `standard` for now. =

[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. Herald added a project: All. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs, stripping the module pre

[PATCH] D116577: [clang-tidy] Added "boost-use-range-based-for-loop" check

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. Herald added a project: All. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs, stripping the module pre

[PATCH] D128022: [HIP] add -fhip-kernel-arg-name

MaskRay accepted this revision. MaskRay added inline comments. Herald added a subscriber: StephenFan. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6353 CmdArgs.push_back("-fgpu-allow-device-init"); +if (Args.hasFlag(options::OPT_fhip_kernel_arg_name, +

[PATCH] D126247: [clang-tidy][doc] Document readability-indentifier-naming resolution order and examples

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs, stripp

[PATCH] D128022: [HIP] add -fhip-kernel-arg-name

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1845-1846 + } + if (getCodeGenOpts().EmitOpenCLArgMetadata || + getCodeGenOpts().HIPSaveKernelArgName) Fn->setMetada

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

LegalizeAdulthood added a comment. In D128157#3605504 , @jspam wrote: > @LegalizeAdulthood Not sure what exactly you mean by "fold your changes into > `checkers/cppcoreguidelines/virtual-class-destructor.cpp`". The only rebase > conflict was in `Virtual

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

MaskRay added a comment. > This saves about ~0.275% of the optimised clang binary. Worth clarifying a bit which -O level and whether -g is used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://reviews.llvm.org/D127911 __

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim added a comment. friendly ping @vitalybuka Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://reviews.llvm.org/D127911 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D128307: [pseudo] Store reduction sequences by pointer in heaps, instead of by value.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG7aff663b2a04: [pseudo] Store reduction sequences by pointer in heaps, instead of by value. (authored by s

[clang-tools-extra] 7aff663 - [pseudo] Store reduction sequences by pointer in heaps, instead of by value.

Author: Sam McCall Date: 2022-06-23T19:41:11+02:00 New Revision: 7aff663b2a04f6bea0732ed3b11e10466affb2ac URL: https://github.com/llvm/llvm-project/commit/7aff663b2a04f6bea0732ed3b11e10466affb2ac DIFF: https://github.com/llvm/llvm-project/commit/7aff663b2a04f6bea0732ed3b11e10466affb2ac.diff LO

[PATCH] D128307: [pseudo] Store reduction sequences by pointer in heaps, instead of by value.

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:208 + // Underlying storage for sequences pointed to by stored SequenceRefs. + std::deque SequenceStorage; + // We don't actually destroy the sequences

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs, stripp

[PATCH] D128372: Clang-Tidy Empty Check

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs, stripp

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs, stripp

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:237 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches + involve unknown expressions. This link is wrong, needs to use the `bugprone/` direc

  1   2   3   >