jamieschmeiser added inline comments.

================
Comment at: clang/test/Driver/check-time-trace-path.cpp:5
+// RUN:   | FileCheck %s
+
+// CHECK:      "beginningOfTime": {{[0-9]{16},}}
----------------
This test is the same as the one in check-time-trace.cpp except for the path 
feature.  A test file can have multiple tests in it.  Rather than repeating all 
of the checks and source, it would be better to just put this test in the 
existing file.  Just add lines 1-4 from this file into that file.  If you need 
to special-case parts of it, you can use --check-prefix


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128048/new/

https://reviews.llvm.org/D128048

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to