MaskRay accepted this revision.
MaskRay added inline comments.
Herald added a subscriber: StephenFan.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6353
CmdArgs.push_back("-fgpu-allow-device-init");
+ if (Args.hasFlag(options::OPT_fhip_kernel_arg_name,
+ options::OPT_fno_hip_kernel_arg_name, false))
----------------
Use `addOptInFlag`
================
Comment at: clang/test/Driver/hip-options.hip:120
+
+// Check -fhip-kernel-arg-name is passed to clang -cc1.
+
----------------
This comment is redundant. There is only one CHECK line and the string is clear
there.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128022/new/
https://reviews.llvm.org/D128022
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
