[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff destination isn't null

pcwang-thead added a comment. In D126461#3597862 , @craig.topper wrote: > In D126461#3596761 , @reames wrote: > >> Despite the comments above, the purpose of this patch remains unclear. >> >> Per the draft spec,

[clang] 957014d - [clang][Analyzer] Add errno state to standard functions modeling.

Author: Balázs Kéri Date: 2022-06-21T08:56:41+02:00 New Revision: 957014da2d2791359181d89a04a0d27da65474d4 URL: https://github.com/llvm/llvm-project/commit/957014da2d2791359181d89a04a0d27da65474d4 DIFF: https://github.com/llvm/llvm-project/commit/957014da2d2791359181d89a04a0d27da65474d4.diff L

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG957014da2d27: [clang][Analyzer] Add errno state to standard functions modeling. (authored by balazske). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

royjacobson added a comment. In D127593#3597374 , @sberg wrote: > You'd only see it when compiling with Clang against MSVC's ``, where > `std::pair` has a deleted copy assignment op (something I approximated with > the `struct S` above). https://godbol

[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff destination isn't null

pcwang-thead added a comment. In D126461#3596769 , @khchen wrote: > Could you please purpose this implement in rvv-intrinsc-doc first? > I think this feature need to have discussion because store to nullptr is UB > but we are making it as defined behavio

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

kito-cheng added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:195 + if (ISAInfo->hasExtension("zawrs")) +Builder.defineMacro("__riscv_zawrs"); } You don't need this line, that would be defined automatically once you've add `zawrs` in `RI

[clang-tools-extra] ed8fcea - Don't use Optional::getValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T23:35:53-07:00 New Revision: ed8fceaa09cd66324c6efc1070f962731a62e2dc URL: https://github.com/llvm/llvm-project/commit/ed8fceaa09cd66324c6efc1070f962731a62e2dc DIFF: https://github.com/llvm/llvm-project/commit/ed8fceaa09cd66324c6efc1070f962731a62e2dc.diff L

[PATCH] D121670: [RISCV] Add zihintntl instructions

sunshaoce updated this revision to Diff 438563. sunshaoce added a comment. Herald added a subscriber: shiva0217. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121670/new/ https://reviews.llvm.org/D121670 Files: clang/test/Preprocessor/ris

[clang] ca4af13 - [clang] Don't use Optional::getValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T22:59:26-07:00 New Revision: ca4af13e480e856f8f889c1e145308fc4eb69816 URL: https://github.com/llvm/llvm-project/commit/ca4af13e480e856f8f889c1e145308fc4eb69816 DIFF: https://github.com/llvm/llvm-project/commit/ca4af13e480e856f8f889c1e145308fc4eb69816.diff L

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

Whitney added inline comments. Comment at: clang/include/clang/Driver/Options.td:2832 +def ftime_trace_path : Joined<["-"], "ftime-trace-path=">, Group, + HelpText<"Path which stores the output files of time profiler">, + Flags<[CC1Option, CoreOption]>, jamiesc

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

tapaswenipathak updated this revision to Diff 438550. tapaswenipathak added a comment. omit an unrelated change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126266/new/ https://reviews.llvm.org/D126266 Files: clang/include/clang/Basic/FileEntr

[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff destination isn't null

craig.topper added a comment. In D126461#3596761 , @reames wrote: > Despite the comments above, the purpose of this patch remains unclear. > > Per the draft spec, the relevant wording is: > "These instructions execute as a regular load except that they wi

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

MaskRay added inline comments. Comment at: llvm/test/MC/RISCV/zawrs-invalid.s:4 +# WRS doesn't take immediates +wrs 1 # CHECK: :[[@LINE]]:5: error: invalid operand for instruction + `[[@LINE]]` is a deprecated FileCheck feature. Use `[[#@LINE]]` Note: you can p

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

tapaswenipathak updated this revision to Diff 438541. tapaswenipathak added a comment. fix for build failure: cmdline: git reset --hard stderr: 'fatal: Unable to create '/var/lib/buildkite-agent/builds/llvm-project-fork/.git/index.lock': File exists. https://buildkite.com/llvm-project/diff

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

MaskRay added a comment. > Context not available. See `-U99` on https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface or use `arc diff` (PHP 8 may need https://discourse.llvm.org/t/arcanist-deprecation-errors-on-php-8/63231) Comment at: llvm/t

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

tapaswenipathak updated this revision to Diff 438535. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126266/new/ https://reviews.llvm.org/D126266 Files: clang/include/clang/Basic/FileEntry.h clang/include/clang/Basic/FileManager.h clang/include

[clang] d66cbc5 - Don't use Optional::hasValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T20:26:05-07:00 New Revision: d66cbc565adbea8b7362349e527ac7aa2c75788f URL: https://github.com/llvm/llvm-project/commit/d66cbc565adbea8b7362349e527ac7aa2c75788f DIFF: https://github.com/llvm/llvm-project/commit/d66cbc565adbea8b7362349e527ac7aa2c75788f.diff L

[clang-tools-extra] 0916d96 - Don't use Optional::hasValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T20:17:57-07:00 New Revision: 0916d96d12fda355933a8f66ed2a1ccc855cab9c URL: https://github.com/llvm/llvm-project/commit/0916d96d12fda355933a8f66ed2a1ccc855cab9c DIFF: https://github.com/llvm/llvm-project/commit/0916d96d12fda355933a8f66ed2a1ccc855cab9c.diff L

[clang-tools-extra] 064a08c - Don't use Optional::hasValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T20:05:16-07:00 New Revision: 064a08cd955019da9130f1109bfa534e79b8ec7c URL: https://github.com/llvm/llvm-project/commit/064a08cd955019da9130f1109bfa534e79b8ec7c DIFF: https://github.com/llvm/llvm-project/commit/064a08cd955019da9130f1109bfa534e79b8ec7c.diff L

[clang] 064a08c - Don't use Optional::hasValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T20:05:16-07:00 New Revision: 064a08cd955019da9130f1109bfa534e79b8ec7c URL: https://github.com/llvm/llvm-project/commit/064a08cd955019da9130f1109bfa534e79b8ec7c DIFF: https://github.com/llvm/llvm-project/commit/064a08cd955019da9130f1109bfa534e79b8ec7c.diff L

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

craig.topper added inline comments. Comment at: clang/test/Driver/riscv-arch.c:585 +// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-ZAWRS-GOOD %s +// RV32-ZHINX-GOOD: "-target-feature" "+zawrs" + This doesn't match the RUN line Commen

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

eopXD added a comment. Looks like the patch application failed, might need to rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128235/new/ https://reviews.llvm.org/D128235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

palmer-dabbelt updated this revision to Diff 438515. palmer-dabbelt added a comment. Herald added a subscriber: jdoerfert. - Fix a whitespace issue - Fix the name of RISCVInstrInfoZawrs.td - Call the #define __riscv_zawrs instead of __riscv_wrs, to match the others - Add tests in clang/test/Driver

[PATCH] D128134: [Driver] Pass -X to ld for riscv64-fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7c5957aedb75: [Driver] Pass -X to ld for riscv64-fuchsia (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[clang] 7c5957a - [Driver] Pass -X to ld for riscv64-fuchsia

Author: Brad Smith Date: 2022-06-20T21:05:01-04:00 New Revision: 7c5957aedb75f381cd9996f9eba96f3add16a721 URL: https://github.com/llvm/llvm-project/commit/7c5957aedb75f381cd9996f9eba96f3add16a721 DIFF: https://github.com/llvm/llvm-project/commit/7c5957aedb75f381cd9996f9eba96f3add16a721.diff LO

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

eopXD added a comment. - I think we will need some test coverage under `llvm/test/CodeGen/RISCV/attributes.ll` and `llvm/test/MC/RISCV/attribute-arch.s` if the extension is existing in the arch string. - Since macro is added, we need some test coverage under `clang/test/Preprocessor/riscv-targ

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

eopXD added a comment. In D128235#3597645 , @palmer-dabbelt wrote: > I've never touched LLVM before, so I have no idea if I'm even in the right > place here... Yes, you are in the right place. All LLVM patches go through the Phabricator. A patch goes i

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

eopXD added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZawrs.td:1 +//===-- RISCVInstrInfoM.td - RISC-V 'M' instructions ---*- tablegen -*-===// +// This doesn't match the filename. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

palmer-dabbelt added a comment. I've never touched LLVM before, so I have no idea if I'm even in the right place here... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128235/new/ https://reviews.llvm.org/D128235 __

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

palmer-dabbelt created this revision. palmer-dabbelt added reviewers: reames, asb. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126364/new/ https://reviews.llvm.org/D126364 ___

[clang] 5ba0a95 - [Clang][VE] Add missing intrinsics

Author: Kazushi (Jam) Marukawa Date: 2022-06-21T07:30:36+09:00 New Revision: 5ba0a9571b3ee3bc76f65e16549012a440d5a0fb URL: https://github.com/llvm/llvm-project/commit/5ba0a9571b3ee3bc76f65e16549012a440d5a0fb DIFF: https://github.com/llvm/llvm-project/commit/5ba0a9571b3ee3bc76f65e16549012a440d5a

[PATCH] D128120: [Clang][VE] Add missing intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ba0a9571b3e: [Clang][VE] Add missing intrinsics (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D127313: [libc++] Implement P0618R0 (Deprecating )

philnik updated this revision to Diff 438486. philnik added a comment. - Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127313/new/ https://reviews.llvm.org/D127313 Files: libcxx/docs/ReleaseNotes.rst libcxx/docs/Status/Cxx17Paper

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

sberg added a comment. In D127593#3596883 , @royjacobson wrote: > In D127593#3596601 , @sberg wrote: > >> Is it intended that a deleted copy assignment op as in `struct S { void >> operator =(S &) = delete; };`

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

steplong added a comment. It looks like misc-new-delete-overloads.cpp is failing on line 20: 1 // RUN: %check_clang_tidy %s misc-new-delete-overloads %t 2 3 typedef decltype(sizeof(int)) size_t; 4 5 struct S { 6 // CHECK-MESSAGES: :[[@LINE+1]]:9: warning: declaration of 'opera

[PATCH] D128223: [clang] Linkage of static locals may require inspecting visibility

cebowleratibm created this revision. cebowleratibm added a reviewer: daltenty. Herald added a project: All. cebowleratibm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. An assertion failure was encountered after https://reviews.llvm.org/D1

[PATCH] D128207: [clang-doc][NFC] Fix reference invalidation assertion failure.

dexonsmith added a comment. Is there a test that can be added so this doesn’t regress? Also, I wonder if `assign` could/should add logic to be resilient to this. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128207/new/ https://reviews.llvm.org/D12

[clang] ad7ce1e - Don't use Optional::hasValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T11:49:10-07:00 New Revision: ad7ce1e7696148d093b96a6262ebc8fd5e216187 URL: https://github.com/llvm/llvm-project/commit/ad7ce1e7696148d093b96a6262ebc8fd5e216187 DIFF: https://github.com/llvm/llvm-project/commit/ad7ce1e7696148d093b96a6262ebc8fd5e216187.diff L

[clang-tools-extra] 5413bf1 - Don't use Optional::hasValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T11:33:56-07:00 New Revision: 5413bf1bac2abb9e06901686cdc959e92940143a URL: https://github.com/llvm/llvm-project/commit/5413bf1bac2abb9e06901686cdc959e92940143a DIFF: https://github.com/llvm/llvm-project/commit/5413bf1bac2abb9e06901686cdc959e92940143a.diff L

[clang] 5413bf1 - Don't use Optional::hasValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T11:33:56-07:00 New Revision: 5413bf1bac2abb9e06901686cdc959e92940143a URL: https://github.com/llvm/llvm-project/commit/5413bf1bac2abb9e06901686cdc959e92940143a DIFF: https://github.com/llvm/llvm-project/commit/5413bf1bac2abb9e06901686cdc959e92940143a.diff L

[clang] 452db15 - [clang] Don't use Optional::hasValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T10:51:34-07:00 New Revision: 452db157c963b2897a0882e3bb05ef845b9e4015 URL: https://github.com/llvm/llvm-project/commit/452db157c963b2897a0882e3bb05ef845b9e4015 DIFF: https://github.com/llvm/llvm-project/commit/452db157c963b2897a0882e3bb05ef845b9e4015.diff L

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

steplong updated this revision to Diff 438437. steplong added a comment. - Remove DEFAULT from test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127641/new/ https://reviews.llvm.org/D127641 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/t

[PATCH] D128183: [clang][dataflow] Extend flow condition in the body of a do/while loop

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sgatev marked an inline comment as done. Closed by commit rGe363c5963dc3: [clang][dataflow] Extend flow condition in the body of a do/while loop (authored by sgatev).

[clang] e363c59 - [clang][dataflow] Extend flow condition in the body of a do/while loop

Author: Stanislav Gatev Date: 2022-06-20T17:31:00Z New Revision: e363c5963dc3ad5d9492d3f37055ad56a84411a5 URL: https://github.com/llvm/llvm-project/commit/e363c5963dc3ad5d9492d3f37055ad56a84411a5 DIFF: https://github.com/llvm/llvm-project/commit/e363c5963dc3ad5d9492d3f37055ad56a84411a5.diff LO

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed marked 3 inline comments as done and an inline comment as not done. omarahmed added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3396 spaceRequiredBeforeParens(Right); +if (Style.SpaceBeforeParens == FormatStyle::SBPO_Custom && +

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed added inline comments. Comment at: clang/docs/tools/dump_format_style.py:317 pass + elif state == State.InNestedEnum: +if line.startswith('///'): MyDeveloperDay wrote: > Can you show us a screenshot of how these changes will look

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed updated this revision to Diff 438433. omarahmed added a comment. - Add version for nestedEnums and nestedFields - Make tests valid Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127270/new/ https://reviews.llvm.org/D127270 Files: clang/

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm (If you like, consider dropping the "-DEFAULT" part from the new filecheck prefixes. I don't think they really add much value.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D128183: [clang][dataflow] Extend flow condition in the body of a do/while loop

sgatev marked an inline comment as done. sgatev added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:3700 +EXPECT_TRUE(AfterLoopEnv.flowConditionImplies( +AfterLoopEnv.makeNot(AfterLoopFooVal))); + }); ---

[PATCH] D128183: [clang][dataflow] Extend flow condition in the body of a do/while loop

sgatev updated this revision to Diff 438427. sgatev added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128183/new/ https://reviews.llvm.org/D128183 Files: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp c

[PATCH] D128190: [WinEH] Apply funclet operand bundles to nounwind intrinsics that lower to function calls

sgraenitz added a comment. Running `check-llvm` and `check-clang` locally found no more failing tests. The issue is not limited to pre-ISel intrinsics (anymore) and I have to re-phrase a few comments. Apart from that, is there any more feedback? Thanks Repository: rG LLVM Github Monorepo CH

[PATCH] D128190: [WinEH] Apply funclet operand bundles to nounwind intrinsics that lower to function calls

sgraenitz updated this revision to Diff 438425. sgraenitz added a comment. Add missing `objc_sync_exit` to fix failing test Transforms/PreISelIntrinsicLowering/objc-arc.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128190/new/ https://reviews.l

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

royjacobson added a comment. In D127593#3596601 , @sberg wrote: > Is it intended that a deleted copy assignment op as in `struct S { void > operator =(S &) = delete; };` (though, somewhat oddly, not in `struct S { > void operator =(S) = delete; };`) is

[PATCH] D127890: [Docs] Update clang & llvm release notes for HLSL

beanz updated this revision to Diff 438419. beanz added a comment. Updates based on feeback from @MaskRay. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127890/new/ https://reviews.llvm.org/D127890 Files: clang/docs/ReleaseNotes.rst

[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff destination isn't null

khchen added a comment. Could you please purpose this implement in rvv-intrinsc-doc first? I think this feature need to have discussion because store to nullptr is UB but we are making it as defined behavior only for these intrinsics. Personally I like they have consistent behavior and in documen

[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff destination isn't null

reames requested changes to this revision. reames added a comment. This revision now requires changes to proceed. Despite the comments above, the purpose of this patch remains unclear. Per the draft spec, the relevant wording is: "These instructions execute as a regular load except that they will

[PATCH] D127313: [libc++] Implement P0618R0 (Deprecating )

philnik updated this revision to Diff 438407. philnik added a comment. - Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127313/new/ https://reviews.llvm.org/D127313 Files: libcxx/docs/ReleaseNotes.rst libcxx/docs/Status/Cxx17Paper

[PATCH] D128183: [clang][dataflow] Extend flow condition in the body of a do/while loop

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:3700 +EXPECT_TRUE(AfterLoopEnv.flowConditionImplies( +AfterLoopEnv.makeNot

[PATCH] D128197: [clangd] Handle initializers that contain =

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG1c92e06ded2d: [clangd] Handle initializers that contain = (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D128197?vs=438369&id=438392

[clang-tools-extra] 1c92e06 - [clangd] Handle initializers that contain =

Author: Kadir Cetinkaya Date: 2022-06-20T16:42:54+02:00 New Revision: 1c92e06ded2da33f9ad00305af281e47cf9c584f URL: https://github.com/llvm/llvm-project/commit/1c92e06ded2da33f9ad00305af281e47cf9c584f DIFF: https://github.com/llvm/llvm-project/commit/1c92e06ded2da33f9ad00305af281e47cf9c584f.dif

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct

jackhong12 added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2328 +} + if (PrevToken->Tok.isLiteral() || HazardyKnusperkeks wrote: > MyDeveloperDay wrote: > > Thank you I wish more of the clauses were commented like this > +1 I'm not

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

sberg added a comment. Is it intended that a deleted copy assignment op as in `struct S { void operator =(S &) = delete; };` (though, somewhat oddly, not in `struct S { void operator =(S) = delete; };`) is now marked as trivial? I think that's the root cause why a build of PDFium with clang-cl

[PATCH] D126859: [clangd] Validate clang-tidy CheckOptions in clangd config

njames93 updated this revision to Diff 438388. njames93 added a comment. Reuse implementation from D127446 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126859/new/ https://reviews.llvm.org/D126859 Files: clang

[PATCH] D127856: [clangd] Support multiline semantic tokens

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:948 +} else { + // If a tokens length is past the end of the line, it should be treated as + // if the token ends at the end of the line and will not wrap onto the ---

[PATCH] D127856: [clangd] Support multiline semantic tokens

kadircet updated this revision to Diff 438387. kadircet added a comment. Split highlights into multiple tokens rather than trimming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127856/new/ https://reviews.llvm.org/D127856 Files: clang-tools-ext

[PATCH] D128207: [clang-doc][NFC] Fix reference invalidation assertion failure.

MTC created this revision. MTC added reviewers: dexonsmith, mehdi_amini. MTC added a project: clang-tools-extra. Herald added subscribers: jsji, usaxena95, pengfei, kadircet, arphaman. Herald added a project: All. MTC requested review of this revision. Herald added subscribers: cfe-commits, ilya-bi

[PATCH] D128206: [Clang] Allow multiple comma separated arguments to `--offload-arch=`

ye-luo accepted this revision. ye-luo added a comment. This revision is now accepted and ready to land. LGTM. This allows me to write concise compile lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128206/new/ https://reviews.llvm.org/D128206

[PATCH] D128206: [Clang] Allow multiple comma separated arguments to `--offload-arch=`

jhuber6 created this revision. jhuber6 added reviewers: tra, yaxunl, jdoerfert, JonChesterfield, ye-luo. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. This patch updates the `--[no-]o

[PATCH] D128204: [clangd] Add fix-it for inserting IWYU pragma: keep

njames93 created this revision. njames93 added reviewers: sammccall, kadircet, kbobyrev. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: cla

[PATCH] D128202: [clangd] Include "final" when printing class declaration

tom-anders added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:1010 + if (D->isEffectivelyFinal()) { + Out << " final"; sammccall wrote: > isEffectivelyFinal returns true for > `struct X { ~X() final; }` > > I don't think we want to print `s

[PATCH] D126559: [MSVC] Fix pragma alloc_text failing for C files

steplong added a comment. Hmm, it looks like MSVC is accepting: extern "C" { static void foo(); } static int foo(); #pragma alloc_text("s", foo) static void foo() {} Ignoring the `pragma alloc_text`, it looks like GCC compiles the following `foo` with C linkage vs LLVM which comp

[PATCH] D128202: [clangd] Include "final" when printing class declaration

sammccall added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:1010 + if (D->isEffectivelyFinal()) { + Out << " final"; isEffectivelyFinal returns true for `struct X { ~X() final; }` I don't think we want to print `struct X final {}` in that

[PATCH] D105494: [clang] Introduce a union inside ProgramPoint.

lenary added a comment. Herald added a project: All. This change looks fine to me (though clang-format wants a reasonable change). I'm not familiar with the clang static analyzer, so I'm not sure I can +2 this, but hopefully this message will act as a ping for the existing reviewers? Repositor

[PATCH] D128202: [clangd] Include "final" when printing class declaration

tom-anders created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. tom-anders requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. Fixes https://github

[PATCH] D125728: [WebAssembly] Update supported features in -mcpu=generic

asb added a comment. One thing that's not ideal about this test case is that it still passes if you delete the changes to WebAssembly.cpp. At least for RISC-V, selecting the -mcpu also emits the relevant `-target-feature +foo` for features supported by that CPU, which doesn't seem to happen her

[PATCH] D128119: [clang] enforce instantiation of constexpr template functions

serge-sans-paille added a comment. This also seems to fix https://github.com/llvm/llvm-project/issues/37522 and https://github.com/llvm/llvm-project/issues/55315 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119

[PATCH] D128197: [clangd] Handle initializers that contain =

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:192 + continue; +// Deletion range initially spans the initializer, excluding the `=

[PATCH] D128197: [clangd] Handle initializers that contain =

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Re

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

jhuber6 added a comment. Is anyone up to review this? I'm mostly looking for some feedback on the interfaces I've built. If no one has time to look into it I can probably just land without review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1272

[PATCH] D127363: [Lex] Fix for char32_t literal truncation on 16 bit architectures

sammccall added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:1600 - llvm::APInt LitVal(PP.getTargetInfo().getIntWidth(), 0); + llvm::APInt LitVal(PP.getTargetInfo().getChar32Width(), 0); tahonermann wrote: > I don't think this is quite righ

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

asb added a comment. I've left one minor comment. My other suggestion would be to absorb in the semantic restrictions work from here . Comment at: llvm/lib/IR/Type.cpp:307 +Type *Type::getWasm_ExternrefTy(LLVMCon

[PATCH] D122385: [clang][deps] Fix clang-cl output argument parsing

jansvoboda11 updated this revision to Diff 438367. jansvoboda11 added a comment. Code review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122385/new/ https://reviews.llvm.org/D122385 Files: clang/test/ClangScanDeps/cl-output.c clang/

[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff destination isn't null

pcwang-thead added a comment. Ping. Any comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126461/new/ https://reviews.llvm.org/D126461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D127184: [clangd] Add to header map

sammccall added a comment. Apologies for not getting to this before vacation, and thanks Nathan for looking at this. (I'll leave for you to stamp) This is fine with me as-is, but I think this mapping shouldn't be our *preferred* way to solve this problem, and should eventually go away. We also

[PATCH] D128190: [WinEH] Apply funclet operand bundles to nounwind intrinsics that lower to function calls

sgraenitz created this revision. sgraenitz added reviewers: rnk, theraven, DHowett-MSFT. Herald added subscribers: jsji, pengfei, hiraditya. Herald added a project: All. sgraenitz requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. WinEHPr

[PATCH] D125885: [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals

This revision was automatically updated to reflect the committed changes. Closed by commit rG541a50e20702: [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals (authored by jspam, committed by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang-tools-extra] 541a50e - [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals

Author: Joachim Priesner Date: 2022-06-20T13:30:30+01:00 New Revision: 541a50e20702a8046fe5076742611354cb6dd0f3 URL: https://github.com/llvm/llvm-project/commit/541a50e20702a8046fe5076742611354cb6dd0f3 DIFF: https://github.com/llvm/llvm-project/commit/541a50e20702a8046fe5076742611354cb6dd0f3.di

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

peixin added a comment. OK. This seems not to be related to this patch. https://buildkite.com/llvm-project/premerge-checks/builds/98446#0181715d-812b-4d2a-b5d0-5c1283d78b5f I also see these failures in another review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

awarzynski added a comment. In D128043#3596096 , @peixin wrote: > The CI failed. Thanks - I didn't notice any failures related to this change. Did I miss anything? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D127856: [clangd] Support multiline semantic tokens

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. (My first reaction was that this belongs in semanticHighlights() rather than toSemanticTokens, but I think you got it right - the single-line restriction is pretty unnatural from clang's

[PATCH] D127655: [AArch64] Define __FP_FAST_FMA[F]

jolanta.jensen updated this revision to Diff 438344. jolanta.jensen added a comment. Removing an unnecessary test change from aarch64-target-features.c as init-aarch64.c provides enough coverage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127655

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

peixin added a comment. The CI failed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128043/new/ https://reviews.llvm.org/D128043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D127812: [AArch64] Function multiversioning support added.

ilinpv added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1086 +.. option:: -mno-fmv + xbolva00 wrote: > ilinpv wrote: > > MaskRay wrote: > > > This file is auto-generated. Don't touch it. > > It looked out of sync with options td files

[PATCH] D128183: [clang][dataflow] Extend flow condition in the body of a do/while loop

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: martong, tschuett, rnkovacs. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. Extend flow condition in the body of a do/while loop.

[PATCH] D128182: [NFC] Switch FloatModeKind enum class to use bitmask enums

jolanta.jensen created this revision. Herald added a project: All. jolanta.jensen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Using bitmask enums simplifies and clarifies the code. Repository: rG LLVM Github Monorepo https://review

[PATCH] D128120: [Clang][VE] Add missing intrinsics

efocht accepted this revision. efocht added a comment. This revision is now accepted and ready to land. Looks ok for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128120/new/ https://reviews.llvm.org/D128120 ___

[PATCH] D127643: [Static Analyzer] Structured bindings to data members

steakhal added a comment. I missed this commit because it was not tagged by "[analyzer]". What is the community preference about tagging CSA commits? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127643/new/ https://reviews.llvm.org/D127643 __

[PATCH] D128166: ManagedStatic: Destroy from destructor

nhaehnle created this revision. Herald added a reviewer: deadalnix. Herald added subscribers: bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, jvesely, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, a

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

dongjunduo added a comment. In D128048#3591829 , @Whitney wrote: > Can you please add some test cases? I have found that new-option unit tests are not included in `clang/test` or `clang/unit-tests`. Could u tell me where I should write the test cases?

  1   2   >