asb added a comment.
I've left one minor comment. My other suggestion would be to absorb in the
semantic restrictions work from here
<https://gist.github.com/asb/b8701efe35cf99bc8fd606b9ca984337>.
================
Comment at: llvm/lib/IR/Type.cpp:307
+Type *Type::getWasm_ExternrefTy(LLVMContext &C) {
+ // pointer to opaque struct in addrspace(10)
----------------
With the move to opaque pointers, I think this and getWasm_FuncRefTy could be
updated to just return a pointer to addrspace 10 and 20 respectively?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122215/new/
https://reviews.llvm.org/D122215
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
