eopXD added a comment. - I think we will need some test coverage under `llvm/test/CodeGen/RISCV/attributes.ll` and `llvm/test/MC/RISCV/attribute-arch.s` if the extension is existing in the arch string. - Since macro is added, we need some test coverage under `clang/test/Preprocessor/riscv-target-features.c` - There is also some test case for error handling under `clang/test/Driver/riscv-arch.c`, maybe add some there too?
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128235/new/ https://reviews.llvm.org/D128235 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
