[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu updated this revision to Diff 424107. ChuanqiXu added a comment. Rebase with main. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113545/new/ https://reviews.llvm.org/D113545 Files: clang/include/clang/AST/DeclBase.h clang/include/clang/Basic/LangOptions.def clang/includ

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae updated this revision to Diff 424105. python3kgae added a comment. Committed. Updated line number check for test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 Files: clang/include/clang/B

[PATCH] D123907: [HLSL] Add shader attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb02d88d5afb5: [HLSL] Add shader attribute (authored by python3kgae). Changed prior to commit: https://reviews.llvm.org/D123907?vs=424093&id=424104

[clang] b02d88d - [HLSL] Add shader attribute

Author: Xiang Li Date: 2022-04-20T23:46:43-07:00 New Revision: b02d88d5afb58f53b30cde31990cd2d355d6c597 URL: https://github.com/llvm/llvm-project/commit/b02d88d5afb58f53b30cde31990cd2d355d6c597 DIFF: https://github.com/llvm/llvm-project/commit/b02d88d5afb58f53b30cde31990cd2d355d6c597.diff LOG:

[PATCH] D124149: [NFC] follow up code cleanup after D123837

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:1573 // attached to the global module and usable within the module unit. - if ((M->isGlobalModule() && !M->Parent) || - // If M is the private module fragment, it is usable only if it is within

[PATCH] D124149: [NFC] follow up code cleanup after D123837

ChuanqiXu created this revision. ChuanqiXu added a reviewer: iains. ChuanqiXu added a project: clang. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. I found there are chances to do simplify the codes further after I landed D123837

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a comment. @rsmith @aaron.ballman Do you think it's worth resubmitting this patch with a look ahead of the `mutable` keyword (this seems to me a better strategy than other flimsy workaround suggested/tried), or would you rather wait for WG21 to come up with something? Repositor

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

pcwang-thead added a comment. In D112921#3462592 , @Mordante wrote: > I didn't look at the code, but I have some hints how we can test libc++. Thanks! I ran tests with no error occurred on my local machine and I really want to know how to test it! Rep

[PATCH] D124147: [clang][cmake] correct grammar and style inconsistency

VoltrexMaster created this revision. Herald added a subscriber: mgorny. Herald added a project: All. VoltrexMaster requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Correct the grammar of comments,

[PATCH] D123907: [HLSL] Add shader attribute

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6391 +where the string literal is one of: "pixel", "vertex", "geometry", "hull", + "domain", "compute", "raygeneration", "intersection", "anyhit", "closesthit", + "mis

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae updated this revision to Diff 424093. python3kgae added a comment. Add comment for test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 Files: clang/include/clang/Basic/Attr.td clang/incl

[PATCH] D123907: [HLSL] Add shader attribute

MaskRay added inline comments. Comment at: clang/test/SemaHLSL/shader_type_attr.hlsl:1 +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -ast-dump -o - %s | FileCheck %s +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -ast-dump -o - %s -DFAIL

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

craig.topper added inline comments. Comment at: clang/lib/Headers/emmintrin.h:3476 +/// This intrinsic corresponds to the VMOVQ / MOVQ instruction +/// in 64 bits. /// craig.topper wrote: > 64 bits -> 64-bit mode 64 bits -> 64-bit CHANGES SINCE LAST ACTION

[PATCH] D123837: [C++20] [Modules] Judge isInCurrentModule currently

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce2257d69fd0: [C++20] [Modules] Judge current module correctly (authored by ChuanqiXu). Changed prior to commit: https://reviews.llvm.org/D123837?

[clang] ce2257d - [C++20] [Modules] Judge current module correctly

Author: Chuanqi Xu Date: 2022-04-21T11:09:55+08:00 New Revision: ce2257d69fd02d0c34164ce3de9ab8dbe6991e0c URL: https://github.com/llvm/llvm-project/commit/ce2257d69fd02d0c34164ce3de9ab8dbe6991e0c DIFF: https://github.com/llvm/llvm-project/commit/ce2257d69fd02d0c34164ce3de9ab8dbe6991e0c.diff LO

[PATCH] D123837: [C++20] [Modules] Judge isInCurrentModule currently

ChuanqiXu added a comment. In D123837#3461474 , @iains wrote: > thanks for multiple iterations! Thanks for the reviewing! > I think maybe you are using a too old clang-format? > it seems that clang-format >= llvm-14 removes spaces around module partiti

[clang] 483efc9 - [Pipelines] Remove Legacy Passes in Coroutines

Author: Chuanqi Xu Date: 2022-04-21T10:59:11+08:00 New Revision: 483efc9ad04dccd9f2163c84c2b6198ebb7049a6 URL: https://github.com/llvm/llvm-project/commit/483efc9ad04dccd9f2163c84c2b6198ebb7049a6 DIFF: https://github.com/llvm/llvm-project/commit/483efc9ad04dccd9f2163c84c2b6198ebb7049a6.diff LO

[PATCH] D123918: [Pipelines] Remove Legacy Passes in Coroutines

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG483efc9ad04d: [Pipelines] Remove Legacy Passes in Coroutines (authored by ChuanqiXu). Herald added a project: clang. Herald added a subscriber: cfe-c

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

jhuber6 added inline comments. Comment at: clang/test/Driver/linker-wrapper-image.c:8 + +// OPENMP: @__start_omp_offloading_entries = external hidden constant %__tgt_offload_entry +// OPENMP-NEXT: @__stop_omp_offloading_entries = external hidden constant %__tgt_offload_entry --

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. Yeah, as I drove away from my desk I realized my mistake. Will get new accurate numbers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D123534 ___

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

daltenty added a comment. Thanks for getting this fixed this so quickly and sorry for the messy revert. > What you're seeing is a symptom of a libc++ issue (PR12704) that was fixed > >10 years ago (rGbff1bfc6be0615ba3036a861fd27b75c96e3297c >

[PATCH] D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Also, please run `clang-format` on the changes. Comment at: clang/lib/Headers/altivec.h:19051 #ifdef __LITTLE_ENDIAN__ - return __builtin_altivec_vstribl_p(__

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

nemanjai added a comment. In D122983#3463569 , @xbolva00 wrote: > But your link shows failures in compiler-rt/, not in llvm test-suite It shows both. But the `compiler-rt` ones have subsequently been fixed while the `test-suite` ones are still failing a

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

xiangzhangllvm updated this revision to Diff 424070. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124067/new/ https://reviews.llvm.org/D124067 Files: clang/include/clang/Basic/BuiltinsX86.def clang/include/clang/Basic/BuiltinsX86_64.def clang/lib/Headers/emmintrin.h clang/lib/He

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

xiangzhangllvm marked an inline comment as done. xiangzhangllvm added inline comments. Comment at: clang/test/CodeGen/X86/sse2-builtins.c:547 // X64: insertelement <2 x i64> undef, i64 %{{.*}}, i32 0 // X64: insertelement <2 x i64> %{{.*}}, i64 0, i32 1 return _mm_cvtsi6

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

xiangzhangllvm updated this revision to Diff 424067. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124067/new/ https://reviews.llvm.org/D124067 Files: clang/include/clang/Basic/BuiltinsX86.def clang/include/clang/Basic/BuiltinsX86_64.def clang/lib/Headers/emmintrin.h clang/lib/He

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

xbolva00 added a comment. In D122983#3463521 , @nemanjai wrote: > This is still causing failures when building `test-suite`: > https://lab.llvm.org/buildbot/#/builders/105/builds/24292 > > Why don't we just turn off this warning for the entire `test-suite

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

MaskRay added subscribers: Meinersbur, MaskRay. MaskRay added a comment. In D122983#3463521 , @nemanjai wrote: > This is still causing failures when building `test-suite`: > https://lab.llvm.org/buildbot/#/builders/105/builds/24292 > > Why don't we just t

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

thakis added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123345/new/ https://reviews.llvm.org/D123345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

rsmith added a comment. In D123345#3463540 , @thakis wrote: > I think your revert to fix the aix CI broke CI everywhere: > http://45.33.8.238/linux/74239/step_7.txt > > Please take a look and reland for now if it takes a while to fix. Relanded with a wo

[clang] 72315d0 - Treat `std::move`, `forward`, etc. as builtins.

Author: Richard Smith Date: 2022-04-20T17:58:31-07:00 New Revision: 72315d02c432a0fe0acae9c96c69eac8d8e1a9f6 URL: https://github.com/llvm/llvm-project/commit/72315d02c432a0fe0acae9c96c69eac8d8e1a9f6 DIFF: https://github.com/llvm/llvm-project/commit/72315d02c432a0fe0acae9c96c69eac8d8e1a9f6.diff

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

thakis added a comment. I think your revert to fix the aix CI broke CI everywhere: http://45.33.8.238/linux/74239/step_7.txt Please take a look and reland for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123345/new

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

nemanjai added a comment. This is still causing failures when building `test-suite`: https://lab.llvm.org/buildbot/#/builders/105/builds/24292 Why don't we just turn off this warning for the entire `test-suite` since I don't expect we want to modify the tests (as some of them have licenses that

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

xiangzhangllvm added a comment. In D124067#3461551 , @RKSimon wrote: > OK - SSE2/SSE41 now have i386 coverage - please can you rebase and update the > checks to use CHECK/X64/X86 ? Hi @RKSimon, I very appreciate your help to update the test! You are ver

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

rsmith added a comment. In D123345#3463224 , @daltenty wrote: > In D123345#3460639 , @Jake-Egan > wrote: > >> Hi, unfortunately there's a build failure on AIX: >> https://lab.llvm.org/buildbot/#/builders/214/bui

[clang] aa643f4 - Fixup D123950 to address revert of D123345

Author: David Tenty Date: 2022-04-20T19:59:07-04:00 New Revision: aa643f455a5362de7189eac630050d2c8aefe8f2 URL: https://github.com/llvm/llvm-project/commit/aa643f455a5362de7189eac630050d2c8aefe8f2 DIFF: https://github.com/llvm/llvm-project/commit/aa643f455a5362de7189eac630050d2c8aefe8f2.diff L

[PATCH] D123775: [AST] Support template declaration found through using-decl for QualifiedTemplateName.

shafik added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:1004 Name = Context.getQualifiedTemplateName(SS.getScopeRep(), /*HasTemplateKeyword*/ false, +Name);

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. Confirmed again with `-DCMAKE_BUILD_TYPE=RelWithDebInfo -DLLVM_ENABLE_ASSERTIONS=On`: 1510883864 (new) - 1510881800 (old) = 2064 bytes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D123

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim updated this revision to Diff 424055. hctim added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Patch update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D12

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. In D123534#3462551 , @dblaikie wrote: > What's the DW_AT_type referring to? (why is there a type called ".str"?) > > For your particular purposes, it seems like the name/type/linkage name could > all be omitted & that might be OK,

[clang] 98d911e - Revert "Treat `std::move`, `forward`, etc. as builtins."

Author: David Tenty Date: 2022-04-20T19:14:37-04:00 New Revision: 98d911e01f3ac62a9f78850b4209effcf2f54c91 URL: https://github.com/llvm/llvm-project/commit/98d911e01f3ac62a9f78850b4209effcf2f54c91 DIFF: https://github.com/llvm/llvm-project/commit/98d911e01f3ac62a9f78850b4209effcf2f54c91.diff L

[clang] de6ddae - Revert "Don't treat 'T &forward(T&&)' as builtin."

Author: David Tenty Date: 2022-04-20T19:14:36-04:00 New Revision: de6ddaeef3aaa8a9ae3663c12cdb57d9afc0f906 URL: https://github.com/llvm/llvm-project/commit/de6ddaeef3aaa8a9ae3663c12cdb57d9afc0f906 DIFF: https://github.com/llvm/llvm-project/commit/de6ddaeef3aaa8a9ae3663c12cdb57d9afc0f906.diff L

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

red1bluelost marked 3 inline comments as done. red1bluelost added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13555-13557 +DiagnoseImpCast(S, E, T, CC, DiagID); +if (!isa(Target) || !isa(Source)) + return; aaron.ballman wrote: > I do

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

red1bluelost updated this revision to Diff 424053. red1bluelost added a comment. Updates patch based on comments. Silences the sign conversions on enum-to-enum so that only enum-to-enum will warn. Simplifies the test case since now only one warning occurs. Repository: rG LLVM Github Monorepo

[PATCH] D122897: [clang][CUDA][Windows] Fix compilation error on Windows with `uint32_t __nvvm_get_smem_pointer`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc23147106f7e: [clang][CUDA][Windows] Fix compilation error on Windows with `uint32_t… (authored by emankov). Herald added a subscriber: cfe-commits.

[clang] c231471 - [clang][CUDA][Windows] Fix compilation error on Windows with `uint32_t __nvvm_get_smem_pointer`

Author: Evgeny Mankov Date: 2022-04-21T00:41:20+03:00 New Revision: c23147106f7efc4b5e29c47a08951116b4d994ac URL: https://github.com/llvm/llvm-project/commit/c23147106f7efc4b5e29c47a08951116b4d994ac DIFF: https://github.com/llvm/llvm-project/commit/c23147106f7efc4b5e29c47a08951116b4d994ac.diff

[PATCH] D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions

maryammo updated this revision to Diff 424050. maryammo added a comment. [NFC] Fix the formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124093/new/ https://reviews.llvm.org/D124093 Files: clang/lib/Headers/altivec.h clang/test/CodeGen/

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

jhuber6 added inline comments. Comment at: clang/test/Driver/linker-wrapper-image.c:8 + +// OPENMP: @__start_omp_offloading_entries = external hidden constant %__tgt_offload_entry +// OPENMP-NEXT: @__stop_omp_offloading_entries = external hidden constant %__tgt_offload_entry --

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman updated this revision to Diff 424048. MosheBerman added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123352/new/ https://reviews.llvm.org/D123352 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D119296: KCFI sanitizer

samitolvanen added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2268-2272 +if (!AddressTaken && F.hasLocalLinkage()) { + F.setPrefixData(nullptr); + F.removeFnAttr("kcfi"); + continue; +} nickdesaulniers wrote: > Can we

[PATCH] D124104: [clang][dataflow] Fix `Environment::join`'s handling of flow condition merging

ymandel marked 2 inline comments as done. ymandel added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124104/new/ https://reviews.llvm.org/D124104 ___ cfe-commits mailing list cfe-comm

[PATCH] D124104: [clang][dataflow] Fix `Environment::join`'s handling of flow condition merging

ymandel updated this revision to Diff 424045. ymandel added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124104/new/ https://reviews.llvm.org/D124104 Files: clang/lib/Analysis/FlowSensitive/DataflowEnvironment

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present for all archs

int3 updated this revision to Diff 424044. int3 edited the summary of this revision. int3 added a comment. Herald added a subscriber: pengfei. fix x86 backend's omission of DWARF unwind Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ http

[PATCH] D118409: [OpenMPIRBuilder] Remove ContinuationBB argument from Body callback.

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118409/new/ https://reviews.llvm.org/D118409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

zibi added inline comments. Comment at: clang/test/Driver/linker-wrapper-image.c:8 + +// OPENMP: @__start_omp_offloading_entries = external hidden constant %__tgt_offload_entry +// OPENMP-NEXT: @__stop_omp_offloading_entries = external hidden constant %__tgt_offload_entry -

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

tstellar updated this revision to Diff 424040. tstellar added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123967/new/ https://reviews.llvm.org/D123967 Files: clang/test/CMakeLists.txt clang/test/lit.site.c

[PATCH] D124132: Thread safety analysis: Don't pass capability kind where not needed (NFC)

aaronpuchert created this revision. aaronpuchert added a reviewer: aaron.ballman. Herald added a project: All. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If no capability is held, or the capability expression is invalid, t

[PATCH] D124131: Thread safety analysis: Store capability kind in CapabilityExpr

aaronpuchert created this revision. aaronpuchert added a reviewer: aaron.ballman. Herald added a project: All. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This should make us print the right capability kind in many more cas

[PATCH] D121299: [NVPTX] Disable DWARF .file directory for PTX

asavonic added a comment. Herald added a subscriber: mattd. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121299/new/ https://reviews.llvm.org/D121299 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D119296: KCFI sanitizer

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. LGTM; it would be good if you could provide steps to test this on the Linux kernel. (i.e. what kernel patches are needed). Consider waiting for at least one additional review

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

bc-lee added a comment. As you confirmed at https://crbug.com/1259122#c21, there is a problem with assembly files like `floatundidf.S` and this patch is intended to fix it. C/C++ files are fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121868

[PATCH] D119296: KCFI sanitizer

samitolvanen added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2255-2260 + for (const char &C : Name) { +if (llvm::isAlnum(C) || C == '_' || C == '.') + continue; +return false; + } + return true; nickdesaulniers wrote: > sami

[PATCH] D124033: [NFC] Adding a note about the macro __FLT_EVAL_METHOD__

zahiraam added inline comments. Comment at: clang/docs/UsersManual.rst:1610-1618 The macro ``__FLT_EVAL_METHOD__`` will expand to either the value set from the command line option ``ffp-eval-method`` or to the value from the target info -setting. The ``__FLT_EVAL_METHOD__`` mac

[PATCH] D124033: [NFC] Adding a note about the macro __FLT_EVAL_METHOD__

zahiraam updated this revision to Diff 424036. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124033/new/ https://reviews.llvm.org/D124033 Files: clang/docs/UsersManual.rst Index: clang/docs/UsersManual.rst === --- clang/

[PATCH] D123958: [randstruct] Randomize all elements of a record

void updated this revision to Diff 424034. void added a comment. Correctly handle all types of Decls that can be found in a RecordDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123958/new/ https://reviews.llvm.org/D123958 Files: clang/inclu

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

daltenty added a comment. In D123345#3460639 , @Jake-Egan wrote: > Hi, unfortunately there's a build failure on AIX: > https://lab.llvm.org/buildbot/#/builders/214/builds/779/steps/9/logs/stdio. > Could you take a look? Hi, any feedback on the AIX brea

[PATCH] D124128: Thread safety analysis: Store CapabilityExprs in ScopedLockableFactEntry (NFC)

aaronpuchert created this revision. aaronpuchert added a reviewer: aaron.ballman. Herald added a project: All. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For now this doesn't make a whole lot of sense, but it will allow us

[PATCH] D119296: KCFI sanitizer

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2255-2260 + for (const char &C : Name) { +if (llvm::isAlnum(C) || C == '_' || C == '.') + continue; +return false; + } + return true; samitolvanen wrote: > nick

[PATCH] D119296: KCFI sanitizer

samitolvanen added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2248 + F->setPrefixData(CreateKCFITypeId(FD->getType())); + F->addFnAttr("kcfi"); +} nickdesaulniers wrote: > While string based attributes are easier to work with in LLVM, I wo

[PATCH] D119296: KCFI sanitizer

samitolvanen updated this revision to Diff 424030. samitolvanen marked 4 inline comments as done. samitolvanen added a comment. Addressed another round of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119296/new/ https://reviews.llvm.org/

[PATCH] D124127: Thread safety analysis: Pack CapabilityExpr using PointerIntPair (NFC)

aaronpuchert created this revision. aaronpuchert added a reviewer: aaron.ballman. Herald added a project: All. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We're storing these quite frequently: FactEntry inherits from Capabi

[PATCH] D124066: [clang-tidy] Ignore macros defined within declarations in modernize-macro-to-enum

LegalizeAdulthood added a comment. The main problem with scenario 2) is the weird interaction between when PPCallbacks methods are invoked and AST traversal is invoked. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124066/new/ https://reviews.llvm.org/D124066 _

[PATCH] D123926: [clang] Add a raw_ostream operator<< overload for QualType

This revision was automatically updated to reflect the committed changes. njames93 marked an inline comment as done. Closed by commit rGcfb8169059c8: [clang] Add a raw_ostream operator<< overload for QualType (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] cfb8169 - [clang] Add a raw_ostream operator<< overload for QualType

Author: Nathan James Date: 2022-04-20T22:09:05+01:00 New Revision: cfb8169059c807ed5fbfb66b3ed558b7b6eb2833 URL: https://github.com/llvm/llvm-project/commit/cfb8169059c807ed5fbfb66b3ed558b7b6eb2833 DIFF: https://github.com/llvm/llvm-project/commit/cfb8169059c807ed5fbfb66b3ed558b7b6eb2833.diff

[PATCH] D124066: [clang-tidy] Ignore macros defined within declarations in modernize-macro-to-enum

LegalizeAdulthood added a comment. Should probably split that bug report into 2 bugs for the two phases of attack. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124066/new/ https://reviews.llvm.org/D124066 ___ cfe-commits mailing list cfe-com

[PATCH] D124066: [clang-tidy] Ignore macros defined within declarations in modernize-macro-to-enum

LegalizeAdulthood added a comment. In D124066#3463008 , @aaron.ballman wrote: > This seems like a case where we might want a configuration option (maybe). > [...] > WDYT? In my bug report on this problem, I sketch out a plan of attack: 1. **DON'T BREA

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae updated this revision to Diff 424019. python3kgae added a comment. Fix doc again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 Files: clang/include/clang/Basic/Attr.td clang/include/cla

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman added a comment. In D123352#3458530 , @steakhal wrote: > In D123352#3439649 , @MosheBerman > wrote: > >> In D123352#3439390 , @steakhal >> wrote: >> >>> tldr

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6390 + ``[shader(string-literal)]`` +where the string literal is one of: . +Normally the shader type is set by shader target with the ``-T`` option like bogner wrote: > I'm gues

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman updated this revision to Diff 424010. MosheBerman edited the summary of this revision. MosheBerman added a comment. - Improved handling of `NS_ASSUME` and other edge cases/ - Added test cases, and changed the test to actually validate the output (not just the presence of fixits.) - Cl

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:162-164 + /// 2. If we are annotating an Objective-C method, and not a function, we + ///want to use the `nullable` form instead of `_Nullable`. + ///When \p SyntaxS

[PATCH] D113804: [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit. Comment at: clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp:39-48 + Finder->addMatcher( + tagDecl( + anyOf(allOf(

[PATCH] D124066: [clang-tidy] Ignore macros defined within declarations in modernize-macro-to-enum

aaron.ballman added a comment. This seems like a case where we might want a configuration option (maybe). Some of the test cases where you silence the diagnostic look like places I would expect us to be able to use a (local) enumeration. e.g., void g(int x) { if (x != 0) { #define INS

[PATCH] D123907: [HLSL] Add shader attribute

bogner added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6390 + ``[shader(string-literal)]`` +where the string literal is one of: . +Normally the shader type is set by shader target with the ``-T`` option like I'm guessing you meant to act

[clang] 38612fb - Reland "[COFF, ARM64] Add __break intrinsic"

Author: Pengxuan Zheng Date: 2022-04-20T13:01:30-07:00 New Revision: 38612fbc8990fe609b08b63f82845f546c22bcff URL: https://github.com/llvm/llvm-project/commit/38612fbc8990fe609b08b63f82845f546c22bcff DIFF: https://github.com/llvm/llvm-project/commit/38612fbc8990fe609b08b63f82845f546c22bcff.diff

[PATCH] D123682: [clang-tblgen] Automatically document options values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf7b98c383df: [clang-tblgen] Automatically document options values (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES S

[clang] af7b98c - [clang-tblgen] Automatically document options values

Author: serge-sans-paille Date: 2022-04-20T22:00:06+02:00 New Revision: af7b98c383df62c0a749c3394b1670a1ed54c9d4 URL: https://github.com/llvm/llvm-project/commit/af7b98c383df62c0a749c3394b1670a1ed54c9d4 DIFF: https://github.com/llvm/llvm-project/commit/af7b98c383df62c0a749c3394b1670a1ed54c9d4.d

[PATCH] D124104: [clang][dataflow] Fix `Environment::join`'s handling of flow condition merging

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:69 /// Attempts to merge distinct values `Val1` and `Val1` in `Env1` and `Env2`, /// respec

[PATCH] D123958: [randstruct] Randomize all elements of a record

void added a comment. In D123958#3461714 , @aaron.ballman wrote: > In D123958#3461020 , @void wrote: > >> In D123958#3459205 , >> @aaron.ballman wrote: >> >>> I think yo

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

probinson added a comment. > What's the DW_AT_type referring to? (why is there a type called ".str"?) I'd expect it to point to a base type, in this case character string. A typeless variable with a location would be pretty weird. But I agree the name/linkage_name would be unnecessary. Reposi

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:13002 + ExprResult NewTrailingRequiresClause = + E->getCallOperator()->getTrailingRequiresClause(); erichkeane wrote: > erichkeane wrote: > > cor3ntin wrote: > > > That doesn't l

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

aaron.ballman added a comment. In D123909#3462791 , @rsmith wrote: > In D123909#3462560 , @aaron.ballman > wrote: > >> This looks like a true positive to me, at least for the moment (Core is >> still trying to d

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 updated this revision to Diff 423993. jhuber6 added a comment. Herald added a subscriber: sstefan1. Adjusting tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123812/new/ https://reviews.llvm.org/D123812 Files: clang/test/Driver/link

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

MaskRay added a comment. Thanks for being willing to wait a bit and collect usage. Given current feedback, I am not going to simply undo the reverts. @cor3ntin To get one patch other folks can try: git revert -n c79e6007edef4b0044be93c464dc806ac687 git revert -n 0f5dbfd29ae0df215a01aff8

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 added inline comments. Comment at: clang/test/Driver/linker-wrapper-image.c:32 +// RUN: %clang -cc1 %s -emit-obj -o %t.o \ +// RUN: -fembed-offload-object=%S/Inputs/dummy-elf.o,cuda,nvptx64-nvida-cuda,sm_70 +// RUN: clang-linker-wrapper --print-wrapped-module --dry-run

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

rsmith added a comment. In D123909#3462560 , @aaron.ballman wrote: > This looks like a true positive to me, at least for the moment (Core is still > trying to decide what to do about CWG2569 which may relax some restrictions > in this area). > > @MaskR

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a comment. In D119136#3462707 , @amyk wrote: > In D119136#3459738 , @alanphipps > wrote: > >> We've also been seeing failures in our downstream Arm compiler when running >> the Perennial C++14 com

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

lichray added a comment. In D119136#3462660 , @aaron.ballman wrote:> > Thanks for the apology, but I still think the reverts were premature, so > hopefully we don't do this again. The issue with reverting all of these is > that you put the burden back

[PATCH] D124033: [NFC] Adding a note about the macro __FLT_EVAL_METHOD__

aaron.ballman added inline comments. Comment at: clang/docs/UsersManual.rst:1610-1618 The macro ``__FLT_EVAL_METHOD__`` will expand to either the value set from the command line option ``ffp-eval-method`` or to the value from the target info -setting. The ``__FLT_EVAL_METHOD__`

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a comment. Sorry for the delayed reply. In D119136#3462660 , @aaron.ballman wrote: > In D119136#3462609 , @MaskRay wrote: > >> In D119136#3462579 , >> @a

  1   2   3   >