zibi added inline comments.
================ Comment at: clang/test/Driver/linker-wrapper-image.c:8 + +// OPENMP: @__start_omp_offloading_entries = external hidden constant %__tgt_offload_entry +// OPENMP-NEXT: @__stop_omp_offloading_entries = external hidden constant %__tgt_offload_entry ---------------- On PowerPC I'm seeing the following error: pointing at `@` char: clang/test/Driver/linker-wrapper-image.c:10:12: error: OPENMP: expected string not found in input // OPENMP: @__start_omp_offloading_entries = external hidden constant %__tgt_offload_entry Are you aware of this? ================ Comment at: clang/test/Driver/linker-wrapper.c:9 + +// NVPTX_LINK: nvlink{{.*}}-m64 -o {{.*}}.out -arch sm_70 {{.*}}.o {{.*}}.o + ---------------- Similar error to above, the coordinates are off by 2 because of subsequent changes: clang/test/Driver/linker-wrapper.c:11:16: error: NVPTX_LINK: expected string not found in input // NVPTX_LINK: nvlink{{.*}}-m64 -o {{.*}}.out -arch sm_70 {{.*}}.o {{.*}}.o Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124039/new/ https://reviews.llvm.org/D124039 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits