[PATCH] D122588: [RISCV][test] Make PATH empty when testing --gcc-toolchain is multilib_riscv_elf_sdk

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5900401b147: [RISCV][test] Make PATH empty when testing --gcc-toolchain is… (authored by StephenFan). Repository: rG LLVM Github Monorepo CHANGE

[clang] a590040 - [RISCV][test] Make PATH empty when testing --gcc-toolchain is multilib_riscv_elf_sdk

Author: luxufan Date: 2022-03-29T14:51:23+08:00 New Revision: a5900401b1475cdf98dbd210ac4bc362563cebbf URL: https://github.com/llvm/llvm-project/commit/a5900401b1475cdf98dbd210ac4bc362563cebbf DIFF: https://github.com/llvm/llvm-project/commit/a5900401b1475cdf98dbd210ac4bc362563cebbf.diff LOG:

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth added a comment. reverted. I will fix this tomorrow. Sorry for the trouble Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115907/new/ https://reviews.llvm.org/D115907 ___ cfe-commits mailing lis

[clang] 6c77972 - Revert "[docs][misexpect][NFC] Fix malformed table in docs"

Author: Paul Kirth Date: 2022-03-29T06:19:53Z New Revision: 6c77972bac7ce125110ed2baea9919fb6866db39 URL: https://github.com/llvm/llvm-project/commit/6c77972bac7ce125110ed2baea9919fb6866db39 DIFF: https://github.com/llvm/llvm-project/commit/6c77972bac7ce125110ed2baea9919fb6866db39.diff LOG: Re

[PATCH] D122636: [llvm][clang][NFC] Add missing references to MisExpect in TOC

paulkirth created this revision. Herald added a subscriber: arphaman. Herald added a project: All. paulkirth requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

tonic added a comment. This is breaking the docs build with the following warning: "MisExpect.rst:document isn't included in any toctree." By default, docs warnings are treated as errors. Can you fix this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

xbolva00 added a comment. In D122271#3413193 , @uabelho wrote: > Hi, > > I noticed these to warning when compiling libunwind/src/UnwindLevel1.c with > this patch: > > 00:22:48 > /repo/bbiswjenk/fem2s10-eiffel176/workspace/llvm/sdk_1_20_ki_dev_test/lib

[PATCH] D122554: [clangd] Handle tabs in getIncrementalChangesAfterNewline()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9325e97a3599: [clangd] Handle tabs in getIncrementalChangesAfterNewline() (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] 9325e97 - [clangd] Handle tabs in getIncrementalChangesAfterNewline()

Author: Nathan Ridge Date: 2022-03-29T01:43:09-04:00 New Revision: 9325e97a3599929a52bef3e5c8e403c98f9428ba URL: https://github.com/llvm/llvm-project/commit/9325e97a3599929a52bef3e5c8e403c98f9428ba DIFF: https://github.com/llvm/llvm-project/commit/9325e97a3599929a52bef3e5c8e403c98f9428ba.diff

[PATCH] D122554: [clangd] Handle tabs in getIncrementalChangesAfterNewline()

nridge updated this revision to Diff 418789. nridge added a comment. address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122554/new/ https://reviews.llvm.org/D122554 Files: clang-tools-extra/clangd/Format.cpp clang-tools-extra

[PATCH] D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

uabelho added a comment. Hi, I noticed these to warning when compiling libunwind/src/UnwindLevel1.c with this patch: 00:22:48 /repo/bbiswjenk/fem2s10-eiffel176/workspace/llvm/sdk_1_20_ki_dev_test/libunwind/src/UnwindLevel1.c:175:12: warning: variable 'framesWalked' set but not used [-Wunuse

[PATCH] D122629: [RISCV] Add index check for vset/vget

pcwang-thead created this revision. pcwang-thead added reviewers: luismarques, asb, craig.topper, khchen. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, arphaman, the_o, bruceho

[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG50de68bc2ffc: [Driver][AVR] Emit proper warnings for different options (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/

[clang] 50de68b - [Driver][AVR] Emit proper warnings for different options

Author: Ben Shi Date: 2022-03-29T12:05:21+08:00 New Revision: 50de68bc2ffc8f6825fb5445ec179a68aa6ad219 URL: https://github.com/llvm/llvm-project/commit/50de68bc2ffc8f6825fb5445ec179a68aa6ad219 DIFF: https://github.com/llvm/llvm-project/commit/50de68bc2ffc8f6825fb5445ec179a68aa6ad219.diff LOG:

[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:477 if (!LinkStdlib) D.Diag(diag::warn_drv_avr_stdlib_not_linked); benshi001 wrote: > We should not merge the above two `if`, due to this check. > > So I will keep my or

[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:477 if (!LinkStdlib) D.Diag(diag::warn_drv_avr_stdlib_not_linked); We should not merge the above two `if`, due to this check

[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:451 if (!Args.hasArg(options::OPT_nostdlib) && !Args.hasArg(options::OPT_nodefaultlibs)) { +if (!CPU.empty()) { MaskRay wrot

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

StephenFan updated this revision to Diff 418774. StephenFan added a comment. Herald added a subscriber: sunshaoce. Address @MaskRay 's comments. 1. explicit default-argument to avoid error-prone 2. change riscv64 test to test the case when `-mno-relax -mrelax` specified. Is the change of riscv64

[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:451 if (!Args.hasArg(options::OPT_nostdlib) && !Args.hasArg(options::OPT_nodefaultlibs)) { +if (!CPU.empty

[PATCH] D122104: [X86][regcall] Support passing / returning structures

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd26190a10fc: [X86][regcall] Support passing / returning structures (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122104/new/ https:/

[clang] cd26190 - [X86][regcall] Support passing / returning structures

Author: Phoebe Wang Date: 2022-03-29T11:29:57+08:00 New Revision: cd26190a10fceb6e1472fabcd9e1736f62f078c4 URL: https://github.com/llvm/llvm-project/commit/cd26190a10fceb6e1472fabcd9e1736f62f078c4 DIFF: https://github.com/llvm/llvm-project/commit/cd26190a10fceb6e1472fabcd9e1736f62f078c4.diff L

[PATCH] D122588: [RISCV] Make PATH empty when testing --gcc-toolchain is multilib_riscv_elf_sdk

StephenFan updated this revision to Diff 418771. StephenFan added a comment. Herald added a subscriber: sunshaoce. Address @MaskRay 's comments Change log: 1. Update test in riscv32-toolchain.c 2. Make system-windows UNSUPPORTED Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

benshi001 added a comment. In D122524#3411879 , @MaskRay wrote: > In D122524#3411872 , @benshi001 > wrote: > >> In D122524#3410542 , @MaskRay >> wrote: >> >>> I think it

[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

benshi001 updated this revision to Diff 418764. benshi001 retitled this revision from "[clang][AVR] Emit proper warnings" to "[Driver][AVR] Emit proper warnings for different options". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122524/new/ https://reviews.llvm.org/D122524 Files: cl

[PATCH] D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads

pow2clk added a comment. Looks good. I made a comment about the CS 4.0 thing, but that can be addressed when more thorough examination of the requested shader models comes around. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6857 + uint32_t ThreadMax = 1024; + if (SMVersion.g

[PATCH] D122620: [clang][DR] Test and mark DR1479 as complete

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122620/new/ https://reviews.llvm.org/D122620

[PATCH] D122564: [RISCV] [NFC] add some tests for overloaded intrinsics of FP16

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd9ef6ad05ff3: [RISCV] [NFC] add some tests for overloaded intrinsics of FP16 (authored by Chenbing.Zheng). Repository: rG LLVM Github Monorepo CH

[clang] d9ef6ad - [RISCV] [NFC] add some tests for overloaded intrinsics of FP16

Author: Chenbing Zheng Date: 2022-03-29T10:00:20+08:00 New Revision: d9ef6ad05ff3cc4504a08d08c6cbd669b9ba764e URL: https://github.com/llvm/llvm-project/commit/d9ef6ad05ff3cc4504a08d08c6cbd669b9ba764e DIFF: https://github.com/llvm/llvm-project/commit/d9ef6ad05ff3cc4504a08d08c6cbd669b9ba764e.diff

[PATCH] D112647: [clang-apply-replacements] Correctly handle relative paths

dexonsmith added inline comments. Herald added a project: All. Comment at: clang-tools-extra/clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:178 } +SM.getFileManager().getFileSystemOpts().WorkingDir = PrevWorkingDir; }; This looks incorrec

[PATCH] D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads

beanz created this revision. beanz added reviewers: aaron.ballman, rnk, jdoerfert, MaskRay, rsmith. Herald added a subscriber: StephenFan. Herald added a project: All. beanz requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. HLSL uses Microsoft-s

[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

dexonsmith added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:273 - if (Status.getName() == Filename) { + if (!Status.IsVFSMapped) { // The name matches. Set the FileEntry. bnbarham wrote: > bnbarham wrote: > > dexonsmith wrote: > > > An

[PATCH] D122544: Utilize comparison operation implemented in APInt

aaronpuchert added a comment. Note that `__int128_t` is not available everywhere, generally only on 64-bit platforms. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-sizeof-expression.cpp:175 // CHECK-MESSAGES: :[[@LINE-1]]:28: warning: suspicious usage of si

[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

bnbarham added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:273 - if (Status.getName() == Filename) { + if (!Status.IsVFSMapped) { // The name matches. Set the FileEntry. bnbarham wrote: > dexonsmith wrote: > > An incremental patch you co

[PATCH] D122513: [analyzer] Fix "RhsLoc and LhsLoc bitwidth must be same"

vabridgers updated this revision to Diff 418749. vabridgers added a comment. Come up with a more principaled fix, thanks @NoQ :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122513/new/ https://reviews.llvm.org/D122513 Files: clang/lib/StaticAn

[PATCH] D122611: [clang][extract-api] Add support for macros

zixuw added inline comments. Comment at: clang/include/clang/ExtractAPI/Serialization/SymbolGraphSerializer.h:22 #include "clang/ExtractAPI/Serialization/SerializerBase.h" +#include "clang/Lex/PreprocessingRecord.h" #include "llvm/Support/JSON.h" Why do we nee

[PATCH] D122511: [clang][extract-api] Add Objective-C protocol support

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:269 +// Collect symbol information. +StringRef Name = Decl->getName(); +StringRef USR = API.recordUSR(Decl); dang wrote: > I think we should be recording this in Stri

[PATCH] D122511: [clang][extract-api] Add Objective-C protocol support

zixuw updated this revision to Diff 418744. zixuw marked 2 inline comments as done. zixuw added a comment. Rebase upstream changes in D122446 : - Move the change of the `objc_interface.m` test to D122446 . Repository: rG LLV

[clang] a427e18 - [docs][misexpect][NFC] Fix malformed table in docs

Author: Paul Kirth Date: 2022-03-29T00:14:07Z New Revision: a427e18896dee3cd00d5f565cfb9d7d2f26ebcec URL: https://github.com/llvm/llvm-project/commit/a427e18896dee3cd00d5f565cfb9d7d2f26ebcec DIFF: https://github.com/llvm/llvm-project/commit/a427e18896dee3cd00d5f565cfb9d7d2f26ebcec.diff LOG: [d

[PATCH] D122623: [docs][misexpect][NFC] Fix malformed table in docs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa427e18896de: [docs][misexpect][NFC] Fix malformed table in docs (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:245 +if (const auto *SuperClassDecl = Decl->getSuperClass()) { + SuperClass.Name = SuperClassDecl->getObjCRuntimeNameAsString(); + SuperClass.USR = API.recordUSR(SuperClassDecl); --

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

zixuw updated this revision to Diff 418738. zixuw marked 4 inline comments as done. zixuw added a comment. - Address review comments: - Use template to reuse logic for building function signatures for FunctionDecl and ObjCMethodDecl. - Move the change of `objc_interface.m` test in this patch fr

[PATCH] D122513: [analyzer] Fix "RhsLoc and LhsLoc bitwidth must be same"

vabridgers added a comment. I think I got it, looks like we're losing the width information at line 685, 686 below. Looks like I need to adjust the bitwidth of V before returning. clang/lib/StaticAnalyzer/Core/SValBuilder.cpp 671 SVal SValBuilder::evalCastSubKind(loc::ConcreteInt V, QualType

[PATCH] D122623: [docs][misexpect] Fix malformed table in docs

paulkirth updated this revision to Diff 418735. paulkirth added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. update table in clang docs too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122623/new/ https://revie

[PATCH] D118525: [modules] Merge ObjC interface ivars with anonymous types.

vsapsai added a reviewer: benlangmuir. vsapsai added a subscriber: benlangmuir. vsapsai added a comment. I've run clang with this change on a bunch of code (especially Objective-C code) and there were no regressions. Also adding @benlangmuir to reviewers as people mentioned he was doing some wo

[PATCH] D122613: [Driver] Make -moutline-atomics default for aarch64-fuchsia targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a963d3278c2: [Driver] Make -moutline-atomics default for aarch64-fuchsia targets (authored by mcgrathr). Repository: rG LLVM Github Monorepo CHA

[clang] 1a963d3 - [Driver] Make -moutline-atomics default for aarch64-fuchsia targets

Author: Roland McGrath Date: 2022-03-28T16:51:55-07:00 New Revision: 1a963d3278c2daab7e12125371442cd129c09954 URL: https://github.com/llvm/llvm-project/commit/1a963d3278c2daab7e12125371442cd129c09954 DIFF: https://github.com/llvm/llvm-project/commit/1a963d3278c2daab7e12125371442cd129c09954.diff

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rG2add3fbd976d: [misexpect] Re-implement MisExpect Diagnostics (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115907/new/ https://revi

[PATCH] D122513: [analyzer] Fix "RhsLoc and LhsLoc bitwidth must be same"

NoQ added a comment. `getSVal` is probably not at fault, it simply retrieves the value it was previously told to put there, it doesn't care what the value is. You probably want to look at `ExprEngine::VisitCast()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

tejohnson added a comment. In D115907#3412685 , @paulkirth wrote: > @tejohnson thanks for pointing me to the document. I knew it had something to > do w/ CC1 but missed that this was well documented. I was equally unaware of the documentation of this un

[PATCH] D122495: [clang][extract-api] Use correct language info from inputs

zixuw updated this revision to Diff 418724. zixuw marked an inline comment as done. zixuw added a comment. Address review issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122495/new/ https://reviews.llvm.org/D122495 Files: clang/include/cla

[PATCH] D122495: [clang][extract-api] Use correct language info from inputs

zixuw marked 2 inline comments as done. zixuw added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:312 - /// Get the language options used to parse the APIs. - const LangOptions &getLangOpts() const { return LangOpts; } + /// Get the language by the APIs.

[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

bnbarham marked 4 inline comments as done. bnbarham added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:273 - if (Status.getName() == Filename) { + if (!Status.IsVFSMapped) { // The name matches. Set the FileEntry. dexonsmith wrote: > An i

[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

bnbarham updated this revision to Diff 418721. bnbarham edited the summary of this revision. bnbarham added a comment. Rename `IsVFSMapped` as suggested by Duncan. Update comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122549/new/ https://r

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth added a comment. @tejohnson thanks for pointing me to the document. I knew it had something to do w/ CC1 but missed that this was well documented. Is there anything else that needs to be done, or do you think this is good to land again? Repository: rG LLVM Github Monorepo CHANGES

Re: [clang] abe997b - [CMake][Fuchsia] Switch to lld on Apple platforms

Neat! On Tue, Mar 22, 2022 at 1:07 AM Petr Hosek via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Petr Hosek > Date: 2022-03-22T01:06:30-07:00 > New Revision: abe997bb2dd61188784954ae866352740629985d > > URL: > https://github.com/llvm/llvm-project/commit/abe997bb2dd61188784954ae86

[PATCH] D120159: [Clang] Implement __builtin_source_location.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd61487490022: [Clang] Implement __builtin_source_location. (authored by jyknight). Changed prior to commit: https://reviews.llvm.org/D120159?vs=41

[clang] d614874 - [Clang] Implement __builtin_source_location.

Author: James Y Knight Date: 2022-03-28T18:29:02-04:00 New Revision: d61487490022aaacc34249475fac3e208c7d767e URL: https://github.com/llvm/llvm-project/commit/d61487490022aaacc34249475fac3e208c7d767e DIFF: https://github.com/llvm/llvm-project/commit/d61487490022aaacc34249475fac3e208c7d767e.diff

[PATCH] D122620: [clang][DR] Test and mark DR1479 as complete

zero9178 created this revision. zero9178 added a reviewer: clang-language-wg. Herald added a project: All. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. DR: http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#1479 Clang

[PATCH] D122343: Support ObjC Method call in enforce_tcb checks

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8048c7c42ff: [attributes] Generalize attribute 'enforce_tcb' to Objective-C methods. (authored by pdherbemont, committed by dergachev.a). Herald added a project: clang. Herald added a subscriber: cfe-com

[clang] c8048c7 - [attributes] Generalize attribute 'enforce_tcb' to Objective-C methods.

Author: Pierre d'Herbemont Date: 2022-03-28T15:08:47-07:00 New Revision: c8048c7c42ffd1731149b0abe15b9081dd27c789 URL: https://github.com/llvm/llvm-project/commit/c8048c7c42ffd1731149b0abe15b9081dd27c789 DIFF: https://github.com/llvm/llvm-project/commit/c8048c7c42ffd1731149b0abe15b9081dd27c789.

[PATCH] D122370: Split up large test files under clang/test/CodeGen/RISCV

4vtomat added a comment. In D122370#3412522 , @luismarques wrote: > What's the timeout value that is being exceeded? I guess it’s 60 seconds? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122370/new/ htt

[PATCH] D122535: [clang-tidy] Never consider assignments as equivalent in `misc-redundant-expression` check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM; can you add a release note when you land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122535/new/ https://reviews.llvm.org

[PATCH] D122544: Utilize comparison operation implemented in APInt

aaron.ballman added a comment. In D122544#3412568 , @SimplyDanny wrote: > In D122544#3411226 , @aaron.ballman > wrote: > >> LGTM! Can you also add a release note for the fix? >> >> I'm happy to land this on your

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

aaron.ballman added a comment. Can you also add a release note for the changes? Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7800 + attr::Kind, AttrKind) { + return llvm::any_of(Node.getAttrs(), + [&](const Attr *A) {

[PATCH] D122513: [analyzer] Fix "RhsLoc and LhsLoc bitwidth must be same"

vabridgers added a comment. Ahhh, gotcha. I'll run that down and report back. Thanks ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122513/new/ https://reviews.llvm.org/D122513 ___ cfe-commits mailing l

[PATCH] D122546: Let clang-repl link privately against Clang components

This revision was automatically updated to reflect the committed changes. Closed by commit rG1721d52a6206: Let clang-repl link privately against Clang components (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122546/new/ h

[clang] 1721d52 - Let clang-repl link privately against Clang components

Author: Aaron Puchert Date: 2022-03-28T23:53:53+02:00 New Revision: 1721d52a62067b8a5ceec58b417b2c73ad870b13 URL: https://github.com/llvm/llvm-project/commit/1721d52a62067b8a5ceec58b417b2c73ad870b13 DIFF: https://github.com/llvm/llvm-project/commit/1721d52a62067b8a5ceec58b417b2c73ad870b13.diff

[PATCH] D120662: [clang-offload-bundler] add -input/-output options

scchan updated this revision to Diff 418711. scchan added a comment. update the clang-offload-bundler-asserts-on test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120662/new/ https://reviews.llvm.org/D120662 Files: clang/lib/Driver/ToolChains/C

[PATCH] D122544: Utilize comparison operation implemented in APInt

SimplyDanny added a comment. In D122544#3411226 , @aaron.ballman wrote: > LGTM! Can you also add a release note for the fix? > > I'm happy to land this on your behalf if you'd prefer, but given that you've > had several quality commits already, you migh

[PATCH] D120956: [clang][AST matchers] new AST matcher argumentCountAsWrittenIs(n) that checks the actual number of arguments given in a function call

aaron.ballman added a comment. In addition to tests, please also add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120956/new/ https://reviews.llvm.org/D120956 ___ cfe-commits mailing lis

[PATCH] D120662: [clang-offload-bundler] add -input/-output options

scchan updated this revision to Diff 418710. scchan added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. fix lit test failures on Windows, rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120662/new/ https://review

[clang-tools-extra] ff60af9 - [clang-tidy] Utilize comparison operation implemented in APInt

Author: Danny Mösch Date: 2022-03-28T23:32:58+02:00 New Revision: ff60af91ac0bbab12dd5ff5dc9b78bc1636f2d86 URL: https://github.com/llvm/llvm-project/commit/ff60af91ac0bbab12dd5ff5dc9b78bc1636f2d86 DIFF: https://github.com/llvm/llvm-project/commit/ff60af91ac0bbab12dd5ff5dc9b78bc1636f2d86.diff L

[PATCH] D122544: Utilize comparison operation implemented in APInt

This revision was automatically updated to reflect the committed changes. Closed by commit rGff60af91ac0b: [clang-tidy] Utilize comparison operation implemented in APInt (authored by SimplyDanny). Changed prior to commit: https://reviews.llvm.org/D122544?vs=418450&id=418709#toc Repository: r

[PATCH] D122529: [ASTMatchers] Output currently matching node on crash

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122529/new/ https://reviews.llvm.org/D122529

[PATCH] D122548: [clang-format] Don't format qualifiers in PPDirective

This revision was automatically updated to reflect the committed changes. Closed by commit rGeee536dd3185: [clang-format] Don't format qualifiers in PPDirective (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122548/new/ https:/

[clang] eee536d - [clang-format] Don't format qualifiers in PPDirective

Author: owenca Date: 2022-03-28T14:28:14-07:00 New Revision: eee536dd31859058dba8a0d17d3b5f61d530d3bc URL: https://github.com/llvm/llvm-project/commit/eee536dd31859058dba8a0d17d3b5f61d530d3bc DIFF: https://github.com/llvm/llvm-project/commit/eee536dd31859058dba8a0d17d3b5f61d530d3bc.diff LOG: [

[PATCH] D122613: [Driver] Make -moutline-atomics default for aarch64-fuchsia targets

abrachet accepted this revision. abrachet added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Fuchsia.h:81 + bool IsAArch64OutlineAtomicsDefault( + const llvm::opt::ArgList &Args) const override { +return true;

[PATCH] D122370: Split up large test files under clang/test/CodeGen/RISCV

luismarques added a comment. What's the timeout value that is being exceeded? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122370/new/ https://reviews.llvm.org/D122370 ___ cfe-commits mailing list cfe-c

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:52-53 +def err_incompatible_fp_eval_method_options : Error< +"option 'ffp-eval-method' cannot be used with" +" %select{option 'fapprox-func'|option 'mreassociate'|option

[clang] d394f9f - Add HLSL Language Option and Preprocessor

Author: Chris Bieneman Date: 2022-03-28T16:16:17-05:00 New Revision: d394f9f8970d758cb39151328dd3040ba7f414ae URL: https://github.com/llvm/llvm-project/commit/d394f9f8970d758cb39151328dd3040ba7f414ae DIFF: https://github.com/llvm/llvm-project/commit/d394f9f8970d758cb39151328dd3040ba7f414ae.diff

[PATCH] D122087: Add HLSL Language Option and Preprocessor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd394f9f8970d: Add HLSL Language Option and Preprocessor (authored by beanz). Herald added subscribers: llvm-commits, hiraditya. Herald added a review

[PATCH] D122611: [clang][extract-api] Add support for macros

zixuw added a comment. Still going through the declaration fragments builder and `ExtractAPIVisitor/Consumer/Action` changes, but it seems that the patch needs a rebase onto the latest main right now as it's missing several already landed changes. Comment at: clang/include/c

[PATCH] D122613: [Driver] Make -moutline-atomics default for aarch64-fuchsia targets

mcgrathr created this revision. mcgrathr added reviewers: phosek, abrachet. Herald added a subscriber: kristof.beyls. Herald added a project: All. mcgrathr requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This makes Fuchsia consisten

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

dang added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:375 + case APIRecord::RK_ObjCIvar: +Kind["identifier"] = AddLangPrefix("ivar"); +Kind["displayName"] = "Instance Variable"; this should probably be more

[clang] 577827c - [flang][driver] Make --version and -version consistent with clang

Author: Emil Kieri Date: 2022-03-28T22:53:17+02:00 New Revision: 577827cbbf1033612d6ce15169f33ee5709abbfc URL: https://github.com/llvm/llvm-project/commit/577827cbbf1033612d6ce15169f33ee5709abbfc DIFF: https://github.com/llvm/llvm-project/commit/577827cbbf1033612d6ce15169f33ee5709abbfc.diff LO

[PATCH] D122542: [flang][driver] Make --version and -version consistent with clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ekieri marked an inline comment as done. Closed by commit rG577827cbbf10: [flang][driver] Make --version and -version consistent with clang (authored by ekieri). Repos

[PATCH] D122611: [clang][extract-api] Add support for macros

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To achieve this we hook into the preprocessor during the ExtractAPIAction

[PATCH] D122511: [clang][extract-api] Add Objective-C protocol support

dang added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:269 +// Collect symbol information. +StringRef Name = Decl->getName(); +StringRef USR = API.recordUSR(Decl); I think we should be recording this in StringAllocator =

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

dang added inline comments. Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:624-660 FunctionSignature DeclarationFragmentsBuilder::getFunctionSignature(const FunctionDecl *Func) { FunctionSignature Signature; for (const auto *Param : Func->parameters()) {

[PATCH] D122513: [analyzer] Fix "RhsLoc and LhsLoc bitwidth must be same"

NoQ added a comment. I mean, regardless of whether we need to report a warning or an error against this code, the AST says that the RHS type and the LHS type are the same. This means that the same should have applied to our SVals that represent LHS and RHS, rendering `std::max(APSIntType(LHSVal

[PATCH] D122547: [clang] Make Driver tests pass when running with temp dir containing "crt"

This revision was automatically updated to reflect the committed changes. Closed by commit rG67aea3b65cc5: [clang] Make Driver tests pass when running with temp dir containing "crt" (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] 67aea3b - [clang] Make Driver tests pass when running with temp dir containing "crt"

Author: Nico Weber Date: 2022-03-28T16:06:43-04:00 New Revision: 67aea3b65cc5417a06712a22a2dfb5f3f7f43eff URL: https://github.com/llvm/llvm-project/commit/67aea3b65cc5417a06712a22a2dfb5f3f7f43eff DIFF: https://github.com/llvm/llvm-project/commit/67aea3b65cc5417a06712a22a2dfb5f3f7f43eff.diff LO

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15208 - for (unsigned i = 0, e = E->getNumArgs(); i != e; i++) { -if (E->getArg(i)->getType()->isArrayType()) - Ops.push_back(EmitArrayToPointerDecay(E->getArg(i)).getPointer());

[PATCH] D122085: Add clang DirectX target support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5e54e275241: Add clang DirectX target support (authored by beanz). Herald added a subscriber: StephenFan. Repository: rG LLVM Github Monorepo CH

[clang] c5e54e2 - Add clang DirectX target support

Author: Chris Bieneman Date: 2022-03-28T15:00:50-05:00 New Revision: c5e54e275241f0575ed0c9fe5c8c65299dd0bd0f URL: https://github.com/llvm/llvm-project/commit/c5e54e275241f0575ed0c9fe5c8c65299dd0bd0f DIFF: https://github.com/llvm/llvm-project/commit/c5e54e275241f0575ed0c9fe5c8c65299dd0bd0f.diff

[PATCH] D122608: Fix behavior of ifuncs with 'used' extern "C" static functions

erichkeane updated this revision to Diff 418682. erichkeane marked an inline comment as done. erichkeane added a comment. Do the two comment fixups aaron suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122608/new/ https://reviews.llvm.org/D122608 Files: clang/lib/CodeGen/Cod

[PATCH] D122608: Fix behavior of ifuncs with 'used' extern "C" static functions

aaron.ballman added a reviewer: rjmccall. aaron.ballman added a subscriber: rjmccall. aaron.ballman added a comment. CodeGen is not my wheelhouse, so I've added @rjmccall in case he spots something I've missed. This seems reasonable to me though. Comment at: clang/lib/CodeGen/

[PATCH] D122378: [doc] Rely on tblgen to dump supported options value when generating doc

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122378/new/ https://reviews.llvm.org/D122378 ___ cfe

[PATCH] D122425: Pass -disable-llvm-passes to avoid running llvm passes

ahatanak added a comment. Sorry, I didn't notice you left a comment until after committing the patch. I agree that `-O1` can be removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122425/new/ https://reviews.llvm.org/D122425 __

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

efriedma added a comment. I'm a little skeptical about making TBAA more aggressive. In most situations, we're probably talking about tiny performance gains, and currently there's no good way to check whether a codebase suffers from type punning issues (either with compile-time analysis or runt

  1   2   3   >