MaskRay added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/AVR.cpp:477 if (!LinkStdlib) D.Diag(diag::warn_drv_avr_stdlib_not_linked); ---------------- benshi001 wrote: > We should not merge the above two `if`, due to this check. > > So I will keep my orginal form when committing. OK. If we decide that empty -mpu will report a warning, reporting an additional warn_drv_avr_stdlib_not_linked may or may not be necessary, but I'm happy to defer that decision to you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122524/new/ https://reviews.llvm.org/D122524 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits