[PATCH] D102555: [libclang] Enhance support for source-to-source rewriting

ggeorgakoudis added a comment. I'm not expert on this to review but I'm interested as a user. @samvv are you still working on this? Do you have any input from the community? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102555/new/ https://reviews

[PATCH] D120395: [X86] Prohibit arithmatic operations on type `__bfloat16`

pengfei added a comment. In D120395#3343799 , @andrew.w.kaylor wrote: > In D120395#3340953 , @craig.topper > wrote: > >> These intrinsics pre-date the existence of the bfloat type in LLVM. To use >> bfloat we h

[PATCH] D120503: [clang-format] Handle trailing comment for InsertBraces

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2340-2341 if (!L.InPPDirective) { Tok = getLastNonComment(L); -if (Tok) +if (Tok) { + Tok = L.Tokens.back().Tok; owenpan wrote: > HazardyK

[PATCH] D117090: [clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by an lvalue

This revision was automatically updated to reflect the committed changes. Closed by commit rG6cbf15e9b5ac: [clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by… (authored by Sockke). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang-tools-extra] 6cbf15e - [clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by an lvalue

Author: Sockke Date: 2022-02-25T14:53:11+08:00 New Revision: 6cbf15e9b5ac31887fda9a8fbbf7caa2dcbcf958 URL: https://github.com/llvm/llvm-project/commit/6cbf15e9b5ac31887fda9a8fbbf7caa2dcbcf958 DIFF: https://github.com/llvm/llvm-project/commit/6cbf15e9b5ac31887fda9a8fbbf7caa2dcbcf958.diff LOG: [

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

ChuanqiXu created this revision. ChuanqiXu added reviewers: jansvoboda11, sammccall, urnathan, Quuxplusone. ChuanqiXu added a project: clang. Herald added a subscriber: dang. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. This patch allows user to use C++20 mo

[PATCH] D118333: [RISCV] Use computeTargetABI from llc as well as clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e115b7d8811: [RISCV] Update computeTargetABI from llc as well as clang (authored by khchen). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. So, this is still approach #4, i.e. changing the types of expressions, which is not what GCC appears to be doing: https://godbolt.org/z/67hqeb37h. You need a custom emitter in IRGen for `_Float16`-typed arithmetic expressions. Comment at: clang/lib/

[PATCH] D120366: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2f501f39589: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments (authored by shangwuyao, committed by jlebar). Repository: rG LLV

[clang] c2f501f - [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

Author: Shangwu Yao Date: 2022-02-24T20:51:43-08:00 New Revision: c2f501f39589a59db9cebc839d0a63dcdc3c5c81 URL: https://github.com/llvm/llvm-project/commit/c2f501f39589a59db9cebc839d0a63dcdc3c5c81 DIFF: https://github.com/llvm/llvm-project/commit/c2f501f39589a59db9cebc839d0a63dcdc3c5c81.diff L

[PATCH] D120366: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. I'll land this for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120366/new/ https://reviews.llvm.org/D120366

[PATCH] D118700: Add support to --gcc-toolchain flag for GCC compiled with --enable-version-specific-runtime-libs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca80c2438697: [Driver] Support GCC detection for GCC compiled with --enable-version-specific… (authored by rpenacob, committed by MaskRay). Changed

[clang] ca80c24 - [Driver] Support GCC detection for GCC compiled with --enable-version-specific-runtime-libs

Author: Raúl Peñacoba Date: 2022-02-25T04:41:03Z New Revision: ca80c2438697dd10c60e11c07d68e3b784013b93 URL: https://github.com/llvm/llvm-project/commit/ca80c2438697dd10c60e11c07d68e3b784013b93 DIFF: https://github.com/llvm/llvm-project/commit/ca80c2438697dd10c60e11c07d68e3b784013b93.diff LOG:

[PATCH] D120445: [clang-format] Treat && followed by noexcept operator as a binary operator inside template arguments

penagos added a comment. I went ahead and did a git rebase but CI still appears to be failing (though tests pass in my local clone). Also, I’ll need someone to commit this on my behalf: - Luis Penagos - l...@penagos.co Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120456: [clang] Bump __cpp_constexpr in accordance with P2493R0

MarcusBoay added a comment. In D120456#3343348 , @cor3ntin wrote: > Thanks for the patch. However, wg21.link/P0848 need to be fully implemented > before we can update `__cpp_concepts`. Could you only modify > `__cpp_constexpr` ? Thanks Thanks for the

[PATCH] D120456: [clang] Bump __cpp_concepts and __cpp_constexpr in accordance with P2493R0

MarcusBoay updated this revision to Diff 411293. MarcusBoay added a comment. Revert __cpp_concepts since it is not fully implemented yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120456/new/ https://reviews.llvm.org/D120456 Files: clang/lib

[PATCH] D120132: [HIP] Fix HIP include path

yaxunl updated this revision to Diff 411290. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120132/new/ https://reviews.llvm.org/D120132 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/lib/Driver/ToolChains/CrossWindows.cpp c

[PATCH] D117090: [clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by an lvalue

Sockke updated this revision to Diff 411288. Sockke added a comment. rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117090/new/ https://reviews.llvm.org/D117090 Files: clang-tools-extra/clang-tidy/readability/NonConstParameterCheck.cpp clang-tools-extra/docs/ReleaseNotes.rs

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets updated this revision to Diff 411286. phyBrackets added a comment. Revised the changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489 Files: clang/docs/analyzer/checkers.rst clang/include

[PATCH] D120529: Disable broken hip test on Windows

shangwuyao added a comment. Seems like C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\lit-tmp-4x8dbzx6\\libbc-hipBundled-amdgcn-gfx1030-4b53df.a somehow got interpreted by filecheck regex as: C:UsersContainerAdministratorAppDataLocalTemp\\

[PATCH] D120529: Disable broken hip test on Windows

shangwuyao added a comment. See the comments in https://reviews.llvm.org/D120366, an example test failure is in https://reviews.llvm.org/harbormaster/build/224364/. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120529/new/ https://reviews.llvm.org

[PATCH] D120529: Disable broken hip test on Windows

shangwuyao created this revision. shangwuyao added reviewers: tra, jlebar, yaxunl. shangwuyao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Disable a hip test that's broken only for Windows at HEAD. Repository: rG LLVM Github Monorepo

[PATCH] D120527: [OpaquePtr][AArch64] Use elementtype on various intrinsics

aeubanks updated this revision to Diff 411274. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120527/new/ https://reviews.llvm.org/D120527 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/arm_acle.c c

[PATCH] D120366: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

shangwuyao added a comment. @yaxunl I saw that you added the test recently, could you provide some context? I think this test is broken at HEAD as I saw it is broken for other patches (see this build ) as well. Repository: rG LLVM Github M

[PATCH] D120445: [clang-format] Treat && followed by noexcept operator as a binary operator inside template arguments

penagos updated this revision to Diff 411272. penagos added a comment. Rebase to trigger CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120445/new/ https://reviews.llvm.org/D120445 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/

[PATCH] D120512: [clang-format] Fix requires related crash

owenpan added a comment. In D120512#3344027 , @curdeius wrote: > LGTM. But your test case is far from the reproduce in the issue report, so > please confirm with @owenpan. See here

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray updated this revision to Diff 411264. lichray added a comment. - Do not overwrite braced inits when forming AST - Explain why losing decltype(auto) as written in AST Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.

[clang] 0f8106b - [Driver][test] Make linux-ld.c work with CLANG_DEFAULT_PIE_ON_LINUX=on

Author: Fangrui Song Date: 2022-02-25T00:34:05Z New Revision: 0f8106baaf88fd9280cc25a3ccca7b2b3860161f URL: https://github.com/llvm/llvm-project/commit/0f8106baaf88fd9280cc25a3ccca7b2b3860161f DIFF: https://github.com/llvm/llvm-project/commit/0f8106baaf88fd9280cc25a3ccca7b2b3860161f.diff LOG:

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

craig.topper added a comment. Here's a fix that I tested on the original repreoduce. It detects that we picked one of the new register classes and tries to redirect back to the normal GPR register class if the GPR register class has the same width. I also checked for MVT::Other to use the GPR c

[PATCH] D120468: [clang][NFC] Move all avr CodeGen tests to avr specific directory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91c587b3b1d6: [clang][NFC] Move all avr CodeGen tests to avr specific directory (authored by benshi001). Repository: rG LLVM Github Monorepo CHAN

[clang] 91c587b - [clang][NFC] Move all avr CodeGen tests to avr specific directory

Author: Ben Shi Date: 2022-02-25T00:23:46Z New Revision: 91c587b3b1d6452da772109de6fb2938d1c11059 URL: https://github.com/llvm/llvm-project/commit/91c587b3b1d6452da772109de6fb2938d1c11059 DIFF: https://github.com/llvm/llvm-project/commit/91c587b3b1d6452da772109de6fb2938d1c11059.diff LOG: [clan

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c4ed02698af: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D120305?v

[PATCH] D120366: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

shangwuyao updated this revision to Diff 411258. shangwuyao added a comment. Disabling the test failing at HEAD with a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120366/new/ https://reviews.llvm.org/D120366 Files: clang/lib/Ba

[PATCH] D120503: [clang-format] Handle trailing comment for InsertBraces

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2340-2341 if (!L.InPPDirective) { Tok = getLastNonComment(L); -if (Tok) +if (Tok) { + Tok = L.Tokens.back().Tok; HazardyKnusperkeks wrote:

[PATCH] D102122: Support warn_unused_result on typedefs

dblaikie added a comment. I don't recall all the context, but did try discussing this with the committee folks and got a variety of strong opinions/wasn't sure whether there was a path forward: https://lists.isocpp.org/ext/2021/05/index.php#msg16554 (for those with access to that). What's your

[PATCH] D120503: [clang-format] Handle trailing comment for InsertBraces

owenpan updated this revision to Diff 411256. owenpan added a comment. - Simplified the code that backtracks to the token which the right braces are to be inserted after. - Added a missing newline in the new testcase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120503/new/ https://re

[PATCH] D120366: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

shangwuyao added a comment. In D120366#3344221 , @jlebar wrote: > - What's different in this patch vs the previous one? Previous patch broke at two different post-commit build configurations. The generated SPIR-V are: define hidden spir_kernel void @

[clang] 0ac6be6 - [Driver][test] Remove soon irrelevant pie tests

Author: Fangrui Song Date: 2022-02-25T00:04:07Z New Revision: 0ac6be6ab6b564327caeac417fe6d29044c7fe61 URL: https://github.com/llvm/llvm-project/commit/0ac6be6ab6b564327caeac417fe6d29044c7fe61 DIFF: https://github.com/llvm/llvm-project/commit/0ac6be6ab6b564327caeac417fe6d29044c7fe61.diff LOG:

[clang] deee339 - [Driver][test] Make hexagon-toolchain-elf.c work with CLANG_DEFAULT_PIE_ON_LINUX=on

Author: Fangrui Song Date: 2022-02-24T23:53:38Z New Revision: deee339796ccffc267d4e1846f4b8203f3f1a485 URL: https://github.com/llvm/llvm-project/commit/deee339796ccffc267d4e1846f4b8203f3f1a485 DIFF: https://github.com/llvm/llvm-project/commit/deee339796ccffc267d4e1846f4b8203f3f1a485.diff LOG:

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. I'll test both CLANG_DEFAULT_PIE_ON_LINUX=on and CLANG_DEFAULT_PIE_ON_LINUX=off, and then push. This is long undue. I did not change the default when CLANG_DEFAULT_PIE_ON_LINUX was added to avoid changes to release/14.x. Repository: rG LLVM Github Monorepo CHANGES S

[clang] da04744 - [clang][test] Make mips-vector-return.c work with CLANG_DEFAULT_PIE_ON_LINUX=on

Author: Fangrui Song Date: 2022-02-24T15:25:35-08:00 New Revision: da047445f77bfd74b04c36169e104f35dbfff84e URL: https://github.com/llvm/llvm-project/commit/da047445f77bfd74b04c36169e104f35dbfff84e DIFF: https://github.com/llvm/llvm-project/commit/da047445f77bfd74b04c36169e104f35dbfff84e.diff

[PATCH] D120366: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

jlebar added a comment. - What's different in this patch vs the previous one? - *Disabled a hip test on Windows that's breaking on head.* Can you clarify: Is this test broken at HEAD, or does it break with your patch? If it's broken at HEAD, then it should be disabled in a separate patch. I

[PATCH] D120366: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

shangwuyao updated this revision to Diff 411241. shangwuyao added a comment. Disabled a hip test on Windows that's breaking on head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120366/new/ https://reviews.llvm.org/D120366 Files: clang/lib/Basi

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

thesamesam accepted this revision. thesamesam added a comment. This revision is now accepted and ready to land. Been running with this for some time now (before we added the option). We should address the tests but they look sorted now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D120372: [clang] 'unused-but-set-variable' warning should not apply to __attribute__((objc_precise_lifetime) Objective-C pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb682616d1fd1: Clang `unused-but-set-variable` warnings should not apply to `__attribute__… (authored by mwyman). Repository: rG LLVM Github Monore

[clang] b682616 - Clang `unused-but-set-variable` warnings should not apply to `__attribute__((objc_precise_lifetime))` Objective-C pointers

Author: Michael Wyman Date: 2022-02-24T14:26:05-08:00 New Revision: b682616d1fd1263b303985b9f930c1760033af2c URL: https://github.com/llvm/llvm-project/commit/b682616d1fd1263b303985b9f930c1760033af2c DIFF: https://github.com/llvm/llvm-project/commit/b682616d1fd1263b303985b9f930c1760033af2c.diff

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#3344107 , @fhahn wrote: > In D109239#3340872 , @zahiraam > wrote: > >> @fhahn I think the last commit fixes the issue. I am currently testing it on >> MacOS 10.14 and it is

[PATCH] D120511: [clang-format] Allow to set token types final

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatToken.h:379 + void setFinalizedType(TokenType T) { +Type = T; +TypeIsFinalized = true; curdeius wrote: > Maybe we should assert here and in `setType` that: > `assert(!TypeIsFin

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

fhahn added a comment. In D109239#3340872 , @zahiraam wrote: > @fhahn I think the last commit fixes the issue. I am currently testing it on > MacOS 10.14 and it is still going (slow remote machine). I would like to get > your permission to push this pa

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

NoQ added a comment. > Oh wait, should we accept this given this serious limitation? This check lands as alpha so it's fine. We know what to do to move it out of alpha; it's somewhat difficult but definitely not impossible, so there's a way forward with this, and the code added by this patch is

[PATCH] D120511: [clang-format] Allow to set token types final

curdeius accepted this revision. curdeius added a subscriber: krasimir. curdeius added a comment. This revision is now accepted and ready to land. Great! @krasimir, FYI, that should fix the issue you reported. Comment at: clang/lib/Format/FormatToken.h:379 + void setFinalizedT

[PATCH] D120512: [clang-format] Fix requires related crash

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. But your test case is far from the reproduce in the issue report, so please confirm with @owenpan. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D120426: [Sema] Mark the referenced destructor during transformation of a `CXXBindTemporaryExpr`

akyrtzi updated this revision to Diff 411219. akyrtzi added a comment. Add a target triple to the test, so it can pass on windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120426/new/ https://reviews.llvm.org/D120426 Files: clang/lib/Sema/T

[PATCH] D119061: [Clang] noinline call site attribute

aaron.ballman added a comment. Precommit CI seems to be failing with relevant failures: Failed Tests (2): Clang :: Parser/stmt-attributes.c Clang :: Sema/attr-noinline.c Comment at: clang/include/clang/Basic/Attr.td:1764 +def NoInline : DeclOrStmtAttr { + let Spelli

[PATCH] D120510: [clang][dataflow] Add limits to size of modeled data structures in environment.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG208c25fcbf48: [clang][dataflow] Add limits to size of modeled data structures in environment. (authored by ymandel). Repository: rG LLVM Github Mo

[clang] 208c25f - [clang][dataflow] Add limits to size of modeled data structures in environment.

Author: Yitzhak Mandelbaum Date: 2022-02-24T20:51:59Z New Revision: 208c25fcbf483b4dd61fb8b99f8422994cc5072e URL: https://github.com/llvm/llvm-project/commit/208c25fcbf483b4dd61fb8b99f8422994cc5072e DIFF: https://github.com/llvm/llvm-project/commit/208c25fcbf483b4dd61fb8b99f8422994cc5072e.diff

[PATCH] D120503: [clang-format] Handle trailing comment for InsertBraces

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2340-2341 if (!L.InPPDirective) { Tok = getLastNonComment(L); -if (Tok) +if (Tok) { + Tok = L.Tokens.back().Tok; So basically o

[clang] df00a99 - Fix typo in file name; NFC

Author: Aaron Ballman Date: 2022-02-24T15:41:25-05:00 New Revision: df00a995f98e6c30b655757287e896e8a202c3ab URL: https://github.com/llvm/llvm-project/commit/df00a995f98e6c30b655757287e896e8a202c3ab DIFF: https://github.com/llvm/llvm-project/commit/df00a995f98e6c30b655757287e896e8a202c3ab.diff

[PATCH] D120510: [clang][dataflow] Add limits to size of modeled data structures in environment.

ymandel added a comment. In D120510#3343935 , @xazax.hun wrote: >> Very large structs still ground the analysis to a halt. > > I had similar experience in the past with analyses that tried to represent > all values in structs eagerly. > > I think a bette

[PATCH] D120512: [clang-format] Fix requires related crash

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the pre

[clang] 2ceee2f - Add -Wno-strict-prototypes to C tests; NFC

Author: Aaron Ballman Date: 2022-02-24T15:30:30-05:00 New Revision: 2ceee2f8843f31fb6dab9f133e9b248b2eaa713a URL: https://github.com/llvm/llvm-project/commit/2ceee2f8843f31fb6dab9f133e9b248b2eaa713a DIFF: https://github.com/llvm/llvm-project/commit/2ceee2f8843f31fb6dab9f133e9b248b2eaa713a.diff

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks added a comment. In D113319#3339801 , @curdeius wrote: > Yep, confirmed, but I don't know how to fix it. > Just removing `TT_BinaryOperator` from `resetTokenMetadata` provokes these > failures: > > [ FAILED ] FormatTest.Concepts >

[PATCH] D120511: [clang-format] Allow to set token types final

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We have a

[clang] 1c25580 - Use functions with prototypes when appropriate; NFC

Author: Aaron Ballman Date: 2022-02-24T15:30:13-05:00 New Revision: 1c2558021c155878c305701e11e3714cb521f599 URL: https://github.com/llvm/llvm-project/commit/1c2558021c155878c305701e11e3714cb521f599 DIFF: https://github.com/llvm/llvm-project/commit/1c2558021c155878c305701e11e3714cb521f599.diff

[PATCH] D120510: [clang][dataflow] Add limits to size of modeled data structures in environment.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. > Very large structs still ground the analysis to a halt. I had similar experience in the past with analyses that tried to represent all values in structs eagerly. I think a better appr

[PATCH] D120495: [clang][dataflow] Add transfer functions for structured bindings

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:80 +/// +/// FIXME: Consider adding support for structured bindings to the CFG builder. +class DecompositionVisitor : public ConstStmtVisitor { Did you look into how hard w

[PATCH] D120289: [clang][dataflow] Add SAT solver interface and implementation

xazax.hun accepted this revision. xazax.hun added a comment. Overall, looks good to me. Some nits inline. Are there plans to get a model/assignment of the variables from the solver? That could be helpful for generating warning messages in the future :) Comment at: clang/inclu

[PATCH] D120503: [clang-format] Handle trailing comment for InsertBraces

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120503/new/ https://reviews.llvm.org/D120503 __

[PATCH] D120510: [clang][dataflow] Add limits to size of modeled data structures in environment.

ymandel created this revision. ymandel added reviewers: sgatev, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. ymandel requested review of this revision. Herald added a project: clang. Adds two new parameters to control the size of data structures modeled in the en

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

cor3ntin added a comment. > The issue is that for its own tests, libc++ headers are not considered system > headers. we should fix libc++. I can do that later today. I though > @Quuxplusone did. Patch here https://reviews.llvm.org/D120509 - I'm still running the test locally to double check

[PATCH] D105297: [OPENMP]Fix PR50347: Mapping of global scope deep object fails.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG638938117aea: [OPENMP]Fix PR50347: Mapping of global scope deep ob

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets added a comment. @steakhal would you just help, where in the file and what exactly write to in the documentation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489 _

[PATCH] D120132: [HIP] Fix HIP include path

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:486 -void RocmInstallationDetector::AddHIPIncludeArgs(const ArgList &DriverArgs, - ArgStringList &CC1Args) const { +std::string RocmInstallationDetecto

[PATCH] D120395: [X86] Prohibit arithmatic operations on type `__bfloat16`

andrew.w.kaylor added a comment. In D120395#3340953 , @craig.topper wrote: > These intrinsics pre-date the existence of the bfloat type in LLVM. To use > bfloat we have to make __bf16 a legal type in C. This means we need to > support loads, stores, an

[PATCH] D120499: [NVPTX] Fix nvvm.match.sync*.i64 intrinsics return type (i64 -> i32)

tra added a comment. Good catch. Thank you for the fix. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:477 TARGET_BUILTIN(__nvvm_match_any_sync_i32, "UiUiUi", "", PTX60) -TARGET_BUILTIN(__nvvm_match_any_sync_i64, "WiUiWi", "", PTX60) +TARGET_BUILTIN(__nvvm_match_any_s

[PATCH] D119816: [SanitizerBounds] Add support for NoSanitizeBounds function

ztong0001 updated this revision to Diff 411191. ztong0001 added a comment. Thank you, Marco! I have made the following changes: - extend clang/test/CodeGen/bounds-checking.c to include additional test for newly added nosanitize_bounds attribute - added a new pure IR test in llvm/test/Instrument

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. Oh wait, should we accept this given this serious limitation? Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:475-479 +def CStringUninitiali

Re: [PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

I thought I caught all of them, too! I encourage someone with commit rights to land the missing five characters "std::" right now, and/or I'll be able to take my own look in about 6 hours from now. Arthur On Thu, Feb 24, 2022, 2:06 PM Corentin Jabot via Phabricator < revi...@reviews.llvm.org> wr

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

cor3ntin added a comment. In D119670#3343726 , @erichkeane wrote: > In D119670#3343718 , @rnk wrote: > >> This broke our libc++ -Werror build: >> >> llvm-project/libcxx/src/filesystem/directory_iterator.cpp:107

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

erichkeane added a comment. In D119670#3343718 , @rnk wrote: > This broke our libc++ -Werror build: > > llvm-project/libcxx/src/filesystem/directory_iterator.cpp:107:57: error: > unqualified call to std::move [-Werror,-Wunqualified-std-cast-call] >

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

krisb added a comment. In D113743#3343481 , @dblaikie wrote: > In D113743#3177437 , @krisb wrote: > >> In D113743#3175301 , @dblaikie >> wrote: >> >>> Not super surprisin

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

rnk added a comment. This broke our libc++ -Werror build: llvm-project/libcxx/src/filesystem/directory_iterator.cpp:107:57: error: unqualified call to std::move [-Werror,-Wunqualified-std-cast-call] __root_(move(other.__root_)),

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

NoQ added a comment. Also I think we might be able to enable this checker for the situation when the buffer is *completely* uninitialized. It is relatively easy for `RegionStore` to answer whether there are any bindings in a top-level region. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D120426: [Sema] Mark the referenced destructor during transformation of a `CXXBindTemporaryExpr`

akyrtzi updated this revision to Diff 411186. akyrtzi added a comment. Move the `const_cast` to the call site. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120426/new/ https://reviews.llvm.org/D120426 Files: clang/lib/Sema/TreeTransform.h cla

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

NoQ added a comment. I removed the [NFCi] marker because this commit does introduce functional change (a new checker). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489

[PATCH] D120489: [analyzer][NFCi] Done some changes to detect Uninitialized read by the char array manipulation functions

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. This looks like a good check to ultimately have but we probably won't be able to move it out of alpha until the extents issue is fixed (which is going to be a fairly intrusive fix). =

[PATCH] D120426: [Sema] Mark the referenced destructor during transformation of a `CXXBindTemporaryExpr`

akyrtzi updated this revision to Diff 411185. akyrtzi added a comment. Make sure to check the destructor decl pointer for nil before passing to `Sema::MarkFunctionReferenced()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120426/new/ https://revi

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

yonghong-song added a comment. @aaron.ballman ping, did you get time to look at this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120296/new/ https://reviews.llvm.org/D120296 ___ cfe-commits mai

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

yonghong-song updated this revision to Diff 411182. yonghong-song added a comment. fix clang-format issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120296/new/ https://reviews.llvm.org/D120296 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno'.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. The patch looks great to me now. As soon as you address comments about `isErrnoAvailable()` (at least, the parameter can now be removed), I think you can commit. Repository: rG LLVM Github Monor

[PATCH] D120504: [AST] RAV doesn't traverse explicitly instantiated function bodies by default

sammccall added a comment. @davidxl does the one-line CodeGenPGO change look reasonable? If you're not the person to ask, could you recommend someone? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120504/new/ https://reviews.llvm.org/D1205

[PATCH] D120504: [AST] RAV doesn't traverse explicitly instantiated function bodies by default

sammccall created this revision. sammccall added reviewers: hokein, davidxl. Herald added subscribers: wenlei, usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. This is consistent wit

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam updated this revision to Diff 411177. zahiraam set the repository for this revision to rG LLVM Github Monorepo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 Files: clang/docs/LanguageExtension

[PATCH] D120503: [clang-format] Handle trailing comment for InsertBraces

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo http

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

DiggerLin updated this revision to Diff 411172. DiggerLin marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119147/new/ https://reviews.llvm.org/D119147 Files: clang/include/clang/Driver/Job.h clang/lib/Driver/Job.c

[PATCH] D120468: [clang][NFC] Move all avr CodeGen tests to avr specific directory

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120468/new/ https://reviews.llvm.org/D120468

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

MaskRay added inline comments. Comment at: clang/test/Driver/aix-ld.c:609 +// Check powerpc-ibm-aix7.1.0.0, 32-bit. -shared (with exp option strings in other opt). +// RUN: %clangxx -x c++ -no-canonical-prefixes %s 2>&1 -### \ +// RUN:-resource-dir=%S/Inputs/resource_dir

[clang] ecff9b6 - [analyzer] Just use default capture after 7fd60ee6e0a87957a718297a4a42d9881fc561e3

Author: Fangrui Song Date: 2022-02-24T10:06:11-08:00 New Revision: ecff9b65b54c7a4bd79ca2af157c81595678f0ee URL: https://github.com/llvm/llvm-project/commit/ecff9b65b54c7a4bd79ca2af157c81595678f0ee DIFF: https://github.com/llvm/llvm-project/commit/ecff9b65b54c7a4bd79ca2af157c81595678f0ee.diff

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

DiggerLin marked 6 inline comments as done. DiggerLin added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:80 +static bool hasExportListLinkerOpts(const ArgStringList &CmdArgs) { + for (size_t i = 0; i < CmdArgs.size(); ++i) { +llvm::StringRef ArgString(Cmd

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn added a comment. In D118259#3275297 , @fhahn wrote: > Does this clang test actually need to check the generated assembly? Shouldn't > it be enough to check that the correct intrinsics are generated? I could remove the CHECK-ASM checks, but th

  1   2   >