xazax.hun added inline comments.

================
Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:80
+///
+/// FIXME: Consider adding support for structured bindings to the CFG builder.
+class DecompositionVisitor : public ConstStmtVisitor<DecompositionVisitor> {
----------------
Did you look into how hard would it be to add structured bindings to the CFG 
builder? If the effort is comparable to this patch (and not significantly 
bigger), it might be better to do that work instead of spending effort on some 
temporary workaround. What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120495/new/

https://reviews.llvm.org/D120495

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D120495: [clang][d... Stanislav Gatev via Phabricator via cfe-commits
    • [PATCH] D120495: [cla... Gábor Horváth via Phabricator via cfe-commits

Reply via email to