NoQ added a comment.
> Oh wait, should we accept this given this serious limitation?
This check lands as alpha so it's fine. We know what to do to move it out of
alpha; it's somewhat difficult but definitely not impossible, so there's a way
forward with this, and the code added by this patch is ultimately correct.
================
Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:601
+ if (ExplodedNode *N = C.generateErrorNode(State)) {
+ State->dump();
+ const char *Msg =
----------------
Yeah, dumps need to be removed from the final code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120489/new/
https://reviews.llvm.org/D120489
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
