[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-22 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz added a comment. Thanks for the review. Are you able to commit for me? Salman Javed Thank you very much. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112356/new/ https://reviews.llvm.org/D112356

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-22 Thread Kazu Hirata via Phabricator via cfe-commits
kazu accepted this revision. kazu added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing the docs! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112356/new/ https://reviews.llvm.org/D112356 _

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-22 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz updated this revision to Diff 381710. salman-javed-nz added a comment. Pre-merge checks failing because patch cannot be applied. Therefore recreating patch to fix this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112356/new/ https

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-22 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz added a comment. A collection of minor corrections that I don't think deserve separate commits. It shouldn't take much congitive load to remove it all as one patch. But I have used Phabricator's "Update Revision" feature to break out the change into smaller chunks anyway. Repos

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-22 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz updated this revision to Diff 381707. salman-javed-nz added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Fix spelling and grammatical mistakes found across the .rst files. // end of patch Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-22 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz updated this revision to Diff 381706. salman-javed-nz added a comment. Standardize to US English spelling for words such as "behavior" and "specialization". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112356/new/ https://reviews.

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-22 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz updated this revision to Diff 381704. salman-javed-nz added a comment. Herald added a reviewer: lebedev.ri. Herald added a subscriber: lebedev.ri. Remove repeated words, e.g. "for a a larger user input". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-22 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz updated this revision to Diff 381703. salman-javed-nz added a comment. Standardize spelling of "e.g." and "i.e." Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112356/new/ https://reviews.llvm.org/D112356 Files: clang-tools-extra

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-22 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz updated this revision to Diff 381702. salman-javed-nz added a comment. Herald added subscribers: kbarton, nemanjai. Replace curly quote characters (‘ ’ “ ”) with standard straight ones (' "). Replace en-dash (`–`) with standard hyphen (`-`). In both cases, the latter is used more o

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-22 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz updated this revision to Diff 381701. salman-javed-nz added a comment. Herald added a subscriber: arphaman. Change double spaces after commas and periods to single space. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112356/new/ htt

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-22 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz created this revision. salman-javed-nz added reviewers: aaron.ballman, whisperity, kazu. salman-javed-nz added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, rnkovacs. salman-javed-nz requested review of this revision. - Fix spelling and grammatical mistakes

[PATCH] D109977: LLVM Driver Multicall tool

2021-10-22 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. @beanz Is this ready to land or do you plan on making any more changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109977/new/ https://reviews.llvm.org/D109977 ___ cfe-commits

[PATCH] D112353: [bazel] fixes for windows build

2021-10-22 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen created this revision. ychen added a reviewer: GMNGeoffrey. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Giving Bazel a try on Win10 by following the README. It needs these fixes to build through. Think that I should sent it

[PATCH] D109632: [clang] de-duplicate methods from AST files

2021-10-22 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added a comment. We are targeting the use case where in impl.m we have @import ImmediateDep1; @import ImmediateDep2; ... @import ImmediateDepN; and each of ImmediateDep has `@import SharedDep;`. For simplicity we'll consider that we are working with a single selector as each of

[PATCH] D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive

2021-10-22 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added a comment. Good point. I did not find that. At this point, I don't know if we need this change. I checked gnu, gnu allow this :-( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112292/new/ https://reviews.llvm.org/D112292 ___

[PATCH] D112334: [clang-tidy] Suppress readability-static-access-through-instance for CUDA built-in variables

2021-10-22 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp updated this revision to Diff 381644. carlosgalvezp added a comment. Replace search with StringRef::contains. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112334/new/ https://reviews.llvm.org/D112334 Files: clang-tools-extra/clang-tidy/readability/StaticAccessedThroug

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

2021-10-22 Thread Bruno De Fraine via Phabricator via cfe-commits
brunodf updated this revision to Diff 381639. brunodf marked 3 inline comments as done. brunodf added a comment. I'm adding a new patch to (partially) address the comments from @rnk. An ObjC test case was included in the commit from @akyrtzi, I've updated it to also cover the case of a unary ope

[PATCH] D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive

2021-10-22 Thread Deepak Eachempati via Phabricator via cfe-commits
dreachem added a comment. There still exists a restriction that the loop variable must not be threadprivate in OpenMP 5.1. See Canonical Loop Nest restrictions, p125, line 7: > The loop iteration variable may not appear in a threadprivate directive. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

2021-10-22 Thread Roger Ferrer Ibanez via Phabricator via cfe-commits
rogfer01 added a comment. Looks good to me too. Thanks a lot @craig.topper ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112102/new/ https://reviews.llvm.org/D112102 ___ cfe-commits mailing list cfe-co

[PATCH] D112280: Support: Use Expected::moveInto() in a few places

2021-10-22 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2410fb4616b2: Support: Use Expected::moveInto() in a few places (authored by dexonsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] 2410fb4 - Support: Use Expected::moveInto() in a few places

2021-10-22 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2021-10-22T12:40:10-07:00 New Revision: 2410fb4616b2c08bbaddd44e6c11da8285fbd1d3 URL: https://github.com/llvm/llvm-project/commit/2410fb4616b2c08bbaddd44e6c11da8285fbd1d3 DIFF: https://github.com/llvm/llvm-project/commit/2410fb4616b2c08bbaddd44e6c11da8285fb

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

2021-10-22 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. LGTM, then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108482/new/ https://reviews.llvm.org/D108482 ___ cfe-commits mailing list cfe-commits@

[libunwind] e6f39c8 - [libunwind] Fix path to libunwind for per-target-runtime-dir builds

2021-10-22 Thread Louis Dionne via cfe-commits
Author: Louis Dionne Date: 2021-10-22T14:36:14-04:00 New Revision: e6f39c8b4891242c0d0d8e7a78041614d9bcdefc URL: https://github.com/llvm/llvm-project/commit/e6f39c8b4891242c0d0d8e7a78041614d9bcdefc DIFF: https://github.com/llvm/llvm-project/commit/e6f39c8b4891242c0d0d8e7a78041614d9bcdefc.diff

[PATCH] D109128: [VFS] Use original path when falling back to external FS

2021-10-22 Thread Keith Smiley via Phabricator via cfe-commits
keith added inline comments. Comment at: llvm/unittests/Support/VirtualFileSystemTest.cpp:1738 + +TEST_F(VFSFromYAMLTest, RelativePathHitWithoutCWD) { + IntrusiveRefCntPtr BaseFS( So this test case is actually failing. The difference between it and the others i

[PATCH] D112336: [Serialization] Fix a uniqueness check

2021-10-22 Thread Kazu Hirata via Phabricator via cfe-commits
kazu created this revision. kazu added a reviewer: rsmith. kazu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The function is intended to maintain uniqueness of two sets -- Found and Data. Now, we can reach the for loop shown in the patc

[PATCH] D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive

2021-10-22 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 updated this revision to Diff 381604. jyu2 added a comment. fix format problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112292/new/ https://reviews.llvm.org/D112292 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/distribute_p

[PATCH] D112334: [clang-tidy] Suppress readability-static-access-through-instance for CUDA built-in variables

2021-10-22 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp added a comment. Btw, regarding this `CHECK-MESSAGES-NOT`, how does it work? I can't find it in `check_clang_tidy.py`. Wouldn't the test fail anyway if unexpected warnings are printed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D109128: [VFS] Use original path when falling back to external FS

2021-10-22 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1179-1180 + if (ExternalFS) +ExternalFS->setCurrentWorkingDirectory(Path); + keith wrote: > dexonsmith wrote: > > keith wrote: > > > JDevlieghere wrote: > > > > I'm pretty

[PATCH] D112334: [clang-tidy] Suppress readability-static-access-through-instance for CUDA built-in variables

2021-10-22 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp created this revision. carlosgalvezp added a project: clang-tools-extra. Herald added subscribers: xazax.hun, yaxunl. carlosgalvezp requested review of this revision. clang-tidy can be used to statically analyze CUDA code, thanks to clang being able to compile CUDA code natively. Thi

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

2021-10-22 Thread Bjorn Pettersson via Phabricator via cfe-commits
bjope added a comment. I actually see lots of these as well: clang: ../lib/Support/APInt.cpp:284: int llvm::APInt::compareSigned(const llvm::APInt &) const: Assertion `BitWidth == RHS.BitWidth && "Bit widths must be same for comparison"' failed. Although I haven't verified if those are relat

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

2021-10-22 Thread Bjorn Pettersson via Phabricator via cfe-commits
bjope added a comment. I get failures after having merged this patch: /llvm/build-all/bin/clang -Xanalyzer -analyzer-output=text -Xanalyzer -analyzer-checker='nullability,optin.portability.UnixAPI,security,valist' -Xanalyzer -analyzer-disable-checker='security.insecureAPI.strcpy' --analyze c

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

2021-10-22 Thread Jason Rice via Phabricator via cfe-commits
ricejasonf added a comment. Can this be accepted if there are no other issues? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108482/new/ https://reviews.llvm.org/D108482 ___ cfe-commits mailing list cfe-

[PATCH] D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive

2021-10-22 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added a comment. In D112292#3080945 , @lebedev.ri wrote: > In which standard version was that rule introduced, is this missing some > checks for the OpenMP version? I check back to omp 45, the rule was there. CHANGES SINCE LAST ACTION https://

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

2021-10-22 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov added a comment. @martong Thanks for your inlines. I'll update the patch. Comment at: clang/unittests/StaticAnalyzer/RangeSetTest.cpp:81 const llvm::APSInt &from(BaseType X) { -llvm::APSInt Dummy = Base; -Dummy = X; -return BVF.getValue(Dummy); +

[PATCH] D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive

2021-10-22 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In which standard version was that rule introduced, is this missing some checks for the OpenMP version? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112292/new/ https://reviews.llvm.org/D112292 ___ cfe-commits ma

[PATCH] D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive

2021-10-22 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit. Comment at: clang/lib/Sema/SemaOpenMP.cpp:8658 !isOpenMPSimdDirective(DKind) && DVar.CKind != OMPC_unknown && + DVar.CKind != OMP

[PATCH] D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive

2021-10-22 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:8653 ? (DSAStack->hasMutipleLoops() ? OMPC_lastprivate : OMPC_linear) -: OMPC_private; -if (((isOpenMPSimdDirective(DKind) && DVar.CKind != OMPC_unknown && -

[PATCH] D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive

2021-10-22 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 updated this revision to Diff 381564. jyu2 edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112292/new/ https://reviews.llvm.org/D112292 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/distribute_parallel_for_simd_loop_messages.cpp clan

[PATCH] D111654: [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

2021-10-22 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov updated this revision to Diff 381562. ASDenysPetrov added a comment. Improved. Rebased on top of D107339 . @martong kind ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111654/new/ https://reviews.llvm.org/D111654 Files: clang/inclu

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

2021-10-22 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. It looks good to me. Wait for others' opinions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112102/new/ https://reviews.llvm.org/D112102 ___ cfe-commits mailing list cfe-comm

[PATCH] D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive

2021-10-22 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:8653 ? (DSAStack->hasMutipleLoops() ? OMPC_lastprivate : OMPC_linear) -: OMPC_private; -if (((isOpenMPSimdDirective(DKind) && DVar.CKind != OMPC_unknown && -

[PATCH] D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive

2021-10-22 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:8653 ? (DSAStack->hasMutipleLoops() ? OMPC_lastprivate : OMPC_linear) -: OMPC_private; -if (((isOpenMPSimdDirective(DKind) && DVar.CKind != OMPC_unknown && -

[PATCH] D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive

2021-10-22 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:8653 ? (DSAStack->hasMutipleLoops() ? OMPC_lastprivate : OMPC_linear) -: OMPC_private; -if (((isOpenMPSimdDirective(DKind) && DVar.CKind != OMPC_unknown && -

[PATCH] D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive

2021-10-22 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added a comment. Hi Alexey, Thanks for review. Comment at: clang/lib/Sema/SemaOpenMP.cpp:8653 ? (DSAStack->hasMutipleLoops() ? OMPC_lastprivate : OMPC_linear) -: OMPC_private; -if (((isOpenMPSimdDirective(DKind) && DVar.CKind != OM

[PATCH] D98895: [X86][clang] Disable long double type for -mno-x87 option

2021-10-22 Thread Andrew Savonichev via Phabricator via cfe-commits
asavonic updated this revision to Diff 381538. asavonic retitled this revision from "[X86][Draft] Disable long double type for -mno-x87 option" to "[X86][clang] Disable long double type for -mno-x87 option". asavonic edited the summary of this revision. asavonic added a comment. Herald added a rev

[PATCH] D111642: [Analyzer][solver] Simplification: reorganize equalities with adjustment

2021-10-22 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. In D111642#3059467 , @steakhal wrote: > The coverage report of the test shows that L2124 is uncovered. Please add a > test demonstrating that path as well. I've added such a test, thanks for the notice! Comme

[PATCH] D111642: [Analyzer][solver] Simplification: reorganize equalities with adjustment

2021-10-22 Thread Gabor Marton via Phabricator via cfe-commits
martong updated this revision to Diff 381536. martong added a comment. - Add a test to cover `if (OldState == State)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111642/new/ https://reviews.llvm.org/D111642 Files: clang/lib/StaticAnalyzer/Core

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

2021-10-22 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov updated this revision to Diff 381533. ASDenysPetrov added a comment. Fixed test unpassing in `array-struct-region.c`. Added examples in comments according to suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107339/new/ https://reviews.llvm.org/D107339 Files:

[PATCH] D112299: Replace references to Makefile.sphinx

2021-10-22 Thread Sylvestre Ledru via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd5e3f36f218: Replace references to Makefile.sphinx (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] fd5e3f3 - Replace references to Makefile.sphinx

2021-10-22 Thread Sylvestre Ledru via cfe-commits
Author: Sylvestre Ledru Date: 2021-10-22T15:32:12+02:00 New Revision: fd5e3f36f2186855966978c0e11b716277eee387 URL: https://github.com/llvm/llvm-project/commit/fd5e3f36f2186855966978c0e11b716277eee387 DIFF: https://github.com/llvm/llvm-project/commit/fd5e3f36f2186855966978c0e11b716277eee387.dif

[PATCH] D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive

2021-10-22 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:8653 ? (DSAStack->hasMutipleLoops() ? OMPC_lastprivate : OMPC_linear) -: OMPC_private; -if (((isOpenMPSimdDirective(DKind) && DVar.CKind != OMPC_unknown && -

[PATCH] D111642: [Analyzer][solver] Simplification: reorganize equalities with adjustment

2021-10-22 Thread Gabor Marton via Phabricator via cfe-commits
martong updated this revision to Diff 381520. martong marked 3 inline comments as done. martong added a comment. - Add comment about intersection in the test file - Add check in the feasible case in the test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D112299: Replace references to Makefile.sphinx

2021-10-22 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112299/new/ https://reviews.llvm.org/D112299

[PATCH] D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

2021-10-22 Thread Kiran Chandramohan via Phabricator via cfe-commits
kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. LGTM. My preference is the following one. If you agree then please make the change, otherwise, you can keep it as is. Also, wait a couple of days to see whether others h

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

2021-10-22 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. In D106102#3080339 , @manas wrote: > I have received a failed build on clang-ppc64be-linux > (https://lab.llvm.org/buildbot/#/builders/52/builds/11704). Although, I > haven't verified the commit. Is there something wrong with th

[PATCH] D111790: [AArch64][Driver][SVE] Allow -msve-vector-bits=+ syntax to mean no maximum vscale

2021-10-22 Thread Bradley Smith via Phabricator via cfe-commits
bsmith updated this revision to Diff 381511. bsmith added a comment. - Don't define SVE target bits macros when vscale min != max - Add tests for above change - Use correct (unsigned) version of getAsInteger Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

2021-10-22 Thread Manas Gupta via Phabricator via cfe-commits
manas added a comment. I have received a failed build on clang-ppc64be-linux (https://lab.llvm.org/buildbot/#/builders/52/builds/11704). Although, I haven't verified the commit. Is there something wrong with this commit? Is the function VisitBinaryOperator reachable? Repository: rG LLVM Git

[clang] 49e1753 - Mark baremetal.cpp test as unsupported on Windows.

2021-10-22 Thread Kristof Beyls via cfe-commits
Author: Kristof Beyls Date: 2021-10-22T11:46:50+01:00 New Revision: 49e1753c5ef9dbedfca890992cd25a70e2cbb470 URL: https://github.com/llvm/llvm-project/commit/49e1753c5ef9dbedfca890992cd25a70e2cbb470 DIFF: https://github.com/llvm/llvm-project/commit/49e1753c5ef9dbedfca890992cd25a70e2cbb470.diff

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add flags

2021-10-22 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Fundamentally this looks ok to me, the biggest concern is fathoming out the change in TokenAnnotator.cpp to mean the same thing, but I think that is what the tests should be for I think. One think I do is use the output of this https://clang.llvm.org/docs/ClangF

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

2021-10-22 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. I've fixed the compilation error and pushed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106102/new/ https://reviews.llvm.org/D106102 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

2021-10-22 Thread Gabor Marton via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcac8808f154c: [analyzer][solver] Introduce reasoning for not equal to operator (authored by manas, committed by martong). Changed prior to commit: https://reviews.llvm.org/D106102?vs=376363&id=381496#to

[clang] cac8808 - [analyzer][solver] Introduce reasoning for not equal to operator

2021-10-22 Thread Gabor Marton via cfe-commits
Author: Manas Date: 2021-10-22T12:00:08+02:00 New Revision: cac8808f154cef6446e507d55aba5721c3bd5352 URL: https://github.com/llvm/llvm-project/commit/cac8808f154cef6446e507d55aba5721c3bd5352 DIFF: https://github.com/llvm/llvm-project/commit/cac8808f154cef6446e507d55aba5721c3bd5352.diff LOG: [a

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add flags

2021-10-22 Thread Christian Rayroud via Phabricator via cfe-commits
crayroud added inline comments. Comment at: clang/include/clang/Format/Format.h:3422 ///true: false: - ///for (auto v : values) {} vs. for(auto v: values) {} + ///for (auto v : values) {} vs. for (auto v: value

[clang] e5b87fb - Fix baremetal.cpp test to handle windows paths.

2021-10-22 Thread Kristof Beyls via cfe-commits
Author: Kristof Beyls Date: 2021-10-22T10:24:04+01:00 New Revision: e5b87fb7222c0f16ca52c6e72540ed24c204638a URL: https://github.com/llvm/llvm-project/commit/e5b87fb7222c0f16ca52c6e72540ed24c204638a DIFF: https://github.com/llvm/llvm-project/commit/e5b87fb7222c0f16ca52c6e72540ed24c204638a.diff

[PATCH] D112299: Replace references to Makefile.sphinx

2021-10-22 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: tstellar. Herald added a reviewer: aaron.ballman. sylvestre.ledru requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. and fix some typos Repository:

[PATCH] D112030: [docs] Remove Makefile.sphinx files

2021-10-22 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. Adjustment made on my side: https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/-/commit/daf38c1634954d9aad7a1393eef0828c57f41a53 @tstellar Maybe you could add this to the release notes? (I think others are probably using it) Repository: rG LLVM Github Mon

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

2021-10-22 Thread Gabor Marton via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rG5f8dca023504: [Analyzer] Extend ConstraintAssignor to handle remainder op (authored by martong). Repositor

[clang] 5f8dca0 - [Analyzer] Extend ConstraintAssignor to handle remainder op

2021-10-22 Thread Gabor Marton via cfe-commits
Author: Gabor Marton Date: 2021-10-22T10:47:25+02:00 New Revision: 5f8dca023504ed21490a40ddc3a0241029782910 URL: https://github.com/llvm/llvm-project/commit/5f8dca023504ed21490a40ddc3a0241029782910 DIFF: https://github.com/llvm/llvm-project/commit/5f8dca023504ed21490a40ddc3a0241029782910.diff

[PATCH] D111640: [Analyzer][NFC] Add RangedConstraintManager to ConstraintAssignor

2021-10-22 Thread Gabor Marton via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2a2c8328f57: [Analyzer][NFC] Add RangedConstraintManager to ConstraintAssignor (authored by martong). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D110387: [Analyzer][NFC] Move RangeConstraintManager's def before ConstraintAssignor's def

2021-10-22 Thread Gabor Marton via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01b4ddbfbbad: [Analyzer][NFC] Move RangeConstraintManager's def before ConstraintAssignor's… (authored by martong). Repository: rG LLVM Github Mo

[clang] e2a2c83 - [Analyzer][NFC] Add RangedConstraintManager to ConstraintAssignor

2021-10-22 Thread Gabor Marton via cfe-commits
Author: Gabor Marton Date: 2021-10-22T10:46:28+02:00 New Revision: e2a2c8328f573c792dcf8707b6adb88fa38cca11 URL: https://github.com/llvm/llvm-project/commit/e2a2c8328f573c792dcf8707b6adb88fa38cca11 DIFF: https://github.com/llvm/llvm-project/commit/e2a2c8328f573c792dcf8707b6adb88fa38cca11.diff

[clang] 01b4ddb - [Analyzer][NFC] Move RangeConstraintManager's def before ConstraintAssignor's def

2021-10-22 Thread Gabor Marton via cfe-commits
Author: Gabor Marton Date: 2021-10-22T10:46:28+02:00 New Revision: 01b4ddbfbbad575437fb157e8c6e3e2ffb8f0cea URL: https://github.com/llvm/llvm-project/commit/01b4ddbfbbad575437fb157e8c6e3e2ffb8f0cea DIFF: https://github.com/llvm/llvm-project/commit/01b4ddbfbbad575437fb157e8c6e3e2ffb8f0cea.diff

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

2021-10-22 Thread Gabor Marton via Phabricator via cfe-commits
martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1618-1627 +const SymbolRef LHS = Sym->getLHS(); +const llvm::APSInt &Zero = +Builder.getBasicValueFactory().getValue(0, Sy

[PATCH] D112296: [Analyzer][solver] Handle adjustments in constraint assignor remainder

2021-10-22 Thread Gabor Marton via Phabricator via cfe-commits
martong created this revision. martong added reviewers: steakhal, ASDenysPetrov, NoQ. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. martong req

[PATCH] D112013: [clang][ASTImporter] Fix for importing functions with EST_Unevaluated prototype.

2021-10-22 Thread Balázs Kéri via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4ff103c02400: [clang][ASTImporter] Fix for importing functions with EST_Unevaluated prototype. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] 4ff103c - [clang][ASTImporter] Fix for importing functions with EST_Unevaluated prototype.

2021-10-22 Thread Balázs Kéri via cfe-commits
Author: Balázs Kéri Date: 2021-10-22T09:42:41+02:00 New Revision: 4ff103c024005fea997143a4bdb7918edd8712eb URL: https://github.com/llvm/llvm-project/commit/4ff103c024005fea997143a4bdb7918edd8712eb DIFF: https://github.com/llvm/llvm-project/commit/4ff103c024005fea997143a4bdb7918edd8712eb.diff L

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

2021-10-22 Thread Gabor Marton via Phabricator via cfe-commits
martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1708-1710 + // Handle StringLiteral. + if (const auto *SL = dyn_cast(Init)) +return getSValFromStringLiteral(SL, Offset, R->getElementType()); ASDenysPetrov wrote: > ma

[PATCH] D111134: Add basic aarch64-none-elf bare metal driver.

2021-10-22 Thread Kristof Beyls via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b93dc6880f7: Add basic aarch64-none-elf bare metal driver. (authored by kristof.beyls). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 3b93dc6 - Add basic aarch64-none-elf bare metal driver.

2021-10-22 Thread Kristof Beyls via cfe-commits
Author: Kristof Beyls Date: 2021-10-22T08:06:17+01:00 New Revision: 3b93dc6880f7ac94469e46980f1136901760d564 URL: https://github.com/llvm/llvm-project/commit/3b93dc6880f7ac94469e46980f1136901760d564 DIFF: https://github.com/llvm/llvm-project/commit/3b93dc6880f7ac94469e46980f1136901760d564.diff