crayroud added inline comments.
================
Comment at: clang/include/clang/Format/Format.h:3422
/// true: false:
- /// for (auto v : values) {} vs. for(auto v: values) {}
+ /// for (auto v : values) {} vs. for (auto v: values) {}
/// \endcode
----------------
HazardyKnusperkeks wrote:
> Please remove again. :)
I changed the documentation to have a space added or removed only before the
for loop colon. Indeed the space after the for is handled by
SpaceBeforeParens... and not SpaceBeforeRangeBasedForLoopColon. Why do you
think it is better to keep it as before ?
================
Comment at: clang/lib/Format/Format.cpp:1221
LLVMStyle.SpaceBeforeParens = FormatStyle::SBPO_ControlStatements;
+ LLVMStyle.SpaceBeforeParensFlags.AfterControlStatements = true;
+ LLVMStyle.SpaceBeforeParensFlags.AfterOperators = true;
----------------
HazardyKnusperkeks wrote:
> Is this needed? Shouldn't the expand take care of that?
Indeed the expand takes care of that and it would be nice not to have to repeat
it here.
I had to add it for the test FormatTest.ConfigurationRoundTripTest, as it is
done for LLVMStyle.BraceWrapping.
What do you think is best ?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110833/new/
https://reviews.llvm.org/D110833
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
