martong added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1708-1710 + // Handle StringLiteral. + if (const auto *SL = dyn_cast<StringLiteral>(Init)) + return getSValFromStringLiteral(SL, Offset, R->getElementType()); ---------------- ASDenysPetrov wrote: > martong wrote: > > I am wondering why this hunk is needed? `getSValFromInitListExpr` is > > handling this case at L1725, isn't it? > L1710 handles `const char x[] = "abc";` > L1725 handles `const char x[] = {"abc"};` > I think I should give an example in comments. Okay, thanks for the explanation. > I think I should give an example in comments. Yes, that's a good idea! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107339/new/ https://reviews.llvm.org/D107339 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits