[PATCH] D108858: TypeInfo records more information about align requirement

rjmccall added a comment. Thanks. Generally looks good; feel free to commit after adding a `RequiredByEnum` case and making sure it compiles. Comment at: clang/lib/AST/ASTContext.cpp:2300 Info.Align = AttrAlign; -Info.AlignIsRequired = true; +Info.Ali

[PATCH] D108858: TypeInfo records more information about align requirement

stevewan updated this revision to Diff 369240. stevewan added a comment. Fix enum usage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108858/new/ https://reviews.llvm.org/D108858 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTCon

[PATCH] D108858: TypeInfo records more information about align requirement

stevewan updated this revision to Diff 369235. stevewan added a comment. Oops missed one flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108858/new/ https://reviews.llvm.org/D108858 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan added a comment. In D107394#2970326 , @rjmccall wrote: > Please add me to the review for the other patch and I'll approve it pretty > quickly, and then we can get back to this one. Sorry for the delay. Posted https://reviews.llvm.org/D108858, o

[PATCH] D108858: TypeInfo records more information about align requirement

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Extend the information preserved in `TypeInfo` by replacing the `AlignIsRequired` bool flag with a three-valued enum, the enum also indicates where the

[clang] a4a5c00 - [Modules] Change result of reading AST block to llvm::Error instead

Author: Ben Barham Date: 2021-08-27T20:16:20-07:00 New Revision: a4a5c00b53d0638e2bd9011fa5cce7ef9739eea6 URL: https://github.com/llvm/llvm-project/commit/a4a5c00b53d0638e2bd9011fa5cce7ef9739eea6 DIFF: https://github.com/llvm/llvm-project/commit/a4a5c00b53d0638e2bd9011fa5cce7ef9739eea6.diff LO

[PATCH] D108268: [Modules] Change result of reading AST block to llvm::Error instead

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4a5c00b53d0: [Modules] Change result of reading AST block to llvm::Error instead (authored by bnbarham, committed by vsapsai). Changed prior to commit: https://reviews.llvm.org/D108268?vs=368798&id=369

[PATCH] D104344: [modules] Track how headers are included by different modules.

vsapsai added a comment. In D104344#2969178 , @jansvoboda11 wrote: > If my understanding is correct, this patch only changes how we track > `HeaderFileInfo::{isImport,NumIncludes}` and makes sure to store the > necessary info into AST files. Right? Ye

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

rjmccall added a comment. Please add me to the review for the other patch and I'll approve it pretty quickly, and then we can get back to this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 ___

[PATCH] D105099: [clang-format] Add an option to put one constructor initializer per line

owenpan abandoned this revision. owenpan added a comment. In favor of https://reviews.llvm.org/D108752. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105099/new/ https://reviews.llvm.org/D105099 ___ cfe-

[clang] 32b2808 - TypePrinter:printTo remove redundant parameter (IsPack/SkipBrackets)

Author: David Blaikie Date: 2021-08-27T17:12:42-07:00 New Revision: 32b280809f4755177feb8a82fc7a632efa3bf469 URL: https://github.com/llvm/llvm-project/commit/32b280809f4755177feb8a82fc7a632efa3bf469 DIFF: https://github.com/llvm/llvm-project/commit/32b280809f4755177feb8a82fc7a632efa3bf469.diff

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM, but may wait 1 or 2 days for the comments from others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105269/new/ https://reviews.llv

[PATCH] D108742: [WIP] Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

rsmith added a comment. In D108742#2970283 , @cor3ntin wrote: >> Drive-by observation: under P2348 , Clang's >> behavior of treating `\n\r` as a single new-line would be "non-standard" >> (requiring special phase 1 mappin

[PATCH] D108742: [WIP] Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

cor3ntin added a comment. In D108742#2970263 , @rsmith wrote: > I assume this is intended to form part of the implementation of > https://wg21.link/p2348 and so shouldn't be considered for review right now? Yes, I wanted your feedback anyway but that wa

[PATCH] D108742: [WIP] Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

cor3ntin added a comment. In D108742#2970218 , @hubert.reinterpretcast wrote: > I find the lack of changes to tests other than API unittests to be somewhat > concerning. > Indeed, I applied the patch and did not notice behaviour changes in how `\f` > o

[PATCH] D108742: [WIP] Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

rsmith added a comment. I assume this is intended to form part of the implementation of https://wg21.link/p2348 and so shouldn't be considered for review right now? Drive-by observation: under P2348 , Clang's behavior of treating `\n\r` as a single new-line would

[PATCH] D102943: [modules] Use `HashBuilder` and `MD5` for the module hash.

arames marked 3 inline comments as done. arames added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4580 - return llvm::APInt(64, code).toString(36, /*Signed=*/false); + return llvm::APInt(64, Hash.getValue()).toString(36, /*Signed=*/false); } --

[PATCH] D102943: [modules] Use `HashBuilder` and `MD5` for the module hash.

arames added a comment. I still need to go through earlier comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ https://reviews.llvm.org/D102943 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D108742: [WIP] Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

hubert.reinterpretcast added a comment. I find the lack of changes to tests other than API unittests to be somewhat concerning. Indeed, I applied the patch and did not notice behaviour changes in how `\f` or `\v` were handled in various contexts sensitive to line-termination. For example: cl

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

tianshilei1992 updated this revision to Diff 369208. tianshilei1992 added a comment. 1. Ignore implicit cast in some cases. 2. Add the test case. What are still missing: 1. Code generation for floating point types. Question: 1. What atomic instruction(s) should we use for floating point types?

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk added inline comments. Comment at: clang/docs/tools/dump_format_style.py:23 + plurals = { +'IncludeCategory': 'IncludeCategories' + } HazardyKnusperkeks wrote: > Could you not just check if there is a y at the end and replace it with ies, > oth

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

arames updated this revision to Diff 369203. arames marked an inline comment as not done. arames added a comment. Now using the `HashBuilder` interface. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ https://reviews.llvm.org/D102943 Fil

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

matthewtff added a comment. This CL breaks -frewrite-includes flow. I've create a repro: https://pastebin.com/fFuUdsfp If you buid it on linux with ToT clang like this: clang++ -target i386-unknown-linux-gnu repro.cc -o repro.bin and then run the binay you'll get output "Hello, One". But if you

[clang] 170a3c6 - [clang-format] Fix AllowAllConstructorInitializersOnNextLine value

Author: owenca Date: 2021-08-27T14:47:49-07:00 New Revision: 170a3c6f7a0599707d8ea5cfb1bc4252920edef7 URL: https://github.com/llvm/llvm-project/commit/170a3c6f7a0599707d8ea5cfb1bc4252920edef7 DIFF: https://github.com/llvm/llvm-project/commit/170a3c6f7a0599707d8ea5cfb1bc4252920edef7.diff LOG: [

[clang] 696e790 - [clang-format] [NFC] Fix the coding style of unit tests header file

Author: owenca Date: 2021-08-27T14:25:38-07:00 New Revision: 696e7905a142a2c422c6b1485857c900dbdd14fb URL: https://github.com/llvm/llvm-project/commit/696e7905a142a2c422c6b1485857c900dbdd14fb DIFF: https://github.com/llvm/llvm-project/commit/696e7905a142a2c422c6b1485857c900dbdd14fb.diff LOG: [

[PATCH] D108789: [clang][NewPM] Mention that legacy PM flags are deprecated

aeubanks added a comment. @tstellar is it ok to cherry-pick this into 13.x? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108789/new/ https://reviews.llvm.org/D108789 ___ cfe-commits mailing list cfe-com

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 369177. stevewan added a comment. Fix missing "&&" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTC

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Looks good and I agree with the choices. Comment at: clang/docs/tools/dump_format_style.py:23 + plurals = { +'IncludeCategory': 'IncludeCategorie

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 369164. stevewan added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.c

[PATCH] D108775: [CMake] Change -DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER=off to -DLLVM_ENABLE_NEW_PASS_MANAGER=off

MaskRay added a comment. @aeubanks I have cherry picked this into release/13.x Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108775/new/ https://reviews.llvm.org/D108775 ___ cfe-commits mailing list cfe-

[PATCH] D107420: [sema] Disallow __builtin_mul_overflow under special condition.

craig.topper added a comment. In D107420#2969715 , @nickdesaulniers wrote: > In D107420#2929115 , @craig.topper > wrote: > >> In D107420#2929039 , >> @aaron.ballman wro

[PATCH] D63270: [clangd] Add include-mapping for C symbols.

ldionne added a comment. Herald added a subscriber: usaxena95. Herald added a project: clang-tools-extra. This is awesome, but the script doesn't work anymore with `-language=cpp` -- is there any interest in looking into that? The C++ Standard Library has changed quite a bit recently and it woul

[PATCH] D108243: Revert "Avoid needlessly copying a block to the heap when a block literal"

ahatanak added a comment. Sorry for the delay in responding. Instead of reverting the commit, can we put this optimization behind an off-by-default flag? As far as we can tell, the only problem we have now that is preventing us to enable this optimization is that clang doesn't copy a block to

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 369163. stevewan marked an inline comment as done. stevewan added a comment. Cleanup the condition check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: cla

Re: [PATCH] D108742: [WIP] Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

Thanks for the tip! On Fri, Aug 27, 2021 at 9:31 PM Shivam Gupta via Phabricator < revi...@reviews.llvm.org> wrote: > xgupta added a comment. > > (If you pass --draft flag to arc while updating revision it becomes WIP so > you don't need to retitle or remove reviewers. Buildbot also work in that

[PATCH] D108742: [WIP] Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

xgupta added a comment. (If you pass --draft flag to arc while updating revision it becomes WIP so you don't need to retitle or remove reviewers. Buildbot also work in that case. And to again ask for review you can use `Add Action` drop down menu.) Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D107024: [DIBuilder] Do not replace empty enum types

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107024/new/ https://reviews.llvm.org/D107024 __

[PATCH] D107420: [sema] Disallow __builtin_mul_overflow under special condition.

nickdesaulniers added a comment. In D107420#2929115 , @craig.topper wrote: > In D107420#2929039 , @aaron.ballman > wrote: > >> In D107420#2928975 , @craig.topper >> wro

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

rjmccall added a comment. Thanks, style suggestion aside, this looks great. Would you mind doing the TypeInfo change in a separate patch? The functional change for AIX can be a really small improvement on top of that. Comment at: clang/include/clang/AST/ASTContext.h:167 +

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan marked an inline comment as done. stevewan added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1984 +auto checkTypeIsTypedef = [](auto &&checkTypeIsTypedef, + const auto Ty) -> bool { + bool isTypedef = false;

[PATCH] D108826: [SLP][LTO][WIP]Allow full SLP in LTO only at link time.

ABataev added a comment. In D108826#2969701 , @nikic wrote: > @ABataev The pipeline already distinguishes between pre-link and post-link > optimization pipelines, see e.g. the flag that gets passed to LoopRotate to > control rotation of loops with calls

[PATCH] D108826: [SLP][LTO][WIP]Allow full SLP in LTO only at link time.

nikic added a comment. @ABataev The pipeline already distinguishes between pre-link and post-link optimization pipelines, see e.g. the flag that gets passed to LoopRotate to control rotation of loops with calls (https://github.com/llvm/llvm-project/blob/2f69c82cec1ae05b4fdcef4ac48f48e9e2bad32b/

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

modimo updated this revision to Diff 369158. modimo added a comment. Check for CachedAttributes count in map rather than value so conservative results are not re-calculated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36850/new/ https://reviews.l

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 369157. stevewan added a comment. Make TypeInfo carry more information about "aligned" attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/inclu

[PATCH] D108826: [SLP][LTO][WIP]Allow full SLP in LTO only at link time.

ABataev added a comment. In D108826#2969677 , @spatel wrote: > In D108826#2969604 , @ABataev wrote: > >> In D108826#2969594 , @lebedev.ri >> wrote: >> >>> Aha, so full lt

[PATCH] D108826: [SLP][LTO][WIP]Allow full SLP in LTO only at link time.

spatel added a comment. In D108826#2969604 , @ABataev wrote: > In D108826#2969594 , @lebedev.ri > wrote: > >> Aha, so full lto. That is consistent with the phase ordering dilemma @spatel >> discovered: D102002 <

[PATCH] D108810: [clang-format] [PR51640] - New AfterEnum brace wrapping changes have cause C# behaviour to change

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed367b9dff10: [clang-format] [PR51640] - New AfterEnum brace wrapping changes have cause C#… (authored by MyDeveloperDay). Repository: rG LLVM Git

[clang] ed367b9 - [clang-format] [PR51640] - New AfterEnum brace wrapping changes have cause C# behaviour to change

Author: mydeveloperday Date: 2021-08-27T19:13:53+01:00 New Revision: ed367b9dff10ee1df9ac1984eb2ad7544da7ab06 URL: https://github.com/llvm/llvm-project/commit/ed367b9dff10ee1df9ac1984eb2ad7544da7ab06 DIFF: https://github.com/llvm/llvm-project/commit/ed367b9dff10ee1df9ac1984eb2ad7544da7ab06.diff

[PATCH] D108774: [OpenMP][FIX] Allow declare variant to work with reference types

This revision was automatically updated to reflect the committed changes. Closed by commit rG2930c839a587: [OpenMP][FIX] Allow declare variant to work with reference types (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108774/

[clang] 2930c83 - [OpenMP][FIX] Allow declare variant to work with reference types

Author: Johannes Doerfert Date: 2021-08-27T13:12:14-05:00 New Revision: 2930c839a5877356db6966409f4f9f2cdbcf3a07 URL: https://github.com/llvm/llvm-project/commit/2930c839a5877356db6966409f4f9f2cdbcf3a07 DIFF: https://github.com/llvm/llvm-project/commit/2930c839a5877356db6966409f4f9f2cdbcf3a07.d

[PATCH] D108826: [SLP][LTO][WIP]Allow full SLP in LTO only at link time.

ABataev added a comment. In D108826#2969594 , @lebedev.ri wrote: > In D108826#2969547 , @ABataev wrote: > >> In D108826#2969471 , @lebedev.ri >> wrote: >> >>> I think th

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

tra added a comment. In D108787#2968503 , @yaxunl wrote: > need a test for non-template static member function as kernel. also need > codegen tests. I've added more tests for different code paths leading to the kernel call. Interestingly enough, only t

[PATCH] D108826: [SLP][LTO][WIP]Allow full SLP in LTO only at link time.

lebedev.ri added a comment. In D108826#2969547 , @ABataev wrote: > In D108826#2969471 , @lebedev.ri > wrote: > >> I think there is something really wrong with vectorzer passes in LTO >> pipelines. >> Can you say

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

tra updated this revision to Diff 369140. tra edited the summary of this revision. tra added a comment. Added more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108787/new/ https://reviews.llvm.org/D108787 Files: clang/include/clang/Sema/S

[PATCH] D108826: [SLP][LTO][WIP]Allow full SLP in LTO only at link time.

ABataev added a comment. In D108826#2969471 , @lebedev.ri wrote: > I think there is something really wrong with vectorzer passes in LTO > pipelines. > Can you say whether the problem you are observing is in ThinLTO, Full LTO, or > both? I saw it in Fu

[PATCH] D107941: Fix assertion when passing function into inline asm's input operand

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe177a1773e4: Fix assertion when passing function into inline asm's input operand (authored by jasonliu). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Githu

[clang] fe177a1 - Fix assertion when passing function into inline asm's input operand

Author: Jason Liu Date: 2021-08-27T13:39:41-04:00 New Revision: fe177a1773e4f88dde1aa37d34a0d3f8cb582f14 URL: https://github.com/llvm/llvm-project/commit/fe177a1773e4f88dde1aa37d34a0d3f8cb582f14 DIFF: https://github.com/llvm/llvm-project/commit/fe177a1773e4f88dde1aa37d34a0d3f8cb582f14.diff LOG

[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

erichkeane added a comment. Codewise I'm ok, but I don't feel comfortable making the direction decision. I'd like to see some level of 'state of things' on the vector types (like, under what conditions does GCC support this, and under what types??), but even then I'm not sure I'm the right one

[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16544 + E, AA_Passing)) + return ExprResult(true); + erichkeane wrote: > Doing this as ExprResult(true) is absurdly jarring. Updated, thanks! =

[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

fhahn updated this revision to Diff 369136. fhahn marked 2 inline comments as done. fhahn added a comment. Use ExprError() instead of ExprResult(true). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108832/new/ https://reviews.llvm.org/D108832 File

[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

fhahn updated this revision to Diff 369135. fhahn added a comment. Updated to remove stray comment. In D108832#2969512 , @erichkeane wrote: > I think I would want some level of examination/analysis as to whether we want > to do this with all of the vec

[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

erichkeane added a comment. I think I would want some level of examination/analysis as to whether we want to do this with all of the vector-types, instead of just the `ext_vector_type`. Comment at: clang/lib/Sema/SemaChecking.cpp:16544 + E, AA_P

[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

fhahn added a comment. > This brings Clang more in line with GCC, which already supports math builtins > with ext_vector_type arguments. This is unfortunately not correct. When I tried this with GCC the `ext_vector_type` attribute was dropped and it fell back to `float`. Repository: rG LLVM

[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

fhahn created this revision. fhahn added reviewers: erichkeane, rjmccall, thegameg, anemet. fhahn requested review of this revision. Herald added a project: clang. At the moment, the various math builtins only accept the scalar types defined by libm. This patch extends __builtin_fminf to also acc

[PATCH] D108826: [SLP][LTO][WIP]Allow full SLP in LTO only at link time.

lebedev.ri added subscribers: spatel, lebedev.ri. lebedev.ri added a comment. I think there is something really wrong with vectorzer passes in LTO pipelines. Can you say whether the problem you are observing is in ThinLTO, Full LTO, or both? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D103929: [clang] P2085R0: Consistent defaulted comparisons

predator5047 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103929/new/ https://reviews.llvm.org/D103929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D108826: [SLP][LTO][WIP]Allow full SLP in LTO only at link time.

ABataev created this revision. Herald added subscribers: hiraditya, inglorion. ABataev requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108826 Files: clang

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA updated this revision to Diff 369112. ZarkoCA added a comment. Rebase to ToT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106393/new/ https://reviews.llvm.org/D106393 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/aix32-co

[PATCH] D108819: [MCParser][z/OS] Mark test as unsupported for the z/OS Target

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d7a77c26d2f: [MCParser][z/OS] Mark test as unsupported for the z/OS Target (authored by fanbo-meng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108819/ne

[clang] 9d7a77c - [MCParser][z/OS] Mark test as unsupported for the z/OS Target

Author: Fanbo Meng Date: 2021-08-27T11:45:38-04:00 New Revision: 9d7a77c26d2f68e1c3b58b61d792d371bd3ed224 URL: https://github.com/llvm/llvm-project/commit/9d7a77c26d2f68e1c3b58b61d792d371bd3ed224 DIFF: https://github.com/llvm/llvm-project/commit/9d7a77c26d2f68e1c3b58b61d792d371bd3ed224.diff LO

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

Ashimaru added a comment. In my company we are using a lot of standard checks and it becomes time consuming - this patch would be extremely useful to us and non of proposals montioned @alexfh seem to solve the issue. We would like to select which directories containing headers would be checked

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

tianshilei1992 added a comment. Yes, there are a couple of issues of implicit cast to be fixed. Current test is just a placeholder. I copied and pasted from the one for `update` clause and just replaced all `update`s with `compare`. I’m also working on that. Repository: rG LLVM Github Monore

[PATCH] D108823: [PowerPC] Mark splat immediate instructions as rematerializable

NeHuang created this revision. NeHuang added reviewers: nemanjai, stefanp, lei, PowerPC. NeHuang added a project: LLVM. Herald added subscribers: shchenz, kbarton, hiraditya, qcolombet. NeHuang requested review of this revision. This patch marks splat immediate instructions `XXSPLTIDP` and `XXSPLT

[PATCH] D104344: [modules] Track how headers are included by different modules.

jansvoboda11 added a comment. FYI, a clangd test is failing in CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104344/new/ https://reviews.llvm.org/D104344 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D108822: [python bindings] Add missing cursor kind in Clang Python's bindings.

ColinChargy created this revision. ColinChargy added a reviewer: rsmith. ColinChargy added a project: clang. Herald added a subscriber: arphaman. ColinChargy requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Some of the values i

[PATCH] D104344: [modules] Track how headers are included by different modules.

jansvoboda11 added a comment. If my understanding is correct, this patch only changes how we track `HeaderFileInfo::{isImport,NumIncludes}` and makes sure to store the necessary info into AST files. Right? Can you explain how values of these members can prevent Clang from importing the header

[PATCH] D108819: [MCParser][z/OS] Mark test as unsupported for the z/OS Target

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108819/new/ https://reviews.llvm.org/D108819 _

[PATCH] D108819: [MCParser][z/OS] Mark test as unsupported for the z/OS Target

fanbo-meng created this revision. fanbo-meng requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Marking test as unsupported for the same reason as https://reviews.llvm.org/D105204 Repository: rG LLVM Github Monorepo https://reviews.llvm.

[PATCH] D108818: [clang] Add a -canonical-prefixes option

thakis created this revision. thakis added reviewers: hans, rnk. Herald added a subscriber: dang. thakis requested review of this revision. In https://reviews.llvm.org/D47480 I complained that there's no positive form of this flag, so let's add one :) https://gcc.gnu.org/PR29931 also has a pendin

[PATCH] D106191: [clang] Option control afn flag

lebedev.ri added a comment. FWIW i think this part is fine in principle. Not sure about errno. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 ___ cfe-commits m

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

spatel added a reviewer: efriedma. spatel added a comment. I'm not familiar with this library, and I haven't looked at current state of how we enable/map optional libs in a while... We definitely want to avoid adding another target option/debug flag, and if we can avoid relying on a function par

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:47419 + : X86ISD::VFCMADDC; + // FIXME: How we handle when FMF of FADD is different from CFMUL's? + CFmul = DAG.getNode(newOp, SDLoc(N), CVT,

[PATCH] D108753: [analyzer] MallocChecker: Add notes from NoOwnershipChangeVisitor only when a function "intents", but doesn't change ownership, enable by default

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:802 +// TODO: Operator delete is hardly the only deallocator -- Can we reuse +// isFreeingCall() or something thats already here? +auto Deallocations = match( --

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk added a comment. > look at the html Done, thanks > I assume you don't have commit access, we'll need your name and email address Here it is: Ludovic Jozeau it should also be on my profile > but if you think you might like to work on some other things, it might be > worth get tin

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:675 + /// retrieved from a CallEnter is the *caller's* stack frame! The inlined + /// function's stack should be retrieved from \p CallExitBeginN. + virtual bo

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:47419 + : X86ISD::VFCMADDC; + // FIXME: How we handle when FMF of FADD is different from CFMUL's? + CFmul = DAG.getNode(newOp, SDLoc(N), CV

[PATCH] D108752: [clang-format] Group options that pack constructor initializers

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a780a2f18c5: [clang-format] Group options that pack constructor initializers (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108752/new

[clang] 8a780a2 - [clang-format] Group options that pack constructor initializers

Author: owenca Date: 2021-08-27T06:27:46-07:00 New Revision: 8a780a2f18c590e27e51a2ab3cc81b481c42b42a URL: https://github.com/llvm/llvm-project/commit/8a780a2f18c590e27e51a2ab3cc81b481c42b42a DIFF: https://github.com/llvm/llvm-project/commit/8a780a2f18c590e27e51a2ab3cc81b481c42b42a.diff LOG: [

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

RKSimon added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:47419 + : X86ISD::VFCMADDC; + // FIXME: How we handle when FMF of FADD is different from CFMUL's? + CFmul = DAG.getNode(newOp, SDLoc(N), CVT,

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

MyDeveloperDay added a comment. In D108765#2969036 , @FederAndInk wrote: > For now, I handle plural manually, but it can be changed, I also kept > Unsigned, what are your thoughts? I think thats ok for now, did you try building the file with sphinx

[PATCH] D107804: [analyzer] MallocOverflow should consider comparisons only preceding malloc

martong added a comment. Probably it is too late, but the title of this change is misleading. I think is should be either `MallocOverflow should consider comparisons AFTER malloc` or `MallocOverflow should NOT consider comparisons only preceding malloc`. Repository: rG LLVM Github Monorepo

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

martong added a comment. Nice work! Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:361 + while (!SCtx->inTopFrame()) { +auto p = FramesModifying.insert(SCtx); +if (!p.second) Why don't we add the stack frame here to `FramesModifyingC

[PATCH] D108810: [clang-format] [PR51640] - New AfterEnum brace wrapping changes have cause C# behaviour to change

owenpan added a comment. LGTM. Comment at: clang/lib/Format/TokenAnnotator.cpp:3799 +if (Style.BraceWrapping.AfterEnum) { + if (Line.startsWith(tok::kw_enum) || + Line.startsWith(tok::kw_typedef, tok::kw_enum)) Nit: I think it would be a littl

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:47419 + : X86ISD::VFCMADDC; + // FIXME: How we handle when FMF of FADD is different from CFMUL's? + CFmul = DAG.getNode(newOp, SDLoc(N), CV

[PATCH] D108810: [clang-format] [PR51640] - New AfterEnum brace wrapping changes have cause C# behaviour to change

MyDeveloperDay updated this revision to Diff 369082. MyDeveloperDay added a comment. Handle comments before the enum CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108810/new/ https://reviews.llvm.org/D108810 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTe

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM, thanks for adding that and fixing the spelling mistake, let the others have time to chip in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108765/new/ https://reviews.llv

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk added a comment. For now, I handle plural manually, but it can be changed, I also kept Unsigned, what are your thoughts? Thanks for being so kind and responsive, it's really great to work on that :) as it is my first contribution to clang. Repository: rG LLVM Github Monorepo CH

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk updated this revision to Diff 369081. FederAndInk added a comment. Use yaml type style for clang-format documentation (`String`, `Integer`, `List of Strings`, ...) instead of c++ types. Fix typo in clang/Format/Format.h Regenarate ClangFormatStyleOptions.rst Repository: rG LLVM

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk added a comment. Ok, well, the reason I proposed this patch in the first place was that I have been working on a `.clang-format` schema (https://json-schema.org/) :) and I spotted the inconsistency. I checked, and clang-format reports an error if we give a negative value to an optio

[PATCH] D107804: [analyzer] MallocOverflow should consider comparisons only preceding malloc

This revision was automatically updated to reflect the committed changes. Closed by commit rG68088563fbad: [analyzer] MallocOverflow should consider comparisons only preceding malloc (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LL

  1   2   >