rjmccall added a comment.
Thanks, style suggestion aside, this looks great. Would you mind doing the
TypeInfo change in a separate patch? The functional change for AIX can be a
really small improvement on top of that.
================
Comment at: clang/include/clang/AST/ASTContext.h:167
+enum class AlignRequirementType {
+ /// The alignment was not explicit in code.
----------------
We've been calling things like this `FooKind` for a while. `FooType` is pretty
problematic in a compiler where we have a lot of type representations. I think
there are a few grandfathered exceptions, but still, let's call it
`AlignRequirementKind`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107394/new/
https://reviews.llvm.org/D107394
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
