matthewtff added a comment.

This CL breaks -frewrite-includes flow. I've create a repro: 
https://pastebin.com/fFuUdsfp
If you buid it on linux with ToT clang like this: clang++ -target 
i386-unknown-linux-gnu repro.cc -o repro.bin
and then run the binay you'll get output "Hello, One". But if you make a 
roundtrip via rewrite includes:
clang++ -target i386-unknown-linux-gnu -E -frewrite-includes repro.cc > 
repro_pp.cc
clang++ -target i386-unknown-linux-gnu repro_pp.cc -o repro_pp.bin
And then run ./repro_pp.bin, you'll get output "Hello, Three". So now the 
binary differs.

If you revert this CL, then both ways of compiling would give the same binary, 
that would output "Hello, One".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93769/new/

https://reviews.llvm.org/D93769

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to