[PATCH] D102569: [clang-tidy] Fix altera-struct-pack-align crash for struct fields with incomplete type

jubnzv created this revision. jubnzv added reviewers: aaron.ballman, njames93. jubnzv added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. jubnzv requested review of this revision. We can only use `ASTContext::getTypeInfo` for complete types. This fixes the following bugzilla

[PATCH] D102568: [Driver] Delete -mimplicit-it=

MaskRay created this revision. MaskRay added reviewers: nickdesaulniers, ostannard, raj.khem. Herald added subscribers: dang, kristof.beyls. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a GNU as and Clang cc1as option, no

[PATCH] D102560: [AIX][clang-repl][test] Mark unsupported pending XCOFF64 integrated-as

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ae529d0db2d: [AIX][clang-repl][test] Mark unsupported pending XCOFF64 integrated-as (authored by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[clang] 9ae529d - [AIX][clang-repl][test] Mark unsupported pending XCOFF64 integrated-as

Author: Hubert Tong Date: 2021-05-15T22:41:45-04:00 New Revision: 9ae529d0db2d6841b3b2e49525e03b33e8445636 URL: https://github.com/llvm/llvm-project/commit/9ae529d0db2d6841b3b2e49525e03b33e8445636 DIFF: https://github.com/llvm/llvm-project/commit/9ae529d0db2d6841b3b2e49525e03b33e8445636.diff L

[PATCH] D102560: [AIX][clang-repl][test] Mark unsupported pending XCOFF64 integrated-as

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102560/new/ https://reviews.llvm.org/D102560 __

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added subscribers: JDevlieghere, rjmccall. dblaikie added a comment. OK - poked around a bit more to better understand this, so attempting to summarize my current understanding (excuse the repetition from previous parts of this thread) and results. - `__attribute__((overloadable))` can

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. In D96033#2761428 , @hubert.reinterpretcast wrote: > If you have some ideas, please let me know. Meanwhile, I am trying out > `system-aix` as the "feature" to XFAIL on. https://reviews.llvm.org/D102560 posted to u

[PATCH] D102560: [AIX][clang-repl][test] Mark unsupported pending XCOFF64 integrated-as

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: v.g.vassilev, lhames, daltenty, jasonliu, jsji. Herald added a subscriber: steven.zhang. hubert.reinterpretcast requested review of this revision. Herald added a project: clang. This patch replaces the `powerpc6

[PATCH] D102558: [Utils] Check for generated functions inline if possible

jdoerfert created this revision. jdoerfert added reviewers: greened, arichardson, ggeorgakoudis. Herald added a subscriber: bollu. jdoerfert requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added projects: clang, LLVM. With D83004

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

sfertile accepted this revision. sfertile added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87029/new/ https://reviews.llvm.org/D87029 ___ cfe-commits mailing list cfe-commit

[PATCH] D100509: Support GCC's -fstack-usage flag

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9b36a041fd7: Support GCC's -fstack-usage flag (authored by pzheng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100

[clang] c9b36a0 - Support GCC's -fstack-usage flag

Author: Pengxuan Zheng Date: 2021-05-15T10:22:49-07:00 New Revision: c9b36a041fd70de0617ea7e241f520b345e12cac URL: https://github.com/llvm/llvm-project/commit/c9b36a041fd70de0617ea7e241f520b345e12cac DIFF: https://github.com/llvm/llvm-project/commit/c9b36a041fd70de0617ea7e241f520b345e12cac.diff

[PATCH] D102556: [HIP] Fix spack detection

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kerbowa, nhaehnle, jvesely. yaxunl requested review of this revision. Missing or duplicate spack package should not cause error, since users may only installed llvm/clang package, or users may installed duplicate

[PATCH] D102118: [BPF] add support for 32 bit registers in inline asm

yonghong-song accepted this revision. yonghong-song added a comment. This revision is now accepted and ready to land. LGTM except one minor issue. Please do address the nit before merging. Thanks! Comment at: clang/test/CodeGen/bpf-inline-asm.c:5 + +long var; +

[PATCH] D102555: [libclang] Enhance support for source-to-source rewriting

samvv updated this revision to Diff 345641. samvv added a comment. Attempt at re-running clang-format-13. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102555/new/ https://reviews.llvm.org/D102555 Files: clang/bindings/python/clang/cindex.py c

[PATCH] D102555: [libclang] Enhance support for source-to-source rewriting

samvv created this revision. samvv added reviewers: rsmith, jkorous. Herald added a subscriber: arphaman. samvv requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hi! This is my first time submitting a patch to LLVM/Clang, so apologies if I'm

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

cryptoad added a comment. Thanks a lot Mitch! Couple of comments from a first look, I'll give it another go later. Comment at: compiler-rt/lib/scudo/standalone/wrappers_cpp.cpp:42 + if (Allocator.canReturnNull()) { \ +errno

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. Once I add `-Xcc -fintegrated-as`, we get: $ cat /home/hstong/.Liodine/llvmproj/clang/test/Interpreter/execute.cpp | /home/hstong/.Nrtphome/.Liodine/llcrossbld/dev/build/bin/clang-repl -Xcc -fintegrated-as fatal error: error in backend: 64-bit XCOFF o

[PATCH] D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check

mgartmann marked 2 inline comments as done. mgartmann added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines-virtual-base-class-destructor.rst:16 + +This check implements `C.35

[PATCH] D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check

mgartmann updated this revision to Diff 345635. mgartmann added a comment. Resolved readability-identifier-naming warning, adjusted check's documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102325/new/ https://reviews.llvm.org/D102325 F

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. @v.g.vassilev, thanks for working with me on this. I understand it is difficult to handle issues that appear on platforms and build configurations one does not have set up. I've added `-Xcc -v` and the output is below. It seems it has to do with the impl

[PATCH] D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check

mgartmann updated this revision to Diff 345634. mgartmann added a comment. Fetched new commits from upstream `main` branch and resolved merge conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99646/new/ https://reviews.llvm.org/D99646 Files

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

steakhal added a comment. In D102280#2760402 , @AbbasSabra wrote: > Is it a requirement for you to build them on Linux? Maybe you can try to > build them on windows with !!clang-cl!!? It is a hard requirement. I'm gonna think more about this in the far

[PATCH] D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/VirtualBaseClassDestructorCheck.cpp:22 +void VirtualBaseClassDestructorCheck::registerMatchers(MatchFinder *Finder) { + ast_matchers::internal::Matcher inheritsVirtualMethod = +

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

dblaikie added a comment. This isn't the sort of thing I'd like to leave to a FIXME later - seems like the sort of thing we shouldn't create now to fix later. @aprantl mind having a second look at this to consider the situation further? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D89425: [Format/ObjC] Add NS_SWIFT_NAME() and CF_SWIFT_NAME() to WhitespaceSensitiveMacros

MyDeveloperDay added a comment. After this change, this FOUNDATION_EXPORT NSString *const kFIRInstanceIDScopeFirebaseMessaging NS_SWIFT_NAME(InstanceIDScopeFirebaseMessaging) DEPRECATED_ATTRIBUTE; typedef NS_ENUM(NSInteger, FIRHTTPMethod) { /** HTTP Method GET */ FIRHTTPMetho

[PATCH] D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check

mgartmann updated this revision to Diff 345623. mgartmann marked 2 inline comments as done. mgartmann added a comment. Incorporated Phabricator review feedback: - added matchers and tests for subclasses with inherited virtual methods - made aid methods static and not part of the check's class - r

[PATCH] D102392: [clang-format] PR50326 AlignAfterOpenBracket AlwaysBreak does not keep to the ColumnLimit

MyDeveloperDay added a comment. This is also the cause of https://bugs.llvm.org/show_bug.cgi?id=49995, we might want to ask for this to be put into any 12.0.1 patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102392/new/ https://reviews.llvm.org

[PATCH] D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check

mgartmann marked 17 inline comments as done. mgartmann added a comment. In D102325#2754241 , @njames93 wrote: > Whats the intended behaviour for derived classes and their destructors? Can > test be added to demonstrate that behaviour? If a derived class

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. In D96033#2760067 , @hubert.reinterpretcast wrote: > In D96033#2759808 , @v.g.vassilev > wrote: > >> Hi @hubert.reinterpretcast, >> >> Would you mind testing this patch: > > Does the

[PATCH] D102489: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support.

thakis added a comment. (Failed on our bots too -- the new test probably just needs a ` REQUIRES: aarch64-registered-target`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102489/new/ https://reviews.llvm.org/D102489 _

[PATCH] D102392: [clang-format] PR50326 AlignAfterOpenBracket AlwaysBreak does not keep to the ColumnLimit

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeae445f65d07: [clang-format] PR50326 AlignAfterOpenBracket AlwaysBreak does not keep to the… (authored by MyDeveloperDay). Repository: rG LLVM Gi

[clang] eae445f - [clang-format] PR50326 AlignAfterOpenBracket AlwaysBreak does not keep to the ColumnLimit

Author: mydeveloperday Date: 2021-05-15T11:29:56+01:00 New Revision: eae445f65d077304703e3290ddb4ff28f6d65ff4 URL: https://github.com/llvm/llvm-project/commit/eae445f65d077304703e3290ddb4ff28f6d65ff4 DIFF: https://github.com/llvm/llvm-project/commit/eae445f65d077304703e3290ddb4ff28f6d65ff4.diff

[PATCH] D102392: [clang-format] PR50326 AlignAfterOpenBracket AlwaysBreak does not keep to the ColumnLimit

MyDeveloperDay updated this revision to Diff 345620. MyDeveloperDay added a comment. slightly closer test to the original failure CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102392/new/ https://reviews.llvm.org/D102392 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Fo

[PATCH] D102392: [clang-format] PR50326 AlignAfterOpenBracket AlwaysBreak does not keep to the ColumnLimit

MyDeveloperDay updated this revision to Diff 345619. MyDeveloperDay added a comment. Add a test that shows it no longer impacts function ptrs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102392/new/ https://reviews.llvm.org/D102392 Files: clang/lib/Format/TokenAnnotator.cpp clang/

[PATCH] D102547: [clang][AVR] Redefine [u]int16_t to be compatible with avr-gcc

benshi001 updated this revision to Diff 345611. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102547/new/ https://reviews.llvm.org/D102547 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/TargetInfo.cpp clang/lib/Basic/Targets/AVR.cpp clang/lib/Basic/Targets/AVR.h