mgartmann marked 2 inline comments as done. mgartmann added inline comments.
================ Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines-virtual-base-class-destructor.rst:16 + +This check implements `C.35 <https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#c35-a-base-class-destructor-should-be-either-public-and-virtual-or-protected-and-non-virtual>`_ from the CppCoreGuidelines. + ---------------- Eugene.Zelenko wrote: > Links to documentation usually placed at the end. See other checks > documentation. Thanks for pointing this out to me! I previously followed the style of other `cppcoreguideline` checks which did not have this line at the end of the file (e.g., [[ https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines-prefer-member-initializer.html | cppcoreguidelines-prefer-member-initializer ]] or [[ https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines-avoid-non-const-global-variables.html | cppcoreguidelines-avoid-non-const-global-variables]]. I adjusted the documentation according to your suggestion and now placed this line at the end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102325/new/ https://reviews.llvm.org/D102325 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
