cryptoad added a comment.
Thanks a lot Mitch! Couple of comments from a first look, I'll give it another
go later.
================
Comment at: compiler-rt/lib/scudo/standalone/wrappers_cpp.cpp:42
+ if (Allocator.canReturnNull()) {
\
+ errno = EINVAL;
\
+ return nullptr;
\
----------------
I don't think errno carry over to C++, there seems to be no sign of it in
https://en.cppreference.com/w/cpp/memory/new/operator_new
================
Comment at: compiler-rt/test/scudo/standalone/lit.cfg.py:21
c_flags = ([config.target_cflags] +
- ["-pthread",
- "-fPIE",
- "-pie",
- "-O0",
- "-UNDEBUG",
- "-ldl",
- "-Wl,--gc-sections"])
+ ["-pthread", "-fPIE", "-pie", "-O0", "-UNDEBUG", "-ldl",
+ "-Wl,--gc-sections"])
----------------
-ldl might not be necessary anymore without the sanitizer dependencies?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102543/new/
https://reviews.llvm.org/D102543
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
