[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:356 +void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, + ArgStringList &CC1Args) const { Anastasia wrote: > benshi

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

sylvestre.ledru added a comment. To understand better, we will be fixing a bug from 2015, correct? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 ___ cfe-commits

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

aeubanks added a comment. could you clang-format the patch? Comment at: clang/lib/CodeGen/CGException.cpp:1666-1667 + ++J) { + if (isa(J)) { +auto LI = dyn_cast(J); +LI->setVolatile(true); ``` if (auto*LI = dyn_cast<...>(J)) { ...

[clang] 000cf84 - Revert "[NFC][Clang] Speculative fix for builtins-ppc-quadword-noi128.c"

Author: Petr Hosek Date: 2021-04-06T23:22:08-07:00 New Revision: 000cf84cf1bb2f5475600737c16c3ccf43096f58 URL: https://github.com/llvm/llvm-project/commit/000cf84cf1bb2f5475600737c16c3ccf43096f58 DIFF: https://github.com/llvm/llvm-project/commit/000cf84cf1bb2f5475600737c16c3ccf43096f58.diff LO

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

NoQ added a comment. Here's a reduced repro - a file that has different behavior before and after the patch (sorry, not perfectly reduced, my creduce is broken again): // RUN: clang --analyze %s typedef Oid; typedef Pointer; typedef text; errstart(int elevel, filename, lineno, funcname

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith added a comment. @rjmccall @rsmith Thanks for your help. Do you have any additional feedback before we commit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith added a comment. In D80344#2671157 , @lebedev.ri wrote: > It would be good for @rjmccall / @rsmith / etc to actually finish reviewing > this and accept it. > I would personally want to see the next patches - what changes are needed for > llvm an

[PATCH] D99810: [ifs][elfabi] Merge llvm-elfabi tool into llvm-ifs

haowei marked 3 inline comments as done. haowei added a comment. I will try to split this change. Comment at: clang/lib/Driver/ToolChains/InterfaceStubs.cpp:26 const bool WriteBin = !Args.getLastArg(options::OPT_emit_merged_ifs); - CmdArgs.push_back(WriteBin ? "write-bin" :

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl added a comment. In D99683#2672668 , @tejohnson wrote: > In D99683#2672578 , @yaxunl wrote: > >> In D99683#2672554 , @tejohnson >> wrote: >> >>> This raises some high

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

yaxunl updated this revision to Diff 335702. yaxunl added a comment. revised by Richard's comments. Check function-scope static var. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98193/new/ https://reviews.llvm.org/D98193 Files: clang/lib/Sema/SemaExpr.cpp clang/test/CodeGenCUDA/de

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

grokos accepted this revision. grokos added a comment. This revision is now accepted and ready to land. Change looks good, so it's accepted on my end. I'll let the other reviewers have a look and post their comments. Please do not commit until we have reached an agreement for all 4 patches toget

[PATCH] D98912: Fix -Winteger-overflow to diagnose regardless of the top-level syntactic form.

vsapsai accepted this revision. vsapsai added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ExprConstant.cpp:972-973 +// Determine if we might warn that the given expression exhibits undefined +// behavior. +bool mightWa

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf added a comment. Ping.. Any further comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93377/new/ https://reviews.llvm.org/D93377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D100000: [clang] WIP: Implement simpler alternative to two-phase lookup for NRVO

mizvekov updated this revision to Diff 335689. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10/new/ https://reviews.llvm.org/D10 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaCoroutine.cpp cla

[PATCH] D100000: [clang] WIP: Implement simpler alternative to two-phase lookup for NRVO

mizvekov updated this revision to Diff 335688. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10/new/ https://reviews.llvm.org/D10 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaCoroutine.cpp cla

[clang] 4018268 - Add missing CHECK lines in test

Author: Weverything Date: 2021-04-06T18:00:31-07:00 New Revision: 401826800ef1d2e73ac9ea8e7e31d6c12d543c5e URL: https://github.com/llvm/llvm-project/commit/401826800ef1d2e73ac9ea8e7e31d6c12d543c5e DIFF: https://github.com/llvm/llvm-project/commit/401826800ef1d2e73ac9ea8e7e31d6c12d543c5e.diff L

[clang] 86175d5 - Minor fix for test hip-code-object-version.hip

Author: Yaxun (Sam) Liu Date: 2021-04-06T20:32:16-04:00 New Revision: 86175d5fedba7c09ad09ee5afd359e7f9246367a URL: https://github.com/llvm/llvm-project/commit/86175d5fedba7c09ad09ee5afd359e7f9246367a DIFF: https://github.com/llvm/llvm-project/commit/86175d5fedba7c09ad09ee5afd359e7f9246367a.dif

[PATCH] D99235: [HIP] Change to code object v4

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/Driver/hip-code-object-version.hip:24-39 // Check bundle ID for code object v2. // RUN: %clang -### -target x86_64-linux-gnu \ // RUN: -mno-code-object-v3 \ // RUN: --offload-a

[PATCH] D100000: [clang] WIP: Implement simpler alternative to two-phase lookup for NRVO WIP, not ready for review.

mizvekov created this revision. Herald added a subscriber: lxfind. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Matheus Izvekov Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D10 Files:

[PATCH] D99235: [HIP] Change to code object v4

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG4fd05e0ad7fb: [HIP] Change to code object v4 (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4fd05e0 - [HIP] Change to code object v4

Author: Yaxun (Sam) Liu Date: 2021-04-06T20:22:58-04:00 New Revision: 4fd05e0ad7fba41f27a6f61d9f7fec4382cb96fe URL: https://github.com/llvm/llvm-project/commit/4fd05e0ad7fba41f27a6f61d9f7fec4382cb96fe DIFF: https://github.com/llvm/llvm-project/commit/4fd05e0ad7fba41f27a6f61d9f7fec4382cb96fe.dif

[PATCH] D77574: [OpenMP] Fix layering problem with FrontendOpenMP

tstellar added inline comments. Herald added a reviewer: bollu. Herald added a subscriber: sstefan1. Herald added a project: clang-tools-extra. Comment at: clang/lib/ASTMatchers/CMakeLists.txt:17-18 ) + +target_link_libraries(clangASTMatchers PUBLIC LLVMFrontendOpenMP) ---

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha updated this revision to Diff 335680. SaurabhJha added a comment. Fix the bug with int <-> float conversion by explicitly passing llvm types to EmitCastBetweenScalarTypes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99037/new/ https://

[PATCH] D99235: [HIP] Change to code object v4

tra added a comment. Still LGTM. Comment at: clang/test/Driver/hip-code-object-version.hip:24-39 // Check bundle ID for code object v2. // RUN: %clang -### -target x86_64-linux-gnu \ // RUN: -mno-code-object-v3 \ // RUN: --offload-arch=gfx906 -nogpulib \ // RUN: %s

[PATCH] D99893: [WIP] Replace std::forward & std::move by cast expressions during Sema

rsmith added a comment. In D99893#2672563 , @cor3ntin wrote: > This would solve some of the issues (perfect code-gen / no body > instantiation), but the declarations are still instantiated of course. > And I have a few folks asking me whether I could get

[PATCH] D99235: [HIP] Change to code object v4

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:115 std::string OffloadKind = "hip"; + if (getOrCheckAMDGPUCodeObjectVersion(C.getDriver(), Args) >= 4) +OffloadKind = OffloadKind + "v4"; --

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek added a comment. @ldionne any more thoughts on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89013/new/ https://reviews.llvm.org/D89013 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D99791: [CGCall] Annotate pointer argument with alignment

rjmccall added a comment. In D99791#2672528 , @lebedev.ri wrote: > @rjmccall thank you for taking a look! > > In D99791#2670333 , @rjmccall wrote: > >> The last major conversation we had about this was this RFC I se

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + hoy wrote: > dblaikie wrote: > > hoy wrote: > > > dblaikie wrote: > > > > hoy wrote: > > > > > dblaik

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha updated this revision to Diff 335677. SaurabhJha added a comment. I reverted the int <-> float conversion to previous code to make the tests pass. That way, we atleast have something working and we can go from there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99993: [clang-tidy] bugprone-argument-comment: ignore name mismatches for decls from system headers

njames93 added a comment. In D3#2672624 , @Eugene.Zelenko wrote: > Why `--header-filter` command line option or `HeaderFilterRegex` > configuration file option could not solve this problem? That's for suppressing warnings emitted in header files. Th

[PATCH] D99683: [HIP] Support ThinLTO

tejohnson added a comment. In D99683#2672578 , @yaxunl wrote: > In D99683#2672554 , @tejohnson wrote: > >> This raises some higher level questions for me: >> >> First, how will you deal with other corner cases that

[PATCH] D99993: [clang-tidy] bugprone-argument-comment: ignore name mismatches for decls from system headers

george.burgess.iv added a comment. Thanks for the comment! > Why `--header-filter` command line option or `HeaderFilterRegex` > configuration file option could not solve this problem? AFAICT, `--header-filter` & `HeaderFilterRegex` exist to filter diagnostics that occur in matching headers. Th

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

MaskRay created this revision. MaskRay added reviewers: atanasyan, doko, nathanchance, nickdesaulniers, sylvestre.ledru, vkalintiris. Herald added subscribers: arichardson, sdardis. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D

[PATCH] D99993: [clang-tidy] bugprone-argument-comment: ignore name mismatches for decls from system headers

Eugene.Zelenko added a comment. Why `--header-filter` command line option or `HeaderFilterRegex` configuration file option could not solve this problem? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D3/new/ https://reviews.llvm.org/D3

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

Holman created this revision. Herald added subscribers: dexonsmith, wenlei, hiraditya. Holman requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This change adds debug information about whether PGO is being used or not. Micr

[PATCH] D99235: [HIP] Change to code object v4

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:115 std::string OffloadKind = "hip"; + if (getOrCheckAMDGPUCodeObjectVersion(C.getDriver(), Args) >= 4) +OffloadKind = O

[PATCH] D99893: [WIP] Replace std::forward & std::move by cast expressions during Sema

Quuxplusone added a comment. No matter how it works internally, I think that (nearer the end of the process) someone should insist that you add some Clang tests to verify e.g. Widget&& a = static_cast(Widget()); // is lifetime-extended, but Widget&& b = std::move(Widget()); //

[PATCH] D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG3da61ddae7fe: [OpenMP] Define omp_is_initial_device() variants in omp.h (authored by hbae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99447/new/ https:/

[clang] 3da61dd - [OpenMP] Define omp_is_initial_device() variants in omp.h

Author: Hansang Bae Date: 2021-04-06T16:58:01-05:00 New Revision: 3da61ddae7fe77f71b89ce20cf6b5febd68d216a URL: https://github.com/llvm/llvm-project/commit/3da61ddae7fe77f71b89ce20cf6b5febd68d216a DIFF: https://github.com/llvm/llvm-project/commit/3da61ddae7fe77f71b89ce20cf6b5febd68d216a.diff L

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl added a comment. In D99683#2672554 , @tejohnson wrote: > This raises some higher level questions for me: > > First, how will you deal with other corner cases that won't or cannot be > imported right now? While enabling importing of noinline functio

[PATCH] D93185: [docs] Use make_unique in FrontendAction example

nicolas17 added a comment. I don't have commit access, please push this for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93185/new/ https://reviews.llvm.org/D93185 ___ cfe-commits mailing list cfe-c

[PATCH] D99893: [WIP] Replace std::forward & std::move by cast expressions during Sema

cor3ntin added a comment. In D99893#2672258 , @rjmccall wrote: > Our builtin logic is capable of recognizing user declarations as builtins > without any sort of explicit annotation in source. That's how we recognize C > library builtins, for example. A

[PATCH] D99194: [analyzer] Fix body farm for Obj-C++ properties

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Great, thanks!~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99194/new/ https://reviews.llvm.org/D99194

[PATCH] D99262: [analyzer] Fix dead store checker false positive

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great and I'm also curious about nested initializers. Comment at: clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp:420-421 + // We should also allow defen

[PATCH] D99683: [HIP] Support ThinLTO

tejohnson added a comment. In D99683#2671727 , @yaxunl wrote: > In D99683#2669136 , @yaxunl wrote: > >> In D99683#2669080 , @tejohnson >> wrote: >> >>> In D99683#2669047

[PATCH] D99993: bugprone-argument-comment: ignore name mismatches for decls from system headers

george.burgess.iv created this revision. george.burgess.iv added reviewers: hokein, gribozavr2. george.burgess.iv added a project: clang. Herald added a subscriber: jfb. george.burgess.iv requested review of this revision. Herald added a project: clang-tools-extra. As of 2a3498e24f97d

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

lebedev.ri added a comment. I'll land this tomorrow if no one wants to object. As discussed in D99791 , this is an obvious, and legal, bugfix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99790/new/ https://review

[PATCH] D99791: [CGCall] Annotate pointer argument with alignment

lebedev.ri planned changes to this revision. lebedev.ri added a comment. @rjmccall thank you for taking a look! In D99791#2670333 , @rjmccall wrote: > The last major conversation we had about this was this RFC I sent out about > five years ago: > > htt

[PATCH] D90188: Add support for attribute 'using_if_exists'

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/using-if-exists.cpp:79 + using B::mf UIE; // expected-note {{using declaration annotated with 'using_if_exists' here}} + using typename B::mt UIE; // expected-note 2 {{using declaration annotated with 'using_

[PATCH] D99235: [HIP] Change to code object v4

yaxunl marked an inline comment as done. yaxunl added a comment. ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99235/new/ https://reviews.llvm.org/D99235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang-tools-extra] c060945 - [docs] Update documentation for bugprone-misplaced-widening-cast

Author: Vince Bridgers Date: 2021-04-06T16:18:50-05:00 New Revision: c060945b23a1c54d4b2a053ff4b093a2277b303d URL: https://github.com/llvm/llvm-project/commit/c060945b23a1c54d4b2a053ff4b093a2277b303d DIFF: https://github.com/llvm/llvm-project/commit/c060945b23a1c54d4b2a053ff4b093a2277b303d.diff

[PATCH] D99898: [clang, test] Fix use of undef FileCheck var

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99898/new/ https://reviews.llvm.org/D99898 __

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90188/new/ https://reviews.llvm.org/D90188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

protze.joachim added a comment. In D99353#2669046 , @awarzynski wrote: > Btw, how important are these aliases for you? I can work with `-ffixed-line-length=132` where needed. It's just not obvious from `flang --help` that this is an alias for `-ffixed-li

[PATCH] D98747: Thread safety analysis: Don't warn about managed locks on join points

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdfec26b186d2: Thread safety analysis: Don't warn about managed locks on join points (authored by aaronpuchert). Repository: rG LLVM Github Monorep

[clang] dfec26b - Thread safety analysis: Don't warn about managed locks on join points

Author: Aaron Puchert Date: 2021-04-06T22:29:48+02:00 New Revision: dfec26b186d2f0c80f2b70901b7cc5747f5b377c URL: https://github.com/llvm/llvm-project/commit/dfec26b186d2f0c80f2b70901b7cc5747f5b377c DIFF: https://github.com/llvm/llvm-project/commit/dfec26b186d2f0c80f2b70901b7cc5747f5b377c.diff

[PATCH] D99675: RFC [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

andrew.w.kaylor added a comment. In D99675#2671924 , @efriedma wrote: >> The expression “llvm.arith.fence(a * b) + c” means that “a * b” must happen >> before “+ c” and FMA guarantees that, but to prevent later optimizations >> from unpacking the FMA the

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha updated this revision to Diff 335643. SaurabhJha added a comment. Changes in latest revision: - Updated definition of areMatrixTypesOfTheSameDimension to reflect the comment - Refactored casting between types into EmitCastBetweenScalarTypes - Removed mentions of "non matrix" - Replaced

[PATCH] D99898: [clang, test] Fix use of undef FileCheck var

thopre updated this revision to Diff 335640. thopre added a comment. Rename NUW_RN for CHECK-YES to NUW Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99898/new/ https://reviews.llvm.org/D99898 Files: clang/test/CodeGen/libcalls.c Index: clang/

[PATCH] D97653: [clang-tidy] Fix RenamerClangTidy checks breaking lambda captures.

njames93 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97653/new/ https://reviews.llvm.org/D97653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG61d065e21ff3: Let clang atomic builtins fetch add/sub support floating point types (authored by yaxunl). Herald added a project: clang. Repository:

[clang] 61d065e - Let clang atomic builtins fetch add/sub support floating point types

Author: Yaxun (Sam) Liu Date: 2021-04-06T15:44:00-04:00 New Revision: 61d065e21ff37fb9040aed711c97daddac2f7577 URL: https://github.com/llvm/llvm-project/commit/61d065e21ff37fb9040aed711c97daddac2f7577 DIFF: https://github.com/llvm/llvm-project/commit/61d065e21ff37fb9040aed711c97daddac2f7577.dif

[PATCH] D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::".

This revision was automatically updated to reflect the committed changes. Closed by commit rGddebed8e9742: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type… (authored by flx). Changed prior to commit: https://reviews.llvm.org/D98738?vs=335267&id=335632#toc Repositor

[clang-tools-extra] ddebed8 - [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::".

Author: Felix Berger Date: 2021-04-06T15:41:35-04:00 New Revision: ddebed8e9742add4372d54021cb55e06b655cfd6 URL: https://github.com/llvm/llvm-project/commit/ddebed8e9742add4372d54021cb55e06b655cfd6 DIFF: https://github.com/llvm/llvm-project/commit/ddebed8e9742add4372d54021cb55e06b655cfd6.diff

[PATCH] D99973: [Windows] Add test coverage for line endings when rewriting includes

This revision was automatically updated to reflect the committed changes. aganea marked an inline comment as done. Closed by commit rG8fbc05acd553: [Windows] Add test coverage for line endings when rewriting includes (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D99973

[clang] 8fbc05a - [Windows] Add test coverage for line endings when rewriting includes

Author: Alexandre Ganea Date: 2021-04-06T15:38:19-04:00 New Revision: 8fbc05acd5531a8bb74f689699e8de2788bcb769 URL: https://github.com/llvm/llvm-project/commit/8fbc05acd5531a8bb74f689699e8de2788bcb769 DIFF: https://github.com/llvm/llvm-project/commit/8fbc05acd5531a8bb74f689699e8de2788bcb769.dif

[PATCH] D99973: [Windows] Add test coverage for line endings when rewriting includes

aganea marked an inline comment as done. aganea added inline comments. Comment at: clang/test/Frontend/rewrite-includes-macros.cpp:15 +} \ No newline at end of file mstorsjo wrote: > I guess the missing newline at end of file isn't one of the aspects that > nee

[PATCH] D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h

JonChesterfield accepted this revision. JonChesterfield added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99447/new/ https://reviews.llvm.org/D99447 ___ cfe-commits mailing lis

[PATCH] D99973: [Windows] Add test coverage for line endings when rewriting includes

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM, thanks for adding a testcase! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99973/new/ https://reviews.l

[PATCH] D99893: [WIP] Replace std::forward & std::move by cast expressions during Sema

rjmccall added a comment. Our builtin logic is capable of recognizing user declarations as builtins without any sort of explicit annotation in source. That's how we recognize C library builtins, for example. As Richard points out, that logic isn't really set up to do the right thing for names

[PATCH] D99984: [RISCV] Prevent __builtin_riscv_orc_b_64 from being compiled RV32 target.

craig.topper created this revision. craig.topper added reviewers: asb, frasercrmck, luismarques, jrtc27, evandro, HsiangKai, khchen, arcbbb. Herald added subscribers: StephenFan, vkmr, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

ldionne accepted this revision as: libc++, libc++abi. ldionne added a comment. LGTM for libcxx and libcxxabi. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 ___

[PATCH] D99973: [Windows] Add test coverage for line endings when rewriting includes

mstorsjo added a comment. Not very familiar with the feature, but from the linked discussion it looks sensible to me, so +1, I can give a formal stamp a bit later if nobody else does. Comment at: clang/test/Frontend/rewrite-includes-macros.cpp:15 +} \ No newline at end of fil

[PATCH] D99898: [clang, test] Fix use of undef FileCheck var

rjmccall added a comment. `NUW_RN` isn't a good name for the variable in this alternative since it's not `readnone` anymore. With an appropriate rename, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99898/new/ https://reviews.llvm.org/D9989

[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. This looks fine to me. Maybe wait for a day or two to see if richardsmith wants to say anything, else this is good to go. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

yaxunl added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17050 +auto Target = SemaRef.IdentifyCUDATarget(FD); +if (Var && Var->isFileVarDecl() && !Var->hasAttr() && +!Var->hasAttr() && !Var->hasAttr() && rsmith wrote: > I suspect you

[PATCH] D99898: [clang, test] Fix use of undef FileCheck var

thopre updated this revision to Diff 335618. thopre added a comment. Change attribute check to a positive match Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99898/new/ https://reviews.llvm.org/D99898 Files: clang/test/CodeGen/libcalls.c Index

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

guiand added a comment. Sorry, I must've missed this. @aqjune, if you'd be willing to take on this change, that would be amazing (I haven't got much time to update these patches lately). We can make these changes incrementally, too; say, one test subfolder at a time. Each patch could add the n

[PATCH] D99983: Provide TreeTransform::TransformAttr the transformed statement; NFC

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, haberman. aaron.ballman requested review of this revision. Herald added a project: clang. It is useful statement an attribute is being applied to when performing semantic processing of the attribute during template instan

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha added inline comments. Comment at: clang/include/clang/AST/OperationKinds.def:185 +/// CK_MatrixCast - A cast between matrix types of the same dimensions. +CAST_OPERATION(MatrixCast) + This line is causing me issues that I don't know how to solve. If w

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://reviews.llvm.org/D71726 ___ cfe-commits mailing list cfe

[PATCH] D99675: RFC [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

mibintc added a comment. In D99675#2671924 , @efriedma wrote: >> The expression “llvm.arith.fence(a * b) + c” means that “a * b” must happen >> before “+ c” and FMA guarantees that, but to prevent later optimizations >> from unpacking the FMA the correct

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1324 + +if (SrcElementTy->isFloatTy() || SrcElementTy->isDoubleTy()) { + QualType DstElementType = DstType->castAs()->getElementType(); fhahn wrote: > SaurabhJha wrote: > >

[PATCH] D99675: RFC [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

kbsmith1 added a comment. In D99675#2671924 , @efriedma wrote: >> The expression “llvm.arith.fence(a * b) + c” means that “a * b” must happen >> before “+ c” and FMA guarantees that, but to prevent later optimizations >> from unpacking the FMA the correc

[PATCH] D99194: [analyzer] Fix body farm for Obj-C++ properties

vsavchenko updated this revision to Diff 335615. vsavchenko added a comment. Set Prop and IVar at the same time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99194/new/ https://reviews.llvm.org/D99194 Files: clang/lib/Analysis/BodyFarm.cpp cla

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

fhahn added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1324 + +if (SrcElementTy->isFloatTy() || SrcElementTy->isDoubleTy()) { + QualType DstElementType = DstType->castAs()->getElementType(); SaurabhJha wrote: > fhahn wrote: > > I th

[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

Quuxplusone added a comment. There's unlikely to be any further substantive comments from me, and this basically LGTM (or, in the places it looks bad, it's just the pre-existing awfulness of how the Clang test suite is organized). I think you need to either get someone's attention to approve thi

[PATCH] D99936: [clang][parser] Unify rejecting (non) decl stmt with gnu attributes

aaron.ballman added a comment. I think the behavior is correct, but I do think the original diagnostic was somewhat better -- an attribute list *can* appear there, if you're lucky. Of course, the old diagnostic isn't great either because adding a `;` after the attribute isn't going to improve t

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

kiranchandramohan added inline comments. Comment at: clang/include/clang/Driver/Options.td:4378 HelpText<"Run the InputOuputTest action. Use for development and testing only.">; +def fdebug_unparse_no_sema : Flag<["-"], "fdebug-unparse-no-sema">, Group, + HelpText<"Unparse

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1324 + +if (SrcElementTy->isFloatTy() || SrcElementTy->isDoubleTy()) { + QualType DstElementType = DstType->castAs()->getElementType(); fhahn wrote: > I think we should sup

[PATCH] D99262: [analyzer] Fix dead store checker false positive

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp:420-421 + // We should also allow defensive initialization of structs. + if (const auto *ILE = + dyn_cast(E->IgnoreParenCasts())) {

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov updated this revision to Diff 335604. mizvekov added a comment. - test/SemaCXX/coroutine-rvo: Make MoveOnly trivial, since the temporary is not created anymore and there is no special reason to test a non-trivial type here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

mizvekov updated this revision to Diff 335599. mizvekov added a comment. - Finally addresses all of Arthur's review requests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99225/new/ https://reviews.llvm.org/D99225 Files: clang/test/CXX/class/cl

[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

mizvekov added inline comments. Comment at: clang/test/SemaCXX/coroutine-rvo.cpp:41-45 struct MoveOnly { - MoveOnly() {}; + MoveOnly() = default; MoveOnly(const MoveOnly&) = delete; - MoveOnly(MoveOnly&&) noexcept {}; - ~MoveOnly() {}; + MoveOnly(MoveOnly &&) = default;

[PATCH] D99194: [analyzer] Fix body farm for Obj-C++ properties

vsavchenko added inline comments. Comment at: clang/lib/Analysis/BodyFarm.cpp:757 + if (PI->getPropertyDecl()) { +Prop = PI->getPropertyDecl(); +if (Prop->getGetterName() == MD->getSelector()) NoQ wrote: > At this point `Prop` may contain a c

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

Anastasia added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:356 +void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, + ArgStringList &CC1Args) const { benshi001 wrote: > Anasta

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader updated this revision to Diff 335596. bader marked 7 inline comments as done. bader added a comment. Add ReST marks to hyperlinks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99488/new/ https://reviews.llvm.org/D99488 Files: clang/docs/S

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ https://reviews.llvm.org/D96853 ___ cfe-commits mailing list cfe-comm

[PATCH] D99969: [OpenCL] Accept .rgba in OpenCL 3.0

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! The code formating check reported an issue though... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99969/new/ https://revie

  1   2   3   >