[PATCH] D86823: [clang][Modules] Perform an Extra Consistency Check When Searching The ModuleManager's Cache For Implicit Modules

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Assuming that it works, this seems fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86823/new/ https://reviews.llvm.org/D86823 ___

[PATCH] D85676: [NewPM] collapsing nested pass mangers of the same type

asbirlea accepted this revision. asbirlea added a comment. This revision is now accepted and ready to land. Seems like a good idea. I'm curious if you saw any impact from this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85676/new/ https:/

[PATCH] D86822: [clang] Enable -fsanitize=thread on Fuchsia.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e800495a78a: [clang] Enable -fsanitize=thread on Fuchsia. (authored by charco). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2e80049 - [clang] Enable -fsanitize=thread on Fuchsia.

Author: Marco Vanotti Date: 2020-08-28T17:26:27-07:00 New Revision: 2e800495a78a6d722eed5766bba1e2fe76f295bc URL: https://github.com/llvm/llvm-project/commit/2e800495a78a6d722eed5766bba1e2fe76f295bc DIFF: https://github.com/llvm/llvm-project/commit/2e800495a78a6d722eed5766bba1e2fe76f295bc.diff

[PATCH] D86822: [clang] Enable -fsanitize=thread on Fuchsia.

charco updated this revision to Diff 288735. charco added a comment. remove change-id lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86822/new/ https://reviews.llvm.org/D86822 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/D

[PATCH] D86823: [clang][Modules] Perform an Extra Consistency Check When Searching The ModuleManager's Cache For Implicit Modules

CodaFi updated this revision to Diff 288734. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86823/new/ https://reviews.llvm.org/D86823 Files: clang/lib/Serialization/ModuleManager.cpp Index: clang/lib/Serialization/ModuleManager.cpp =

[PATCH] D86823: [clang][Modules] Perform an Extra Consistency Check When Searching The ModuleManager's Cache For Implicit Modules

aprantl added inline comments. Comment at: clang/lib/Serialization/ModuleManager.cpp:152 + const FileEntry *Entry) -> bool { +if (Kind != MK_ImplicitModule) { + return true; nit: LLVM style omits curly braces on single

[PATCH] D86502: [CSSPGO] A Clang switch -fpseudo-probe-for-profiling for pseudo-probe instrumentation.

wmi added a comment. In D86502#2245578 , @hoy wrote: > In D86502#2245460 , @wmi wrote: > >>> The early instrumentation also allows the inliner to duplicate probes for >>> inlined instances. When a probe along with

[clang] b5ef137 - [gcov] Increment counters with atomicrmw if -fsanitize=thread

Author: Fangrui Song Date: 2020-08-28T16:32:35-07:00 New Revision: b5ef137c11b1cc6ae839ee75b49233825772bdd0 URL: https://github.com/llvm/llvm-project/commit/b5ef137c11b1cc6ae839ee75b49233825772bdd0 DIFF: https://github.com/llvm/llvm-project/commit/b5ef137c11b1cc6ae839ee75b49233825772bdd0.diff

[PATCH] D86823: [clang][Modules] Perform an Extra Consistency Check When Searching The ModuleManager's Cache For Implicit Modules

CodaFi created this revision. CodaFi added reviewers: vsapsai, aprantl, doug.gregor. Herald added subscribers: cfe-commits, danielkiss. Herald added a project: clang. CodaFi requested review of this revision. The ModuleManager's use of FileEntry nodes as the keys for its map of loaded modules is l

[PATCH] D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys

CodaFi abandoned this revision. CodaFi added a comment. Herald added a subscriber: danielkiss. We have tested this proposed change out on our CI systems and have seen no relief from the symptoms of inode reuse with this approach. Abandoning this revision in favor of a more narrow fix. Reposito

[PATCH] D86822: [clang] Enable -fsanitize=thread on Fuchsia.

mcgrathr accepted this revision. mcgrathr added a comment. I'm not 100% sure we don't need more fiddles in the driver, but we can iterate from here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86822/new/ https://reviews.llvm.org/D86822

[PATCH] D86822: [clang] Enable -fsanitize=thread on Fuchsia.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86822/new/ https://reviews.llvm.org/D86822 ___ c

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

snehasish accepted this revision. snehasish added a comment. This revision is now accepted and ready to land. LGTM. Please wait a bit for additional comments from others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/ https://reviews.llvm

[PATCH] D86822: [clang] Enable -fsanitize=thread on Fuchsia.

charco created this revision. charco added reviewers: mcgrathr, phosek. Herald added subscribers: cfe-commits, danielkiss. Herald added a project: clang. charco requested review of this revision. This CL modifies clang enabling using -fsanitize=thread on fuchsia. The change doesn't build the runti

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

modimo added a comment. In D86156#2245103 , @nikic wrote: > I have no familiarity with BFI, so possibly stupid question: There is already > some similar handling as part of BFIImpl here: > https://github.com/llvm/llvm-project/blob/0f14b2e6cbb54c84ed3b00b

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

modimo updated this revision to Diff 288719. modimo added a comment. Remove redundant VH callback as @nikic helpfully pointed out! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86156/new/ https://reviews.llvm.org/D86156 Files: llvm/include/llvm/Analysis/LoopAnalysisManager.h llvm/i

[PATCH] D67113: ICK_Function_Conversion is a third kind conversion

aaronpuchert added a comment. Herald added a subscriber: danielkiss. In D67113#2244463 , @aaron.ballman wrote: > There may be a deeper issue here in that there are four standard conversion > sequences, not three: http://eel.is/c++draft/conv#1, but otherw

[PATCH] D86502: [CSSPGO] A Clang switch -fpseudo-probe-for-profiling for pseudo-probe instrumentation.

hoy updated this revision to Diff 288716. hoy marked an inline comment as done. hoy added a comment. Updating D86502 : [CSSPGO] A Clang switch -fpseudo-probe-for-profiling for pseudo-probe instrumentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D86502: [CSSPGO] A Clang switch -fpseudo-probe-for-profiling for pseudo-probe instrumentation.

hoy marked an inline comment as done. hoy added a comment. In D86502#2245460 , @wmi wrote: >> The early instrumentation also allows the inliner to duplicate probes for >> inlined instances. When a probe along with the other instructions of a >> callee fu

[PATCH] D86820: [X86] Add a /tune: option for clang-cl

craig.topper created this revision. craig.topper added reviewers: rnk, thakis, hans, echristo, erichkeane. Herald added subscribers: dang, danielkiss. craig.topper requested review of this revision. We recently added support for -mtune. This patch adds /tune: so we can specify the tune CPU from c

[PATCH] D86819: [PowerPC][Power10] Implementation of 128-bit Binary Vector Rotate builtins

Conanap created this revision. Conanap added reviewers: PowerPC, saghir, nemanjai, hfinkel. Conanap added projects: LLVM, clang, PowerPC. Herald added subscribers: danielkiss, steven.zhang, kbarton. Conanap requested review of this revision. This patch implements 128-bit Binary Vector Rotate built

[PATCH] D86558: [OPENMP]Add support for allocate vars in untied tasks.

ABataev updated this revision to Diff 288711. ABataev added a comment. Herald added a subscriber: danielkiss. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86558/new/ https://reviews.llvm.org/D86558 Files: clang/lib/CodeGen/CGOpenMPRuntim

[clang] 7128e64 - [UpdateTestChecks] include { in function signature check line

Author: sstefan1 Date: 2020-08-28T23:44:03+02:00 New Revision: 7128e647063dd858901aa7a5d90be8744c673866 URL: https://github.com/llvm/llvm-project/commit/7128e647063dd858901aa7a5d90be8744c673866 DIFF: https://github.com/llvm/llvm-project/commit/7128e647063dd858901aa7a5d90be8744c673866.diff LOG:

[PATCH] D86769: [UpdateTestChecks] include { in function signature check line

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7128e647063d: [UpdateTestChecks] include { in function signature check line (authored by sstefan1). Herald added subscribers: cfe-commits, danielkiss

[PATCH] D86502: [CSSPGO] A Clang switch -fpseudo-probe-for-profiling for pseudo-probe instrumentation.

wmi added a comment. Herald added a subscriber: danielkiss. > The early instrumentation also allows the inliner to duplicate probes for > inlined instances. When a probe along with the other instructions of a callee > function are inlined into its caller function, the GUID of the callee > funct

[PATCH] D85762: [OPENMP]Do not allow threadprivates as base for array-like reduction.

ABataev updated this revision to Diff 288701. ABataev added a comment. Herald added a subscriber: danielkiss. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85762/new/ https://reviews.llvm.org/D85762 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D84887: [OPENMP]Fix codegen for is_device_ptr component, captured by reference.

ABataev updated this revision to Diff 288700. ABataev added a comment. Herald added a subscriber: danielkiss. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84887/new/ https://reviews.llvm.org/D84887 Files: clang/lib/CodeGen/CGOpenMPRuntim

[clang] 0e00a95 - Add new warning for compound punctuation tokens that are split across macro expansions or split by whitespace.

Author: Richard Smith Date: 2020-08-28T13:35:50-07:00 New Revision: 0e00a95b4fad5e72851de012d3a0b2c2d01f8685 URL: https://github.com/llvm/llvm-project/commit/0e00a95b4fad5e72851de012d3a0b2c2d01f8685 DIFF: https://github.com/llvm/llvm-project/commit/0e00a95b4fad5e72851de012d3a0b2c2d01f8685.diff

[PATCH] D86751: Add new warning for compound punctuation tokens that are split across macro expansions or split by whitespace.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. rsmith marked an inline comment as done. Closed by commit rG0e00a95b4fad: Add new warning for compound punctuation tokens that are split across macro… (authored by rsmi

[PATCH] D86751: Add new warning for compound punctuation tokens that are split across macro expansions or split by whitespace.

rsmith marked an inline comment as done. rsmith added inline comments. Herald added a subscriber: danielkiss. Comment at: clang/test/Parser/compound-token-split.cpp:30 + +[ // expected-warning-re ^}}'[' tokens introducing attribute appear in different source files}} +#define

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl marked an inline comment as done. rahmanl added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1030 +/// recursive return edges vs. indirect branches. The format of the metadata is +/// described as follows: 1st bit (LSB): set if this is a return

[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

andrewjcg updated this revision to Diff 288695. andrewjcg added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86802/new/ https://reviews.llvm.org/D86802 Files: clang/lib/Frontend/FrontendAction.cpp clang/test/Modules/Inputs

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl updated this revision to Diff 288694. rahmanl added a comment. - Move getBBAddrMetadata to AsmPrinter as a static function + nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/ https://reviews.llvm.org/D85408 Files: clang/docs

[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

bruno added inline comments. Comment at: clang/lib/Frontend/FrontendAction.cpp:814 +CI.getPreprocessor().getHeaderSearchInfo().loadModuleMapFile( +*File, /*IsSystem*/ false); + else andrewjcg wrote: > bruno wrote: > > Is this clang-format

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Herald added a subscriber: danielkiss. Sounds good to me - thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81865/new/ https://reviews.llvm.org/D81865 __

[PATCH] D85676: [NewPM] collapsing nested pass mangers of the same type

ychen added a comment. Herald added subscribers: wenlei, danielkiss. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85676/new/ https://reviews.llvm.org/D85676 ___ cfe-commits mailing list cfe-commit

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

nikic added a comment. Herald added a subscriber: danielkiss. New compile-time numbers: https://llvm-compile-time-tracker.com/compare.php?from=d7c119d89c5f6d0789cfd0a139c80e23912c0bb0&to=e0a1a6cac1b982023f8ceba8285d1ee7bc96bd32&stat=instructions The regression is now reduced to 0.2%. I assume th

[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

andrewjcg added a comment. > How about a malformed module map is not loaded and gives no errors? Heh yeah, was thinking the same :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86802/new/ https://reviews.llvm.org/D86802 _

[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

tschuett added a comment. Herald added a subscriber: danielkiss. How about a malformed module map is not loaded and gives no errors? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86802/new/ https://reviews.llvm.org/D86802 _

[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

andrewjcg added a comment. > Can you add a simple testcase to prove the point of the change? Yup, will do! Comment at: clang/lib/Frontend/FrontendAction.cpp:814 +CI.getPreprocessor().getHeaderSearchInfo().loadModuleMapFile( +*File, /*IsSystem*/ false); +

[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

bruno added a comment. Hi Andrew, thanks for improving this. I think this makes sense: dependents can choose to not use modules without having to trigger the build system to rebuild all dependencies. Can you add a simple testcase to prove the point of the change? Comment at:

[clang] 8782c72 - Strength-reduce SmallVectors to arrays. NFCI.

Author: Benjamin Kramer Date: 2020-08-28T21:14:20+02:00 New Revision: 8782c727655942c9aa4c80d698c9ba575510799c URL: https://github.com/llvm/llvm-project/commit/8782c727655942c9aa4c80d698c9ba575510799c DIFF: https://github.com/llvm/llvm-project/commit/8782c727655942c9aa4c80d698c9ba575510799c.dif

[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

andrewjcg created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. andrewjcg requested review of this revision. In some build environments/systems, flags for explicit module map files may be propagated up to dependents which may not choose to enable use of modu

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

emaste added inline comments. Comment at: clang/lib/Basic/Targets.cpp:361-362 return new LinuxTargetInfo(Triple, Opts); +case llvm::Triple::FreeBSD: + return new FreeBSDTargetInfo(Triple, Opts); case llvm::Triple::NetBSD: Bdragon28 wrote: > B

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

zequanwu added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:895 + if (!Self.getLangOpts().RTTIData) { +bool isMSVC = Self.getDiagnostics().getDiagnosticOptions().getFormat() == + DiagnosticOptions::MSVC; hans wrote: > zequanwu wr

[PATCH] D85743: [CodeGen][AArch64] Support arm_sve_vector_bits attribute

leonardchan added a comment. > The IR differences were caused by the new pass manager which is on by default > for the Fuchsia builder. I've re-landed the patch with a fix for > `CodeGen/attr-arm-sve-vector-bits-call.c` to use the legacy pm with > `-fno-experimental-new-pass-manager`. Thanks f

[PATCH] D86796: [Sema] Address-space sensitive index check for unbounded arrays

chrish_ericsson_atx updated this revision to Diff 288649. chrish_ericsson_atx added a comment. Removed Change-Id from commit log message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86796/new/ https://reviews.llvm.org/D86796 Files: clang/includ

[PATCH] D86796: [Sema] Address-space sensitive index check for unbounded arrays

chrish_ericsson_atx created this revision. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. chrish_ericsson_atx requested review of this revision. Check applied to unbounded (incomplete) arrays and pointers to spot cases where the computed address is beyond the large

[PATCH] D86795: [PowerPC] Implement builtins for xvcvspbf16 and xvcvbf16spn

amyk created this revision. amyk added reviewers: bsaleil, lei, nemanjai, power-llvm-team, PowerPC. amyk added projects: LLVM, PowerPC. Herald added subscribers: llvm-commits, cfe-commits, shchenz, hiraditya. Herald added a project: clang. amyk requested review of this revision. This patch adds th

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.h:44 llvm::Optional - GetDeclFailureInfo(const StringRef &TypeName, const NamedDecl *Decl, + getDeclFailureInfo(const StringRef &TypeName, const NamedDecl *Decl,

[clang] 331dcc4 - [PowerPC] Implemented Vector Load with Zero and Signed Extend Builtins

Author: Albion Fung Date: 2020-08-28T11:28:58-05:00 New Revision: 331dcc43eac28b8e659f928fd1f1ce7fd091e1e3 URL: https://github.com/llvm/llvm-project/commit/331dcc43eac28b8e659f928fd1f1ce7fd091e1e3 DIFF: https://github.com/llvm/llvm-project/commit/331dcc43eac28b8e659f928fd1f1ce7fd091e1e3.diff L

[PATCH] D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Conanap marked an inline comment as done. Closed by commit rG331dcc43eac2: [PowerPC] Implemented Vector Load with Zero and Signed Extend Builtins (authored by Conanap).

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.h:44 llvm::Optional - GetDeclFailureInfo(const StringRef &TypeName, const NamedDecl *Decl, + getDeclFailureInfo(const StringRef &TypeName, const NamedDecl *Decl,

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob marked 2 inline comments as not done. dougpuob added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.h:44 llvm::Optional - GetDeclFailureInfo(const StringRef &TypeName, const NamedDecl *Decl, + getDeclFailureInfo(const Stri

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

froydnj requested review of this revision. froydnj added a comment. Throwing this back into the review queue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81865/new/ https://reviews.llvm.org/D81865 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

froydnj updated this revision to Diff 288628. froydnj added a comment. Updated to use a struct instead of a union for the actual table in an effort to avoid UB. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81865/new/ https://reviews.llvm.org/D81865 Files: clang/lib/Basic/Diagnostic

[PATCH] D85743: [CodeGen][AArch64] Support arm_sve_vector_bits attribute

c-rhodes added a comment. In D85743#2243188 , @c-rhodes wrote: > In D85743#2242931 , @leonardchan > wrote: > >> Hi! The `attr-arm-sve-vector-bits-call.c` test seems to be failing on our >> clang builders: >> >> Co

[PATCH] D85032: [builtins] Make divXf3 handle denormal results

atrosinenko updated this revision to Diff 288625. atrosinenko added a comment. Re-upload after changing parent diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85032/new/ https://reviews.llvm.org/D85032 Files: compiler-rt/lib/builtins/fp_div_

[PATCH] D85031: [builtins] Unify the softfloat division implementation

atrosinenko updated this revision to Diff 288623. atrosinenko added a comment. Add some other explanations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85031/new/ https://reviews.llvm.org/D85031 Files: compiler-rt/lib/builtins/divdf3.c compi

[PATCH] D86065: [SVE] Make ElementCount members private

rsandifo-arm added a comment. In D86065#2241146 , @david-arm wrote: > Hi @ctetreau, ok for now I'm going to completely remove the operators and > revert the code using those operators to how it was before. I'm not sure what > you mean about the predicate

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:428 case IdentifierNamingCheck::CT_HungarianNotation: { const NamedDecl *pNamedDecl = dyn_cast(pDecl); aaron.ballman wrote: > I feel like I m

[PATCH] D33825: [clang-tidy] signal handler must be plain old function check

jfb requested changes to this revision. jfb added a comment. This revision now requires changes to proceed. Herald added a subscriber: dexonsmith. Please consider these changes, and whether this is relevant as implemented: http://wg21.link/p0270 Comment at: clang-tools-extra/

[PATCH] D33825: [clang-tidy] signal handler must be plain old function check

bruntib updated this revision to Diff 288617. bruntib added a comment. Update lincense. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33825/new/ https://reviews.llvm.org/D33825 Files: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp clang-t

[PATCH] D86531: [analyzer][StdLibraryFunctionsChecker][NFC] Use Optionals throughout the summary API

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1006 +return IntRangeVector{std::pair{b, *e}}; + return IntRangeVector{}; +} This return of empty vector and possibility of adding empty

[PATCH] D33825: [clang-tidy] signal handler must be plain old function check

bruntib updated this revision to Diff 288606. bruntib added a comment. Herald added a subscriber: mgehre. I rebased the patch so it compiles with master version of LLVM/Clang. I did no other change, so I would like if this patch would be committed on behalf of @NorenaLeonetti if the patch is acc

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.h:44 llvm::Optional - GetDeclFailureInfo(const StringRef &TypeName, const NamedDecl *Decl, + getDeclFailureInfo(const StringRef &TypeName, const NamedDecl *Decl,

[PATCH] D33825: [clang-tidy] signal handler must be plain old function check

bruntib commandeered this revision. bruntib added a reviewer: NorenaLeonetti. bruntib added a comment. Herald added subscribers: martong, steakhal, jfb. I'll rebase this patch and continue its development. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33825/new/ h

[PATCH] D67113: ICK_Function_Conversion is a third kind conversion

aaron.ballman added a comment. In D67113#2243451 , @aaronpuchert wrote: > Maybe this is to trivial for a review. The comment on > `StandardConversionSequence::Third` in clang/Sema/Overload.h says > >> The third conversion can be a qualification conversio

[PATCH] D84603: Thread safety analysis: More consistent warning message

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:1644 if (!LDat) { - Analyzer->Handler.handleMutexNotHeld("", D, POK, Cp.toString(), - LK_Shared, Loc); + Analyzer->Handler.handleMutexNotH

[PATCH] D86531: [analyzer][StdLibraryFunctionsChecker][NFC] Use Optionals throughout the summary API

martong marked 3 inline comments as done. martong added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86531/new/ https://reviews.llvm.org/D86531 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D86721: [clang-format] Parse double-square attributes as pointer qualifiers

aaron.ballman added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:8071 verifyIndependentOfContext("MACRO(A *__attribute((foo)) a);"); + verifyIndependentOfContext("MACRO(A *[[clang::attr]] a);"); verifyIndependentOfContext("MACRO('0' <= c && c <= '9');

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

stuij added a comment. @ostannard: pinging on behalf of @dnsampaio. The changes still apply cleanly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https://reviews.llvm.org/D72932 ___ cfe-commi

[PATCH] D86743: [analyzer] Ignore VLASizeChecker case that could cause crash

balazske added a comment. I do not know how these changes can appear: F12796482: Screenshot from 2020-08-28 16-06-02.png The checker makes only 2 assumptions, about the array dimension being positive and about the size of the array and the extent. (This state

[PATCH] D85031: [builtins] Unify the softfloat division implementation

atrosinenko updated this revision to Diff 288599. atrosinenko added a comment. This update is expected to be completely NFC w.r.t. code behavior and significantly clarify the proof up to the end of half-width iterations. Particularly, the reasoning about possible overflow of intermediate results

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

martong added a comment. In D72705#2238487 , @Szelethus wrote: > I debated this >

[PATCH] D86065: [SVE] Make ElementCount members private

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4257c5832aa: [SVE] Make ElementCount members private (authored by david-arm). Changed prior to commit: https://reviews.llvm.org/D86065?vs=288370&id=288594#toc Repository: rG LLVM Github Monorepo CH

[clang] f4257c5 - [SVE] Make ElementCount members private

Author: David Sherwood Date: 2020-08-28T14:43:53+01:00 New Revision: f4257c5832aa51e960e7351929ca3d37031985b7 URL: https://github.com/llvm/llvm-project/commit/f4257c5832aa51e960e7351929ca3d37031985b7 DIFF: https://github.com/llvm/llvm-project/commit/f4257c5832aa51e960e7351929ca3d37031985b7.diff

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

martong added a comment. > Another solution for the problem is if the system calls are modeled in a way > that there is always a state split between error end non-error (we will have > a path where it is known that the specific variable can be only (for example) > NULL and this can be detected

[PATCH] D86751: Add new warning for compound punctuation tokens that are split across macro expansions or split by whitespace.

sbenza accepted this revision. sbenza added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Parser/compound-token-split.cpp:30 + +[ // expected-warning-re ^}}'[' tokens introducing attribute appear in different source files}} +#define

[PATCH] D86743: [analyzer] Ignore VLASizeChecker case that could cause crash

vabridgers added a comment. Thanks Balazs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86743/new/ https://reviews.llvm.org/D86743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

Eugene.Zelenko added a comment. In D86671#2244236 , @dougpuob wrote: > In D86671#2243788 , @Eugene.Zelenko > wrote: > >> It'll be good idea to add test case. > > Hi @Eugene.Zelenko, > I have created a `readability-

[PATCH] D86736: [analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a GDM trait

martong added a comment. > For any other loops, in order to know whether we should analyze another > iteration, among other things, we evaluate it's condition. Which is a problem > for ObjCForCollectionStmt, because it simply doesn't have one Shouldn't we try to fix the ObjCForCollectionStmt in

[PATCH] D86782: [clang-format] Allow configuring list of macros that map to attributes

arichardson created this revision. arichardson added reviewers: MyDeveloperDay, JakeMerdichAMD, sammccall, curdeius, jrtc27. Herald added a project: clang. Herald added a subscriber: cfe-commits. arichardson requested review of this revision. This adds a `AttributeMacros` configuration option tha

[PATCH] D86660: Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl

labath added a comment. I'm going to respond to the rest of your (very insightful) comment later. So far, I'm just responding to this: >> This isn't exactly layout related, but there is the question of covariant >> methods. If a method is covariant, then its return type must be complete. > >

[PATCH] D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__

martong added a comment. In D86135#2235473 , @Szelethus wrote: > In D86135#2233611 , @martong wrote: > >>> The fundamental problem is, we simply can't ask Preprocessor what a macro >>> expands into without hacking

[PATCH] D86743: [analyzer] Ignore VLASizeChecker case that could cause crash

balazske added a comment. The fix is probably OK but I could not find out what causes the problem in this case and not in other (similar) ones. Why is not possible to assume `SVB.evalEQ(State, DynSize, *ArraySizeNL)` to true: DynSize: `extent_$1{e}` *ArraySizeNL: `8 U64b` The problem occurs like

[PATCH] D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:896-898 +RawLexer.reset(new Lexer(SM.getLocForStartOfFile(LocInfo.first), LangOpts, + MB->getBufferStart(), MacroNameTokenPos, +

[PATCH] D86780: Copy blocks in variadic methods

sunbohong created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. sunbohong requested review of this revision. This commit will fix https://bugs.llvm.org/show_bug.cgi?id=46399. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86780 Files:

[PATCH] D86660: Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:1755-1759 + QualType FromTy = ArrayFrom->getElementType(); + QualType ToTy = ArrayTo->getElementType(); + + FromRecordDecl = FromTy->getAsRecordDecl(); + ToRecordDecl = To

[clang] a146195 - [SyntaxTree] Add coverage for declarators and init-declarators

Author: Eduardo Caldas Date: 2020-08-28T12:19:38Z New Revision: a1461953f4efe574e3fdecfbae68bd18707748fb URL: https://github.com/llvm/llvm-project/commit/a1461953f4efe574e3fdecfbae68bd18707748fb DIFF: https://github.com/llvm/llvm-project/commit/a1461953f4efe574e3fdecfbae68bd18707748fb.diff LOG

[clang] 38bc006 - [SyntaxTree][NFC] Refactor function templates into functions taking base class

Author: Eduardo Caldas Date: 2020-08-28T12:19:38Z New Revision: 38bc0060e60fef5395c23b8b75163e5bdee23af6 URL: https://github.com/llvm/llvm-project/commit/38bc0060e60fef5395c23b8b75163e5bdee23af6 DIFF: https://github.com/llvm/llvm-project/commit/38bc0060e60fef5395c23b8b75163e5bdee23af6.diff LOG

[PATCH] D86719: [SyntaxTree][NFC] Refactor function templates into functions taking base class

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. eduucaldas marked an inline comment as done. Closed by commit rG38bc0060e60f: [SyntaxTree][NFC] Refactor function templates into functions taking base class (authored b

[PATCH] D86065: [SVE] Make ElementCount members private

paulwalker-arm added a comment. To be more clear, I'm happy to defer the divide conversation for if/when we run into issues so my previous acceptance still stands. It'll be good to get the intent of the patch in (i.e. stoping access to internal class members) asap, plus any follow up work will

[PATCH] D86719: [SyntaxTree][NFC] Refactor function templates into functions taking base class

eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:245 +/// `int S::f(){}` -> range of `S::f()`. +/// FIXME: \p Name must be a source range, e.g. for `operator+`. static SourceRange getDeclaratorR

[PATCH] D86719: [SyntaxTree][NFC] Refactor function templates into functions taking base class

eduucaldas updated this revision to Diff 288584. eduucaldas marked an inline comment as done. eduucaldas added a comment. Rebase and answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86719/new/ https://reviews.llvm.org/D86719 Files:

[PATCH] D86778: Extract infrastructure to ignore intermediate expressions into `clang/AST/IgnoreExpr.h`

gribozavr2 added a comment. > This allows users to use IgnoreExprNodes outside of clang/AST/Expr.h Did you mean "outside of Expr.cpp"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86778/new/ https://reviews.llvm.org/D86778 __

[PATCH] D86778: Extract infrastructure to ignore intermediate expressions into `clang/AST/IgnoreExpr.h`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. This allows users to use `IgnoreExprNodes` outside of `clang/AST/Expr.h` Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86778

[PATCH] D86775: [clang-format] Parse __ptr32/__ptr64 as a pointer qualifier

arichardson created this revision. arichardson added reviewers: MyDeveloperDay, JakeMerdichAMD, sammccall, curdeius. Herald added a project: clang. Herald added a subscriber: cfe-commits. arichardson requested review of this revision. Before: x = (foo *__ptr32) * v; MACRO(A * __ptr32 a); x = (foo

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. In D86671#2243788 , @Eugene.Zelenko wrote: > It'll be good idea to add test case. Hi @Eugene.Zelenko, I have created a `readability-identifier-naming-hungarain-notion.cpp` file and several test cases for regression testing. Is

  1   2   >