[PATCH] D84623: Remove HAVE_VCS_VERSION_INC, not needed

hlopko added a comment. Herald added a subscriber: JDevlieghere. Friendly ping, this change will remove HAVE_VCS_VERSION_INC define. If you disagree, please complain :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84623/new/ https://reviews.llvm.

[PATCH] D85938: [OpenMP][OMPIRBuilder] Use the source (=directory + filename) for locations

lebedev.ri added a comment. still lg, i guess Comment at: clang/test/OpenMP/irbuilder_nested_parallel_for.c:258 +// CHECK-DEBUG-NEXT:call void @__kmpc_barrier(%struct.ident_t* [[GLOB83:@.*]], i32 [[OMP_GLOBAL_THREAD_NUM239]]), [[DBG107]] +// CHECK-DEBUG-NEXT:ret void,

[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

davidxl added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HeapProfiler.cpp:512 + +int ModuleHeapProfiler::GetHeapProfVersion(const Module &M) const { return 1; } + define a macro for the version number? Repository: rG LLVM Github Monorepo

[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

davidxl added a comment. one nit: since the same instrumentation can be used to profiling global variable accesses (especially those indirect accessed), the option name seems excluding those cases. Shall it be renamed to fmem-prof? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:619 getCheckerManager().runCheckersForEvalCall(DstEvaluated, *I, *Call, *this, - CallOpts); +

[PATCH] D85878: [OpenMP] Context selector extensions for return value overloading

jdoerfert added a comment. In D85878#2217408 , @JonChesterfield wrote: > If I recall correctly, &foo with variants of foo returns a pointer to the > base. Correct. > If we have no base, and disable_implicit_base, what does &foo yield? It > should prob

[PATCH] D85810: [clang] Pass-through remarks options to lld

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:81 +CmdArgs.push_back("-mllvm"); +std::string Passes = std::string("-pass-remarks=") + A->getValue(); +CmdArgs.push_back(Args.MakeArgString(Passes)); Delete such one

[PATCH] D85810: [clang] Pass-through remarks options to lld

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:71 + + bool isLLD = llvm::sys::path::filename(LinkerPath) == "ld.lld" || + llvm::sys::path::stem(LinkerPath) != "ld.lld"; Checking the path is brittle. Consider

[PATCH] D85938: [OpenMP][NFC] Update check lines after D85099

jdoerfert updated this revision to Diff 285551. jdoerfert added a comment. This revision is now accepted and ready to land. Herald added subscribers: llvm-commits, ormris, hiraditya. Herald added a project: LLVM. Resolve the root cause Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

vitalybuka added a comment. LGTM with some nits Comment at: llvm/lib/Transforms/Instrumentation/HeapProfiler.cpp:124 + +namespace { + maybe remove all static about and extend namespace {} Comment at: llvm/lib/Transforms/Instrumentation/HeapPr

[PATCH] D85878: [OpenMP] Context selector extensions for return value overloading

JonChesterfield added a comment. If I recall correctly, &foo with variants of foo returns a pointer to the base. If we have no base, and disable_implicit_base, what does &foo yield? It should probably be a compilation error with some descriptive message Repository: rG LLVM Github Monorepo C

[PATCH] D85877: [OpenMP] Support nested OpenMP context selectors (declare variant)

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Thanks! Probably good to implement this just at the time math headers needs it as that gives us a real world example of the change working. Repository: rG LLVM Github Mono

[PATCH] D85879: [OpenMP] Overload `std::isnan` and friends multiple times for the GPU

JonChesterfield added a comment. I think this is reasonable. It's unfortunate to have isnan return bool or int depending on the system headers, but considering we have that in a language that doesn't mangle the return type into the name the workaround seems OK. I think `#define isnan()` in a sy

[PATCH] D85619: [clang][OpenMP][OMPBuilder] Use OMPBuilder to CG `omp single`

fghanim added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85619/new/ https://reviews.llvm.org/D85619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D85938: [OpenMP][NFC] Update check lines after D85099

jdoerfert added a comment. Root cause: We sometimes, depending on the invocation and potentially other factors, use a full path and sometimes not: So wen I run this with clang locally I get this: @98 = private unnamed_addr constant [98 x i8] c";/data/src/llvm-project/clang/test/OpenMP/irbuild

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

JohelEGP added a comment. In D79773#2141164 , @MyDeveloperDay wrote: > This is actually failing in the handling of parsing the `<>` in > (`parseAngle()` actually `parseBrace()` inside of that), it is not really > concepts specific except it may be seen

[PATCH] D85879: [OpenMP] Overload `std::isnan` and friends multiple times for the GPU

jdoerfert added inline comments. Comment at: clang/lib/Headers/__clang_cuda_cmath.h:85 +//(note that we do not create implicit base functions here). To avoid +//this clash we add a new trait to some of them that is always true +//(this is LLVM after all ;)

[PATCH] D85808: [remarks] Optimization remarks hotness filtering from profile summary

tejohnson added inline comments. Comment at: lld/ELF/Config.h:280 + // If threshold option is not specified, it is disabled by default. + llvm::Optional optRemarksHotnessThreshold = 0; weiwang wrote: > tejohnson wrote: > > Since this field is being added in p

[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

tejohnson created this revision. tejohnson added reviewers: vitalybuka, kcc, eugenis, davidxl. Herald added subscribers: dang, jfb, hiraditya, mgorny. Herald added projects: clang, LLVM. tejohnson requested review of this revision. See RFC for background: http://lists.llvm.org/pipermail/llvm-dev/2

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

Szelethus added inline comments. Comment at: clang/lib/Analysis/SarifPathDiagnosticConsumer.cpp:307 .Case(FULLNAME, HELPTEXT) #include "clang/StaticAnalyzer/Checkers/Checkers.inc" #undef CHECKER NoQ wrote: > This thing still worries me but this definitely is

[PATCH] D85808: [remarks] Optimization remarks hotness filtering from profile summary

weiwang added a comment. In D85808#2214272 , @tejohnson wrote: > In D85808#2212297 , @weiwang wrote: > >> This is the 3rd of 3 dependent patches: >> >> 1. [lld] Enable remarks hotness filtering in lld: >> https://r

[PATCH] D85879: [OpenMP] Overload `std::isnan` and friends multiple times for the GPU

tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_cmath.h:85 +//(note that we do not create implicit base functions here). To avoid +//this clash we add a new trait to some of them that is always true +//(this is LLVM after all ;)). It

[PATCH] D85879: [OpenMP] Overload `std::isnan` and friends multiple times for the GPU

jdoerfert added inline comments. Comment at: clang/lib/Headers/__clang_cuda_cmath.h:85 +//(note that we do not create implicit base functions here). To avoid +//this clash we add a new trait to some of them that is always true +//(this is LLVM after all ;)

[PATCH] D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor

vrnithinkumar marked 5 inline comments as done. vrnithinkumar added a comment. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:619 getCheckerManager().runCheckersForEvalCall(DstEvaluated, *I, *Call, *this, - C

[PATCH] D85559: [MSAN] Reintroduce libatomic load/store instrumentation

eugenis added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:3513 +assert(InsPoint); +if (!InsPoint) { + return; guiand wrote: > TODO: Remove this redudant call you've already checked it with assert(isa) - which

[PATCH] D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae6523cd62a4: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing… (authored by akhuang). Changed prior to commit: htt

[PATCH] D85573: [CGAtomic] Mark atomic libcall functions `nounwind`

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85573/new/ https://reviews.llvm.org/D85573 ___

[PATCH] D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor

vrnithinkumar updated this revision to Diff 285514. vrnithinkumar added a comment. - Addressing review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85796/new/ https://reviews.llvm.org/D85796 Files: clang/include/clang/StaticAnalyzer/Co

[clang] ae6523c - [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on.

Author: Amy Huang Date: 2020-08-13T15:48:55-07:00 New Revision: ae6523cd62a44642390f4f9d9ba9ce17d5bbbc58 URL: https://github.com/llvm/llvm-project/commit/ae6523cd62a44642390f4f9d9ba9ce17d5bbbc58 DIFF: https://github.com/llvm/llvm-project/commit/ae6523cd62a44642390f4f9d9ba9ce17d5bbbc58.diff LOG

[PATCH] D85938: [OpenMP][NFC] Update check lines after D85099

hubert.reinterpretcast added a comment. In D85938#2216905 , @lebedev.ri wrote: > Thanks. Seems to fix the test for me FWIW, but > > 1. why wasn't this caught by anyone and all of the bots? For what it's worth, I have been affected by this and was drafting

[PATCH] D85938: [OpenMP][NFC] Update check lines after D85099

jdoerfert planned changes to this revision. jdoerfert added a comment. Something is fishy here. Now the pre-merge tests fail... this should accept strictly more... I have to look into this, best guess: some non-determinism Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D85943: Hack for automating fixes for some -Wconversion warning instances

leonardchan created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. leonardchan requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85943 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Frontend/fuchsia-wc

[PATCH] D85924: [clang][feature] Add cxx_abi_relative_vtable feature

leonardchan updated this revision to Diff 285506. leonardchan retitled this revision from "[clang] Add __RELATIVE_CXX_ABI_VTABLES predefine macro" to "[clang][feature] Add cxx_abi_relative_vtable feature". leonardchan edited the summary of this revision. Repository: rG LLVM Github Monorepo CHA

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl marked 3 inline comments as done. yaxunl added a comment. In D60620#2216796 , @tra wrote: > Couple of minor nits. LGTM otherwise. Will revise as suggested when committing. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60620/new/

[PATCH] D85938: [OpenMP][NFC] Update check lines after D85099

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Thanks. Seems to fix the test for me FWIW, but 1. why wasn't this caught by anyone and all of the bots? 2. what is the actual underlying problem, if any? Repository: rG LLVM Github

[PATCH] D85938: [OpenMP][NFC] Update check lines after D85099

jdoerfert created this revision. jdoerfert added a reviewer: lebedev.ri. Herald added subscribers: guansong, bollu, yaxunl. Herald added a project: clang. jdoerfert requested review of this revision. Herald added a subscriber: sstefan1. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added a comment. Actually I think any subsequent updates to tests can be done in a follow-up patch, since I'm not changing the status-quo on address space here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/

[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

danielkiss marked an inline comment as done. danielkiss added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:352 +def FeatureEmitNoteBTIProperty : SubtargetFeature<"markbtiproperty", "MarkBTIProperty", +"true", "Emit .note.gnu.property for Branch Target Id

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp:103 +Context->getOptions().CheckOptions) +.get("UseAssignment", 0) != 0) {} + `Opt

[PATCH] D85934: Enable OpenMP offloading to VE and enable tests for offloading to VE

manorom created this revision. manorom added a reviewer: simoll. Herald added subscribers: openmp-commits, cfe-commits, guansong, yaxunl, mgorny. Herald added projects: clang, OpenMP. manorom requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1.

[PATCH] D60620: [HIP] Support target id by --offload-arch

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Couple of minor nits. LGTM otherwise. Comment at: clang/include/clang/Basic/TargetID.h:42 +/// is not a null pointer. +/// If \p CanonicalizeProc is true, canonicalize returned pro

[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

danielkiss updated this revision to Diff 285492. danielkiss added a comment. Fix review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81930/new/ https://reviews.llvm.org/D81930 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp clang/test

[PATCH] D85924: [clang] Add __RELATIVE_CXX_ABI_VTABLES predefine macro

mcgrathr added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:1127 + if (LangOpts.RelativeCXXABIVTables) +Builder.defineMacro("__RELATIVE_CXX_ABI_VTABLES"); ldionne wrote: > mcgrathr wrote: > > This should also test `LangOpts.CplusPlu

[PATCH] D85933: Don't track consteval references for dependent members

wchilders created this revision. wchilders added reviewers: Tyker, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. wchilders requested review of this revision. Previously dependent references to consteval (`ReferenceToConsteval`) were tracked, and dependent expressi

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan updated this revision to Diff 285488. leonardchan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 Files: clang/include/clang/AST/ASTContext.h clang/include/cl

[PATCH] D85924: [clang] Add __RELATIVE_CXX_ABI_VTABLES predefine macro

mcgrathr added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:1127 + if (LangOpts.RelativeCXXABIVTables) +Builder.defineMacro("__RELATIVE_CXX_ABI_VTABLES"); This should also test `LangOpts.CplusPlus` so it's never defined in C compil

[PATCH] D85924: [clang] Add __RELATIVE_CXX_ABI_VTABLES predefine macro

ldionne added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:1127 + if (LangOpts.RelativeCXXABIVTables) +Builder.defineMacro("__RELATIVE_CXX_ABI_VTABLES"); Should we be using some `__has_feature(...)` instead? Repository: rG LLVM

[PATCH] D84029: [clang][Driver] Default to /usr/bin/ld on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rGf59bec7acb82: [clang][Driver] Default to /usr/bin/ld on Solaris (authored by ro). Changed prior to commit: https://reviews.llvm.org/D84029?vs=282192&id=285484#toc Repository: rG LLVM Github Monorepo

[clang] f59bec7 - [clang][Driver] Default to /usr/bin/ld on Solaris

Author: Rainer Orth Date: 2020-08-13T22:42:58+02:00 New Revision: f59bec7acb8228fc215fca3ee1e524c38083c50b URL: https://github.com/llvm/llvm-project/commit/f59bec7acb8228fc215fca3ee1e524c38083c50b DIFF: https://github.com/llvm/llvm-project/commit/f59bec7acb8228fc215fca3ee1e524c38083c50b.diff L

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl added inline comments. Comment at: clang/include/clang/Basic/TargetID.h:42 +/// is not a null pointer. +/// If \p CanonicalizeProc is true, canonicalize returned processor name. +llvm::Optional tra wrote: > Comment needs updating as parameters and return v

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl updated this revision to Diff 285482. yaxunl marked 13 inline comments as done. yaxunl added a comment. revised by Artem's comments, with minor bug fixes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60620/new/ https://reviews.llvm.org/D60620 Files: clang/include/clang/Basic/

[PATCH] D85879: [OpenMP] Overload `std::isnan` and friends multiple times for the GPU

tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_cmath.h:85 +//(note that we do not create implicit base functions here). To avoid +//this clash we add a new trait to some of them that is always true +//(this is LLVM after all ;)). It

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb updated this revision to Diff 285479. jfb added a comment. Fix a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Builtins.def

[PATCH] D85843: Add "status" to the list of absl libraries.

oontvoo added a comment. (With LGTM from sbenza) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85843/new/ https://reviews.llvm.org/D85843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D85843: Add "status" to the list of absl libraries.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG114c9fa0e46f: Add "status" to the list of absl libraries. (authored by oontvoo). Repository: rG LLVM Github Monorepo C

[clang-tools-extra] 114c9fa - Add "status" to the list of absl libraries.

Author: Vy Nguyen Date: 2020-08-13T16:08:14-04:00 New Revision: 114c9fa0e46f7bf1d05d92da70da116b19f16911 URL: https://github.com/llvm/llvm-project/commit/114c9fa0e46f7bf1d05d92da70da116b19f16911 DIFF: https://github.com/llvm/llvm-project/commit/114c9fa0e46f7bf1d05d92da70da116b19f16911.diff LOG

[clang] dedaf78 - [SystemZ][z/OS] enable trigraphs by default on z/OS

Author: Abhina Sreeskantharajan Date: 2020-08-13T16:02:07-04:00 New Revision: dedaf78fa71433d3c9da2e3d2f3dad3e9cd3bdd2 URL: https://github.com/llvm/llvm-project/commit/dedaf78fa71433d3c9da2e3d2f3dad3e9cd3bdd2 DIFF: https://github.com/llvm/llvm-project/commit/dedaf78fa71433d3c9da2e3d2f3dad3e9cd3

[PATCH] D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS

This revision was automatically updated to reflect the committed changes. Closed by commit rGdedaf78fa714: [SystemZ][z/OS] enable trigraphs by default on z/OS (authored by abhina.sreeskantharajan, committed by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D85787: [InstCombine] Aggregate reconstruction simplification (PR47060)

lebedev.ri added a comment. @spatel thank you for taking a look! In D85787#2216518 , @spatel wrote: > In D85787#2214038 , @lebedev.ri > wrote: > >> @ reviewers - i'm not so much interested in deep code/algo review

[PATCH] D85787: [InstCombine] Aggregate reconstruction simplification (PR47060)

spatel added a comment. In D85787#2214038 , @lebedev.ri wrote: > @ reviewers - i'm not so much interested in deep code/algo review, > but more like in the general direction disscussion, like, is this okay for > instcombine? :) The test diffs look great,

[PATCH] D85735: [OpenMP] Context selector extensions for template functions

jdoerfert updated this revision to Diff 285468. jdoerfert added a comment. Test formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85735/new/ https://reviews.llvm.org/D85735 Files: clang/include/clang/Basic/AttrDocs.td clang/include/clan

[PATCH] D85879: [OpenMP] Overload `std::isnan` and friends multiple times for the GPU

jdoerfert added a comment. (I think the tests are failing due to missing parent revisions in the build, these have to go in in-order.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85879/new/ https://reviews.llvm.org/D85879 __

[PATCH] D85924: [clang] Add __RELATIVE_CXX_ABI_VTABLES predefine macro

leonardchan created this revision. leonardchan added reviewers: mcgrathr, phosek. leonardchan added a project: libc++abi. Herald added a project: clang. Herald added a subscriber: cfe-commits. leonardchan requested review of this revision. This will be set if relative vtables are enabled. Reposi

[PATCH] D85875: [OpenMP][FIX] Do not crash trying to print a missing (demangled) user condition

jdoerfert updated this revision to Diff 285463. jdoerfert added a comment. Remove leftover comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85875/new/ https://reviews.llvm.org/D85875 Files: clang/lib/AST/OpenMPClause.cpp clang/test/AST/as

[PATCH] D85875: [OpenMP][FIX] Do not crash trying to print a missing (demangled) user condition

jdoerfert added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:2204-2207 +if (Selector.ScoreOrCondition) + Selector.ScoreOrCondition->printPretty(OS, nullptr, Policy); +else + OS << "..."; ABataev wrote: > Why it can

[PATCH] D85878: [OpenMP] Context selector extensions for return value overloading

jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5879 D.SetIdentifier(&VariantII, D.getBeginLoc()); return BaseFD; } ABataev wrote: > Does the user of this function expect that BaseFD can be `nullptr` after this > change? It was

[PATCH] D85923: [clangd] Fix crash-bug in preamble indexing when using modules.

adamcz created this revision. adamcz added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. adamcz requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. When preamble contains #undef,

[PATCH] D85879: [OpenMP] Overload `std::isnan` and friends multiple times for the GPU

jdoerfert added inline comments. Comment at: clang/lib/Headers/__clang_cuda_cmath.h:85 +//(note that we do not create implicit base functions here). To avoid +//this clash we add a new trait to some of them that is always true +//(this is LLVM after all ;)

[clang] c2807b2 - [darwin][driver] fix isMacosxVersionLT minimum supported OS version check

Author: Alex Lorenz Date: 2020-08-13T12:06:45-07:00 New Revision: c2807b2e56c05080354818c221ed4a35abd8a5c8 URL: https://github.com/llvm/llvm-project/commit/c2807b2e56c05080354818c221ed4a35abd8a5c8 DIFF: https://github.com/llvm/llvm-project/commit/c2807b2e56c05080354818c221ed4a35abd8a5c8.diff L

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

MaskRay added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:299 + /// This overrides the default ABI used by the target. + TargetCXXABI::Kind CXXABIOverride; + bool HasCXXABIOverride = false; This is usually represented with llvm::Option

[PATCH] D85920: [FPEnv][AST] WIP!!! For casts, keep FP options in trailing storage of CastExpr

kpn created this revision. kpn added reviewers: rjmccall, mibintc, shafik, sepavloff. kpn added a project: clang. Herald added subscribers: cfe-commits, jfb, martong. kpn requested review of this revision. This change allows FP options to be in the trailing storage of CastExpr. Needed for proper

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan updated this revision to Diff 285449. leonardchan added a comment. Store a TargetCXXABI::Kind instead of a string in LangOpts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 Files: clang/incl

Re: [PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

Done > Dňa 13. 8. 2020 o 7:29 užívateľ Arthur Eubanks via Phabricator > napísal: > > aeubanks added a comment. > > It still seems to trigger on structs at head: > > $ cat /tmp/a.cc > struct A { > > const char *a; > const char *b; > const char *c; > > }; > > static A a = {"", > > ""

[clang] 2f7adf5 - [Diagnostics] Skip var decl of structs for -Wstring-concatenation

Author: Dávid Bolvanský Date: 2020-08-13T20:20:26+02:00 New Revision: 2f7adf5ee37934ee5769276644fcafbc9d4dcda3 URL: https://github.com/llvm/llvm-project/commit/2f7adf5ee37934ee5769276644fcafbc9d4dcda3 DIFF: https://github.com/llvm/llvm-project/commit/2f7adf5ee37934ee5769276644fcafbc9d4dcda3.dif

[PATCH] D85917: [MSP430] Fix passing C structs and unions as function arguments

atrosinenko updated this revision to Diff 285436. atrosinenko added a comment. Restore test formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85917/new/ https://reviews.llvm.org/D85917 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/Code

[PATCH] D85917: [MSP430] Fix passing C structs and unions as function arguments

atrosinenko created this revision. atrosinenko added reviewers: asl, krisb, arsenm, rjmccall, jdoerfert. Herald added a project: clang. atrosinenko requested review of this revision. Herald added a subscriber: wdng. Pass structures, classes and unions by reference on MSP430, according to Section

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D71199#2215719 , @baloghadamsoftware wrote: > Since no better idea cam to my mind, in this version I check whether > `modernize-use-d

[PATCH] D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS

abhina.sreeskantharajan updated this revision to Diff 285427. abhina.sreeskantharajan added a comment. Thanks for catching that. I fixed up the testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85722/new/ https://reviews.llvm.org/D85722 File

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

dblaikie added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4642 +int Num; +if (V == "future") + A->render(Args, CmdArgs); ro wrote: > MaskRay wrote: > > phosek wrote: > > > Another option would be `unstable`. > > I picked `futu

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4642 +int Num; +if (V == "future") + A->render(Args, CmdArgs); MaskRay wrote: > phosek wrote: > > Another option would be `unstable`. > I picked `future` because there is an

[PATCH] D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM with suggested changes. Comment at: clang/test/Lexer/cxx1z-trigraphs.cpp:19 +// Note, there is intentionally trailing whitespace one lines below. // ??/ +error here; In

[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/Syntax/TreeTestBase.cpp:38 +namespace { +static ArrayRef tokens(syntax::Node *N) { + assert(N->isOriginal() && "tokens of mod

[PATCH] D85798: Split Preprocessor/init.c test. NFC.

tra added inline comments. Comment at: clang/test/Preprocessor/init-arm.c:19 +// ARM:#define __CHAR16_TYPE__ unsigned short +// ARM:#define __CHAR32_TYPE__ unsigned int +// ARM:#define __CHAR_BIT__ 8 MaskRay wrote: > Consider spending a bit more time and adding `

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4642 +int Num; +if (V == "future") + A->render(Args, CmdArgs); phosek wrote: > Another option would be `unstable`. I picked `future` because there is an precedent: `-mcp

[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

eduucaldas added a reviewer: gribozavr2. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:15-17 +using namespace clang; +using namespace clang::syntax; + Following the [[ https://llvm.org/docs/CodingStandards.html#us

[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

eduucaldas updated this revision to Diff 285421. eduucaldas added a comment. Remove unused `SyntaxTreeTest::addFile` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85913/new/ https://reviews.llvm.org/D85913 Files: clang/unittests/Tooling/Syntax/B

[PATCH] D84029: [clang][Driver] Default to /usr/bin/ld on Solaris

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:573 +const char *DefaultLinker = getDefaultLinker(); +if (!llvm::sys::path::is_absolute(DefaultLinker)) + return GetProgramPath(DefaultLinker); swap then and else branches to a

[PATCH] D85883: [clangd] Add ClangdServer::customAction() extension point

adamcz added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85883/new/ https://reviews.llvm.org/D85883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ added inline comments. Comment at: clang/lib/Analysis/SarifPathDiagnosticConsumer.cpp:307 .Case(FULLNAME, HELPTEXT) #include "clang/StaticAnalyzer/Checkers/Checkers.inc" #undef CHECKER This thing still worries me but this definitely isn't a link-time dep

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ updated this revision to Diff 285417. NoQ added a comment. In D67422#2215371 , @Szelethus wrote: > The patch looks great. I guess the only remaining discussion remains as to > whether this should be in `libAnalysis`, or somewhere else. Here is my take

[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

eduucaldas updated this revision to Diff 285416. eduucaldas added a comment. Fix the diff base Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85913/new/ https://reviews.llvm.org/D85913 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp cla

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb updated this revision to Diff 285414. jfb added a comment. Update overloading as discussed: on the original builtins, and separate the _sized variant, making its 4th parameter non-optional. If this looks good, I'll need to update codege for a few builtins (to handle volatile), as well as add

[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

eduucaldas updated this revision to Diff 285413. eduucaldas added a comment. Switch to using directive on source files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85913/new/ https://reviews.llvm.org/D85913 Files: clang/unittests/Tooling/Syntax

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

vsavchenko accepted this revision. vsavchenko added a comment. Awesome, looks great! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67422/new/ https://reviews.llvm.org/D67422 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

bjope added a comment. In D80525#2215778 , @adamcz wrote: > Looks like it's an issue with not clearing the module cache. I'll revert this > change to fix the build, then re-submit with proper fix. Ok, thanks. Let me know if you want me to investigate fur

[PATCH] D83178: [clangd] Send EOF before resetting diagnostics consumer

This revision was automatically updated to reflect the committed changes. Closed by commit rG66a2e3a52564: [clangd] Send EOF before resetting diagnostics consumer (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83178/new/ https

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0464acd0197c: [clangd] Move clang-tidy check modifications into ClangdServer (authored by kadircet). Changed prior to commit: https://reviews.llvm

[clang-tools-extra] 0464acd - [clangd] Move clang-tidy check modifications into ClangdServer

Author: Kadir Cetinkaya Date: 2020-08-13T18:32:59+02:00 New Revision: 0464acd0197cda149f81dff20bf5c379a057722a URL: https://github.com/llvm/llvm-project/commit/0464acd0197cda149f81dff20bf5c379a057722a DIFF: https://github.com/llvm/llvm-project/commit/0464acd0197cda149f81dff20bf5c379a057722a.dif

[clang-tools-extra] 66a2e3a - [clangd] Send EOF before resetting diagnostics consumer

Author: Kadir Cetinkaya Date: 2020-08-13T18:32:59+02:00 New Revision: 66a2e3a525645ad8d356ef4f5b752bfcae3c27b7 URL: https://github.com/llvm/llvm-project/commit/66a2e3a525645ad8d356ef4f5b752bfcae3c27b7 DIFF: https://github.com/llvm/llvm-project/commit/66a2e3a525645ad8d356ef4f5b752bfcae3c27b7.dif

[PATCH] D85879: [OpenMP] Overload `std::isnan` and friends multiple times for the GPU

tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_cmath.h:85 +//(note that we do not create implicit base functions here). To avoid +//this clash we add a new trait to some of them that is always true +//(this is LLVM after all ;)). It

  1   2   3   >