JonChesterfield added a comment. I think this is reasonable. It's unfortunate to have isnan return bool or int depending on the system headers, but considering we have that in a language that doesn't mangle the return type into the name the workaround seems OK.
I think `#define isnan()` in a system header will clobber the text inside the variant region. Perhaps we want some #ifdef isnan #undef isnan logic, or at least #ifdef isnan #warning? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85879/new/ https://reviews.llvm.org/D85879 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
