[PATCH] D73768: clang-format: [JS] document InsertTrailingCommas.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc04c54fc1f6: clang-format: [JS] document InsertTrailingCommas. (authored by mprobst). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73768/new/ https://revi

[clang] dc04c54 - clang-format: [JS] document InsertTrailingCommas.

Author: Martin Probst Date: 2020-02-03T08:51:52+01:00 New Revision: dc04c54fc1f6660770040f9a17ea600ce95e4b60 URL: https://github.com/llvm/llvm-project/commit/dc04c54fc1f6660770040f9a17ea600ce95e4b60 DIFF: https://github.com/llvm/llvm-project/commit/dc04c54fc1f6660770040f9a17ea600ce95e4b60.diff

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

alexeyr added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp:363 + ASTContext &Context) { + const auto OpKind = getOp(TheExpr); + // if there are no nested operators of the same kind, it's handled by

[PATCH] D73090: [clang-tidy] Fix PR#44528 'modernize-use-using and enums'

f00kat added a comment. Sorry for my english. Sometimes it's more difficult than bug fixing Comment at: clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp:74 if (ReplaceRange.getBegin().isMacroID() || - ReplaceRange.getBegin() >= LastReplacementEnd) { + (Resu

[PATCH] D73090: [clang-tidy] Fix PR#44528 'modernize-use-using and enums'

f00kat updated this revision to Diff 241971. f00kat marked an inline comment as done. f00kat added a comment. Clean up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73090/new/ https://reviews.llvm.org/D73090 Files: clang-tools-extra/clang-tidy/m

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

jdoerfert added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71830/new/ https://reviews.llvm.org/D71830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] 3ecba39 - [Driver][test] Change %itanium_abi_triple to generic ELF

Author: Fangrui Song Date: 2020-02-02T21:46:48-08:00 New Revision: 3ecba396e91ccfb6e066afcfd18bdc24597fe4dd URL: https://github.com/llvm/llvm-project/commit/3ecba396e91ccfb6e066afcfd18bdc24597fe4dd DIFF: https://github.com/llvm/llvm-project/commit/3ecba396e91ccfb6e066afcfd18bdc24597fe4dd.diff

[clang] 7eeb901 - [Driver] Fix fsemantic-interposition.c for Windows and Darwin

Author: Fangrui Song Date: 2020-02-02T20:55:24-08:00 New Revision: 7eeb90152859f254fe4e9182c749ab065d33c89d URL: https://github.com/llvm/llvm-project/commit/7eeb90152859f254fe4e9182c749ab065d33c89d DIFF: https://github.com/llvm/llvm-project/commit/7eeb90152859f254fe4e9182c749ab065d33c89d.diff

[clang] aed488e - [Driver] Move -fsemantic-interposition decision from cc1 to driver

Author: Fangrui Song Date: 2020-02-02T20:45:29-08:00 New Revision: aed488e3a4dfdf15696521e13ac5e6ac2f9e7af7 URL: https://github.com/llvm/llvm-project/commit/aed488e3a4dfdf15696521e13ac5e6ac2f9e7af7 DIFF: https://github.com/llvm/llvm-project/commit/aed488e3a4dfdf15696521e13ac5e6ac2f9e7af7.diff

[PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

calebh added a comment. What about unary operations? I don't see those supported in the current version of libclang Python either. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10833/new/ https://reviews.llvm.org/D10833

[PATCH] D73856: [docu] Improve docu of misc-misplaced-const

AlexanderLanin created this revision. AlexanderLanin added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. East const makes the problem more obvious. With west const people were telling me the const is on the wrong side. Also it's time to use

[clang-tools-extra] d24d8af - Fixed typo in CTE release notes failing build

Author: Nathan James Date: 2020-02-02T21:51:34Z New Revision: d24d8af320fd8977f085ee5ceafadaad98f76bf0 URL: https://github.com/llvm/llvm-project/commit/d24d8af320fd8977f085ee5ceafadaad98f76bf0 DIFF: https://github.com/llvm/llvm-project/commit/d24d8af320fd8977f085ee5ceafadaad98f76bf0.diff LOG:

[PATCH] D73090: [clang-tidy] Fix PR#44528 'modernize-use-using and enums'

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! I'm happy to commit on your behalf once the minor nits are fixed up. Comment at: clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp:73 + // But als

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/QualifiedAutoCheck.cpp:262 + << (Var->getType().isLocalVolatileQualified() ? "volatile " : "") + << Var->getName() << FixItHint::CreateInsertion(InsertPos, "const "); +

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

This revision was automatically updated to reflect the committed changes. njames93 marked an inline comment as done. Closed by commit rG8a68c40a1bf2: [clang-tidy] Added option for disabling const qualifiers in readability… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang-tools-extra] 8a68c40 - [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

Author: Nathan James Date: 2020-02-02T21:27:25Z New Revision: 8a68c40a1bf256523993ee97b39f79001eaade91 URL: https://github.com/llvm/llvm-project/commit/8a68c40a1bf256523993ee97b39f79001eaade91 DIFF: https://github.com/llvm/llvm-project/commit/8a68c40a1bf256523993ee97b39f79001eaade91.diff LOG:

[PATCH] D73843: [clang-tidy] Fix false positive for cppcoreguidelines-init-variables

This revision was automatically updated to reflect the committed changes. Closed by commit rGefcd09cea9a5: [clang-tidy] Fix false positive for cppcoreguidelines-init-variables (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7384

[clang-tools-extra] efcd09c - [clang-tidy] Fix false positive for cppcoreguidelines-init-variables

Author: Nathan James Date: 2020-02-02T21:26:29Z New Revision: efcd09cea9a51c522954aa24e4b5513266daf6c3 URL: https://github.com/llvm/llvm-project/commit/efcd09cea9a51c522954aa24e4b5513266daf6c3 DIFF: https://github.com/llvm/llvm-project/commit/efcd09cea9a51c522954aa24e4b5513266daf6c3.diff LOG:

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/QualifiedAutoCheck.cpp:262 + << (Var->getType().isLocalVolatileQualified() ? "volatile " : "") + << Var->getName() << FixItHint::Creat

[PATCH] D73843: [clang-tidy] Fix false positive for cppcoreguidelines-init-variables

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73843/new/ https://reviews.llvm.org/D73843

[PATCH] D73090: [clang-tidy] Fix PR#44528 'modernize-use-using and enums'

f00kat updated this revision to Diff 241931. f00kat added a comment. 1. clang-format 2. Add comment for additional "files IDs equals" check 3. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73090/new/ https://reviews.llvm.org/D73090 Files:

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/readability/QualifiedAutoCheck.cpp:262 + << (Var->getType().isLocalVolatileQualified() ? "volatile " : "

[PATCH] D31343: Add an attribute plugin example

aaron.ballman added inline comments. Comment at: clang/examples/Attribute/Attribute.cpp:25 +struct ExampleAttrInfo : public ParsedAttrInfo { + ExampleAttrInfo() { +// Set the kind to NoSemaHandlerAttribute to make sure clang doesn't assume It would be really

[PATCH] D31337: Use virtual functions in ParsedAttrInfo instead of function pointers

aaron.ballman added inline comments. Comment at: clang/lib/Sema/ParsedAttr.cpp:141 +static ParsedAttrInfo DefaultParsedAttrInfo; static const ParsedAttrInfo &getInfo(const ParsedAttr &A) { Might as well lower this variable into the function -- no real need for

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

aaron.ballman added inline comments. Comment at: clang/docs/ClangPlugins.rst:74 + + class ExampleAttrInfo : public ParsedAttrInfo { + public: We should be documenting the fields of `ParsedAttrInfo` that the user would be interacting with. We should also consid

[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/ParsedAttr.h:45 +struct ParsedAttrInfo { + /// Corresponds to the Kind enum + unsigned AttrKind : 16; Please add a full stop to the end of all the comments (here and elsewhere). ===

[PATCH] D73580: [clang-tidy] rename_check.py: maintain alphabetical order in Renamed checks section

Eugene.Zelenko added a comment. Another side effect is that rename_check.py messes list.rst by removing "Offer fixes". Probably proper solution would be moving update_checks_list from add_new_check.py to shared module. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D73786: [ARM,MVE] Fix vreinterpretq in big-endian mode.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Big endian making things fun again. VECTOR_REG_CAST looks useful for lowering too. LGTM Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:3958 // Occasionally we need to c

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62383 tests passed, 0 failed and 839 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

njames93 updated this revision to Diff 241924. njames93 added a comment. - Small reformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73548/new/ https://reviews.llvm.org/D73548 Files: clang-tools-extra/clang-tidy/llvm/LLVMTidyModule.cpp clan

[clang] a9ab01a - Remove superfluous space from -Wrange-loop-construct message

Author: Aaron Puchert Date: 2020-02-02T16:22:58+01:00 New Revision: a9ab01a330f4c7c316fa87c8446888c73dae5536 URL: https://github.com/llvm/llvm-project/commit/a9ab01a330f4c7c316fa87c8446888c73dae5536 DIFF: https://github.com/llvm/llvm-project/commit/a9ab01a330f4c7c316fa87c8446888c73dae5536.diff

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

aaronpuchert added a comment. I've been thinking about the warning messages, which seem to a bit inaccurate. Sorry for piggy-backing this onto the change, I hope you don't mind. Comment at: clang/lib/Sema/SemaStmt.cpp:2758-2759 // the correct time to bind a const referenc

[PATCH] D73841: [clang-tidy] Fixed crash 44745 in readability-else-after-return

This revision was automatically updated to reflect the committed changes. Closed by commit rGd591bdce6d62: [clang-tidy] Fixed crash 44745 in readability-else-after-return (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73841/new

[clang-tools-extra] d591bdc - [clang-tidy] Fixed crash 44745 in readability-else-after-return

Author: Nathan James Date: 2020-02-02T14:04:46Z New Revision: d591bdce6d623208d4aeb335a762d839f0f8f0f7 URL: https://github.com/llvm/llvm-project/commit/d591bdce6d623208d4aeb335a762d839f0f8f0f7 DIFF: https://github.com/llvm/llvm-project/commit/d591bdce6d623208d4aeb335a762d839f0f8f0f7.diff LOG:

[PATCH] D68923: Don't warn about missing declarations for partial template specializations

aaronpuchert added a comment. In D68923#1853303 , @aaron.ballman wrote: > In D68923#1853302 , @aaronpuchert > wrote: > > > Thanks for the reviews! Do you think it makes sense to bring this to Clang > > 10? > > >

[PATCH] D73845: [Gnu toolchain] Look at standard GCC multilib/multiarch paths by default

lebedev.ri added a comment. 1. Please clang-format your changes 2. Hurd stuff is not a NFC refactoring, but adding some new feature - tests missing, i think? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

topisani updated this revision to Diff 241914. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73453/new/ https://reviews.llvm.org/D73453 Files: clang-tools-extra/clangd/QueryDriverDatabase.cpp clang-tools-extra/clangd/test/system-include-extractor.test Index: clang-tools-extra/clangd

[PATCH] D73845: [Gnu toolchain] Look at standard GCC multilib/multiarch paths by default

sthibaul added a comment. There is no behavior change, I checked for no regression on GNU/Linux with ninja check-all. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 ___ cfe-

[PATCH] D73845: [Gnu toolchain] Look at standard GCC multilib/multiarch paths by default

sthibaul created this revision. sthibaul added reviewers: kristina, sammccall, lebedev.ri. Herald added subscribers: cfe-commits, krytarowski, arichardson, emaste. Herald added a project: clang. The current code for GNU/Linux is actually completely generic, and can be moved to Gnu, so it can bene