njames93 marked 2 inline comments as done. njames93 added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/readability/QualifiedAutoCheck.cpp:262 + << (Var->getType().isLocalVolatileQualified() ? "volatile " : "") + << Var->getName() << FixItHint::CreateInsertion(InsertPos, "const "); + } ---------------- aaron.ballman wrote: > Not specific to this patch, so feel free to address in another one -- I think > you should be passing `Var` instead of `Var->getName()` -- the diagnostics > engine does magic to format the name properly for any `NamedDecl`, including > proper quoting. (Similar applies elsewhere.) I couldn't do that as it actually messes the quotes up: `'auto &'TdNakedCRef''` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73548/new/ https://reviews.llvm.org/D73548 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
