[clang-tools-extra] 24b326c - [APFloat] Fix checked error assert failures

Author: Ehud Katz Date: 2020-01-09T09:42:32+02:00 New Revision: 24b326cc610dfdccdd50bc78505ec228d96c8e7a URL: https://github.com/llvm/llvm-project/commit/24b326cc610dfdccdd50bc78505ec228d96c8e7a DIFF: https://github.com/llvm/llvm-project/commit/24b326cc610dfdccdd50bc78505ec228d96c8e7a.diff LOG

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux added a comment. Ah right, let's wait for Sam comments/advises and I'll prepare a proper patch for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57054/new/ https://reviews.llvm.org/D57054

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 236967. modocache added a comment. Initialize PipelineTuningOptions properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71903/new/ https://reviews.llvm.org/D71903 Files: clang/lib/CodeGen/BackendUtil.c

[PATCH] D72434: Support offset of member designator with the arrow for __builtin_offsetof

Jim created this revision. Jim added a reviewer: eli.friedman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Push array index 0 into offsets to support offset of member designator x->b. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72434 Files: clan

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

bruno updated this revision to Diff 236965. bruno added a comment. Remove some FIXMEs that are now done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71734/new/ https://reviews.llvm.org/D71734 Files: clang/include/clang/AST/Decl.h clang/inclu

[PATCH] D72433: [Driver][PowerPC] Move powerpcspe logic from cc1 to Driver

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61322 tests passed, 0 failed and 737 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72433: [Driver][PowerPC] Move powerpcspe logic from cc1 to Driver

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61321 tests passed, 1 failed and 737 were skipped. failed: Clang.Driver/ppc-features.cpp {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

bruno updated this revision to Diff 236964. bruno added a comment. Change the approach: handle type merging for tag types using the ODRHash mechanism Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71734/new/ https://reviews.llvm.org/D71734 Files:

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

bruno marked an inline comment as done. bruno added a comment. Comment at: clang/lib/Serialization/ASTReader.cpp:9286 + false /*UseCanonicalDecls*/); + (void)Ctx.IsEquivalent(D, Canon); +} martong wrote: > Would it be possible to check the st

[PATCH] D72433: [Driver][PowerPC] Move powerpcspe logic from cc1 to Driver

MaskRay updated this revision to Diff 236962. MaskRay added a comment. Improve tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72433/new/ https://reviews.llvm.org/D72433 Files: clang/lib/Basic/Targets/PPC.cpp clang/lib/Driver/ToolChains/Ar

[PATCH] D72433: [Driver][PowerPC] Move powerpcspe logic from cc1 to Driver

MaskRay updated this revision to Diff 236961. MaskRay retitled this revision from "[PowerPC] Change SubArchType if -mspe is specified" to "[Driver][PowerPC] Move powerpcspe logic from cc1 to Driver". MaskRay edited the summary of this revision. MaskRay removed subscribers: wuzish, merge_guards_bot

[PATCH] D72433: [PowerPC] Change SubArchType if -mspe is specified

merge_guards_bot added a comment. Herald added a subscriber: wuzish. {icon check-circle color=green} Unit tests: pass. 61322 tests passed, 0 failed and 737 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72433: [PowerPC] Change SubArchType if -mspe is specified

MaskRay created this revision. MaskRay added reviewers: PowerPC, Bdragon28, jhibbits. Herald added subscribers: cfe-commits, shchenz, jsji, kbarton, nemanjai. Herald added a project: clang. Follow-up of D72014 . Repository: rG LLVM Github Monorepo https://revi

[PATCH] D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix

njames93 added a comment. Thanks for this, Also how would you feel about adding a parameter to the script that could create alias definitions in much the same way? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72421/new/ https://reviews.llvm.org/D

[PATCH] D72212: [Sema] Improve -Wrange-loop-analysis warnings

rtrieu added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:2812-2813 - // TODO: Determine a maximum size that a POD type can be before a diagnostic - // should be emitted. Also, only ignore POD types with trivial copy - // constructors. - if (VariableType.isPODT

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 updated this revision to Diff 236946. njames93 marked 4 inline comments as done. njames93 added a comment. Runs on the entire llvm project with no build issues afterwards. also fixed my facepalm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72217/new/ https://reviews.llvm.org/

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 marked 2 inline comments as done and an inline comment as not done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/QualifiedAutoCheck.cpp:94-95 + auto Pointee = QType.getTypePtr()->getPointeeType(); + if (Pointee.isNull()) +re

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/QualifiedAutoCheck.cpp:94-95 + auto Pointee = QType.getTypePtr()->getPointeeType(); + if (Pointee.isNull()) +return Pointee.isLocalConstQualified(); + return Pointee.isConstQualified(); -

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

thakis added a comment. Why do you want this? Isn't it always easy to fix your build instead? In general, stricter is better when we can get away with it, and since we've had this behavior for a while… Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D72227: Add options for clang to align branches within 32B boundary

skan updated this revision to Diff 236945. skan marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72227/new/ https://reviews.llvm.org/D72227 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/intel-alig

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

Quuxplusone added subscribers: zoecarver, CaseyCarter, ldionne, EricWF, mclow.lists. Quuxplusone added a comment. Re which libc++ folks could give feedback on this ADL-diagnosing patch: I don't know precisely, but the candidates are few! @mclow.lists @ericwf @ldionne @zoecarver @CaseyCarter.

LLVM buildmaster will be updated and restarted soon

Hello everyone, LLVM buildmaster will be updated and restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

echristo added a comment. Sadly I'm just noticing this: I don't really agree with the rationale for adding fortran support to the clang driver. My proposed design here would be to move the aspects you need out of clang and into a separate library in llvm that you can use instead. I don't neces

[PATCH] D72014: [PowerPC]: Add powerpcspe target triple subarch component

This revision was automatically updated to reflect the committed changes. Closed by commit rGff0311c4b3b9: [PowerPC]: Add powerpcspe target triple subarch component (authored by chmeee). Changed prior to commit: https://reviews.llvm.org/D72014?vs=235716&id=236937#toc Repository: rG LLVM Gith

[PATCH] D44352: [Concepts] Type Constraints

rsmith added inline comments. Comment at: include/clang/AST/ASTNodeTraverser.h:518 +if (const auto *TC = D->getTypeConstraint()) + if (TC->wereArgumentsSpecified()) +for (const auto &ArgLoc : TC->getTemplateArgsAsWritten()->arguments()) For consi

[clang] ff0311c - [PowerPC]: Add powerpcspe target triple subarch component

Author: Justin Hibbits Date: 2020-01-08T19:10:53-06:00 New Revision: ff0311c4b3b9dce9d25d08e38aa163682b155513 URL: https://github.com/llvm/llvm-project/commit/ff0311c4b3b9dce9d25d08e38aa163682b155513 DIFF: https://github.com/llvm/llvm-project/commit/ff0311c4b3b9dce9d25d08e38aa163682b155513.diff

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

erichkeane added a comment. Sorry, I didn't realize you were waiting for me. This seems fine as it is, I don't see the attribute buying us anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71499/new/ https://reviews.llvm.org/D71499 _

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. Herald added subscribers: cfe-commits, aprantl. Herald added a project: clang. This patch adds an option to limit debug info by only emitting complete class type information when its constructor is emitted. This applies to clas

[clang] b2fb6a7 - [NFC] Whitespace fixes

Author: Gabor Horvath Date: 2020-01-08T16:41:18-08:00 New Revision: b2fb6a7ba118f651cc76580ecb48eb5f877920aa URL: https://github.com/llvm/llvm-project/commit/b2fb6a7ba118f651cc76580ecb48eb5f877920aa DIFF: https://github.com/llvm/llvm-project/commit/b2fb6a7ba118f651cc76580ecb48eb5f877920aa.diff

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. I did evaluate the performance of the check on LLVM with the script in the attachement. F11185973: full_transformation.sh The result, after splitting all multi-decl statements with `readability-isolate-declarations` (which produce

[PATCH] D68115: Zero initialize padding in unions

lebedev.ri added a subscriber: aaron.ballman. lebedev.ri added a comment. In D68115#1811089 , @hubert.reinterpretcast wrote: > In D68115#1810891 , @lebedev.ri > wrote: > > > Does this have to be an unilateral chan

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

hubert.reinterpretcast added a comment. In D65761#1804302 , @hubert.reinterpretcast wrote: > I have confirmed that the case I mentioned fails with rGd157a9b > . @ajpaverd, is a fix fo

[PATCH] D68115: Zero initialize padding in unions

hubert.reinterpretcast added a comment. In D68115#1810891 , @lebedev.ri wrote: > Does this have to be an unilateral change, > likely penalizing non-`-ftrivial-auto-var-init=` cases, > i.e. [why] can't it be **only** done for when `-ftrivial-auto-var-init

[PATCH] D43357: [Concepts] Function trailing requires clauses

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, I'm happy to iterate on this further after you commit (though feel free to ask for another round of review if you prefer). The changes to recovery from missing parens in a trailing req

[PATCH] D72421: Refresh the add_new_check.py now that we use a table + autofix

sylvestre.ledru updated this revision to Diff 236924. sylvestre.ledru added a comment. Fix some rst warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72421/new/ https://reviews.llvm.org/D72421 Files: clang-tools-extra/clang-tidy/add_new_che

[PATCH] D72421: Refresh the add_new_check.py now that we use a table + autofix

sylvestre.ledru updated this revision to Diff 236923. sylvestre.ledru added a comment. arf, arc.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72421/new/ https://reviews.llvm.org/D72421 Files: clang-tools-extra/clang-tidy/add_new_check.py Inde

[PATCH] D72421: Refresh the add_new_check.py now that we use a table + autofix

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: alexfh. Herald added a subscriber: mgorny. Herald added a project: clang. sylvestre.ledru updated this revision to Diff 236922. sylvestre.ledru added a comment. sylvestre.ledru updated this revision to Diff 236923. remove art

[PATCH] D72421: Refresh the add_new_check.py now that we use a table + autofix

sylvestre.ledru updated this revision to Diff 236922. sylvestre.ledru added a comment. remove artifcats Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72421/new/ https://reviews.llvm.org/D72421 Files: clang-tools-extra/clang-tidy/add_new_check.py

Re: [clang] 24ab9b5 - Generalize the pass registration mechanism used by Polly to any third-party tool

On Wed, Jan 8, 2020 at 1:40 AM Serge Guelton wrote: > On Tue, Jan 07, 2020 at 04:57:29PM -0800, Eric Christopher wrote: > > > ; CHECK-EP-VECTORIZER-START-NEXT: Running pass: NoOpFunctionPass > > > +; CHECK-EXT: Running pass: {{.*}}::Bye on foo > > > > > > Why is this running on e

Re: [clang] 24ab9b5 - Generalize the pass registration mechanism used by Polly to any third-party tool

On Wed, Jan 8, 2020 at 3:07 PM Michael Kruse wrote: > Am Di., 7. Jan. 2020 um 18:57 Uhr schrieb Eric Christopher via > cfe-commits : > >> Is there anything I should have done? Probably reaching llvm-dev before > >> commiting. Reaching the right reviewers has always been a challenge to > me, I had

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

arichardson added a comment. In D71499#1810526 , @lebedev.ri wrote: > Land this? (branching is near..) I was planning to wait until Sunday for @erichkeane to comment whether the AST attribute is needed and if I don't hear back until then land I would co

[PATCH] D72417: [ms] [X86] Use "P" modifier on all branch-target operands in inline X86 assembly.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61323 tests passed, 0 failed and 736 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 marked 10 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/QualifiedAutoCheck.cpp:31 + Const, + Volatile // Ignore restrict as not c++ keyword. +}; aaron.ballman wrote: > We still support `re

Re: [clang] 24ab9b5 - Generalize the pass registration mechanism used by Polly to any third-party tool

Am Di., 7. Jan. 2020 um 18:57 Uhr schrieb Eric Christopher via cfe-commits : >> Is there anything I should have done? Probably reaching llvm-dev before >> commiting. Reaching the right reviewers has always been a challenge to me, I >> had >> hoped that the mail to llvm-dev would trigger some subsc

[PATCH] D43357: [Concepts] Function trailing requires clauses

saar.raz marked an inline comment as done. saar.raz added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:6340-6347 if (!AllowExplicit) { ExplicitSpecifier ES = ExplicitSpecifier::getFromDecl(Function); if (ES.getKind() != ExplicitSpecKind::ResolvedFalse

[PATCH] D72417: [ms] [X86] Use "P" modifier on all branch-target operands in inline X86 assembly.

epastor created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Extend llvm.org/D71677 to apply to all branch-target operands, rather than special-casing call instructions. Also add a regression

[PATCH] D68115: Zero initialize padding in unions

lebedev.ri added a comment. Can patch description be made a bit more verbose? > However with -ftrivial-auto-var-init=pattern those undefs became 0xAA pattern > and break some code. Break how? Does this have to be an unilateral change, likely penalizing non-`-ftrivial-auto-var-init=` cases, i.e

[PATCH] D69770: [APFloat] Add recoverable string parsing errors to APFloat

smeenai added inline comments. Herald added a subscriber: herhut. Comment at: llvm/lib/MC/MCParser/AsmParser.cpp:3133 return TokError("invalid floating point literal"); - } else if (Value.convertFromString(IDVal, APFloat::rmNearestTiesToEven) == - APFloat::opI

[PATCH] D72167: Add support for __declspec(guard(nocf))

ajpaverd added a comment. Thanks for the feedback @aaron.ballman and @dmajor! Comment at: clang/include/clang/Basic/Attr.td:2914 + let Spellings = [Declspec<"guard">]; + let Subjects = SubjectList<[Function]>; + let Args = [EnumArgument<"Guard", "GuardArg", ["nocf"], ["nocf"

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth marked an inline comment as done. JonasToth added inline comments. Comment at: clang/lib/Analysis/ExprMutationAnalyzer.cpp:20 AST_MATCHER_P(LambdaExpr, hasCaptureInit, const Expr *, E) { return llvm::is_contained(Node.capture_inits(), E); https://

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1467-1468 if (Method->isStatic()) return cast_or_null( getOrCreateType(QualType(Func, 0), Unit)); + return getOrCreateInstanceMethodType(Method->getThisType(), Func, Unit, decl);

[PATCH] D72415: [clangd] Respect `--sysroot` argument if it is set

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! I wonder what accident of history led to the different number of dashes between the flags, weird. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D72167: Add support for __declspec(guard(nocf))

ajpaverd updated this revision to Diff 236906. ajpaverd marked 7 inline comments as done. ajpaverd added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72167/new/ https://reviews.llvm.org/D72167 Files: clang/include/

[PATCH] D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check.

JonasToth added a comment. Adding a `-fno-delayed-template-parsing` to the RUN-line should suffice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72333/new/ https://reviews.llvm.org/D72333 ___ cfe-comm

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

JonasToth added a comment. @Quuxplusone thank you for the input! I think it is a good idea if the library-implementors take a look at it. I myself don't have enough knowledge of C++ and the libraries to judge all this stuff. So who to ping or to add as reviewer? Comment at:

[PATCH] D71572: [ItaniumCXXABI] Make tls wrappers properly comdat

mstorsjo added a comment. @rsmith - does this look right to you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71572/new/ https://reviews.llvm.org/D71572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D72415: [clangd] Respect `--sysroot` argument if it is set

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61323 tests passed, 0 failed and 736 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D68115: Zero initialize padding in unions

jfb added a comment. @vitalybuka could we move this patch forward? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68115/new/ https://reviews.llvm.org/D68115 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D72415: [clangd] Respect `--sysroot` argument if it is set

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. - Since `--sysroot` is a superset of the `-isysroot` argument, we shouldn't add the `-isysro

[PATCH] D72414: Implement new AST matchers `hasAnyCapture` and `capturesThis`.These matchers match on LambdaExpr:hasAnyCapture - matches if any child VarDecl matcher matches one of the captured vars.c

rhiro created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add new AST matchers `hasAnyCapture` and `capturesThis` as LambdaExpr matchers. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72414 Files: clang/include/clang/ASTMatchers/AST

[PATCH] D72411: [CodeGen] partially revert 2b4fa5348ee157b6b1a1af44d0137ca8c7a71573 to fix Objective-C static variable initialization

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:377 - if (D.needsDestruction(getContext()) && HaveInsertPoint()) { + if (hasNontrivialDestruction(D.getType()) && HaveInsertPoint()) { // We have a constant initializer, but a nontrivial destructor.

[PATCH] D72167: Add support for __declspec(guard(nocf))

dmajor added a comment. I've confirmed that the current patch fixes our CFG failures. Thanks again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72167/new/ https://reviews.llvm.org/D72167 ___ cfe-comm

[PATCH] D72411: [CodeGen] partially revert 2b4fa5348ee157b6b1a1af44d0137ca8c7a71573 to fix Objective-C static variable initialization

arphaman created this revision. arphaman added reviewers: rsmith, rjmccall, erik.pilkington, ahatanak. Herald added subscribers: ributzka, dexonsmith, jkorous. Herald added a project: clang. The following commit: commit 2b4fa5348ee157b6b1a1af44d0137ca8c7a71573 Author: Richard Smith Date:

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

aaron.ballman added a comment. This check is missing a whole lot of reserved identifiers. For instance, in C++ it is missing everything from http://eel.is/c++draft/zombie.names and for C it is missing everything from future library directions. Are you intending to cover those cases as well?

Re: r373159 - For P0784R7: compute whether a variable has constant destruction if it

Hi Richard, I posted a patch that partially reverts your commit: https://reviews.llvm.org/D72411. Unfortunately I can't revert it fully. Thanks, Alex On Mon, 11 Nov 2019 at 15:30, Alex L wrote: > Here's a reduced test case. > > ``` > // OPTIONS: -x objective-c -std=gnu99 -fobjc-arc -emit-llvm

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

SjoerdMeijer added a subscriber: samparker. SjoerdMeijer added a comment. Just a quick message, linking in @samparker, and I guess moving Low Overhead Loops to run before ConstantIslands could be problematic, but we can/should have a proper look tomorrow. Repository: rG LLVM Github Monorepo

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

logan-5 updated this revision to Diff 236891. logan-5 marked 3 inline comments as done. logan-5 added a comment. Added tests for template parameters. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72378/new/ https://reviews.llvm.org/D72378 Files:

[PATCH] D71698: [AArch64][SVE] Add intrinsic for non-faulting loads

efriedma added inline comments. Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:5333 + // We need a layer of indirection because early machine code passes balk at + // physical register (i.e. FFR) uses that have no previous definition. + let hasSideEffects = 1, hasNoSch

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 236889. modocache added a comment. Update tests -- we now re-run the SCC pass, but don't insert the coroutine funclets into the SCC, so we no longer see the funclets in the output being tested here. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 updated this revision to Diff 236884. logan-5 marked 15 inline comments as done. logan-5 added a comment. Beefed up tests and split into separate files. Added tests for instantiations of template functions that //do// definitely result in ADL, and made the warning messages more descripti

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 added a comment. Hi @Quuxplusone, glad you found your way here. I thought of adding you as a reviewer out the gate but then I didn't. Comment at: clang-tools-extra/clang-tidy/bugprone/UnintendedADLCheck.cpp:43 + Whitelist( + utils::options::parseStringLis

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

efriedma added a comment. It might be possible to rearrange Low Overhead Loops to run before ConstantIslands, but you'd probably need to do more to make it work properly. I don't think ConstantIslands knows how to handle the branches generated by LowOverheadLoop. If you think it's necessary,

[PATCH] D72380: [DataFlow] Factor two worklist implementations out

xazax.hun updated this revision to Diff 236886. xazax.hun added a comment. - Added doxygen comments and unit tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72380/new/ https://reviews.llvm.org/D72380 Files: clang/include/clang/Analysis/FlowSensitive/DataflowValues.h clang/incl

[PATCH] D72380: [DataFlow] Factor two worklist implementations out

xazax.hun marked 2 inline comments as done. xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowWorklist.h:20 +namespace clang { +template class DataflowWorklistBase { + llvm::BitVector EnqueuedBlocks; xazax.hun wrote

[PATCH] D70172: [CUDA][HIP] Fix assertion due to dtor check on windows

rsmith added a comment. Herald added a subscriber: herhut. This doesn't look quite right to me. I don't think we should treat the `delete this;` for a destructor as being emitted-for-device in any translation unit in which the vtable is marked used. (For example, if in your testcase `MSEmitDele

[PATCH] D72227: Add options for clang to align branches within 32B boundary

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:2200 + "from being across or against the boundary of specified size. " + "-x86-align-branch-boundary=0 doesn't align branches.">; +def malign_branch_EQ > -x86-align

[PATCH] D72167: Add support for __declspec(guard(nocf))

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2914 + let Spellings = [Declspec<"guard">]; + let Subjects = SubjectList<[Function]>; + let Args = [EnumArgument<"Guard", "GuardArg", ["nocf"], ["nocf"]>]; Should we also suppor

[PATCH] D72380: [DataFlow] Factor two worklist implementations out

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowWorklist.h:20 +namespace clang { +template class DataflowWorklistBase { + llvm::BitVector EnqueuedBlocks; mgehre wrote: >

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/QualifiedAutoCheck.cpp:159 +void QualifiedAutoCheck::check(const MatchFinder::MatchResult &Result) { + if (auto Var = Result.Nodes.getNodeAs("auto")) { +bool IsPtrConst = isPointerCons

[PATCH] D72153: [libTooling] Add function to determine associated text of a declaration.

ymandel updated this revision to Diff 236879. ymandel added a comment. Fixed behavior in some corner cases; added tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72153/new/ https://reviews.llvm.org/D72153 Files: clang/include/clang/Tooling/T

[PATCH] D72380: [DataFlow] Factor two worklist implementations out

mgehre added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowWorklist.h:20 +namespace clang { +template class DataflowWorklistBase { + llvm::BitVector EnqueuedBlocks; Should this class have a bit of doxygen and a unit test? CHA

[PATCH] D72121: [clang-tidy] Fix readability-identifier-naming missing member variables

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming-member-decl-usage.cpp:137 +} +}; // namespace CtorInits

[PATCH] D70765: LTOVisibility.rst: fix up syntax in example

This revision was automatically updated to reflect the committed changes. Closed by commit rG43f938eddc8a: LTOVisibility.rst: fix up syntax in example (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70765/new/ https://reviews.

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/QualifiedAutoCheck.cpp:31 + Const, + Volatile // Ignore restrict as not c++ keyword. +}; We still support `restrict` in C++ though: https://godbolt.org/z/CT5nw2 Also, one

[PATCH] D72380: [DataFlow] Factor two worklist implementations out

xazax.hun added a comment. Fortunately, UninitializedValues has some statistics. So I printed it for a big translation unit (SemaExpr.cpp) before and after this change. Before: *** Analysis Based Warnings Stats: 33023 functions analyzed (0 w/o CFGs). 161696 CFG blocks built. 4 avera

[clang] 43f938e - LTOVisibility.rst: fix up syntax in example

Author: Teresa Johnson Date: 2020-01-08T11:43:11-08:00 New Revision: 43f938eddc8a5c8e12c116ca5f31df5a6fead24e URL: https://github.com/llvm/llvm-project/commit/43f938eddc8a5c8e12c116ca5f31df5a6fead24e DIFF: https://github.com/llvm/llvm-project/commit/43f938eddc8a5c8e12c116ca5f31df5a6fead24e.diff

[PATCH] D72380: [DataFlow] Factor two worklist implementations out

xazax.hun updated this revision to Diff 236873. xazax.hun added a comment. - Prepopulating the worklist for UninitializedValues seems to be redundant. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72380/new/ https://reviews.llvm.org/D72380 Files: clang/include/clang/Analysis/FlowSens

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

zahen created this revision. zahen added reviewers: rnk, thakis, hans. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this patch adding a new /D flag when compiling a source file that consumed a PCH with clang-cl would issue a diagnostic and then fail. With the pa

[PATCH] D72233: Add a new AST matcher 'optionally'.

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch! I've commit on your behalf in 2823e91d55891e33a7a8b9a4016db4ec9e2765ae CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72233/n

[clang] 2823e91 - Add a new AST matcher 'optionally'.

Author: Rihan Yang Date: 2020-01-08T14:10:11-05:00 New Revision: 2823e91d55891e33a7a8b9a4016db4ec9e2765ae URL: https://github.com/llvm/llvm-project/commit/2823e91d55891e33a7a8b9a4016db4ec9e2765ae DIFF: https://github.com/llvm/llvm-project/commit/2823e91d55891e33a7a8b9a4016db4ec9e2765ae.diff LO

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

lebedev.ri added a comment. Land this? (branching is near..) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71499/new/ https://reviews.llvm.org/D71499 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D72233: Add a new AST matcher 'optionally'.

air20 marked an inline comment as done. air20 added inline comments. Comment at: clang/lib/ASTMatchers/Dynamic/Registry.cpp:282 REGISTER_MATCHER(hasInitStatement); + REGISTER_MATCHER(hasInitializer); REGISTER_MATCHER(hasKeywordSelector); aaron.ballman wrot

[PATCH] D71842: Allow newlines in AST Matchers in clang-query files

ymandel added inline comments. Comment at: clang/include/clang/ASTMatchers/Dynamic/Parser.h:167 static llvm::Optional - parseMatcherExpression(StringRef MatcherCode, Sema *S, - const NamedValueMap *NamedValues, - Diagnostics *Er

[PATCH] D72233: Add a new AST matcher 'optionally'.

air20 updated this revision to Diff 236866. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72233/new/ https://reviews.llvm.org/D72233 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatchers/ASTMatchers.h clang/include/clang/ASTMatchers/ASTMatchersInternal.h

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

MaskRay planned changes to this revision. MaskRay added a comment. @ostannard @nickdesaulniers @peter.smith Unfortunately we will have to get buy-in from GCC before committing to do an incompatible design. A promise that they will implement a new approach to overcome the disadvantages and an ag

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

llunak added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69585/new/ https://reviews.llvm.org/D69585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

Quuxplusone added a comment. Repeating for emphasis: This is awesome. :) Having the opt-in //option// to not-ignore overloaded operators is good; please keep that option (in case anyone tries to talk you into removing it). For more than you wanted to know about ADL, why it's bad for library wri

[PATCH] D72363: [PowerPC] Default ppc64 linux-gnu/freebsd to -fno-PIC

MaskRay added a comment. In D72363#1810036 , @sfertile wrote: > LGTM: I really didn't like setting PIC as the default just to work around > some codegen bugs. I believe there are PowerPC codegen tests that will fail > with this change though (or perhaps

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

Quuxplusone added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnintendedADLCheck.cpp:43 + Whitelist( + utils::options::parseStringList(Options.get("Whitelist", "swap"))) {} + JonasToth wrote: > JonasToth wrote: > > logan-5 wro

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 updated this revision to Diff 236859. njames93 added a comment. better template support, still runs on llvm and clang libs just fine CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72217/new/ https://reviews.llvm.org/D72217 Files: clang-tools-extra/clang-tidy/llvm/LLVMTidyModu

  1   2   >