On Wed, Jan 8, 2020 at 1:40 AM Serge Guelton <sguel...@redhat.com> wrote:
> On Tue, Jan 07, 2020 at 04:57:29PM -0800, Eric Christopher wrote:
> > > ; CHECK-EP-VECTORIZER-START-NEXT: Running pass: NoOpFunctionPass
> > > +; CHECK-EXT: Running pass: {{.*}}::Bye on foo
> > >
> > > Why is this running on every test of the pass manager? It should
> be an
> > example
> > > run in the examples directory and not on by default? Same for
> every other
> > PM
> > > test. This seems like a bug?
> >
> > It's not. When the examples are active and if the appropriate cmake
> flag is
> > set
> > (which is not the case by default), the pass is linked in
> statically, and
> > is run
> > in the default pipeline. The CHECK-EXT prefix is disabled otherwise.
> That's
> > one
> > of the configuration I did test :-)
> >
> >
> >
> > I really don't think this is ideal. The examples directory shouldn't
> affect
> > tests being run or not or in what way. Can we back this part out and
> talk about
> > it a bit more? I don't think we should need to do this to test the
> > functionality.
>
> I can just error if LLVM_BYE_LINK_INTO_TOOLS=ON, and remove that part. It
> means
> less testing, but somehow Polly is already some kind of test case. Would
> that be okay with you?
>
I'd really like to avoid linking bye into any of the tools by default and
instead just come up with a different test mechanism to show it's working.
-eric
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
