saar.raz marked an inline comment as done. saar.raz added inline comments.
================ Comment at: clang/lib/Sema/SemaOverload.cpp:6340-6347 if (!AllowExplicit) { ExplicitSpecifier ES = ExplicitSpecifier::getFromDecl(Function); if (ES.getKind() != ExplicitSpecKind::ResolvedFalse) { Candidate.Viable = false; Candidate.FailureKind = ovl_fail_explicit_resolved; return; } ---------------- rsmith wrote: > (Huh, this looks wrong: we should be checking this before we form parameter > conversion sequences, shouldn't we?) Should I fix this in this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43357/new/ https://reviews.llvm.org/D43357 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits