[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

This revision was automatically updated to reflect the committed changes. Closed by commit rG583ba07884ed: [clangd] Add xref for macros to FileIndex. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71406/new/ https://reviews.l

[clang-tools-extra] 583ba07 - [clangd] Add xref for macros to FileIndex.

Author: Utkarsh Saxena Date: 2020-01-08T08:27:50+01:00 New Revision: 583ba07884ed9281d1f1f5311ee2e280c977d62d URL: https://github.com/llvm/llvm-project/commit/583ba07884ed9281d1f1f5311ee2e280c977d62d DIFF: https://github.com/llvm/llvm-project/commit/583ba07884ed9281d1f1f5311ee2e280c977d62d.diff

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

ilya-biryukov added a comment. @rsmith, gentle ping. WDYT? Is this a step in the right direction? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71920/new/ https://reviews.llvm.org/D71920 ___ cfe-commit

[PATCH] D72355: [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no diagnostics

ilya-biryukov requested changes to this revision. ilya-biryukov added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:571 + ADD_FAILURE() << D << Code; +assert(AST.getDiagnostics().empty()

[PATCH] D72119: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder

ilya-biryukov added a comment. I'm also looking into fixing this in clang, this shouldn't be too hard. But please land the workaround for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72119/new/ https://reviews.llvm.org/D72119 _

[PATCH] D71365: expand printf when compiling HIP to AMDGPU

sameerds added a comment. In D71365#1807872 , @b-sumner wrote: > Should this be looking forward to also handling OpenCL, which does require > vector support? Sure. The implementation is general enough that we can point at the two places in AMDGPUEmitPr

[PATCH] D72119: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/FindTarget.cpp:370 +if (auto *TD = DTST->getTemplateName().getAsTemplateDecl()) { + Outer.add(TD->get

[PATCH] D68578: [HIP] Fix device stub name

rjmccall added a comment. I mean, I made a recommendation and you dismissed it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68578/new/ https://reviews.llvm.org/D68578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

logan-5 updated this revision to Diff 236754. logan-5 marked an inline comment as done. logan-5 added a comment. Addressed some nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72378/new/ https://reviews.llvm.org/D72378 Files: clang-tools-ext

[PATCH] D72233: Add a new AST matcher 'optionally'.

air20 marked an inline comment as done. air20 added a comment. In D72233#1808890 , @aaron.ballman wrote: > In D72233#1808125 , @air20 wrote: > > > In D72233#1807698 , @aaron

[PATCH] D43357: [Concepts] Function trailing requires clauses

rsmith added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3440-3447 + // C++2a [temp.deduct]p5 + // [...] When all template arguments have been deduced [...] all uses of + // template parameters [...] are replaced with the corresponding deduced +

[PATCH] D72276: [clang-format] Add IndentCaseBlocks option

capn updated this revision to Diff 236740. capn marked an inline comment as done. capn added a comment. Added case without {} to tests to ensure that still works as expected too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72276/new/ https://revi

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61312 tests passed, 0 failed and 736 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

rjmccall added a reviewer: rjmccall. rjmccall added a comment. It's not unusual for new warnings to require changes to other tests. I agree with enabling this by default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72231/new/ https://reviews.ll

[PATCH] D72380: [DataFlow] Factor two worklist implementations out

xazax.hun updated this revision to Diff 236734. xazax.hun added a comment. - Add missing new line at the end of file. - Populate the initial worklist in UninitializedValues more efficiently. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72380/new/ https://reviews.llvm.org/D72380 Files:

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:100 + + Checks for usages of identifiers reserved for use by the C++ implementation. + The C++ standard reserves the following names for such use: One sentence is enough,

[PATCH] D72380: [DataFlow] Factor two worklist implementations out

xazax.hun created this revision. xazax.hun added reviewers: gribozavr2, NoQ, Szelethus, rsmith. xazax.hun added a project: clang. Herald added subscribers: Charusso, gamesh411, dkrupp, rnkovacs. In Clang, we have the tendency to have ad-hoc worklist implementations everywhere. This patch is a fir

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

MaskRay updated this revision to Diff 236730. MaskRay marked 2 inline comments as done. MaskRay retitled this revision from "[Driver][CodeGen] Add -fpatchable-function-entry=N[,M]" to "[Driver][CodeGen] Add -fpatchable-function-entry=N[,0]". MaskRay added reviewers: ostannard, peter.smith. MaskRa

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

logan-5 created this revision. logan-5 added reviewers: JonasToth, alexfh, aaron.ballman. logan-5 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. This patch adds `bugprone-reserved-identifier`, which flags uses of `__name

[PATCH] D72284: [clang-tidy] Factor out renaming logic from readability-identifier-naming

logan-5 added a comment. (Just in case this got lost in the shuffle) If this looks good, (I think) I'll need someone with commit access to help wrap it up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72284/new/ https://reviews.llvm.org/D72284

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

Eugene.Zelenko added a comment. By the word, will be interesting to see results of this check run on LLVM code. Probably results should be split on modules. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:146 +- New alias :doc:`llvm-qualified-auto + ` to ---

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 updated this revision to Diff 236723. njames93 marked an inline comment as done. njames93 added a comment. Added an alias into the llvm module, LMK if I have done that incorrectly CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72217/new/ https://reviews.llvm.org/D72217 Files:

Re: [PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

> On Jan 7, 2020, at 2:45 PM, Ben D. Jones via Phabricator via cfe-commits > wrote: > > bendjones added a comment. > > In D70284#1752806 , @bendjones wrote: > >> Any additional thoughts @dexonsmith @erik.pilkington @ahatanak? > > > @dexonsmith @erik.p

Re: [clang] 24ab9b5 - Generalize the pass registration mechanism used by Polly to any third-party tool

Hi Serge! Thanks for a lot of the answers here :) > > The proposed infrastructure makes this process smoother and non intrusive > to the > llvm-project codebase: all development can be done in a separate git repo, > integration is controlled through cmake flags, and integration to > clang/opt/bug

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 marked 2 inline comments as done. logan-5 added a comment. @JonasToth Thanks for the feedback. Will be updating the diff in the next day or so. Comment at: clang-tools-extra/clang-tidy/bugprone/UnintendedADLCheck.cpp:89 + +const auto *Lookup = +Result.Nodes

[PATCH] D72375: Disallow an empty string literal in an asm label

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72375/new/ https://reviews.llvm.org/D72375 ___ cfe-commits mailing list cfe-commi

[PATCH] D72373: [clang-tidy] extend misc-misplaced-const to detect using besides typedef

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MisplacedConstCheck.cpp:64 + } else { +assert(0 && "This should not be reachable"); + } llvm_unreachable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-qualified-auto.cpp:183 + + auto LambdaTest = [] { return 0; }; + // CHECK-MESSAGES-NOT: :[[@LINE-1]]:3: warning: 'auto LambdaTest' can

[PATCH] D69868: Allow "callbr" to return non-void values

void updated this revision to Diff 236716. void added a comment. Missed a change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/ https://reviews.llvm.org/D69868 Files: llvm/docs/LangRef.rst llvm/include/llvm/CodeGen/MachineBasicBlock

[PATCH] D72375: Disallow an empty string literal in an asm label

aaron.ballman created this revision. aaron.ballman added reviewers: rjmccall, joerg, eli.friedman. An empty string literal in an asm label does not make a whole lot of sense. GCC does not diagnose such a construct, but it also generates code that cannot be assembled by gas should two symbols hav

[PATCH] D72373: [clang-tidy] extend misc-misplaced-const to detect using besides typedef

AlexanderLanin added a comment. looking at this at least many are indeed valid results: F11183407: partial-misc-misplaced-const-llvm-output.zip I guess false positives could be reduced by eliminating those cases where the variables are (intentionally) modifi

[PATCH] D72373: [clang-tidy] extend misc-misplaced-const to detect using besides typedef

AlexanderLanin created this revision. AlexanderLanin added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72373 Files: clang-tools-extra/clang-tidy/misc/MisplacedConstCh

[PATCH] D43357: [Concepts] Function trailing requires clauses

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: clang/include/clang/AST/ASTNodeTraverser.h:391-392 +if (const Expr *TRC = D->getTrailingRequiresClause()) + Visit(TRC); + It would be better to do this before we visit t

[PATCH] D69868: Allow "callbr" to return non-void values

void updated this revision to Diff 236710. void added a comment. Remove check that the successor may be in the indirect list of a callbr instruction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/ https://reviews.llvm.org/D69868 Files:

[PATCH] D69868: Allow "callbr" to return non-void values

void marked 5 inline comments as done. void added inline comments. Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:1115-1116 + if (Succ->hasAddressTaken()) +if (auto *bb = Succ->getBasicBlock()) + if (auto *cbr = dyn_cast(getBasicBlock()->getTerminator())) +i

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker updated this revision to Diff 236707. Tyker added a comment. rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h clang/include/clang/AST/ASTContext.h clang/include/clang/AST/ASTImporter.h

Re: [PATCH] D69876: Allow output constraints on "asm goto"

Yeah. I reverted the push. The correct code should be in Phabricator now. :-( On Tue, Jan 7, 2020 at 2:45 PM James Y Knight via Phabricator < revi...@reviews.llvm.org> wrote: > jyknight added a comment. > > I think you pushed the incorrect change? This was the clang half, but now > it's showing t

[PATCH] D72167: Add support for __declspec(guard(nocf))

dmajor added a comment. Is the current patch an interdiff? It would be helpful to have the diff against the master repo; Phabricator can take care of showing interdiffs if necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72167/new/ https:/

[PATCH] D72363: [PowerPC] Default ppc64 linux-gnu/freebsd to -fno-PIC

This revision was automatically updated to reflect the committed changes. Closed by commit rG907a0cadb2c8: [PowerPC] Default ppc64 linux-gnu/freebsd to -fno-PIC (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72363/new/ https://

[PATCH] D72304: Summary: Add OpenMP Directives (master and critical) to OMPBuilder, and use them in clang.

jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:250 + llvm::ArrayType *KmpCriticalNameTy; + llvm::PointerType *KmpCriticalNamePtrTy; + fghanim wrote: > jdoerfert wrote: > > If there is no good reason again

[PATCH] D72363: [PowerPC] Default ppc64 linux-gnu/freebsd to -fno-PIC

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61304 tests passed, 0 failed and 736 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `gi

[clang] 907a0ca - [PowerPC] Default ppc64 linux-gnu/freebsd to -fno-PIC

Author: Fangrui Song Date: 2020-01-07T15:09:22-08:00 New Revision: 907a0cadb2c807d86d3150f2397e6697ba4676df URL: https://github.com/llvm/llvm-project/commit/907a0cadb2c807d86d3150f2397e6697ba4676df DIFF: https://github.com/llvm/llvm-project/commit/907a0cadb2c807d86d3150f2397e6697ba4676df.diff

[PATCH] D72233: Add a new AST matcher 'optionally'.

aaron.ballman added a comment. In D72233#1808125 , @air20 wrote: > In D72233#1807698 , @aaron.ballman > wrote: > > > LGTM aside from a minor nit. Do you need someone to commit on your behalf? > > > How do I submit

[PATCH] D50119: P1144 "Trivially relocatable" (0/3): Compiler support for `__is_trivially_relocatable(T)`

rjmccall added a comment. In D50119#1808727 , @Quuxplusone wrote: > In D50119#1808616 , @rjmccall wrote: > > > If the committee is actively looking into this problem and considering > > multiple alternatives, I don

[PATCH] D72363: [PowerPC] Default ppc64 linux-gnu/freebsd to -fno-PIC

Bdragon28 added a comment. I am definitely in favor of this change, as the defaulting to PIC has been causing headaches in the FreeBSD kernel. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72363/new/ https://reviews.llvm.org/D72363

[PATCH] D72304: Summary: Add OpenMP Directives (master and critical) to OMPBuilder, and use them in clang.

fghanim marked 5 inline comments as done. fghanim added a comment. I don't think there is enough in this patch to split it into two or three patches. The main part is `EmitOMPInlinedRegion` which does all the heavy lifting. At this point, both create `Master` & `Critical` are almost wrappers co

[PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

bendjones added a comment. In D70284#1752806 , @bendjones wrote: > Any additional thoughts @dexonsmith @erik.pilkington @ahatanak? @dexonsmith @erik.pilkington @ahatanak does this look good to go? Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D69876: Allow output constraints on "asm goto"

jyknight added a comment. I think you pushed the incorrect change? This was the clang half, but now it's showing the LLVM half. Can you re-upload the diff for the clang half? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews

[PATCH] D72363: [PowerPC] Default ppc64 linux-gnu/freebsd to -fno-PIC

MaskRay created this revision. MaskRay added reviewers: PowerPC, adalava, Bdragon28, sfertile, stefanp. Herald added subscribers: cfe-commits, steven.zhang, shchenz, jsji, kbarton, krytarowski, arichardson, nemanjai, emaste. Herald added a project: clang. According to D53384

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

lebedev.ri added a comment. In D72362#1808825 , @Eugene.Zelenko wrote: > It'll be reasonable to add CERT alias. I'm not sure about that. This diagnoses **any** potential recursion, while CERT is much more specific than that. (`Avoid cycles during initia

[PATCH] D71848: Allow the discovery of Android NDK's triple-prefixed binaries.

jyknight added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4696 + llvm::Triple ToolchainTriple = TC.getTriple(); + if (ToolchainTriple.isAndroid()) { +std::string ArchName = ToolchainTriple.getArchName(); Adding the hardcoding here seems unfort

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

Eugene.Zelenko added a comment. It'll be reasonable to add CERT alias. Comment at: clang-tools-extra/clang-tidy/misc/NoRecursionCheck.cpp:213 + CallGraphNode::CallRecord *Node = &EntryNode; + while (1) { +// Did we see this node before? true ===

[PATCH] D72276: [clang-format] Add IndentCaseBlocks option

capn updated this revision to Diff 236690. capn added a comment. Added release note update and test for both case labels and blocks being indented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72276/new/ https://reviews.llvm.org/D72276 Files:

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

lebedev.ri created this revision. lebedev.ri added reviewers: JonasToth, aaron.ballman, ffrankies, Eugene.Zelenko, erichkeane, NoQ. lebedev.ri added a project: LLVM. Herald added subscribers: xazax.hun, Anastasia, mgorny. Herald added a project: clang. Recursion is a powerful tool, but like any t

[PATCH] D72239: [clang-tidy] new opencl recursion not supported check

lebedev.ri added a comment. In D72239#1805281 , @lebedev.ri wrote: > I was just going to look into this kind of check. > This can be implemented without recursion in the check itself. > Let me write it and post my variant. D72362

[PATCH] D70172: [CUDA][HIP] Fix assertion due to dtor check on windows

yaxunl added a comment. In D70172#1772140 , @rjmccall wrote: > Richard is definitely our main expert in the implicit synthesis of special > members. It seems to me that if we need the destructor declaration at some > point, we should be forcing it to ex

[PATCH] D72212: [Sema] Improve -Wrange-loop-analysis warnings

MaskRay added inline comments. Comment at: clang/test/SemaCXX/warn-range-loop-analysis.cpp:22 struct Bar { + // The type is too large to suppress the warning for trivially copyable types. + char s[128]; `too large to suppress` means it does not suppress the w

[PATCH] D72331: OpaquePtr: add type to inalloca attribute.

dblaikie accepted this revision. dblaikie added a subscriber: rnk. dblaikie added a comment. This revision is now accepted and ready to land. Looks pretty good to me - couple of minor things. If you want to check with @rnk (best point of contact on the inalloca feature in general), that'd probab

[PATCH] D72212: [Sema] Improve -Wrange-loop-analysis warnings

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Commit eec0240f97180ea876193dcfa3cb03cb652d9fe3 "Adds -Wrange-loop-analysis to -Wall" was premature before this fix, as

[PATCH] D69876: Allow output constraints on "asm goto"

void updated this revision to Diff 236683. void added a comment. Push the correct changes to Phabricator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D69876 Files: clang/docs/LanguageExtensions.rst clang/i

[PATCH] D50119: P1144 "Trivially relocatable" (0/3): Compiler support for `__is_trivially_relocatable(T)`

Quuxplusone added a comment. In D50119#1808616 , @rjmccall wrote: > If the committee is actively looking into this problem and considering > multiple alternatives, I don't see a particular need to accept your proposal > into Clang in advance of the commi

[PATCH] D69876: Allow output constraints on "asm goto"

This revision was automatically updated to reflect the committed changes. Closed by commit rG52366088a8e4: Allow output constraints on "asm goto" (authored by void). Changed prior to commit: https://reviews.llvm.org/D69876?vs=236683&id=236684#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D72212: [Sema] Improve -Wrange-loop-analysis warnings

MaskRay added inline comments. Comment at: clang/test/SemaCXX/warn-range-loop-analysis-trivially-copyable.cpp:6 + struct Record { +volatile int a; +int b; `test_POD` can be dropped. It does not add test coverage. "Struct with a volatile member no longer

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

gbencze added a comment. ping @aaron.ballman - any thoughts on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71973/new/ https://reviews.llvm.org/D71973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

Re: [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

On Tue, Jan 7, 2020 at 3:40 PM John McCall wrote: > > On Tue, Jan 7, 2020 at 3:18 PM Aaron Ballman wrote: > > It seems like GCC doesn't do good things when trying to link two > > functions with empty asm labels but Clang does seem to do something > > reasonable. I can't quite tell whether this is

[PATCH] D70270: clang-tidy: modernize-use-using uses AST and now supports struct defintions and multiple types in a typedef

This revision was automatically updated to reflect the committed changes. Closed by commit rG73d93617d3ae: [clang-tidy] modernize-use-using uses AST and now supports struct defintions… (authored by mitchell-stellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang-tools-extra] 73d9361 - [clang-tidy] modernize-use-using uses AST and now supports struct defintions and multiple types in a typedef

Author: Mitchell Balan Date: 2020-01-07T16:36:11-05:00 New Revision: 73d93617d3ae23bad232fa3a160c638728c71c01 URL: https://github.com/llvm/llvm-project/commit/73d93617d3ae23bad232fa3a160c638728c71c01 DIFF: https://github.com/llvm/llvm-project/commit/73d93617d3ae23bad232fa3a160c638728c71c01.diff

[PATCH] D71533: [clangd] Show template arguments in type hierarchy when possible

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61304 tests passed, 0 failed and 736 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71533: [clangd] Show template arguments in type hierarchy when possible

nridge updated this revision to Diff 236674. nridge marked 3 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71533/new/ https://reviews.llvm.org/D71533 Files: clang-tools-ext

[PATCH] D72306: [PowerPC] FreeBSD >= 13 default ABI is ELFv2

adalava abandoned this revision. adalava added a comment. In D72306#1808613 , @MaskRay wrote: > Obsoleted by D72352 ? Sure, abandoning in favor of D72352 . Thank you! Repository: rG

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

Mordante planned changes to this revision. Mordante added a comment. While looking at the test failures I noticed the tests `pointer_to_integral_type_conv` in `clang/test/Sema/MicrosoftExtensions.c` were not tested. Will look into it later. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D72276: [clang-format] Add IndentCaseBlocks option

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:1235 + "}", + Style)); } MyDeveloperDay wrote: > Could you add a test with indented case labels and indented case blocks? what happens if

[PATCH] D50119: P1144 "Trivially relocatable" (0/3): Compiler support for `__is_trivially_relocatable(T)`

rjmccall added a comment. If the committee *isn't* taking this up, they absolutely should, though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50119/new/ https://reviews.llvm.org/D50119 ___ cfe-commi

Re: [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

On Tue, Jan 7, 2020 at 3:18 PM Aaron Ballman wrote: > It seems like GCC doesn't do good things when trying to link two > functions with empty asm labels but Clang does seem to do something > reasonable. I can't quite tell whether this is a case for a diagnostic > or not. Note the generated assembl

[PATCH] D72119: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61301 tests passed, 0 failed and 736 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D50119: P1144 "Trivially relocatable" (0/3): Compiler support for `__is_trivially_relocatable(T)`

rjmccall added a comment. If the committee is actively looking into this problem and considering multiple alternatives, I don't see a particular need to accept your proposal into Clang in advance of the committee's decision. Arguably that would even be somewhat inappropriate, since it might be

[PATCH] D72306: [PowerPC] FreeBSD >= 13 default ABI is ELFv2

MaskRay added a comment. Obsoleted by D72352 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72306/new/ https://reviews.llvm.org/D72306 ___ cfe-commits mailing list cf

[PATCH] D72119: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61301 tests passed, 0 failed and 736 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71572: [ItaniumCXXABI] Make tls wrappers properly comdat

mstorsjo updated this revision to Diff 236664. mstorsjo retitled this revision from "[ItaniumCXXABI] Make tls wrappers comdat on Windows" to "[ItaniumCXXABI] Make tls wrappers properly comdat". mstorsjo edited the summary of this revision. mstorsjo added a comment. Making the tls wrappers comdat

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

efriedma added a comment. http://lab.llvm.org:8011/builders/aosp-O3-polly-before-vectorizer-unprofitable is currently broken, I think due to this patch. It looks like polly isn't getting linked into clang by default anymore? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

Re: [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

On Tue, Jan 7, 2020 at 3:13 PM John McCall wrote: > > On Tue, Jan 7, 2020 at 3:02 PM Aaron Ballman wrote: > > On Tue, Jan 7, 2020 at 2:57 PM John McCall via cfe-commits > > wrote: > > > On Tue, Jan 7, 2020 at 1:44 PM Aaron Ballman via Phabricator > > > wrote: > > > > Sorry to dredge up an old r

Re: [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

On Tue, Jan 7, 2020 at 3:02 PM Aaron Ballman wrote: > On Tue, Jan 7, 2020 at 2:57 PM John McCall via cfe-commits > wrote: > > On Tue, Jan 7, 2020 at 1:44 PM Aaron Ballman via Phabricator > > wrote: > > > Sorry to dredge up an old review, but I recently ran into a bug in this > > > area and am n

[PATCH] D72352: [PowerPC][Triple] Use elfv2 on freebsd>=13 and linux-musl

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61303 tests passed, 0 failed and 736 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72352: [PowerPC][Triple] Use elfv2 on freebsd>=13 and linux-musl

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61303 tests passed, 0 failed and 736 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72355: [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no diagnostics

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

Re: [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

On Tue, Jan 7, 2020 at 2:57 PM John McCall via cfe-commits wrote: > > On Tue, Jan 7, 2020 at 1:44 PM Aaron Ballman via Phabricator > wrote: > > aaron.ballman added inline comments. > > > > > > > > Comment at: cfe/trunk/lib/AST/Mangle.cpp:127 > > +// do not add a "\01" prefix.

Re: [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

On Tue, Jan 7, 2020 at 1:44 PM Aaron Ballman via Phabricator wrote: > aaron.ballman added inline comments. > > > > Comment at: cfe/trunk/lib/AST/Mangle.cpp:127 > +// do not add a "\01" prefix. > +if (!ALA->getIsLiteralLabel() || ALA->getLabel().startswith("llvm.")) { > +

[PATCH] D72355: [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no diagnostics

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72355 Files: clang-tools-extra/clangd/un

[PATCH] D72119: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder

nridge updated this revision to Diff 236652. nridge marked an inline comment as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72119/new/ https://reviews.llvm.org/D72119 Files: clang-tools-ext

[PATCH] D72119: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder

nridge updated this revision to Diff 236653. nridge added a comment. Remove no longer used flag from XRefTests.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72119/new/ https://reviews.llvm.org/D72119 Files: clang-tools-extra/clangd/FindTarge

[PATCH] D50119: P1144 "Trivially relocatable" (0/3): Compiler support for `__is_trivially_relocatable(T)`

Quuxplusone added a comment. @rjmccall ping? any further thoughts on `[[maybe_trivially_relocatable]]`, in light of the followup libc++ patches? (Those patches do not use `[[maybe_trivially_relocatable]]`, although that may just be because I wrote them.) How could one go about getting this pat

[PATCH] D72352: [PowerPC][Triple] Use elfv2 on freebsd>=13 and linux-musl

MaskRay updated this revision to Diff 236647. MaskRay added a comment. Add powerpc64-unknown-freebsd11 (its expected EOL is September 30, 2021) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72352/new/ https://reviews.llvm.org/D72352 Files: clang

[PATCH] D72352: [PowerPC][Triple] Use elfv2 on freebsd>=13 and linux-musl

This revision was automatically updated to reflect the committed changes. Closed by commit rG8edf759ca7e1: [PowerPC][Triple] Use elfv2 on freebsd>=13 and linux-musl (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72352/new/ http

[PATCH] D72352: [PowerPC][Triple] Use elfv2 on freebsd>=13 and linux-musl

MaskRay updated this revision to Diff 236649. MaskRay retitled this revision from "[Triple] Use elfv2 on freebsd>=13 and linux-musl" to "[PowerPC][Triple] Use elfv2 on freebsd>=13 and linux-musl". MaskRay edited the summary of this revision. MaskRay added a comment. Herald added a subscriber: shch

[clang] fb6e80d - [test] Move ppc64 tests from test/Preprocessor/init.c to init-ppc64.c

Author: Fangrui Song Date: 2020-01-07T11:32:52-08:00 New Revision: fb6e80da446b94d42d484910ea28a82b4900f01f URL: https://github.com/llvm/llvm-project/commit/fb6e80da446b94d42d484910ea28a82b4900f01f DIFF: https://github.com/llvm/llvm-project/commit/fb6e80da446b94d42d484910ea28a82b4900f01f.diff

[clang] 4558842 - [OPENMP]Reduce calls for the mangled names.

Author: Alexey Bataev Date: 2020-01-07T14:28:17-05:00 New Revision: 45588428910a7cbcf58317b874dad18b580c9ce5 URL: https://github.com/llvm/llvm-project/commit/45588428910a7cbcf58317b874dad18b580c9ce5 DIFF: https://github.com/llvm/llvm-project/commit/45588428910a7cbcf58317b874dad18b580c9ce5.diff

[PATCH] D72352: [Triple] Use elfv2 on freebsd>=13 and linux-musl

adalava accepted this revision. adalava added a comment. This revision is now accepted and ready to land. LGTM. Just a comment regarding FreeBSD 11.x. Comment at: clang/test/Driver/ppc-abi.c:27 +// RUN: %clang -target powerpc64-unknown-freebsd12 %s -### 2>&1 | FileCheck --ch

[PATCH] D72212: [Sema] Improve -Wrange-loop-analysis warnings

Mordante marked an inline comment as done. Mordante added a comment. You're welcome. It would be nice if we can get this one in the release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72212/new/ https://reviews.llvm.org/D72212 ___

[PATCH] D72352: [Triple] Use elfv2 on freebsd>=13 and linux-musl

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D72352: [Triple] Use elfv2 on freebsd>=13 and linux-musl

MaskRay updated this revision to Diff 236640. MaskRay added a comment. Simplify Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72352/new/ https://reviews.llvm.org/D72352 Files: clang/lib/Basic/Targets/PPC.h clang/lib/Driver/ToolChains/Clang.cpp

  1   2   >